summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix Snow Leopard SDK errorsmark@chromium.org2009-09-162-2/+2
| | | | | | | error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing Review URL: http://codereview.chromium.org/204028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26304 0039d316-1c4b-4281-b951-d872f2087c98
* Build sync engine as part of the browser build.nick@chromium.org2009-09-1546-96/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | As before, syncapi is built as a dynamic library, and only on windows. The difference is that it's built from source, rather than being pulled in as a binary. Changes to sync engine code: * Use OS_WIN instead of OS_WINDOWS (requires build_config.h). * Rename platform-specific files to match the chrome convention. This allows them to be excluded by rules that already exist in chrome.gyp. The convention is either a /win/ directory, or an _win.cc at the end of the file. Other valid platforms are _mac, _linux, and _posix Changes to DEPS: * On Windows, pull in pthreads-win32. Changes to chrome.gyp: * Add new library targets for sync, notifier, sync_proto, and syncapi. Review URL: http://codereview.chromium.org/193103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
* applicationDockMenu: is used in the unit test, it should not be privatemark@chromium.org2009-09-152-1/+3
| | | | | | Review URL: http://codereview.chromium.org/201127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26294 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the AutocompletePopupPositioner into a BubblePositioner in ↵pkasting@chromium.org2009-09-1531-181/+215
| | | | | | | | | | | | preparation for using it to position both the Omnibox bubble and InfoBubbles. It now gets the bounds of the location stack, which can be turned into useful coordinates for both items. This should not result in any visible change. BUG=21028 TEST=none Review URL: http://codereview.chromium.org/194110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98
* Use a better highlight images for "hover" state and pushed "state".finnur@chromium.org2009-09-152-3/+3
| | | | | | | | | BUG=18452 TEST=Try different themes and make sure the extension toolstrips have a nice hover and "pushed" images (by hovering over and then clicking and holding the left mouse button). Review URL: http://codereview.chromium.org/201125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26287 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Connect signal handlers before initing widgets in browser window.estade@chromium.org2009-09-151-1/+1
| | | | | | | | | | | Moved the function call to the beginning of InitWidgets() to enforce this. BUG=21868 TEST=interactive ui tests still working locally Review URL: http://codereview.chromium.org/205012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26284 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "First part of automated_ui_tests improvements."phajdan.jr@chromium.org2009-09-151-21/+0
| | | | | | | | | | | | Revert "Fix Mac by disabling some UI tests on it." Too many failures. TBR=huanr Review URL: http://codereview.chromium.org/193118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26281 0039d316-1c4b-4281-b951-d872f2087c98
* Size the buffer used for the metrics log text properly.mark@chromium.org2009-09-151-4/+6
| | | | | | | | | | | | | | | | The existing code was abusing the WriteInto interface (base/string_util.h). The size passed to WriteInto should be the size of the string plus one for a terminating NUL byte. This bug caused the final newline in the log to be clipped. c_str users (there probably weren't any) would see the final newline which wouldn't be wouldn't be followed by a NUL byte. TEST=not really any BUG=21733 Review URL: http://codereview.chromium.org/194099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26280 0039d316-1c4b-4281-b951-d872f2087c98
* Some scaffolding for the task manager.thakis@chromium.org2009-09-154-1/+162
| | | | | | | | | BUG=13156 TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button). Review URL: http://codereview.chromium.org/200094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26278 0039d316-1c4b-4281-b951-d872f2087c98
* Land review 193091: Avoid unnecessary conversions between wchar_taa@chromium.org2009-09-151-3/+3
| | | | | | | | | and wstring. TBR=erikkay@chromium.org Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26277 0039d316-1c4b-4281-b951-d872f2087c98
* Unified the color definitions for the dividers so that extension shelf is ↵finnur@chromium.org2009-09-154-14/+15
| | | | | | | | | | using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did. BUG=18452 TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds. Review URL: http://codereview.chromium.org/204026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26274 0039d316-1c4b-4281-b951-d872f2087c98
* First part of automated_ui_tests improvements.phajdan.jr@chromium.org2009-09-151-0/+21
| | | | | | | | | | | | - disable unreliable RestoreTab action - make more command sync, waiting for their completion TEST=none BUG=21547, 21636 Review URL: http://codereview.chromium.org/196096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26272 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome should shut down cleanly when quit from the Dock icon menu, duringmark@chromium.org2009-09-1510-72/+133
| | | | | | | | | | | | | | | | | | | | | | user logout, and during system restart and shutdown. MainMenu.xib changes (because you're not expected to parse nibs yourself): - The quit menu item's action is changed from the AppController object's -quit: method (which no longer exists) to the application object's -terminate: method (the Cocoa standard). - The application and owner object types are changed from NSApplication to CrApplication. - The application menu name is changed from Chromium to ^IDS_SHORT_PRODUCT_NAME. Cocoa doesn't use this anyway, it gets replaced at runtime with the localized value of CFBundleName, but we shouldn't have branding-specific strings in our nibs. BUG=18078 TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch. You should NOT see the "Google Chrome didn't shut down correctly" info bar. Review URL: http://codereview.chromium.org/201121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26269 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mole/toolstrip URLs properly.erikkay@chromium.org2009-09-152-7/+32
| | | | | | | | | | | | | * expand/collapse to chrome-extension://crashme no longer crashes * expand/collapse to a relative URL now works BUG=20412,21905 TEST=browser_tests ExtensionApi.Toolstrip (note that the test doesn't actually exercise these changes due to 21905) Review URL: http://codereview.chromium.org/195093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26266 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-1517-53/+57
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to svn add files when landing patch.sky@chromium.org2009-09-154-0/+685
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/193115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26261 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the sqlite cookie database and web database to use the new sqlitebrettw@chromium.org2009-09-1510-549/+989
| | | | | | | | | | | wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/193032 for Charlie:sky@chromium.org2009-09-155-4/+36
| | | | | | | | | | | | | | | First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
* Address ExtensionApiTest.Tabs flakinessrafaelw@chromium.org2009-09-151-2/+1
| | | | | | | | | | | | This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add support for SELinux.agl@chromium.org2009-09-151-16/+62
| | | | | | | | | | | | | | | | | | This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Tell the AppCacheService which request context to use when fetching ↵michaeln@google.com2009-09-151-2/+4
| | | | | | | | | | | | | resources for updates. Done for both chrome and test_shell. The service does not yet take a reference to that context, because the extra reference apparently gives some tests grief. 2) Added methods to generate new storage ids for different object types on the IO thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/195077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26253 0039d316-1c4b-4281-b951-d872f2087c98
* Keyword editor fixes:thomasvl@chromium.org2009-09-151-0/+8
| | | | | | | | | | | | | | | | | The "make default" button Auto size to always fit the text. Be a small style control, look better (changes font). General fix up so the window resizes. TableView Turn off column select Turn off multiple selection (code doesn't support it on delete). Update the xib for the class name change that happened as part of the prior commit. BUG=21892 TEST=window resize correctly, make default button fits it's text for all languages. Review URL: http://codereview.chromium.org/206016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26252 0039d316-1c4b-4281-b951-d872f2087c98
* Committing original patch http://codereview.chromium.org/178036paul@chromium.org2009-09-151-6/+7
| | | | | | | | | | | | | by Vassili Bykov. BUG=19983 TEST=Follow the steps in the bug to test the bubble's move-out-of-the-way behavior with dowload shelf both visible and hidden. Review URL: http://codereview.chromium.org/200135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26250 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the pageup, Shift-pageup, and Option-Shift-pageup keys scroll the ↵rohitrao@chromium.org2009-09-151-0/+22
| | | | | | | | | | underlying webpage when using the findbar. BUG=http://crbug.com/17421 TEST=Try pressing pageup with focus in the findbar. Review URL: http://codereview.chromium.org/204006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26246 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the text color is set correctly for incognito themes until we ↵pinkerton@chromium.org2009-09-151-0/+13
| | | | | | | | | | theme them correctly BUG=20707 TEST=tab text appears correctly in incognito. Review URL: http://codereview.chromium.org/196123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26232 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Restore focus to the previously focused view when dismissing the find bar.rohitrao@chromium.org2009-09-156-1/+195
| | | | | | | | | | | | | | If a result was found, restore focus to the tab contents. This allows for keyboard navigation using the find bar. Now with fix for valgrind failure. This CL reverts 26219, which in turn reverted 26214. BUG=http://crbug.com/12657 BUG=http://crbug.com/21374 TEST=See test case in bug 21374 Review URL: http://codereview.chromium.org/205010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26231 0039d316-1c4b-4281-b951-d872f2087c98
* Check in syncapi header consistent with most recent build of syncapi.dlltim@chromium.org2009-09-151-0/+3
| | | | | | | | | from the chrome sync client devchannel release branch. TBR=idana Review URL: http://codereview.chromium.org/196124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build. When I recreated my changelist I accidentally left out two files ↵finnur@chromium.org2009-09-152-0/+360
| | | | | | | | | | | | | | I had added. Fixing. TBR=jcampan BUG=None TEST=Build should work Review URL: http://codereview.chromium.org/204023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26228 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-1512-477/+263
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a test to insure we are not regressing on http://crbug.com/19941jcampan@chromium.org2009-09-152-0/+41
| | | | | | | | | | | We would crash when an SSL error would happen on a page with no navigation entry. TEST=Run the test. BUG=http://crbug.com/19941 Review URL: http://codereview.chromium.org/196115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26224 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the Firefox import behavior such that if we're in first run, the ↵gwilson@google.com2009-09-151-0/+9
| | | | | | | | | | | | | importer is headless, and we're only importing the home page, skip the Firefox lock. Otherwise, the process would silently wait for Firefox to close with no warnings. BUG=18709 TEST=set "import_home_page" : true, "skip_first_run_ui" : true in the master_preferences, and run without FirstRun. Import should not block. Review URL: http://codereview.chromium.org/174057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26221 0039d316-1c4b-4281-b951-d872f2087c98
* mac: drop NOTIMPLEMENTED in GotFocus()avi@chromium.org2009-09-152-2/+3
| | | | | | | | | | | See http://codereview.chromium.org/194109 for details. BUG=none TEST=none Review URL: http://codereview.chromium.org/196122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26220 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26214.rohitrao@chromium.org2009-09-156-193/+1
| | | | | | Review URL: http://codereview.chromium.org/201116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26219 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky test ExtensionApiTest.Tabs.maruel@chromium.org2009-09-151-1/+2
| | | | | | | | | | | TBR=asargent BUG=20828 TEST=ExtensionApiTest.Tabs random failure Review URL: http://codereview.chromium.org/205009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26218 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Restore focus to the previously focused view when dismissing the find bar.rohitrao@chromium.org2009-09-156-1/+193
| | | | | | | | | | | | If a result was found, restore focus to the tab contents. This allows for keyboard navigation using the find bar. BUG=http://crbug.com/12657 BUG=http://crbug.com/21374 TEST=See test case in bug 21374 Review URL: http://codereview.chromium.org/201061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26214 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteEditViewTest.DesiredTLD until it becomes not flaky.tyoshino@google.com2009-09-151-1/+1
| | | | | | | | | | BUG=21864 TEST=none TBR=suzhe Review URL: http://codereview.chromium.org/195085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26208 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteEditViewTest.EnterToSearch until it becomes not flaky.tyoshino@google.com2009-09-151-1/+1
| | | | | | | | | | BUG=21849 TBR=suzhe TEST=none Review URL: http://codereview.chromium.org/204019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26199 0039d316-1c4b-4281-b951-d872f2087c98
* Potential fix for http://crbug.com/13111thakis@chromium.org2009-09-151-0/+1
| | | | | | | | | | | | | | | | | The browser_window_controller is destroyed before the window is destroyed. In its dealloc, it sends the download shelf an |exiting| message that deletes all item controllers, but the items's views might still be visible and hold weak references to their controllers. When they are clicked, they would se nd a message to free'd memory. This is all speculation. BUG=13111 TEST=Release to dev channel, monitor crash reports. Should go down. Review URL: http://codereview.chromium.org/193109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26198 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing test AutocompleteEditViewTest.AltEnter until it's fixed.tyoshino@google.com2009-09-151-1/+1
| | | | | | | | | BUG=21846 TEST=none TBR=suzhe Review URL: http://codereview.chromium.org/205007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build failure.tyoshino@google.com2009-09-151-10/+10
| | | | | | | | | | | | | | Initialize gfx::NativeWindow (i.e. HWND) and AutocompleteEditView* so that Chromium Linux doesn't fail to build due to uninitialized variable warning. BUG=none TEST=none Review URL: http://codereview.chromium.org/204017 Review URL: http://codereview.chromium.org/204017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26192 0039d316-1c4b-4281-b951-d872f2087c98
* Add autocomplete_edit_view_browsertest.cc.suzhe@chromium.org2009-09-152-0/+506
| | | | | | | | | | | This CL adds automated tests for AutocompleteEditView. BUG=20422: Autocomplete edit view needs automated testing TEST=none Review URL: http://codereview.chromium.org/177052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26190 0039d316-1c4b-4281-b951-d872f2087c98
* Drag and drop for extension in RTL wasn't working properly.cira@chromium.org2009-09-151-1/+2
| | | | | | | | | | | | ExtensionShelf::ToolstripAtX would never find a toolstrip for any value of x (or would find wrong one). BUG=11880 TEST=Load chrome with --lang=he, add 2-3 extensions and try dragging and switching their positions. It should work as LTR. Review URL: http://codereview.chromium.org/204015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26188 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop NOTIMPLEMENTED in GotFocus()evan@chromium.org2009-09-151-1/+2
| | | | | | | | Leftover cruft. Review URL: http://codereview.chromium.org/194109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26187 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-1514-623/+477
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Don't vertically tile the frame background.tony@chromium.org2009-09-151-7/+10
| | | | | | | | | BUG=21728 Review URL: http://codereview.chromium.org/203060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26185 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, another variable also has the same problem (warning turned into error ↵finnur@chromium.org2009-09-151-2/+2
| | | | | | | | | | | | due to initialization order). TBR=erikkay BUG=None TEST=Linux build compiles. Review URL: http://codereview.chromium.org/204016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26184 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build warning treated as error.finnur@chromium.org2009-09-141-1/+1
| | | | | | | | | TBR=erikkay BUG=None Review URL: http://codereview.chromium.org/193108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26181 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-1414-477/+623
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead NOTIMPLEMENTEDs and enables some code that no longersky@chromium.org2009-09-143-10/+2
| | | | | | | | | | | needs to be ifdef'd out. BUG=none TEST=none Review URL: http://codereview.chromium.org/196111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26177 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix Linux views buildpkasting@chromium.org2009-09-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26172 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 01:46:01 +0000