| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
It still passes, and provides coverage for situation where there are
lots of DNS requests at the same time.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Known limitations:
* Runs in browser process, should run in a separate process.
* No UI.
* No FF password import.
BUG=15455
TEST=Check that firefox settings are correctly imported on first run, firefox password importing and Safari importing still don't work.
Review URL: http://codereview.chromium.org/160341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8205
Review URL: http://codereview.chromium.org/159603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As with the rest of our shadow drawing, we don't overlap 1 pixel, we
just draw the area around.
BUG=15505
Review URL: http://codereview.chromium.org/160306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
matches up with Windows.
BUG=17915
Review URL: http://codereview.chromium.org/160281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/159186
Renaming GetNormalBounds to GetRestoredBounds from browser_window.h.
BUG=None
TEST=None
TBR=tfarina
Review URL: http://codereview.chromium.org/160337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inserted for LTR systems
To avoid empty square displayed around tooltip when system does not have RTL support, only add Unicode marks when element's directionality is not the same as UI's directionality.
Note:
1. tooltip will be displayed using its element's directionality.
2. in system without RTL support, tooltip will only be displayed correctly (in its element's directionality and without empty square around) when both UI and element's directionality is LTR.
BUG=http://crbug.com/17468
TEST=
1. Uninstall the right-to-left script and east Asian script through the Control Panel and restart system.
2. Run English Chrome.
3. given the following HTML, the displayed tooltip should not have empty square around.
<html>
<head>
<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="TEXT/HTML; CHARSET=utf-8">
</head>
<body>
<span style="background-color:Blue" title="Hi!">And now here!</span>
</body></html>
Review URL: http://codereview.chromium.org/160262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8205
TEST=go to wrench->options->personal stuff->show saved passwords, it works
Review URL: http://codereview.chromium.org/159522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple files. Do you want to allow this?" dialog on linux.
BUG=12757
TEST=Download several files from the same domain. After the first download, you should be prompted for every additional file you want to download from that domain (try for example http://amnoid.de/ddsview/download.html , click on the "download" link twice).
Review URL: http://codereview.chromium.org/159528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined star/location bar/go construct doesn't look native. In
GTK mode, make the star and go buttons act like toolbar buttons, and
draw a GTK text entry widget onto the toolbar. The omnibox popup
is just the size of the entry when in GTK theme mode.
There's still a lot of work to be done on this; I want to properly
draw focus rings, have the rest of the location box use theme colors, et cetera, but this is less broken then what's currently
there.
Review URL: http://codereview.chromium.org/159532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerators to be broken.
This CL also makes sure to keep the focus on the location bar when reloading the NTP.
BUG=http://crbug.com/14954
TEST=See bug.
Review URL: http://codereview.chromium.org/160206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17822
TEST=Use multiple monitors. Start Chrome, move the window to a non-primary
monitor, and exit Chrome. Disconnect or disable the monitor and start Chrome
again. Chrome should appear at the origin of a remaining monitor. Also try
chaning the resolution of the non-primary monitor. As far as the window fits
within the monitor, it should be shown as-is. If not, it is moved to the origin
and resized, if necessary.
Review URL: http://codereview.chromium.org/160246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke valgrind ui_tests
Review URL: http://codereview.chromium.org/160320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems NXClient sends GDK_Tab not only when we press control+tab keys but also when we press control+shift+tab keys.
To emulate Firefox, this change checks if |modifier| is control+shift when |keyval| is either GDK_Tab, GDK_ISO_Left_Tab, or GDK_KP_Tab.
BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards"
TEST=Execute Chromium on an NX Client, press control+shift+tab keys, and verify tabs cycle backwards.
Review URL: http://codereview.chromium.org/155564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by suzhe@google.com (http://codereview.chromium.org/155772)
BUG=http://crbug.com/12343
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z,
then launch chrome again in another terminal. The second chrome shall be started
in 5 seconds, and the first one shall be killed.
Review URL: http://codereview.chromium.org/159577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
exist, and some newly added code handled that poorly, leading to crashes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a NULL IOBuffer:data_.
BUG=http://crbug.com/16371
Review URL: http://codereview.chromium.org/159561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17475
TEST=obvious
Review URL: http://codereview.chromium.org/159570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
AutomationMsg_RequestStart.
Review URL: http://codereview.chromium.org/159228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsServiceBackend into a set of utility functions.
The intent of this is:
a) make extensions_service.cc smaller
b) have smaller pieces hanging around that we can more easily
reconfigure to implement new features.
c) improve testability.
Review URL: http://codereview.chromium.org/159400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the section background so that it looks the same on white, but is actually transparent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Install two themes without closing the infobar - make sure only one infobar is visible.
Review URL: http://codereview.chromium.org/160296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tweaks for the list view mode.
This also fixes an issue where the thumbnails were not positioned
correctly at startup in RTL
BUG=17810, 17811, 17751
TEST=Hide the recent activities and make sure that the right border of
even more is shown. Switch to list mode. Make sure that the filler are
hidden. Try dragging the items in the list view. The text should not
dissappear.
Review URL: http://codereview.chromium.org/160291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/159550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)
BUG=none
TEST=use the new hotkeys
Review URL: http://codereview.chromium.org/160292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iframe.
Also, override some styles that gets set in the theme css which is
written for the new new tab page.
BUG=None
TEST=Start chrome with --old-new-tab-page
Review URL: http://codereview.chromium.org/160290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
picker.
BUG=none
TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash
Review URL: http://codereview.chromium.org/159540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called after Cleanup, which
results in the AutomationResourceMessageFilter member getting destroyed and a subsequent crash.
Added a NULL check for the same.
Review URL: http://codereview.chromium.org/160293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/160239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an unused version of the OnMessageReceived method.
R=brettw
BUG=17104
TEST=none
Review URL: http://codereview.chromium.org/160242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I don't think we're guaranteed to have a pending one.
BUG=17916
Review URL: http://codereview.chromium.org/160286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When we use gtk_scrolled_window_add_with_viewport, it sets its own
shadow.
BUG=16913
Review URL: http://codereview.chromium.org/159535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't even realize I checked in the code that disabled it.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17806
Review URL: http://codereview.chromium.org/160210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to ChromeURLRequestContext.
BUG=16932
TEST=none
Review URL: http://codereview.chromium.org/159519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proxy settings are set using Gnome's network properties dialog, by running the
binary directly. The binary was renamed from gnome-system-preferences to
gnome-system-properties in Janurary 2009, so to ensure the dialog works on both
newer and older systems, this patch searches the users PATH for the binary to use.
Upstream rename: http://git.gnome.org/cgit/gnome-control-center/commit/?id=4f1b6aafba338a267b6c1b911ceb33358b2eca09
BUG=17756
TEST='Under the Hood' -> 'Change proxy settings' still works on Ubuntu Hardy as well as Ubuntu Jaunty.
Review URL: http://codereview.chromium.org/160146
Patch from Joel Stanley.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causes a blank spot which no other thumbnail can be dragged to. This
will go away on page refresh, but we can easily redraw all items
keeping the filler in the rightmost indices.
Original patch by pierre.lafayette@gmail.com, http://codereview.chromium.org/160152
BUG=17738
r=me
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We can use a TYPE_IO loop for the renderer thread on Linux
in single-process mode since we run the plugins out of process.
Review URL: http://codereview.chromium.org/160274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17668
TEST=Run the test
Review URL: http://codereview.chromium.org/160108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
seconds.
This is as opposed to the value of 1 hour in release mode, which makes testing
difficult for people trying to test out autoupdate.
BUG=http://crbug.com/17867
TEST=Run with --enable-extensions --extension-update-frequency=30 will actually update an extension
that has updates after 30 seconds.
Review URL: http://codereview.chromium.org/159490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15418
Review URL: http://codereview.chromium.org/149758
Patch from Chris Masone <cmasone@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Switch NIB.
* Use NSWindowController.
* "Make default browser" button hooked up.
* Import bookmarks still not implemented.
Review URL: http://codereview.chromium.org/149512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingProtocolManagerTest.TestGetHashBackOffTimes
and undisable the test.
TEST=none
http://crbug.com/1880
Review URL: http://codereview.chromium.org/160225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the ability to load multiple text blacklists into the binary blacklist representation.
NOTE: Included Binary file means this change expects to fail on the trybots
in blacklist_io_test.cc:103. All other checks must pass.
BUG=16932
TEST=BlacklistIO*
Review URL: http://codereview.chromium.org/159199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21841 0039d316-1c4b-4281-b951-d872f2087c98
|