summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* ProcessSingleton(all): create the lock immediately after failing to connect ↵mattm@chromium.org2010-05-216-26/+119
| | | | | | | | | | | | | to an existing process. ProcessSingletonLinux: if creating the lock fails, try to notify again. BUG=44417 TEST=manual Review URL: http://codereview.chromium.org/2066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47875 0039d316-1c4b-4281-b951-d872f2087c98
* Don't populate WebDropData with file URLs when dragging files.dcheng@chromium.org2010-05-211-1/+1
| | | | | | | | | | | This is the Windows patch. There will be separate patches for Mac and Linux. BUG=42685 TEST=none Review URL: http://codereview.chromium.org/2126010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47870 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED() that I'm triggering when I righttony@chromium.org2010-05-211-1/+2
| | | | | | | | | | | click on a text field. BUG=None TEST=Right click on a text field with an IME installed. Review URL: http://codereview.chromium.org/2108023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47868 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing mounting case.dhg@chromium.org2010-05-201-1/+1
| | | | | | | | | BUG=chromium-os:3292 TEST=none Review URL: http://codereview.chromium.org/2102013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47866 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for blank status bubble.mirandac@google.com2010-05-201-21/+14
| | | | | | | | | | Fixes a codepath which could possibly lead to an empty status bubble. I haven't been able to repro, but calling SetText instead of SetTextAndAnimate looks like the one spot that doesn't check for an empty string before displaying. Eliminating this loophole by consolidating into a single method, SetText, that always triggers the "hide" animation on an empty string, and only triggers animate if |should_animate| is set. This is actually closer to the SetText method before I added the status bubble expansion code. BUG=43640 TEST=no more empty link target bubbles floating on the screen. Review URL: http://codereview.chromium.org/2111013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47863 0039d316-1c4b-4281-b951-d872f2087c98
* Made feedback icon hidden on login screen.zelidrag@chromium.org2010-05-201-0/+3
| | | | | | | | | BUG=chromium-os:3348 TEST=make sure feedback icon does not show on login mgr screens Review URL: http://codereview.chromium.org/2081015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47861 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: delete text when cutting from the omnibox.estade@chromium.org2010-05-201-2/+5
| | | | | | | | | BUG=44232 TEST=cut all the contents from the omnibox. The url (along with the protocol) should be on both PRIMARY and CLIPBOARD selections. The omnibox should now lay empty. Review URL: http://codereview.chromium.org/2108014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47847 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix GConfValue leak in GConfTitlebarListener.mattm@chromium.org2010-05-201-0/+4
| | | | | | | | | BUG=none TEST=tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.\* (Probably any ui test will work.) Review URL: http://codereview.chromium.org/2106018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47840 0039d316-1c4b-4281-b951-d872f2087c98
* Marking DevToolsSanityTest.TestStepOut as flaky on Linux too.robertshield@chromium.org2010-05-201-1/+1
| | | | | | | | | | BUG=43479 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2111014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47839 0039d316-1c4b-4281-b951-d872f2087c98
* Simple code rearranging to better group by function area and protocol.mrossetti@chromium.org2010-05-203-1583/+1601
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2136020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47838 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: use the shared menu.css for the options menu.arv@chromium.org2010-05-204-34/+11
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/2063014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47837 0039d316-1c4b-4281-b951-d872f2087c98
* Implement full screen lock functionality.oshima@chromium.org2010-05-206-34/+134
| | | | | | | | | | | | | | | | | * Send Unlock request to PM when authentication succeeds. * Re-enable input when Unlock request failed. * Changed if (screen_locker_) to assertion in Show method: state is controlled in PowerManager now, and duplicated Show request should not happen. * Send Unlock/Lock complete to PowerManager. BUG=http://crosbug.com/2914 TEST=none locker Review URL: http://codereview.chromium.org/2126008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47833 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill telephone number prefix and suffix heuristics.dhollowa@chromium.org2010-05-202-2/+43
| | | | | | | | | | | Extends matching of telephone number prefix and suffix fields to include fields explicitly labeled with "prefix" and "suffix" strings. BUG=40694 TEST=PhoneFieldTest.ThreePartPhoneNumberPrefixSuffix Review URL: http://codereview.chromium.org/2129016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47829 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47675.mirandac@chromium.org2010-05-2026-25/+253
| | | | | | | | | | Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data. BUG=18774 TEST=none Review URL: http://codereview.chromium.org/2095020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47827 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing overlap problem when a download in dangerous.dhg@chromium.org2010-05-201-1/+2
| | | | | | | | | BUG=chromium-os:2773 TEST=none Review URL: http://codereview.chromium.org/2079013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47823 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-2010-18/+39
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* Moved ImportantFileWriter to chrome/common in preparation of moving ↵sanjeevr@chromium.org2010-05-207-365/+8
| | | | | | | | | | | JsonPrefStore to chrome/common. BUG=None. TEST=Unit-tests moved and modified. Review URL: http://codereview.chromium.org/2128014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47818 0039d316-1c4b-4281-b951-d872f2087c98
* Marking BrowserEncodingTest.TestOverrideEncoding as FLAKY.robertshield@chromium.org2010-05-201-1/+2
| | | | | | | | | | Bug=44668 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2106020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47817 0039d316-1c4b-4281-b951-d872f2087c98
* Marking BrowserEncodingTest.TestEncodingAutoDetect as FLAKY. robertshield@chromium.org2010-05-201-1/+2
| | | | | | | | | | BUG=44666 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2071021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47814 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a preference for the tab key cycling between just form fields, or ↵rsesek@chromium.org2010-05-205-0/+23
| | | | | | | | | | | | | | | links as well. XIB change: Add a checkbox bound to FilesOwner.tabsToLinks underneath the translate webpages preference. BUG=31177 TEST=Uncheck Chromium-->Preferences-->Under the Hood-->Pressing Tab... Then press Tab on Google.com and the links don't get focus; it alternates between search field and location bar. Review URL: http://codereview.chromium.org/2082011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47807 0039d316-1c4b-4281-b951-d872f2087c98
* Boot times weren't getting displayeddavemoore@chromium.org2010-05-202-4/+4
| | | | | | | | | BUG=NONE TEST=Ensure that boot times are shown at startup. Review URL: http://codereview.chromium.org/2102011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47805 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=chromium-os:3362nkostylev@google.com2010-05-202-7/+4
| | | | | | | | TEST=After bubble is shown select another window/open dialog. Review URL: http://codereview.chromium.org/2111012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47804 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionTestRoundTripApiCall.RunTest as FLAKY.cbentzel@chromium.org2010-05-201-1/+3
| | | | | | | | | BUG=44650 TEST=None Review URL: http://codereview.chromium.org/2083017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47800 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent valgrind errors due to incomplete animations by providing a test ↵mrossetti@chromium.org2010-05-205-5/+29
| | | | | | | | | | | setting to have animations ignored. Apply it to the BookmarkBarControllerTest.OffTheSideButtonHidden unit test. BookmarkBarController and BookmarkBarFolderController now have a -[setIgnoreAnimations:] function for accomplishing this. BUG=44563 TEST=None Review URL: http://codereview.chromium.org/2095017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47799 0039d316-1c4b-4281-b951-d872f2087c98
* Clear password field when navigating though users on the login screen.nkostylev@google.com2010-05-204-9/+34
| | | | | | | | | BUG=chromium-os:2319 TEST=Enter password on the login screen. Navigate to the left/right user window. Navigate back. Password field should be empty. Review URL: http://codereview.chromium.org/2132011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47785 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47746 - Reenabling TestAboutChromeViewAccObj.cbentzel@chromium.org2010-05-201-1/+1
| | | | | | | | | | | | | | | This test appears to be passing fine. TEST=NONE BUG=NONE TBR=dmazzoni@chromiun.org TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/2124013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47739 - Fix failure of ↵cbentzel@chromium.org2010-05-201-8/+5
| | | | | | | | | | | | | | | | | | | browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj This still failed on the continuous builds. Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible. BUG=44486 TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/2119010 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/2075022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47783 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/2081006/show on behalf of ↵zelidrag@chromium.org2010-05-2010-78/+402
| | | | | | | | | | | | | | | rkc@chromium.org: Changes for sending user e-mail along with the feedback Changes to implement complete userfeedback stack. TBR=zelidrag@chromium.org TEST=none BUG=chromium-os:2761 Review URL: http://codereview.chromium.org/2090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47777 0039d316-1c4b-4281-b951-d872f2087c98
* Show the extension name in the task manager for extension created worker ↵jam@chromium.org2010-05-204-2/+31
| | | | | | | | | processes. BUG=30713 Review URL: http://codereview.chromium.org/2108015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47776 0039d316-1c4b-4281-b951-d872f2087c98
* Run WebSocket experiment if reporting is active.ukai@chromium.org2010-05-202-2/+13
| | | | | | | | | BUG=44626 TEST=none Review URL: http://codereview.chromium.org/2093009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47775 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed sync unit test leak and removed suppression.akalin@chromium.org2010-05-201-0/+1
| | | | | | | | | BUG=44540 TEST=ran valgrind on sync unit tests Review URL: http://codereview.chromium.org/2105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47771 0039d316-1c4b-4281-b951-d872f2087c98
* Share the same label between the language selector and the options dialog.satorux@chromium.org2010-05-201-9/+12
| | | | | | | | | | | | The "Language and Input" dialog is opened from two places. We should share the same label in the two places. BUG=3431 TEST=manually Review URL: http://codereview.chromium.org/2094014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47769 0039d316-1c4b-4281-b951-d872f2087c98
* Integrated new bug icon in status bar. It opens bug reporting dialog.zelidrag@chromium.org2010-05-209-0/+143
| | | | | | | | | | BUG=chromium-os:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Review URL: http://codereview.chromium.org/2134009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47762 0039d316-1c4b-4281-b951-d872f2087c98
* Simple change that re-positions the arrow location on displayed extension ↵twiz@google.com2010-05-203-30/+129
| | | | | | | | | | | popup views. This change allows popups to re-orient themselves if they are partially clipped by the working monitor. Note that this only applies to popups created via the experimental extension popup API. BUG=42779 TEST=None Review URL: http://codereview.chromium.org/1774012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47760 0039d316-1c4b-4281-b951-d872f2087c98
* Create gdk_event right way to elimination compilation error in chroot ↵oshima@chromium.org2010-05-201-3/+6
| | | | | | | | | | | | | | environment. I didn't bother allocating new one because i thought none is using event object except for our code, but i was wrong. TextField is copying the struct, which was causing the warning. BUG=none TEST=none Review URL: http://codereview.chromium.org/2086017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47749 - Integrated new bug icon in status bar. It opens bug reporting ↵cbentzel@chromium.org2010-05-209-265/+0
| | | | | | | | | | | | | | dialog. BUG=chromiumos:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Review URL: http://codereview.chromium.org/2135005 TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/2125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47751 0039d316-1c4b-4281-b951-d872f2087c98
* For notifications, use the same shadow border that the autocomplete dropdown ↵johnnyg@chromium.org2010-05-193-62/+87
| | | | | | | | | | | uses rather than using images. This looks a lot sharper. BUG=none TEST=none Review URL: http://codereview.chromium.org/2078019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47750 0039d316-1c4b-4281-b951-d872f2087c98
* Integrated new bug icon in status bar. It opens bug reporting dialog.zelidrag@chromium.org2010-05-199-0/+265
| | | | | | | | | BUG=chromium-os:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Review URL: http://codereview.chromium.org/2135005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47749 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add _CHROME_LOGGED_IN property on root window.derat@chromium.org2010-05-194-15/+25
| | | | | | | | | | | | | | | This gets set to either 1 or 0 depending on whether the user is currently logged in or not. I'm doing this as a step towards using the same window manager process during and after login; this will let the WM know which log file it should be using, for instance. BUG=chromium-os:2790 TEST=tried it, and will add an autotest for this soon Review URL: http://codereview.chromium.org/2078017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47748 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabling TestAboutChromeViewAccObj.ctguil@chromium.org2010-05-191-1/+1
| | | | | | | | | | | | This test appears to be passing fine. TEST=NONE BUG=NONE TBR=dmazzoni@chromiun.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47746 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for Nigori permute and decrypt.albertb@chromium.org2010-05-191-0/+29
| | | | | | | | | BUG=none TEST=NigoriTest.* Review URL: http://codereview.chromium.org/2089019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47745 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extensions to be overinstalled with extensions of sameaa@chromium.org2010-05-1910-162/+69
| | | | | | | | | | | | | | | | | | | | | | version. This is useful during development, for switching themes, and for user scripts (since user scripts have no development mode). Since we can't always immediately delete the version directory for an extension after unloading it (because some files might be in use), this required changing the directory layout of the extensions directory to allow multiple copies of the same version of the same extension to be present at once. This was done by adding a counter to the version directory name. Also get rid of all the old "Current Version" cruft, since we no longer use that. BUG=26538 Review URL: http://codereview.chromium.org/1521039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47740 0039d316-1c4b-4281-b951-d872f2087c98
* Fix failure of ↵ctguil@chromium.org2010-05-191-5/+8
| | | | | | | | | | | | | | browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible. BUG=44486 TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/2119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47739 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI shared resources: Update menu style to follow Roma's spec for menusarv@chromium.org2010-05-191-10/+22
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2104011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47736 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks: Reorganize the HTML a bit to reduce loading flicker.arv@chromium.org2010-05-191-109/+99
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2097011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47734 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a bunch of TODO(shess).shess@chromium.org2010-05-199-54/+22
| | | | | | | | | | | | | | | | | | The TODO on AutocompleteEditViewMac about the popup needing the field for placement and font got half done. The placement part just seemed too intrusive to be worthwhile, but the font part seemed reasonable to get rid of. The others are all either not sensible anymore, or were addressed without being removed, or have been in there long enough that if nobody has complained by now, their subject must not matter. BUG=none TEST=none Review URL: http://codereview.chromium.org/2127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47732 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill fill billing address when credit card settings specify a billing ↵dhollowa@chromium.org2010-05-196-54/+219
| | | | | | | | | | | | | | | | | | | address. Fixes address type matching in |AddressField::AddressTypeFromText| method. Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences. Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others. BUG=44227 TEST=AddressFieldTest.ParseOneLineAddress, \ AddressFieldTest.ParseOneLineAddressBilling, \ AddressFieldTest.ParseOneLineAddressShipping, \ AutoFillManagerTest.FillCreditCardForm, \ AutoFillManagerTest.FillCreditCardFormWithBilling, \ FormStructureTest.HeuristicsSample8, \ and manual test with everything2.html bug file. Review URL: http://codereview.chromium.org/2078016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47731 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionTestSimpleApiCall, RunTest as flaky after failure on Vista ↵robertshield@chromium.org2010-05-191-1/+1
| | | | | | | | | | | | Tests. BUG=44599 TEST=none TBR=cbentzel,joi Review URL: http://codereview.chromium.org/2071019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47724 0039d316-1c4b-4281-b951-d872f2087c98
* Change default to three threads for video decoding and add command line ↵fbarchard@chromium.org2010-05-191-1/+2
| | | | | | | | | | | --video-threads. BUG=44128 TEST=player_wtl.exe --video-threads=6 d:\mediatests\crowd\crowd2.mp4 Review URL: http://codereview.chromium.org/2080008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash when refreshing extensions.finnur@chromium.org2010-05-193-1/+34
| | | | | | | | | | | | | | If you have two extensions with page actions, you can get into a state where it crashes if you refresh Extension A, then Extension B and Extension A again. BUG=http://crbug.com/44415 TEST=Covered by new test ExtensionBrowserTest.PageActionRefreshCrash Review URL: http://codereview.chromium.org/2134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47722 0039d316-1c4b-4281-b951-d872f2087c98