| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
tree view.
BUG=18960
TEST=Double click the empty space of the task manager tree view. The browser should not crash.
Review URL: http://codereview.chromium.org/165253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: We are very liberal in hiding the mouse cursor, much like Preview
and some other apps. Safari is much more conservative (e.g., press "x"
in random text content), but for us to do that we'd have to wire up the
renderer to tell us when to hide the cursor.
BUG=14077
TEST=Give web content keyboard focus, press various keys.
Patch by viettrungluu@gmail.com
Review URL: http://codereview.chromium.org/165252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/165097 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18582
TEST=Open the task manager. The "End Process" button should not be sensitive.
Review URL: http://codereview.chromium.org/164261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would render the window as maximized, but the window state wouldn't be
set properly.
TEST=Start chrome, maximize chrome, close chrome. Restart chrome. Window
controls in compiz should be the maximized version and there should
be no rounded corners.
Review URL: http://codereview.chromium.org/165186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExternalTabContainer instantiates
an automation profile object which implements the Profile interface. This object was not being
passed the external tab handle which is needed for cookies to be set correctly in the external host.
HTTP Post requests should not be treated as top level URL requests to be handled by the external host.
These were getting converted incorrectly to HTTP Get requests thus resulting in Post requests not
working correctly in the external tab container.
Fixes bug http://b/issue?id=2042101
Bug=2042101
Review URL: http://codereview.chromium.org/164207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=\
Make browser window thin (e.g. 400pix wide).
Show bookmark bar. Quit. Relaunch.
Make sure the "off the side" chevron on the bookmark bar is pinned to the right of the window.
Resize width wider and thinner a little; make sure chevron stays pinned.
Make browser window wide (e.g. 1000pix wide).
Quit. Relaunch.
Make sure chevron is pinned to the right of the window.
Repeat all these tests but close the bookmark bar before quitting so it starts life closed.
Review URL: http://codereview.chromium.org/165207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window edge. Middle clicking a link on the page shouldn't do
this.
BUG=15430
Review URL: http://codereview.chromium.org/164257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory the pickle was created from is deleted. I don't think the
current code actually causes a problem as Pickle's destructor won't
attempt to delete the memory in this case, but I'm adding this to make
it clear the Pickle should be deleted and prevent any future problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to http://src.chromium.org/viewvc/chrome?view=rev&revision=22540,
which eliminated one crash, but still left behind another, this time due to
racing between history backend and WebView creation.
The solution is to make sure no visited-link-related messages are sent to the
rendering process until we know for sure it is created.
BUG=17555
TEST=VisitedLinkeRelayTest.WebViewReadiness
R=darin
Review URL: http://codereview.chromium.org/165210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more items.
This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008.
BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.
Review URL: http://codereview.chromium.org/159853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to URLPickerDelegate.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/164149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a user pressed RELOAD, FORWARD, or BACK buttons.
Note that this change does not revert the bar when Command+r is pressed. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 .
Windows change: http://codereview.chromium.org/155908
Linux change: http://codereview.chromium.org/164137
BUG=18710
TEST=The same as http://codereview.chromium.org/155908 (except the F5 stuff since Chromium Mac seems not to support F5 reload?)
Review URL: http://codereview.chromium.org/164145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60
TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later.
Review URL: http://codereview.chromium.org/160444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
lower the window. This is Chromium's custom titlebar, not the one provided
by the window manager.
BUG=15430
Review URL: http://codereview.chromium.org/165123
Patch from Nigel Tao <nigeltao@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The existing code attempted to do this but it had a bug.
BUG=18530
Review URL: http://codereview.chromium.org/165094
Patch from Doug Muir <dmuir@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=28094 is in. Until then, this will be flaky and crash the browser.
TBR=jam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/165134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the main window, in the default theme, we still use the chrome icons.
There are still several more places that need updating: the tab strip, the task manager, etc. I will deal with that later.
BUG=13320
Review URL: http://codereview.chromium.org/165194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this bug was masked by how long bookmarks take to create in the primary window (as the bookmark system is loaded late)
BUG=18550
TEST=Install a theme with custom colors for bookmark bar text, then open a new window and verify that the bookmark bar text is themed correctly.
Review URL: http://codereview.chromium.org/165172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Imports Glen's new icons, and creates centered versions of all of them. Then
use these icons in the GTK theme interface.
Also selects the button tinting color to be a lighter color on some very dark
backgrounds.
Review URL: http://codereview.chromium.org/164202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
Review URL: http://codereview.chromium.org/164204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- They will not dismiss when you show and then hide a context menu (unless that context menu initiates certain actions such as "Edit").
- They will dismiss when you click away from them.
BUG=18523
Review URL: http://codereview.chromium.org/164183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
login credentials expire.
Review URL: http://codereview.chromium.org/164161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A DCHECK in SafeBrowsingService::UpdateStarted can potentially be
triggered if there is an error opening the database for reading,
or if there is no response from the server for a update request.
Both of these cases can cause our 'update_in_progress_' flag to
not be reset properly before the next update.
This CL adds:
- a timeout for update responses
- better handling for database errors
that properly resets the update state.
BUG=12835 (http://crbug.com/12835)
TEST=None.
Review URL: http://codereview.chromium.org/165008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation.
This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs.
BUG=18203,18553
TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus.
Review URL: http://codereview.chromium.org/164100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows does this too, it's just not an explicit call.
BUG=18602
Review URL: http://codereview.chromium.org/165158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Install the Zen Spring theme and activate a different window.
The tree overlay should be lighter.
Review URL: http://codereview.chromium.org/164186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valid X509Certificate in the HttpResponseInfo structure passed in if the current URL scheme is https
Not returning this certificate causes a number of DCHECKS to fire in the network stack implementation and in the renderer process, which eventually causes the navigation to fail.
Fix is to return a dummy X509Certificate on the same lines as Gears.
This fixes bug http://b/issue?id=2039699
Bug=2039699
Review URL: http://codereview.chromium.org/164110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18093
TEST= While running Chrome with a theme installed, and force a popup. Note that the popup window is not themed.
Review URL: http://codereview.chromium.org/159871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18784,http://crbug.com/18786
TEST=less redness == more goodness
TBR=tim
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generic ones.
Complete the apis points so the ones folks might need are all there already.
Switch the code using the old calls over to the new helpers.
TEST=no l10n stuff broke
BUG=none
Review URL: http://codereview.chromium.org/165132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Open the web inspector. When it finishes loading, it should show
the chromium icon instead of the last frame of the throbber.
Review URL: http://codereview.chromium.org/164159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This first pass is fairly simple. If a permission is not specified in the
manifest, the corresponding module will not be exposed to script. For example,
without specifying the "tabs" permission, chrome.tabs and chrome.windows will
not be available.
BUG=12140
TEST=no
Review URL: http://codereview.chromium.org/164039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this patch, you have to click repeatedly on a folder to get the context menu to pop up, because the first few clicks dismiss whatever submenus you may have open. This patch fixes that.
There is another problem present with and without this patch where a bookmark bar folder menu that has shown a context menu will not regain the application/X grabs. This makes it possible to use the rest of the browser while the menu is showing, and clicking away from the menu won't dismiss the menu. In the interests of keeping this patch easy to review I will look into that issue separately.
BUG=18275
Review URL: http://codereview.chromium.org/165138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove the "User Data" tab.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: The drop-down menu is actually a drag-down (activating on
click-hold or on drag), working much like Safari's (and other Apple
apps, such as Dictionary). This can be changed to a pop-down if that's
what's desired.
TODO: Show keyboard shortcut for "Show Full History".
Patch by viettrungluu.
BUG=http://crbug.com/13203
TEST=Navigate around, check out and use the menus; do so in multiple tabs and
windows.
Review URL: http://codereview.chromium.org/160496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK+ sends the following events on double click:
GDK_BUTTON_PRESS
GDK_BUTTON_RELEASE
GDK_BUTTON_PRESS
GDK_2BUTTON_PRESS
GDK_BUTTON_RELEASE
If we start a gtk_window_begin_move_drag on the second GDK_BUTTON_PRESS, the call to gtk_window_maximize fails. To work around this, we keep track of the last click and if it's going to be a double click, we don't call gtk_window_begin_move_drag.
BUG=18401
Review URL: http://codereview.chromium.org/165102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13299
TEST=Cntrl-Tab should switch to the next tab, cntrl-shift-tab should switch to the previous tab.
Review URL: http://codereview.chromium.org/164133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views. Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.
BUG=http://crbug.com/17619
TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar. Trigger an infobar and then close it. Trigger
the download shelf and then close it. Trigger a download shelf with the infobar
open, or with the bookmark bar open. Switch to and from fullscreen with various
bars open. Resize the browser window with various bars open. Start the browser
with and without the bookmark bar open. Try all of the above in a popup window.
Review URL: http://codereview.chromium.org/165014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make dialog wider, set first column width to fixed (but resizable), set initial sort order.
BUG=17919
Review URL: http://codereview.chromium.org/164125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18551
TEST=Create a pop-up window.
Fullscreen it (Cmd-Shift-F).
Go back (Cmd-Shift-F again).
Repeat a few times across different launches of Chromium.
Review URL: http://codereview.chromium.org/164024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't animate the infobar closing and opening when switching
between themes.
* Don't show multiple infobars when intalling themes in rapid
succession.
BUG=18213
Review URL: http://codereview.chromium.org/165029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from thiago.farnia at gmail.com. Original review url:
http://codereview.chromium.org/155888
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it stopped working after r22660
Review URL: http://codereview.chromium.org/165108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thumbnails
BUG=15247
TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail
toolbar). Then go to the options menu and "Restore all removed
thumbnails". The removed thumbnails should be back.
Review URL: http://codereview.chromium.org/165107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
color since we already set the shelf to the toolbar background
color.
Review URL: http://codereview.chromium.org/164116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22697 0039d316-1c4b-4281-b951-d872f2087c98
|