| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=With bookmark sync enabled, go to Wrench Menu->Sync my bookmarks. Ensure that the Bookmark Sync section is there and useable.
Review URL: http://codereview.chromium.org/385026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Popups are not implemented within this change.
BUG=23881
TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI.
Review URL: http://codereview.chromium.org/366029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rid of jankyness on 10.6. It really shouldn't have worked right on 10.5 either.
The layer needed to be hosted in a view. Views should not overlap.
The only ways to do this correctly are:
a) Turn on setWantsLayer for the browser view and make a subview to host our
animation.
b) An overlay window
Went with 'b', because 'a' may be a big memory hit, and I'm not sure how
webkit works in a layered environment.
BUG=23500
TEST=see bug
Review URL: http://codereview.chromium.org/385053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
codereview.chromium.org/293019
TEST=BUG=none
Review URL: http://codereview.chromium.org/389016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- don't reload tabs to ensure that a page loaded (it's handled in
waiting for completion of IDC_NEW_TAB)
- simplify the code, making it shorter and issuing less automation calls
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than the "origin".
BUG=26961
TEST=test extension linked in the bug
Review URL: http://codereview.chromium.org/385058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've chosen to use a union here instead of restoring the original memcpy code.
Errors were as follows:
cc1plus: warnings being treated as errors
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘virtual bool SafeBrowsingDatabaseBloom::ContainsUrl(const GURL&, std::string*, std::vector<int, std::allocator<int> >*, std::vector<SBFullHashResult, std::allocator<SBFullHashResult> >*, base::Time)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: error: dereferencing pointer ‘full_hash.207’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertSub(int, SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: error: dereferencing pointer ‘full_hash.258’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertAdd(SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: error: dereferencing pointer ‘full_hash.237’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: note: initialized from here
make: *** [out/Release/obj.target/browser/chrome/browser/safe_browsing/safe_browsing_database_bloom.o] Error 1
Review URL: http://codereview.chromium.org/389021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26155
TEST=Install a chrome theme; the default gradient shouldn't be shown on the
popup notification.
Review URL: http://codereview.chromium.org/384063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.close().
BUG=26277
TEST=none
Review URL: http://codereview.chromium.org/385056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added ProfileSyncService::IsSyncEnabled().
BUG=23073
TEST=manually (OS X),trybot
Review URL: http://codereview.chromium.org/389019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set. At the same time, allow it in release mode as well.
BUG=27252
Review URL: http://codereview.chromium.org/384084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18084
TEST=You should be able to undo and redo typing and pasting in the omnibox, unless autocomplete has kicked in or you selected/highlighted an entry in the popup.
Review URL: http://codereview.chromium.org/246009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add DCHECKs for main thread in all the places we use animation contexts.
Added a stack based class that takes an animate flag to enable/disable animation operations (grouping, durations) to clean up the code that does optional animation.
This might help the crashes in the bug because before we created animation context groups when we didn't need them and those empty groups could be tripping up something in the system frameworks (I some something similar in nib loading on 10.6).
BUG=26979
TEST=like we have a repeat fail case...
Review URL: http://codereview.chromium.org/390014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Tha panel allows inspecting cookies and local/session storage which are enabled by default.
TEST=DevToolsSanityTest.TestShowStoragePanel
Review URL: http://codereview.chromium.org/391032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't run experiment task if there are not request context ready yet.
BUG=27491
TEST=none
Review URL: http://codereview.chromium.org/384076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These controls are only visible when sync is enabled. This isn't finished,
but it is enough to be usable.
Made RemoveViewFromView() handle top-most views. Also added
RemoveGroupFromView().
BUG=23073
TEST=manual testing, trybots
Review URL: http://codereview.chromium.org/380006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use assignment/casting in place of memcpy() where possible
* Avoid some unnecessary size_t->int casts by just using size_t
* Be more consistent about usage of SBPrefix type
* Write shorter statements/blocks if possible, e.g. "a -= (b + c);" instead of "a = a - b; a = a - c;"
* Update copyrights
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/386009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reusable.
o Adds the ability to position the arrow of the bubble on the top right as well as the top left (default).
BUG=none
TEST=Nothing should change visually. This is prep for use by browser action popups and the first run UI.
Review URL: http://codereview.chromium.org/385060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r31736 due to valgrind errors.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26713
TEST=still compiles
Review URL: http://codereview.chromium.org/387031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/27301
TEST=new profile with no bookmarks. Shrink horiz width so "bookmarks
go here" text overlaps with "Other bookmarks". Make sure they line up
vertically. Now go to NTP and detach bookmark bar (cmd-shift-b).
Make sure text still lines up.
Review URL: http://codereview.chromium.org/385055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Check the output of localtime() before using it.
BUG=none
TEST=memory_test on 64bit Linux
Review URL: http://codereview.chromium.org/386012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mega patch contains a few simple but tightly dependent changes:
1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org.
2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion.
3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp.
4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch.
Review URL: http://codereview.chromium.org/387020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All In New Window" and "Open All In Incognito Window" (17616).
Bookmark Folders have the bar context menu, not the bookmark context
menu (26748).
Disable bookmark manager item on bookmark contextual menus (26944).
BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944
TEST=Add some bookmarks.
Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu.
Add a bookmark folder.
Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu.
Make sure Bookmark Manager item is DISabled in both context menus.
nib change: hook up actions in the "Open All Blah" items just like the normal "Open All".
Review URL: http://codereview.chromium.org/373022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.
Previous versions of this patch included modifications
to the tab switching test. Those are blocked on setting
up a new builder for accurate measurement and are now
removed from this CL.
BUG=4104
TEST=none
Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31645
Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31679
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31683
Review URL: http://codereview.chromium.org/378038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/386011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes the SetUserText behavior similar to the Windows/Linux versions (by calling SetWindowTextAndCaretPos() that also deals with the selection).
R=shess
BUG=None
TEST=Make sure the location bar still works as expected on Mac.
Review URL: http://codereview.chromium.org/329024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27436
Review URL: http://codereview.chromium.org/391023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
using GTK theme or Classic theme.
BUG=27075
Review URL: http://codereview.chromium.org/384060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows side.
BUG=24132
TEST=none
Review URL: http://codereview.chromium.org/372068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fails to resolve the css and js script files specified in
the manifest. We shouldn't rely on the results of GetFilePath
in the error, but show the relative path instead.
BUG=27423
TEST=Create an extension with a content script, but specify
a css and a js file that doesn't exist. The error message
should be descriptive and make sense.
Review URL: http://codereview.chromium.org/385052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add gtk_tree::TreeAdapter class.
BUG=26713
TEST=compare behavior to windows impl
Review URL: http://codereview.chromium.org/371079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTTP sites. This was because
the automation resource message filter tracked HTTP requests based on the request ids which are generated
by the renderer process. As a result a new request would get created say with id 0, while an existing request
would end in ChromeFrame causing the new request to incorrectly shutdown.
Fix is to revert back to the original way of tracking requests with an auto incrementing id. The automation url
job maintains both ids now, i.e. the automation request id and the chrome request id. The download notification
receives the automation id and basically looks up the associated automation request id and sends the notification
back to ChromeFrame.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=27401
Other fixes in this CL include the following:-
1. The active document instance would never get destroyed. This was because we call ShowUI on the doc host
which maintains a reference. We need to call HideUI in Setsite of NULL, which releases the reference.
2. When the active x instance is shutting down we try to shutdown all running requests in the OnDestroy handler.
To ensure that the request is deleted from the request map and released in the same thread which created it
we post a task back to the ui thread which never runs as the window is being destroyed. Fix is to create
a message only window with every urlmonrequest instance which supports task marshaling.
Tests in a future CL.
Bug=27401
Review URL: http://codereview.chromium.org/386008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread.
Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location.
BUG=19738
Review URL: http://codereview.chromium.org/384040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a chrome theme asks to use a background image on a toolbar button,
use it. Oddly enough, all of the graphics drawing was written but the
plumbing of actually setting the background wasn't...
TEST=Good Smile, Chuck Anderson, etc. should have button backgrounds which
are very different from the toolbar background in the GTK port.
BUG=NONE
Review URL: http://codereview.chromium.org/384057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the dark at a fix for some crashes.
BUG=26979
TEST=dragging tabs over an existing window should still animate as the placeholder shifts around.
Review URL: http://codereview.chromium.org/385048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
massive changes due to the xib are due to editing the xib on SnowLeopard.
Changes internals of bookmark bubble controller so that it will work correctly
with items with the same name.
BUG=27330
TEST=Create several bookmark folders and items using the bookmark bubble and
verify that it is still working correctly.
Review URL: http://codereview.chromium.org/384025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
what these methods actually do, and so I can repurpose them for a different info-bar test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/385029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27399
TEST=Extensions without an icon now have a light-blue
puzzle-piece icon when installing/uninstalling them
and when listing them on chrome://extensions.
Review URL: http://codereview.chromium.org/384055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
has been moved.
BUG=27388
TEST=Click the zoom button on a browser window. Make sure the '+' disappears.
Review URL: http://codereview.chromium.org/384054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the data of the image, where as XDestroyImage does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/386003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31699 0039d316-1c4b-4281-b951-d872f2087c98
|