| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
R=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, found another gtk bug: http://bugzilla.gnome.org/show_bug.cgi?id=594089 We can't write a suppression for this bug because the warning message is too generic, but it shouldn't be much of a problem in release builds.
BUG=20940
Review URL: http://codereview.chromium.org/196014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally was using theme colors, which seem to have changed.
http://crbug.com/20556
TEST=Type www.google.com and hit tab, should see "Search Google:" in a
bubble. The bubble should be blue with a darker background.
Review URL: http://codereview.chromium.org/175055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Randomly chose 90% opaque. For some reason -controlColor didn't work
right anymore for hovered background, switch to -controlHighlightColor
(which sounds closer to the point anyhow).
http://crbug.com/20679
TEST=Omnibox popup should be slightly transparent, but not annoyingly so.
Review URL: http://codereview.chromium.org/188014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=21062
TEST=Click the option menu button (the top right button). The button
should look pressed as long as the menu is visible.
Review URL: http://codereview.chromium.org/201020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch, we'll persist ForceTLS state to disk. It's saved as a
JSON file (ForceTLSState) in the profile directory for the moment.
You still need the --force-https flag in order to trigger any ForceTLS
behaviour.
For the moment, this state isn't cleared when the rest of the browser
state it. That's ok because it's still behind a flag.
http://codereview.chromium.org/186014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bunch of "unrecognized selector sent to instance" NSLogs.
BUG=http://crbug.com/20937, http://crbug.com/20813
TEST=Right-click on a bookmark button and delete it.
Repeat a few times. Make sure we don't crash.
Launch from the command line (.../Chromium.app/Contents/MacOS/Chromium)
Move the mouse around the toolbar hovering over the buttons and the chevron.
Make sure no "does not respond to selector" messages printed.
Review URL: http://codereview.chromium.org/199014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/21092
Review URL: http://codereview.chromium.org/196027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resize to fit the graphic.
Fetch the hung from ResourceBundle since it looks like it should be under theme control.
Swap the kill and wait buttons.
Add in localization objects.
Resize message and window to find localized content.
Bookmark Bubble:
Right align labels to fields.
Make window resize to fit labels.
Switch to small controls per Cole.
Stop bringing the frozen tab graphic into the bundle so we avoid the extra copy.
BUG=20525
BUG=20533
TEST=Hung renderer localized and fits content. Bookmark bubble fits labels in all languages.
Review URL: http://codereview.chromium.org/193020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version string written by OS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/198023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=19858
Review URL: http://codereview.chromium.org/201014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox). The second is to make UpdateGeometry message synchronous for WMP. The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing.
While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate.
BUG=20259
TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235
Review URL: http://codereview.chromium.org/196012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=asargent,phajdan.jr
Review URL: http://codereview.chromium.org/200016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=20801
TEST=Create a new profile and open the new tab page. Pin and reorder the
pre-populated thumbnails. The thumbnails and favicons should continue to
work.
Review URL: http://codereview.chromium.org/195010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/198017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
This is kinda a janky hack to get the browser test to keep
working but I couldn't think of anything better.
Review URL: http://codereview.chromium.org/196015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21044
TEST= try installing a theme with a corrupt image. note that loading bubble disappears.
Review URL: http://codereview.chromium.org/196016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and Reenable.
BUG=20828
Review URL: http://codereview.chromium.org/193013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There seems to be no other reliable way to do that due to Windows file semantics.
This should decrease the flakiness.
TEST=Covered by ui_tests.
http://crbug.com/20809
Review URL: http://codereview.chromium.org/192010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Focus the location bar, deactive/reactivate the browser window with
Alt-Tab, the focus should still be on the location bar.
Click few links on a page to have a history navigation. Focus the location
bar, use backspace to delete some text. Focus a text area in a web page,
make sure backspace works as expected (deletes text). Now click on a non
text area, press backspace. You should trigger a navigate back.
Review URL: http://codereview.chromium.org/185014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/17696
TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading.
Review URL: http://codereview.chromium.org/191011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch, we'll persist ForceTLS state to disk. It's saved as a
JSON file (ForceTLSState) in the user data directory for the moment.
You still need the --force-https flag in order to trigger any ForceTLS
behaviour, however.
For the moment, this state isn't cleared when the rest of the browser
state it. That's ok because it's still behind a flag.
http://codereview.chromium.org/186014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19951,20552
TEST=compare pages rendered in Chromium and Safari. They should appear the same.
mark: review
jrg/brettw: FYI
Review URL: http://codereview.chromium.org/194013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/198012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12347
Review URL: http://codereview.chromium.org/192011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943
BUG=20731
Review URL: http://codereview.chromium.org/194002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcampan
BUG=None
TEST=Release build should work now.
Review URL: http://codereview.chromium.org/196008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar should not change the focus.
Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message.
BUG=9687
TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button.
Review URL: http://codereview.chromium.org/188016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes the buttons drag-able -- you can drag or click and wait to
open their menu. Lucky for me, I wrote reusable code.
To do (not now): The "off-the-end" button on the bookmark bar needs the
same fix.
Bug (not to be fixed now): The menu doesn't do the right thing when the
window is moved off the left edge to the screen -- it doesn't open to
the right in the correct fashion. Nor does it do the proper thing when
you move the window off the bottom edge of the screen -- it doesn't open
upwards entirely correctly. <shrug>
BUG=18572
TEST=Click on the Page and Wrench menu buttons and observe. Also test \
dragging to open.
Review URL: http://codereview.chromium.org/174556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20957
TEST= Install many themes quickly, with many windows open. Close browser and reopen. Theme should not be corrupted.
Review URL: http://codereview.chromium.org/197010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18734
TEST=Launch Chrome. Add some bookmarks then open the bookmark menu.
You should see all "bookmark bar" bookmarks, followed by a separator
line, followed by an "Other bookmarks" submenu at the end.
Go to a bookmark then click on STAR. Change folder to "other bookmarks".
Now open bookmark menu; see item moved from "main page" to the
"other bookmarks" folder at the end.
Undo that change by clicking on STAR, changing parent.
Make sure back to normal.
Review URL: http://codereview.chromium.org/195001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed.
BUG=http://crbug.com/17852
TEST=delete all bookmarks. No chevron.
Add one bookmark to bookmark bar. No chevron.
Make window real wide.
Add some more bookmarks (but not enough that it spills over). No chevron.
Make window thinner. Chevron appears!
Widen window until chevron hides.
Add more bookmarks until it appears again.
Review URL: http://codereview.chromium.org/201005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/20243
TEST=Go to www.popuptest.com. Select test #2, allow one of the popups
through. Try to edit in the omnibox. Should be able to select and
copy, but not enter text.
Review URL: http://codereview.chromium.org/183043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to our tweaking of the text area, the I-beam cursor was sometimes
janky.
http://crbug.com/20238
TEST=I don't even know how to really test this.
Review URL: http://codereview.chromium.org/181011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16106
TEST=none
Review URL: http://codereview.chromium.org/176016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view.
Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled. I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well.
BUG=13279
TEST=none
Review URL: http://codereview.chromium.org/187002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
privileges to the new""
Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed.
BUG=17636
Review URL: http://codereview.chromium.org/172120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
asking Pango"
This reverts commit r25131. It seems to have regressed Linux startup;
will track perf builder after committing this to be sure.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/198006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color.
BUG=20697
TEST=All links on the NTP should have different underline color. Also,
try with different themes.
Review URL: http://codereview.chromium.org/194004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/186019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if a throbber decides it's done animating during the walk. This might happen
for toast throbbers, like the sad tab icon.
TEST=none, really
BUG=20907
Review URL: http://codereview.chromium.org/185016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/19866, http://crbug.com/20828
Review URL: http://codereview.chromium.org/195003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20956
TEST= Install themes, note that tab backgrounds look good.
Review URL: http://codereview.chromium.org/198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20835
TBR=yurys
Review URL: http://codereview.chromium.org/194010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25305 0039d316-1c4b-4281-b951-d872f2087c98
|