| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make the code more object-oriented, make the object expose less accessors
- make some parts of code look more obvious, use existing helpers
- make the public interfaces slightly better (less ctor parameters)
- make some names slightly better
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3029025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49091
TEST='Manage' button in DOMUI Basics prefs should bring up an empty sub-page.
Review URL: http://codereview.chromium.org/2806081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR: arv
BUG=49328
TEST=no bookmark bar promo on first run to empty profile. or ever.
Review URL: http://codereview.chromium.org/3053015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29675
TEST=none
TBR=evan@chromium.org,willchan@chromium.org
Review URL: http://codereview.chromium.org/2884041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative/defensive fix for bug 49274.
BUG=49274
TEST=manual (checked that this didn't break normal behavior)
Review URL: http://codereview.chromium.org/3054018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
insertions and deletions.
BUG=none
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/3039029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3026016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--host-rules seems like a reasonable enough substitute for these two command line flags, and removing them will simplifies the fairly complicated URL rewrite logic in HttpNetworkTransaction.
BUG=None
TEST=built and ran net_unittests
Review URL: http://codereview.chromium.org/3041019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, increase login timeout.
BUG=None
TEST=unit tests
Review URL: http://codereview.chromium.org/3061019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
encoding menu on those pages.
BUG=48157
TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't.
Review URL: http://codereview.chromium.org/3027023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "MainMessageLoopStart()" and related platform methods to handle tasks
directly tied to the start of the main message loop.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/2931007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
closes.
Review URL: http://codereview.chromium.org/3043020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL http://codereview.chromium.org/3026006
Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.
BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.
Review URL: http://codereview.chromium.org/3064002
TBR= nkostylev@chromium.org
Review URL: http://codereview.chromium.org/2878056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port magic from GTMFadeTruncatingTextFieldCell to Chrome's GradientButtonCell, used by buttons in the bookmark bar. Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis.
Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it.
BUG=45104
TEST=Add a bookmark to the bookmark bar and increase the length of it's title. Once you get past a certain length, rather than truncate the title should fade out nicely. Exactly in the same way long tab titles do. Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast.
Review URL: http://codereview.chromium.org/2806066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Tests that use a regular PrefService are green.
Review URL: http://codereview.chromium.org/3046023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add test register form page.
Added extra debug logging.
Full cycle:
1. Register screen navigates to chrome://register (host page).
2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event.
3. Once URL is received it is loaded in an iframe.
4. When register form is loaded it sends get_user_info msg via postMessage to host page.
5. host page requests DOMUI for system/user info: getUserInfo msg.
6. Once info is received host page sends that to an iframe with set_user_info msg.
7. Register form notifies host page on registration success/skip status with complete_registration msg.
8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified.
BUG= http://crosbug.com/4813
TEST=manual
Review URL: http://codereview.chromium.org/3058006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
swap Alt/Ctrl keys and Search/Ctrl keys.
BUG=chromium-os:2636
TEST=manually on eeepc
Review URL: http://codereview.chromium.org/3038025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed that the layout names added in generated_resource.grd appear in the languages and input dialog. also confirmed that error messages are gone from logs.
BUG=chromium-os:3440
Review URL: http://codereview.chromium.org/3063007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser connected to the renderer. This basically
meant that if the browser process exited then other popups could not query cookies from the host.
Part of the fix for http://b/issue?id=2277519
Bug=2277519
Review URL: http://codereview.chromium.org/3066004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move utility functions into a header file (currently chewing and pinyin
are the customers).
TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4808
Review URL: http://codereview.chromium.org/3015028
Patch from Takayoshi Kochi <kochi@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2636
TEST=manually on eeepc, ran the browser_tests
Review URL: http://codereview.chromium.org/2806077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not be misleading (e.g. "depressed" where it should be "disabled"). Better indenting. Inline a function that has only one caller for simplicity.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).
BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Nicer indenting.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, the language name and the input method list were
hard-coded in the HTML file. With this change, these values will be
displayed based on the underlying data from C++ world.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3008016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change.
Make naming for theme and locale changes consistent and clear.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2878055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3075001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50107
TEST=Resize gripper nest to browser actions container should no longer appear
Review URL: http://codereview.chromium.org/3052011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/3028018 on behalf of zbehan@.
third_party: add a stub cros directory and cros_api.gyp for libcros to satisfy gyp depdendencies
cros: fix more of the third_party includes, forbid similar includes for future
BUG=none
TEST=make sure both chrome and chromeos builds are happy.
TBR=zelidrag
Review URL: http://codereview.chromium.org/3035021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Readibility review code using the cocoa browser accessibility stuff for
objective c
Review URL: http://codereview.chromium.org/2951011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49037
TEST=Close clear browser data overlay dialog during clear operation.
Review URL: http://codereview.chromium.org/2873067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by jwillcox@litl.com:
http://codereview.chromium.org/2904010/show
BUG=48066
TEST=Load a page from new tab page, then ensure the thumbnail is updated by viewing the new tab page again
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and don't care about people who manually hack the DLLs.
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3071002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests currently use the method AwaitSyncCycleCompletion(), which ends up waiting for a sync event before it signals the end of a sync cycle. However, if it is called after the sync cycle is already complete, it ends up waiting for several seconds for a random unrelated sync event before it returns.
This checkin fixes this unnecessary delay by checking to see if the client has any unsynced items before it waits, thereby significantly speeding up the sync integration tests.
In addition to this, a new method called AwaitQuiescence() is now available to test cases so they can wait for racy updates initiated by multiple clients to propagate across the system.
BUG=49998
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3041018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PasswordStore can only be queried from one thread, although the implementation
doesn't immediately look it. This adds DCHECKs to ensure we don't mess this up
in future.
R=wtc,stuartmorgan
BUG=none
TEST=PasswordManagerTest.*
Review URL: http://codereview.chromium.org/3056008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=compile
BUG=44549
Review URL: http://codereview.chromium.org/3032025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make TabContentsDelegate::IsPopup a const function;
- Add a default implementation for IsPopup;
- Update all derived classes;
- Remove the bad const_cast in tab_contents.cc;
BUG=none.
TEST=none. Code quality improvement and expect no changes.
Review URL: http://codereview.chromium.org/3060013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See also http://codereview.chromium.org/3048020
BUG=49972
TEST=Manually
Review URL: http://codereview.chromium.org/3007012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This only shows the existing exceptions (doesn't allow you to add or remove them). It also only works for image exceptions. It always shows the exceptions, instead of hiding/showing them when you press the exceptions button.
BUG=48862
TEST=manual
Review URL: http://codereview.chromium.org/2856058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes separator used in AutoFill label containing credit card info to prefix the card number with an asterisk.
BUG=50075
TEST=AutoFillManagerTest.GetCreditCardSuggestions*
Review URL: http://codereview.chromium.org/3029030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL http://codereview.chromium.org/3026006
Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.
BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.
Review URL: http://codereview.chromium.org/3064002
TBR=dpolukhin@chromium.org
Review URL: http://codereview.chromium.org/3030020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2832080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50240
TEST=none
Review URL: http://codereview.chromium.org/3039030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Revert http://codereview.chromium.org/3064004
BUG=50103
TEST=memory bots, heapcheck.
Review URL: http://codereview.chromium.org/3023018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
only the troublesome script is reloaded.
Retry logic frequency on an exponential backoff.
Review URL: http://codereview.chromium.org/3019018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3072
TEST=none
Review URL: http://codereview.chromium.org/3018013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL http://codereview.chromium.org/3026006
Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.
BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.
Review URL: http://codereview.chromium.org/3064002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
getting put into
browser history.
BUG=none
TEST=Exercise overlays in dom-ui options window via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3017027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53634 0039d316-1c4b-4281-b951-d872f2087c98
|