| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Review URL: http://codereview.chromium.org/21018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(non-versioned) directory. This is designed for developers to iterate on extension development without having to go through the install process.
Review URL: http://codereview.chromium.org/20020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
languages when the user changes the language from languages options menu.
It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region.
Issue=5829
Review URL: http://codereview.chromium.org/19520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke chromium full build.
Review URL: http://codereview.chromium.org/21024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
specific code for the settings dialog and the table view are just copied from
the old dialog. I tried to change as little as possible. The only significant
change should be that I commented out saving the settings in the profile.
Review URL: http://codereview.chromium.org/19741
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a method that allows loading a single specific extension.
Load extensions upon successful install.
Review is for which ever one of you gets in first, or both if you care. ;-)
Review URL: http://codereview.chromium.org/19759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
POSIX: bitmap data on the wire
On Windows, when drawing a given rect in the renderer, we allocate memory for the bitmap, render and send a shared memory handle across IPC. In the browser, we bitblit the shared memory to the backing store and draw it to the screen.
In the long term, on Linux, we want the backingstore to be shared with both X and the renderer. The renderer then draws directly to that store, sends an IPC to the browser and the browser sends a message to X to bitblit to the display. Since only cache a few backing stores we'll need messages from the browser to tell the renderer to attach and detatch from shared memory regions as they get created and evicted.
In the short term, however, to get something that works, we make a BitmapWireData typedef. This will be a shared memory region on Windows, as before, and on POSIX we'll be sending the bitmap data over the wire. Obviously this'll be pretty slow but it'll work sooner.
Review URL: http://codereview.chromium.org/19491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes are basically hacks, but they're hacks that get our frame width, tabstrip layout (in non-OTR mode), and client edge drawing to exactly match pre-Magic-BrowzR code. In subsequent changes I will clean this all up to work better.
This also fixes windows refusing to become activated.
BUG=5054,6174
Review URL: http://codereview.chromium.org/19548
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/6294
Review URL: http://codereview.chromium.org/19767
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Makes over 200 tests pass on Linux.
Review URL: http://codereview.chromium.org/18758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also fixes a regression from the BrowserInit porting work. I was a little over-zealous removing the CommandLine handling. It turns out that it's this that MessageWindow uses to convey the command line of the signalling process to the existing process, and that the existing process re-runs BrowserInit with the signalling process' command line. So I plumbed that back through again.
Review URL: http://codereview.chromium.org/19746
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
notification service via some other dependency before.
Also fix some other omissions I made.
Review URL: http://codereview.chromium.org/19529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
variety of places and added ones in other files that were accidentally
depending on them.
Review URL: http://codereview.chromium.org/19742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
really painful to add more types, since lots of headers include the
notification service to derive from the notification observer. This splits that
out, so much less of the project should end up including notification_types.h
---Paths modified but not in any changelist:
Review URL: http://codereview.chromium.org/19744
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=pinkerton,brettw
Review URL: http://codereview.chromium.org/19528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Force OS to decide about doing network lookup, rather
than guessing whether it is in the cache before asking
the OS. This will cost more OS operations, but should
roughly double the hit rate for scan based pre-resolution.
r=mbelshe
Review URL: http://codereview.chromium.org/19524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser.
Review URL: http://codereview.chromium.org/14142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
loading yet)
Review URL: http://codereview.chromium.org/19525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of windows messages are performed on the UI thread.
SetClipboardData requires the clipboard to be open with a handle
to a window that will be notified when the contents are going to
change again. If Windows messages are not processed, any other app
writing to the clipboard will be locked while we acknowledge their
request (by processing the message).
The IO thread doesn't pump windows messages anymore so write
clipboard operations cannot be performed from that thread and have
to be posted to another thread.
BUG=5823
Review URL: http://codereview.chromium.org/19733
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=idanan
Review URL: http://codereview.chromium.org/19735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Have files of that type automatically download and open.
Review URL: http://codereview.chromium.org/19403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin parent window which lives on the browser UI thread is destroyed asynchronously, we may have stale windows which have already been destroyed sent by the renderer for moving around.The DeferWindowPos API fails on receiving such a window.
Review URL: http://codereview.chromium.org/19523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19721
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
platform-specific files, and have WebContents just use the platform-independent
header that declares the creation functions.
Review URL: http://codereview.chromium.org/19719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for example Linux.
The problem was that old code assumed wstring is UTF-16, which resulted
in string corruption on Linux. I actually tested it on browser/history
unit tests, see http://codereview.chromium.org/18758.
Review URL: http://codereview.chromium.org/18805
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19711
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
kSetupExe constants to the executable path.
Review URL: http://codereview.chromium.org/19493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1609821
Review URL: http://codereview.chromium.org/19694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Wrong titlebar height
* Titlebars not handling custom font size properly
* Drawing errors in maximized mode
* One-pixel overlap glitch on bottom corners of client edges
* Borders not handling custom border sizes correctly
* Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip)
* Wrong icon sizing (only a problem in theory, no one uses this code ATM)
These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable.
BUG=5054
Review URL: http://codereview.chromium.org/19484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://clients4.google.com/firefox/metrics/collect,
which has a certificate that matches the host name.
Remove the net::LOAD_IGNORE_CERT_COMMON_NAME_INVALID
load flag.
R=evanm
BUG=b/876021
Review URL: http://codereview.chromium.org/19450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a proof of concept I converted
FindInPageControllerTest.FindInPageFrames over to this.
See the description in InProcessBrowserTest for how it all works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
formatting changes, i.e. CRLF, space at end of line.
Review URL: http://codereview.chromium.org/19486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is mostly making sure we have all the symbols we need.
Review URL: http://codereview.chromium.org/19683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The first run import will trigger the eula again : this requires changes in browser_main.cc
so the master prefs are not processed again by the importer process
- The launch of setup.exe to show the eula was using a path that only works on developer builds
this requires relocating a constant from setup_constants to util_constants
BUG=1468838
Review URL: http://codereview.chromium.org/19680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation.
This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes.
This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.)
Review URL: http://codereview.chromium.org/19684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
|