summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Don't allow hotkeys to activate un-activatable menu items on linux.estade@chromium.org2009-04-021-2/+6
| | | | | | | BUG=9400 Review URL: http://codereview.chromium.org/56184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13025 0039d316-1c4b-4281-b951-d872f2087c98
* A file I left out of rietveld issue 56153estade@chromium.org2009-04-021-1/+1
| | | | | | | | TBR=paul Review URL: http://codereview.chromium.org/56182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13019 0039d316-1c4b-4281-b951-d872f2087c98
* Installing extensions (drag/drop, download crx file) will now begeorged@chromium.org2009-04-016-9/+74
| | | | | | | | | handled by the Chrome instance w/o shell execute. This will install the extension in the proper profile using the running bits. Review URL: http://codereview.chromium.org/55046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13000 0039d316-1c4b-4281-b951-d872f2087c98
* Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.hdarin@chromium.org2009-04-012-6/+18
| | | | | | | | | | | | | This also eliminates webkit_glue::GetScreenInfo and webkit_glue::GetScreenInfoHelper. As part of this CL, I also extracted all of the ParamTraits for WebKit API types into chrome/common/webkit_param_traits.h. R=dglazkov Review URL: http://codereview.chromium.org/58008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12993 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-013-1574/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable save package on linux, mac.estade@chromium.org2009-04-012-12/+16
| | | | | | Review URL: http://codereview.chromium.org/56153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12966 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to set the cursor on null windows.estade@chromium.org2009-04-011-0/+5
| | | | | | Review URL: http://codereview.chromium.org/59003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12964 0039d316-1c4b-4281-b951-d872f2087c98
* Fix distributor logo placement on glass frame when window is restored from ↵ben@chromium.org2009-04-012-0/+10
| | | | | | | | | | | | fullscreen. Force a layout in WM_NCCALCSIZE since NC metrics can change as a result of handling this message. http://crbug.com/8511 Review URL: http://codereview.chromium.org/56086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12930 0039d316-1c4b-4281-b951-d872f2087c98
* Port plugin messages.jam@chromium.org2009-04-013-35/+18
| | | | | | Review URL: http://codereview.chromium.org/49050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12928 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: DeleteURLAndFavicon was a friend.agl@chromium.org2009-04-011-1/+1
| | | | | | | ... so the FRIEND_TEST needs the "DISABLED_" in it too :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12922 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DeleteURLAndFaviconagl@chromium.org2009-04-011-1/+1
| | | | | | | | This test started failing. However, reverting doesn't change anything! Disabling for now, hclam is looking into it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12921 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebConsoleMessage instead of ConsoleMessageLevel.darin@chromium.org2009-03-315-15/+26
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/57073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12916 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't use static ChromeFont objectsagl@chromium.org2009-03-312-5/+5
| | | | | | | | | | With Darin's change (12485) we now have huge library trees from almost every target. This is breaking because the static ChromeFont is entering Skia before Skia has been constructed. This will only bite us in the future if we have static ChromeFont objects. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12908 0039d316-1c4b-4281-b951-d872f2087c98
* OCD fixing of style for the initializer list of ExtensionView.brettw@chromium.org2009-03-311-3/+6
| | | | | | Review URL: http://codereview.chromium.org/56113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ninebox rendering.estade@chromium.org2009-03-311-23/+15
| | | | | | | | | | | - Correct some wrong x/y coords. - Get rid of FillWidget. We can't paint the widget with a debugging color because some of our images are partially translucent, so the debug color will shine through. TEST=CustomContainerButton hover-over should now appear properly. Download items in the shelf should appear properly. Review URL: http://codereview.chromium.org/56091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12898 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create an empty folder when saving complete html pages with no extra ↵estade@chromium.org2009-03-311-3/+3
| | | | | | | | | | resources to save. patch by Paul Robinson <http://codereview.chromium.org/57030> Review URL: http://codereview.chromium.org/56089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12897 0039d316-1c4b-4281-b951-d872f2087c98
* Record new tab button presses.glen@chromium.org2009-03-311-1/+3
| | | | | | Review URL: http://codereview.chromium.org/56049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12896 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebScriptSource and WebFindInPageRequest from the WebKit API.darin@chromium.org2009-03-313-13/+14
| | | | | | | | | | | | | | | | | | This change introduces some helper functions in glue_util.cc for efficient conversion between WebString and WebCore::String when inside the implementation of webkit/glue. This is a temporary change since eventually all code in glue that uses WebCore will be moved into the WebKit API implementation. Instead of making the Chrome automation use WebFindInPageRequest, I decided to introduce AutomationMsg_Find_Params as a copy of the old FindInPageRequest structure. That preserves the IPC protocol and avoids making the automation library depend on WebKit. R=dglazkov Review URL: http://codereview.chromium.org/57060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12881 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the gtk tab rendering code to use ChromeCanvas instead of directly ↵jhawkins@chromium.org2009-03-314-159/+102
| | | | | | | | drawing with gdk. Review URL: http://codereview.chromium.org/57063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12880 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitted code from revision 12809. The bug in the Windows SSL stack thatmarkus@chromium.org2009-03-311-2/+10
| | | | | | | this code originally uncovered has been fixed in a separate changelist. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12876 0039d316-1c4b-4281-b951-d872f2087c98
* Delete downloads after updating observers.paulg@google.com2009-03-311-3/+7
| | | | | | | | | | | | | | | | | | The download page adds itself as an observer to in-progress and unconfirmed dangerous downloads, and removes itself when the download manager indicates its state has changed. This caused a crash when the downloads were deleted during a "clear browsing data" operation, since the delete happened before the download page was notified of a download manager state change. The download page then attempted to remove itself from a deleted item. BUG=9444 (http://crbug.com/9444) Review URL: http://codereview.chromium.org/56096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12874 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify code in PrintSettings. Removes support for settings marginssverrir@chromium.org2009-03-316-103/+36
| | | | | | | | | | etc in metric units but I will add again if required. This is to prepare adding user defined print settings. Also fixes some typos in printing code. Review URL: http://codereview.chromium.org/56077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12856 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "id" key for extension manifests optional inaa@chromium.org2009-03-315-56/+84
| | | | | | | | | | | | | | --load-extension mode. This makes this mode more convenient, and should lead to less copy-and-paste of extension IDs. Also, remove the "format_version" key. This is basically duplicated in the code that checks the version number of the crx file format. And if we ever really need a format version for the manifest, we can always add it later. Review URL: http://codereview.chromium.org/56044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12837 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanic change based on comment from previous code review.huanr@chromium.org2009-03-313-9/+8
| | | | | | | | | Rename RunCommand to RunCommandAsync and RunCommandSync to RunCommand. Review URL: http://codereview.chromium.org/57039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
* Display a title for files in the back/forward menu.estade@chromium.org2009-03-301-1/+2
| | | | | | | | | | Patch by Paul Robinson <http://codereview.chromium.org/56045> BUG=7871 Review URL: http://codereview.chromium.org/57013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some line endings in browser/dom_ui.brettw@chromium.org2009-03-302-115/+115
| | | | | | Review URL: http://codereview.chromium.org/57028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12818 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting, as this changelist broke unittests on Windows.markus@chromium.org2009-03-301-10/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12816 0039d316-1c4b-4281-b951-d872f2087c98
* Make NTP work by correctly marking the kind of urls we type in. Patch from ↵pinkerton@chromium.org2009-03-301-1/+5
| | | | | | rohitrao@google.com. http://codereview.chromium.org/55058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12810 0039d316-1c4b-4281-b951-d872f2087c98
* Change the bad-certificate handler for SSL (using NSS) to return anmarkus@chromium.org2009-03-301-2/+10
| | | | | | | | | | | | | | | | | | | | | | | error. This requires a few additional changes in the rest of the code. In particular, we now have to teach HttpNetworkTransaction about how to restart connections with bad certificates. This was originally intended to be done by ReconnectIgnoringLastError(), but that API turns out be very difficult to implement in the SSLClientSocket. So, instead, we just create a completely new SSLClientSocket. We also have to be careful to store a copy of the certificate from within the bad-certificate handler, as it won't be available by the time GetSSLInfo() is called. And we fix a bug that would cause us to erroneously talk SSL on reconnected TCP sockets, even though we were still supposed to negotiate a proxy tunnel first. Review URL: http://codereview.chromium.org/43115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12809 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-3017-184/+245
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
* Break out the tab rendering logic into TabGtk and TabRendererGtk.jhawkins@chromium.org2009-03-3010-646/+1324
| | | | | | Review URL: http://codereview.chromium.org/56030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12795 0039d316-1c4b-4281-b951-d872f2087c98
* The NativeButton HWND would not be created yet when we were setting the ↵jcampan@chromium.org2009-03-301-5/+5
| | | | | | | | | | | | initial focus in the first run bubble view. This CL makes sure to set the focus when everything is set-up. BUG=9387 TEST=Run chrome to show the first run bubble (you can use the --first-run parameter). When Chrome comes-up, it shows the "Search from here" info bubble. The focus should be on the "Keep Google..." button. Review URL: http://codereview.chromium.org/55019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12790 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in chrome UI tests.phajdan.jr@chromium.org2009-03-301-2/+5
| | | | | | | | | Can't include them in the Linux build yet because they wouldn't pass. Review URL: http://codereview.chromium.org/57010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12780 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in automation. Remove WaitForTabCountToChange.phajdan.jr@chromium.org2009-03-303-55/+38
| | | | | | | | | | WaitForTabCountToBecome is easier to use and more reliable. Also removed Windows2000-specific code from accessibility unit tests. Review URL: http://codereview.chromium.org/45070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12774 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the DOMUIToStandard unit test and uncomment it. The NavigationControllerbrettw@chromium.org2009-03-301-8/+20
| | | | | | | | wasn't getting hooked up properly to the WebContents, and we were getting the wrong RenderViewHost out of it later on in the test. Review URL: http://codereview.chromium.org/55045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12773 0039d316-1c4b-4281-b951-d872f2087c98
* A workaround fix for Issue 3693.hbono@chromium.org2009-03-301-0/+6
| | | | | | | | | To investigate the behavior of Safari, it seems to finish an ongoing composition when we click a left mouse button. So, this change just emulates the behavior. BUG=3693 Review URL: http://codereview.chromium.org/42691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12759 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NOTIMPLEMENTED bits for fast shutdown code on non-Windows.evan@chromium.org2009-03-291-8/+0
| | | | | | | | This was just temporary code anyway. Review URL: http://codereview.chromium.org/49048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12756 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash that occurs when the about:network window is closed while stilldarin@chromium.org2009-03-281-0/+1
| | | | | | | | | | | tracking network jobs. BUG=9446 R=brettw Review URL: http://codereview.chromium.org/45072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12752 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build.aa@chromium.org2009-03-281-1/+0
| | | | | | Review URL: http://codereview.chromium.org/55055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12746 0039d316-1c4b-4281-b951-d872f2087c98
* Add more of the server-side plumbing for extension APIs. Alsoaa@chromium.org2009-03-2814-90/+394
| | | | | | | | added getTabsForWindow() to drive it. Review URL: http://codereview.chromium.org/42680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12744 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to specify a default MIME type when loading a resource. ↵abarth@chromium.org2009-03-283-0/+18
| | | | | | | | | | | | | We'll need this to correctly load stylesheets that lack a Content-Type header in standards mode. We're waiting on https://bugs.webkit.org/show_bug.cgi?id=24904 upstream before this works fully. This change, as it stands, is a no-op. R=wtc BUG=7448 Review URL: http://codereview.chromium.org/55049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12739 0039d316-1c4b-4281-b951-d872f2087c98
* A crash report from the field reports that we are removing a ↵jcampan@chromium.org2009-03-281-2/+5
| | | | | | | | | | | | | SafeBrowsingBlockingPage from a global map that is not to be found causing a stl exception to be thrown. I am not sure what the cause is yet, my investigations results are in the bug comment. This is a work-around the crasher while I keep investigating. BUG=9442 TEST=Access a page which contains sub-resource malware. Review URL: http://codereview.chromium.org/49049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12732 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes a lint issue -- line exceeding 80 characters.xji@chromium.org2009-03-281-1/+2
| | | | | | Review URL: http://codereview.chromium.org/56039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12730 0039d316-1c4b-4281-b951-d872f2087c98
* Use Webkit::WebInputEvent and remove webkit/glue/webinputevent.darin@chromium.org2009-03-2710-55/+80
| | | | | | | | | | This change adds a temporary dependency on src/KeyIdentifier.{h,cpp} which I am going to remove after this CL. I didn't want to grow this CL any larger. R=dglazkov Review URL: http://codereview.chromium.org/53099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12728 0039d316-1c4b-4281-b951-d872f2087c98
* The URL in the bug triggers an SSL interstitial for a redirect that ↵jcampan@chromium.org2009-03-273-2/+64
| | | | | | | | | | | | | | | | | | | redirects to a bad SSL page. This happens because: - when proceeding on an interstitial, we wait for the navigation to commit before hiding the current interstitial - when showing an interstitial, if an interstitial is already showing we call DontProceed on it In the case of this bug, the interstitial has already been approved when the showing of the 2nd interstitial calls DontProceed on it, causing bad things to happen. The fix is easy: we shouldn't call DontProceed on an interstitial already "Proceeded". BUG=9286 TEST=See bug. Review URL: http://codereview.chromium.org/56019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12727 0039d316-1c4b-4281-b951-d872f2087c98
* Move message flags into a separate header that can be usedtc@google.com2009-03-279-14/+22
| | | | | | | | | outside the views system. Mac will need this as well when implementing message boxes. Review URL: http://codereview.chromium.org/56026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12722 0039d316-1c4b-4281-b951-d872f2087c98
* Properly fix menu display when using dark system themes.evan@chromium.org2009-03-272-4/+4
| | | | | | | | | The drawing code in the tab strip was modifying the GC, which affected the GC used for drawing menus. Review URL: http://codereview.chromium.org/55022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12713 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the crashing test so the tree can be open while I fix it.brettw@chromium.org2009-03-271-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12706 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor plugin process code which checks with the browser process before ↵jam@chromium.org2009-03-276-89/+5
| | | | | | | | | | | shutdown, to avoid races in which the browser process thinks the process is fine to use while it's shutting down. I also removed PluginProcess/WorkerProcess since they didn't have any code in them now. I removed the plugin process code which waits 10 seconds before shutting itself down. That was a premature optimization, since testing with/without this didn't show any difference (see http://www/~jabdelmalek/chrome/test/plugins/processes.html). In both cases, the plugin on a page would get recreated in less than 100ms, even with reusing or starting a plugin process from scratch. We already spawn new renderer processes on back and forth if it's a different origin, and the plugin will be in the cache anyways. Review URL: http://codereview.chromium.org/53091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12703 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12673.brettw@chromium.org2009-03-273-85/+130
| | | | | | Review URL: http://codereview.chromium.org/56020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12700 0039d316-1c4b-4281-b951-d872f2087c98