summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert "During uninstall if Chrome is set as default,"kuchhal@chromium.org2009-08-205-222/+104
| | | | | | | | | | allow user to choose another browser as default." reverting r23841 Review URL: http://codereview.chromium.org/173131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23845 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two tests while I investigate why Purify doesnt like them.kuchhal@chromium.org2009-08-201-2/+2
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23844 0039d316-1c4b-4281-b951-d872f2087c98
* During uninstall if Chrome is set as default, allow user to choose another ↵kuchhal@chromium.org2009-08-205-104/+222
| | | | | | | | | | | browser as default. BUG=14023 TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser. Review URL: http://codereview.chromium.org/172080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23841 0039d316-1c4b-4281-b951-d872f2087c98
* Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme install on 64 bit chromium builds.tony@chromium.org2009-08-201-4/+4
| | | | | | | | | | Extension signature sizes are always 4 bytes, not variable depending on platform. Review URL: http://codereview.chromium.org/173104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
* Make new FTP the default on Windows. Use the --wininet-ftpwtc@chromium.org2009-08-201-8/+7
| | | | | | | | | | | | command-line switch to select the old WinInet-based FTP implementation. R=phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/173099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23836 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-202-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Review URL: http://codereview.chromium.org/173098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-2014-378/+137
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the compile for TOOLKIT_VIEWS.phajdan.jr@chromium.org2009-08-201-1/+1
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/174146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Reapply r23734, fixing destruction order issues.erg@google.com2009-08-203-9/+131
| | | | | | | | http://crbug.com/18856 Review URL: http://codereview.chromium.org/174100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23828 0039d316-1c4b-4281-b951-d872f2087c98
* Add (incomplete) UI for creating application shortcuts on Linuxphajdan.jr@chromium.org2009-08-203-4/+123
| | | | | | | | | TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/171082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23827 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Make sure that the window tooltip is within the browser viewport.arv@google.com2009-08-201-8/+18
| | | | | | | | | | | | | | BUG=18534 TEST=Open a new window. Open several tabs in this window and then close the window. An item representing this window should be shown on the new tab page. Hover this item (or tab to it). The tooltip should be repositioned so that it is not clipped by the window viewport. Review URL: http://codereview.chromium.org/173100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23825 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove the DownloadsHandler from the new tab page.arv@google.com2009-08-202-16/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23824 0039d316-1c4b-4281-b951-d872f2087c98
* Do extensions update manifest XML parsing in a sandboxed process.asargent@chromium.org2009-08-207-423/+222
| | | | | | | | | | | | | | | | This involves moving the xml parsing code from static functions in extension_updater.cc to a UpdateManifest class, and switching from logging any errors directly to collecting them up and passing them across the IPC channel. BUG=http://crbug.com/12677 TEST=extensions auto-update should still work correctly Review URL: http://codereview.chromium.org/164541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
* Various omnibox UI fixes:rohitrao@chromium.org2009-08-203-37/+80
| | | | | | | | | | | | | * Truncate match contents to 70% of the available width, reserving 30% for the description. * Animate omnibox shrinkage. BUG=14898 TEST=Omnibox should animate smaller, but not bigger/opened/closed. Match description should always be partially visible, if present. Review URL: http://codereview.chromium.org/173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23821 0039d316-1c4b-4281-b951-d872f2087c98
* Change default memory model from MEDIUM to HIGH.mbelshe@google.com2009-08-201-1/+1
| | | | | | | | | | | | | | | This will eliminate the workingsetsize reductions that we currently do in the browser. Memory usage will increase by about 25%. But it should alleviate swapping issues that some users are seeing. BUG=none TEST=none Review URL: http://codereview.chromium.org/173057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23818 0039d316-1c4b-4281-b951-d872f2087c98
* Essentially revert r16636. We get no speedup from using CIImage and we are ↵avi@chromium.org2009-08-201-14/+3
| | | | | | | | | | | susceptible to random leaks. BUG=http://crbug.com/18661 TEST=throbbers should work just fine Review URL: http://codereview.chromium.org/171110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23813 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23805.abarth@chromium.org2009-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23807 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the XSSAuditor by default. Please watch out for compatibility issues.abarth@chromium.org2009-08-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/174013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23805 0039d316-1c4b-4281-b951-d872f2087c98
* Splits the menu classes into individual files in anticipation ofsky@chromium.org2009-08-207-7/+16
| | | | | | | | | | | porting them. BUG=none TEST=make sure to thorougly test bookmark menus on windows. Review URL: http://codereview.chromium.org/173091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests UtilityProcessHostTest use the helper app on the Mac.mark@chromium.org2009-08-201-5/+5
| | | | | | | | | | BUG=none, not worth it for this TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper, not Chromium. No application icon should appear in the dock during this test. Review URL: http://codereview.chromium.org/174061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23792 0039d316-1c4b-4281-b951-d872f2087c98
* Try to shutdown the browser more peacefully before using more brutal methods.phajdan.jr@chromium.org2009-08-191-17/+17
| | | | | | | | | | | | | Also, do proper cleanup before browser shutdown in MetricsService UI test. I hope this will reduce the flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/173023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
* Support navigating to absolute index through automation.amit@chromium.org2009-08-194-9/+49
| | | | | | | | | | | | Also, send more information in AutomationMsg_DidNavigate BUG=none TEST=none Review URL: http://codereview.chromium.org/165333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23776 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Limit the dragged item to the viewport boundaries.arv@google.com2009-08-191-2/+17
| | | | | | | | | | | | BUG=16361, 15099 TEST=Drag the thumbnails on the new tab page and make sure that the visual representation is never clipped. Also make sure that no new scrollbars show up due to dragging. Review URL: http://codereview.chromium.org/173090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23775 0039d316-1c4b-4281-b951-d872f2087c98
* When importing a lot of history, the NOTREACHED in ↵vandebo@chromium.org2009-08-193-2/+22
| | | | | | | | | | | VisitedLinkMaster::AddFingerprint is reached. This causes an exit on debug builds, for production builds part of the history would silently not get imported. The root cause is that the initial size of the hash table only considers one of the two sources of input. BUG=none TEST=VisitedLinkTest::BigImport Review URL: http://codereview.chromium.org/164419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23773 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the left and right tab curve images. We were spending a lottony@chromium.org2009-08-192-33/+73
| | | | | | | | | | | | | | | | of time regenerating the images for all the tabs. This speeds up the time needed to paint a tab by about 30%. This helps a bit, but we're still slow. We need to calculate damage rects and only redraw damage rects (most of the remaining time is spent on painting to the canvas now). BUG=15872 Review URL: http://codereview.chromium.org/174095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23771 0039d316-1c4b-4281-b951-d872f2087c98
* Renable ShowModalDialogTest test with a longer timeout. Until we have a way ↵jam@chromium.org2009-08-191-4/+5
| | | | | | | | of executing JS in the renderer from a ui test, we'll have to use hacks like this. Review URL: http://codereview.chromium.org/165090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23770 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crash if a download starts before we have the plugin list. The fix ↵jam@chromium.org2009-08-192-11/+34
| | | | | | | | | | | is to make ResourceDispatcherHost support a handler pausing a request in its OnResponseStarted callback. Note I didn't find any way of testing the resource handler code, so I didn't know how to add a good test for this. BUG=19414 Review URL: http://codereview.chromium.org/173037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23769 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make sure we found the window corresponding to the XID of the window ↵jhawkins@chromium.org2009-08-191-1/+3
| | | | | | | | | | under the drag. BUG=19552 TEST=Drag a tab up and out of the tab strip. This should not crash. Review URL: http://codereview.chromium.org/174091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23768 0039d316-1c4b-4281-b951-d872f2087c98
* Add icu:: qualifiers to a couple of more files. They're missed in the ↵jshin@chromium.org2009-08-191-1/+1
| | | | | | | | | | | previous CL. BUG=8198 TEST=Building all targets succeed without an error. TBR=darin Review URL: http://codereview.chromium.org/173076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23762 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Default to not using custom frame under Fluxbox.derat@chromium.org2009-08-191-3/+3
| | | | | | | | | BUG=19130 TESTED=checked that it compiles :-P Review URL: http://codereview.chromium.org/173079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23760 0039d316-1c4b-4281-b951-d872f2087c98
* Pref-backed SSLConfigService for Linux.mattm@chromium.org2009-08-1912-25/+463
| | | | | | | | | | Makes SSLConfigService into a ref-counted interface, and makes Profile own an SSLConfigServiceFactory which is used to create the SSLConfigService and pass it through the URLRequestContext on down to where it is actually used. R=eroman,wtc BUG=11507,19290 Review URL: http://codereview.chromium.org/165003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23757 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Use checkbox menu items in the options menu to control which sections ↵arv@google.com2009-08-193-16/+37
| | | | | | | | | | | | | | | to show. I also changed to use black text on white for the menu. BUG=None TEST=Hide and show the different sections on new tab page and makes sure that the checkbox is correctly synced with the state. Review URL: http://codereview.chromium.org/174035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23750 0039d316-1c4b-4281-b951-d872f2087c98
* Make popups on Chrome OS turn into foreground tabs when theydavemoore@chromium.org2009-08-191-0/+25
| | | | | | | are too big Review URL: http://codereview.chromium.org/174019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23747 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK Theme: Make inactive titlebar legible."erg@google.com2009-08-192-123/+9
| | | | | | | | | | | This reverts commit 872a67636100b790dd034fe502e585d6a6abe716 (r23734). Use of notifications is questionable. TBR=estade Review URL: http://codereview.chromium.org/174087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23744 0039d316-1c4b-4281-b951-d872f2087c98
* Check the favicon and loading state when a tab is created in case its ↵pinkerton@chromium.org2009-08-191-48/+61
| | | | | | | | | | TabContents is from an existing browser (such as torn off from a drag). BUG=18352 TEST=dragging a tab out with a favicon should keep the favicon. Creating new tabs should be unaffected. dragging a tab out with a throbber should show the throbber and change to the correct favicon. Review URL: http://codereview.chromium.org/174074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23741 0039d316-1c4b-4281-b951-d872f2087c98
* Add progress disks to os x download items. Some more spacing tweaks. Still ↵thakis@chromium.org2009-08-192-23/+103
| | | | | | | | | | | not done. BUG=18902 TEST=download something, note that a green disk appears, and disappears after some flashing after the download is done. Review URL: http://codereview.chromium.org/174048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23740 0039d316-1c4b-4281-b951-d872f2087c98
* This change enables Chrome to load locale information for the extension. It ↵cira@chromium.org2009-08-196-0/+447
| | | | | | | | | | | | | | | | | | | | | | detects default locale, and filters out all locales not supported by Chrome or with invalid names/missing messages. It also checks for folders that start with _ and are not in the reserved list. We don't validate messages file with this CL. Added support for loading supplied locale information to the extension_file_util, and detecting default locale. Added new constants to extension class (_locales directory name, messages filename). Added new error messages to _constants. Added new unittests. BUG=12131 TEST=There should be no visible changes, except in case of error when loading extension (e.g. create empty _locales folder and try loading). Review URL: http://codereview.chromium.org/170015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23739 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Release the reference to the startup custom pages model so that it's ↵jhawkins@chromium.org2009-08-192-1/+6
| | | | | | | | | | owned by the GtkTreeView and will be destroyed when the tree view is destroyed. BUG=19670 TEST=Load chromium with a fresh profile. Open and close the options window at least three times. The browser should not crash. Review URL: http://codereview.chromium.org/173038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23737 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Make inactive titlebar legible.erg@google.com2009-08-192-9/+123
| | | | | | | | | | | | I'm pretty certain we'll never be able to match the text color on custom popup windows, but at the very least make it legible. Tested in both light and dark themes. http://crbug.com/18856 Review URL: http://codereview.chromium.org/173061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23734 0039d316-1c4b-4281-b951-d872f2087c98
* Port more browser focus tests to linux.estade@chromium.org2009-08-1912-260/+202
| | | | | | | | | | | | | | | | | | | Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking. Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs. Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong. Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes. BUG=19076 BUG=19659 TEST=all the ported interactive ui tests (as well as all the already-working tests) pass. TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf) Review URL: http://codereview.chromium.org/173030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23732 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation call to wait for multiple navigations.phajdan.jr@chromium.org2009-08-194-36/+46
| | | | | | | | | | | | | Convert one ErrorPage UI test to use it. The rest of the tests will require more work. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23729 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement BackingStore on the Mac as a CGLayer instead of a Skia canvas,amanda@chromium.org2009-08-195-150/+132
| | | | | | | | | | | | | | to get better performance. As a side effect, remove the ugly stopgap scrolling code. Do not close 14823 with this fix, but it should help (primary motivation was improving the plugin drawing path). Paul: review rafael: please check the change to extension_tabs_module.cc John, Rohit: FYI, comments welcome BUG=14823, TEST=scrolling and plugin performance should improve Review URL: http://codereview.chromium.org/171054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23722 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add automation call to wait for multiple navigations."phajdan.jr@chromium.org2009-08-194-46/+36
| | | | | | | | | | Broke the page cyclers. TBR=tony Review URL: http://codereview.chromium.org/174065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23717 0039d316-1c4b-4281-b951-d872f2087c98
* Load 16x16 icons for shelf.thakis@chromium.org2009-08-191-1/+1
| | | | | | | | | BUG=18902 TEST=The 16x16 icons on the left of a download item look crisp. Review URL: http://codereview.chromium.org/174049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23715 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Revert updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-192-21/+0
| | | | | | | | | | | | | | | This backs out r23596. I'm pretty sure that it worked when I tested it right before submitting, but it's totally breaking stuff now -- it looks like when I update the PRIMARY selection, GTK notices that it's lost the selection and automatically unhighlights the text in the omnibox, making it impossible to use Ctrl-C to copy omnibox text to the clipboard. :-( BUG=19648 TESTED=Hit Ctrl-L, Ctrl-C and confirmed that text remains highlighted and becomes CLIPBOARD selection. Review URL: http://codereview.chromium.org/174058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23714 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation call to wait for multiple navigations.phajdan.jr@chromium.org2009-08-194-36/+46
| | | | | | | | | | | | | Convert one ErrorPage UI test to use it. The rest of the tests will require more work. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23711 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDMap back to base/ where it is needed.phajdan.jr@chromium.org2009-08-192-2/+2
| | | | | | | | | TEST=Covered by base_unittests. BUG=none Review URL: http://codereview.chromium.org/173026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23709 0039d316-1c4b-4281-b951-d872f2087c98
* Give the test an autorelease pool so the dialog gets cleaned up at the end ↵pinkerton@chromium.org2009-08-191-1/+2
| | | | | | | | of the test. Review URL: http://codereview.chromium.org/173019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23706 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Re-enable devtools sanity tests.pfeldman@chromium.org2009-08-191-6/+0
| | | | | | | TBR=mnaganov Review URL: http://codereview.chromium.org/173053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23704 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-11-16 07:50:57 +0000