summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Disable FieldTrial code to repair UI reliability test regressionjar@google.com2008-10-202-0/+6
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/7520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3608 0039d316-1c4b-4281-b951-d872f2087c98
* Construct a field trial to see if HIGH or MEDIUM memory model "works better"jar@google.com2008-10-196-10/+77
| | | | | | | | | | | | | | Includes definition of a FieldTrial class to support this. I have thoughts in my head about how this will eventually extend to be controllable via UMA (as well as being able to run tests defined at compile time, as was done in this example. r=mbelshe, mmentovai Review URL: http://codereview.chromium.org/7638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3604 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3487: We now set the bounds for the links in the About box as soon as ↵finnur@google.com2008-10-191-19/+18
| | | | | | | | we know where they should be placed, instead of waiting until the Layout call to do so. This fixes an issue of the links not appearing at all -- something, that I can't reproduce myself, but Darin could on his Vista machine (until he tried this fix). Review URL: http://codereview.chromium.org/7513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3603 0039d316-1c4b-4281-b951-d872f2087c98
* Move more platform-specific stuff from WebContents to the view.brettw@google.com2008-10-187-187/+189
| | | | | | | | | | | I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently. I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit. I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it. Review URL: http://codereview.chromium.org/7650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3601 0039d316-1c4b-4281-b951-d872f2087c98
* Support shortcut show styles for "run maximized", "run minimized" etc.ben@chromium.org2008-10-172-1/+3
| | | | | | | http://crbug.com/3278 Review URL: http://codereview.chromium.org/7504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3579 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkDragData to allow for multiple nodes. I'm going tosky@google.com2008-10-175-150/+306
| | | | | | | | | | | | | | | | | need this for the bookmark manager, which will let you drag multiple nodes around. I didn't make the bookmark bar deal with multiple nodes though (it won't allow a drop of multiple nodes). I may add support for this at some point, but not in this patch. BUG=674 TEST=covered by unit tests, but make sure the aren't problems dragging around bookmarks on the bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/7498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3575 0039d316-1c4b-4281-b951-d872f2087c98
* We were still warning about a dangerous download when the user has picked ↵jcampan@chromium.org2008-10-171-2/+8
| | | | | | | | | | the option to always ask for download. BUG=3539 TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning. Review URL: http://codereview.chromium.org/7634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3570 0039d316-1c4b-4281-b951-d872f2087c98
* Straighten out the way the system menu works a bit. We no longer create the ↵ben@chromium.org2008-10-177-41/+32
| | | | | | | | | menu every time it is shown (or reset it). Resetting it caused some system-wide system menu items to be voted off the island (e.g. nView desktop manager, and some other third party addins). Resetting also caused some of the NC overpainting issues to be worse. This simplifies things a bit by creating the menu at frame creation time, then when the menu is run doing enabling only. Review URL: http://codereview.chromium.org/7497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3569 0039d316-1c4b-4281-b951-d872f2087c98
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-177-9/+74
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where "text/xml" responses get buffered past 512 bytes, causing ↵ericroman@google.com2008-10-171-0/+1
| | | | | | | | | | the response to be truncated. BUG=3521 Review URL: http://codereview.chromium.org/7610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
* Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest formark@chromium.org2008-10-172-3/+8
| | | | | | | autorelease pool management on the Mac. Review URL: http://codereview.chromium.org/7640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3563 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3556 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SchedulePaint and a few other methods to use gfx types.ben@chromium.org2008-10-1714-32/+29
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3550 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code I accidentally left in which is causing asserts and crashes.brettw@google.com2008-10-171-6/+0
| | | | | | | | | | | close_on_deactivate_ was getting set to true which was deleting the object, causing us to crash later. The code that originally set this externally is still there, so this restores the old behavior. TEST=Press tab on any page, it shouldn't assert or crash. Review URL: http://codereview.chromium.org/7631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crasher in SpellChecker Add to dictionary feature.sidchat@google.com2008-10-171-1/+2
| | | | | | | Issue=3039 Review URL: http://codereview.chromium.org/7484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3546 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-1719-202/+1199
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Add processing for a master profile json file on first run. Allows:cpu@google.com2008-10-175-18/+137
| | | | | | | | | - set home page / show home button - show bookmarks bar Review URL: http://codereview.chromium.org/7369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-175-25/+70
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Add some trace statements in an attempt to find the reason why a Find test ↵finnur@google.com2008-10-171-0/+23
| | | | | | | | is flaky. This will be removed once I get a run that hangs again. Review URL: http://codereview.chromium.org/7626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3534 0039d316-1c4b-4281-b951-d872f2087c98
* testing a theory...ben@chromium.org2008-10-171-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3533 0039d316-1c4b-4281-b951-d872f2087c98
* Removes expiring of recently closed tabs from new tab page. Also makessky@google.com2008-10-172-34/+5
| | | | | | | | | | | it so that if you restore a tab we remove from the tab restore service (this is what control-shift-t does too). BUG=2598 TEST=make sure closed tabs still show up on the new tab page. Review URL: http://codereview.chromium.org/4016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where a shelf or infobar would not be closed correctly when closing ↵glen@google.com2008-10-174-16/+21
| | | | | | | | | | | | | | a tab. The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called. http://crbug.com/2069 BUG=2069 Review URL: http://codereview.chromium.org/7155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3528 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out most view creation from WebContents. This adds a new ↵brettw@google.com2008-10-1719-200/+358
| | | | | | | | sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result. Review URL: http://codereview.chromium.org/6608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
* The translation lead requested that this sentence be a singletc@google.com2008-10-171-14/+41
| | | | | | | | | string, otherwise it will likely be grammatically incorrect. This is a hack until http://crbug.com/3295 is implemented. Review URL: http://codereview.chromium.org/7396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for a possible assertion caused by r3407.hbono@chromium.org2008-10-171-1/+2
| | | | | | | | When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|. To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class. Review URL: http://codereview.chromium.org/7387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3506 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing file from r3496.aa@google.com2008-10-171-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3499 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey ↵aa@google.com2008-10-164-15/+183
| | | | | | | | | | | | | flag. Implementation follows the pattern of the visited links system. Things still to be done: - stop using a hardcoded script directory - watch script directory and update shared memory when necessary - move file io to background thread - support for @include patterns -- now, all scripts are applied to all pages Review URL: http://codereview.chromium.org/7254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-16234-3006/+2881
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build: GetViewContainer changed name from under me. :)finnur@google.com2008-10-161-2/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/7464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in downloading files (issue 3423).finnur@google.com2008-10-161-0/+9
| | | | | | | | | | | | | | | | | | | | | | | I was finally able to reproduce a problem where we would crash when clicking Save on the Download Tab (it would also crash during animation of the items on the download shelf after switching away from the tab downloading). The reason for the crash is that if the controls on the download shelf have not been laid out once (before switching to a tab that doesn't have a download shelf), then we'll crash inside NativeControlContainer ctor when it tries to ValidateNativeControl() (it walks up the parent hierarchy trying to find the ViewContainer and ends up dereferencing a NULL pointer). This was reviewed by jcampan as http://codereview.chromium.org/7446 I had to recreate the changelist before submitting (long story). Review URL: http://codereview.chromium.org/7604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more shared_event that I missed last timeagl@chromium.org2008-10-164-4/+0
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3485 0039d316-1c4b-4281-b951-d872f2087c98
* When a mixed-content resource was loaded, we would apply the mixed-content ↵jcampan@chromium.org2008-10-162-5/+4
| | | | | | | | | | | | | | | state to the active entry, which would be the pending entry if there is one. That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry). More details: In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry. BUG=2742 TEST=Run the SSL UI tests 1000 times. Review URL: http://codereview.chromium.org/7440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3480 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1665-294/+118
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Return without doing anything instead of dereferencing junk in unexpected cases.mark@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3470 0039d316-1c4b-4281-b951-d872f2087c98
* Update SpellChecker to download the latest version of the bdic dictionary files.sidchat@google.com2008-10-162-3/+46
| | | | | | Review URL: http://codereview.chromium.org/6474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3468 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the following changes to the bookmark bar context menu:sky@google.com2008-10-163-88/+75
| | | | | | | | | | | | . Nukes the open menu item. . Adds open incognito and for folders open all incognito. BUG=144 TEST=Fully test the context menu of bookmark folders/urls. Review URL: http://codereview.chromium.org/7357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3464 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser\interstitial_page.cc to the SCons build.sgk@google.com2008-10-161-1/+2
| | | | | | | Move render_widget_host_hwnd.cc to render_widget_host_win.cc. Review URL: http://codereview.chromium.org/7336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3463 0039d316-1c4b-4281-b951-d872f2087c98
* Change the prefix for unconfirmed, potentially dangerous downloads mal@chromium.org2008-10-161-1/+1
| | | | | | | | | | | | | | | | | from: dangerous_download_%d to: unconfirmed %d We want to avoid alarming names in the UI. I'm open to better suggestions for the prefix. R= jcampan@chromium.org, brian@chromium.org Review URL: http://codereview.chromium.org/7107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3455 0039d316-1c4b-4281-b951-d872f2087c98
* This is the same change as 2419 minus a line of debug code I accidentally ↵petersont@google.com2008-10-165-183/+567
| | | | | | | | left in browser_main.cc which ignored the user preference. Review URL: http://codereview.chromium.org/4229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken resize from bottom with magic frame.ben@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3443 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-1671-217/+207
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* As agreed on by the SafeBrowsing server team:paulg@google.com2008-10-152-15/+14
| | | | | | | | | | | 1. Back off when we encounter a parse error. 2. Ignore commands we don't understand instead of returning an error. 3. Make redirect URL parsing in an update response more robust to changes in format. Review URL: http://codereview.chromium.org/7329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3425 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check in Chrome to not run user level mode if machine level Chromekuchhal@chromium.org2008-10-152-7/+57
| | | | | | is already installed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3423 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lot of robustness to SDCH filter decodingjar@google.com2008-10-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | a) Do meta-refresh (and partially disable sdch) when we have an sdch decode error early on (due to lack of dictionary). b) Gracefully handle proxy removal of "gzip" in "content-encoding: sdch,gzip". c) Recover from completely stripped content encoding (in response to a request for which we advertised an SDCH dictionary) by using a filter that can optionally decode sdch with an optional gzip as well. Some field tests have shown problems with this protocol's transit across the ether. The general approach we've adopted is to stop using SDCH on the problematic site when we have problems. This will prevent a malicious site from shutting down all use of SDCH. r=kmixter,openvcdiff,huanr Review URL: http://codereview.chromium.org/6433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3420 0039d316-1c4b-4281-b951-d872f2087c98
* Change SpellChecker language without restarting the browser.sidchat@google.com2008-10-156-25/+143
| | | | | | Review URL: http://codereview.chromium.org/7056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3407 0039d316-1c4b-4281-b951-d872f2087c98
* This file was left out of my last checkin due to prior gcl cruft.beng@google.com2008-10-151-32/+21
| | | | | | http://crbug.com/2186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3402 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-1590-1051/+942
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Insert NULL check to fix dist crashben@chromium.org2008-10-151-5/+4
| | | | | | Review URL: http://codereview.chromium.org/7407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3399 0039d316-1c4b-4281-b951-d872f2087c98
* Change #ifdef _DEBUG test to #ifndef NDEBUG test.maruel@google.com2008-10-153-6/+6
| | | | | | Review URL: http://codereview.chromium.org/7404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher when shutting down with a pending dangerous download.jcampan@chromium.org2008-10-151-2/+4
| | | | | | | | BUG=3457 TEST=See bug Review URL: http://codereview.chromium.org/7406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3396 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-14 15:23:15 +0000