summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Relands cl 16982 as it wasn't the cause of the build breakage. Here'ssky@chromium.org2009-05-272-0/+15
| | | | | | | | | | | | | | the description for that cl: Lands http://codereview.chromium.org/115505 for bug http://crbug.com/4030 for tyoshino. BUG=http://crbug.com/4030 TEST=make sure control-w dismisses bookmark manager. Review URL: http://codereview.chromium.org/113902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16987 0039d316-1c4b-4281-b951-d872f2087c98
* Make the import feature a little more complete:kuchhal@chromium.org2009-05-2711-60/+452
| | | | | | | | | | | | | - Now we show import progress of individual items - In case Firefox is running we display a warning and allow user to close it before proceeding - Delete the Firefox lock when import finishes BUG=11191 Review URL: http://codereview.chromium.org/114047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16986 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16982.maruel@chromium.org2009-05-272-15/+0
| | | | | | | Broke Modules Mac Review URL: http://codereview.chromium.org/113901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16985 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide ↵pfeldman@chromium.org2009-05-274-6/+94
| | | | | | | | developer tools by default. Review URL: http://codereview.chromium.org/117003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/115505 for bugsky@chromium.org2009-05-272-0/+15
| | | | | | | | | | | http://crbug.com/4030 for tyoshino. BUG=http://crbug.com/4030 TEST=make sure control-w dismisses bookmark manager. Review URL: http://codereview.chromium.org/113887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where cmd-w was hard-coded to closing a browser tab regardless of ↵pinkerton@chromium.org2009-05-276-0/+147
| | | | | | | | | | the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window. BUG=10047 TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window. Review URL: http://codereview.chromium.org/115789 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16981 0039d316-1c4b-4281-b951-d872f2087c98
* Create OpenClose browser test for TaskManager with necessary refactoring.phajdan.jr@chromium.org2009-05-275-8/+31
| | | | | | | | http://crbug.com/12320 Review URL: http://codereview.chromium.org/113636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16978 0039d316-1c4b-4281-b951-d872f2087c98
* Do not monitor system power state during unit tests.phajdan.jr@chromium.org2009-05-271-0/+5
| | | | | | | | | | | | | The observer requires that message loop stays up and same through its lifetime. This is not true during testing. TEST=none http://crbug.com/12187 Review URL: http://codereview.chromium.org/113824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16976 0039d316-1c4b-4281-b951-d872f2087c98
* Show Unicode IDNs for "On startup" setting and "Add page" dialog for it.jungshik@google.com2009-05-272-3/+12
| | | | | | | | | | | | | | | | | TEST=visit an IDN URL, and open the "Basics" tab of the "Options" dialog, select "Open the following pages", press "Add..." button, select the IDN URL, and confirm that the URL field is shown in Unicode, or paste a Punycode URL to the URL field of the "Add page" dialog, press "Add" button, and confirm that the "Open the followig pages" list shows the Unicode URL. http://crbug.com/3991 Patch by tkent Original review: http://codereview.chromium.org/115759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16974 0039d316-1c4b-4281-b951-d872f2087c98
* For "Copy link address" context menu, copy the URL with Unicode host namejungshik@google.com2009-05-271-27/+27
| | | | | | | | | | | | | | instead of Punycode host name. http://crbug.com/4008 TEST="Copy link address" copies Unicode host name for both of <a href="punycode URL"> and <a href="Unicode URL"> if Accept-Language preference is matched. Patch by tkent Original review: http://codereview.chromium.org/115752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comparison in window_sizer_linux. There can be multiple desktops so ↵thestig@chromium.org2009-05-271-1/+2
| | | | | | | | | | | | data_len can be greater. TBR=evan BUG=none TEST=should work on window managers that support the wm-spec. Review URL: http://codereview.chromium.org/113884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16970 0039d316-1c4b-4281-b951-d872f2087c98
* Control spacing of toolbar elements with pixels rather than " " GtkLabels.estade@chromium.org2009-05-272-13/+16
| | | | | | | | | | | This fixes another large fonts issue. BUG=12573 TEST=toolbar should look like it does on windows (where there is spacing, the size of it, etc.) Review URL: http://codereview.chromium.org/115792 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16963 0039d316-1c4b-4281-b951-d872f2087c98
* Use the original profile for the downloads manager so that a download managerarv@google.com2009-05-271-1/+2
| | | | | | | | | | | | | | | | | in an incognito window is in sync with all other download managers. BUG=11514 TEST=Open a download manager (Ctrl+J) and an incognito window with a download manager (Ctrl+Shift+N followed by Ctrl+J). Then start to download a file and note that both download managers should get updated. Try pausing and eventually click "Remove all" in either DM and all downloads should get removed from both DMs. Review URL: http://codereview.chromium.org/115804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16960 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken toolkit_views build by adding include of message_loop.ben@chromium.org2009-05-271-0/+1
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/115806 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16957 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix CHECK fail in window_sizer.evan@chromium.org2009-05-271-20/+37
| | | | | | | | | | 1) We shouldn't use CHECK for situations that can reasonably occur. 2) We need to recover from the case where this WORKAREA property isn't available. Review URL: http://codereview.chromium.org/113877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16956 0039d316-1c4b-4281-b951-d872f2087c98
* Fox some compilation problems for Linux. This also adds bookmark_bar_view andbrettw@chromium.org2009-05-262-4/+8
| | | | | | | window_sizer to the Linux build. Review URL: http://codereview.chromium.org/115803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16953 0039d316-1c4b-4281-b951-d872f2087c98
* Show the time remaining of download items in the download manager.arv@google.com2009-05-261-3/+13
| | | | | | | | | | | | BUG=9607 TEST=Download a large file and go to the download manager (Ctrl+J). The remaining time of your current downloads should decreasen as the download is getting closer to being done. Review URL: http://codereview.chromium.org/115797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16949 0039d316-1c4b-4281-b951-d872f2087c98
* Removes WidgetWin dependency from StatusBubbleViews so that it can compile ↵ben@chromium.org2009-05-2611-84/+134
| | | | | | | | | | | | | | | | on Linux. Requires: - making SetOpacity a cross platform method on Widget, replacing SetLayeredAlpha. - moving Window::SetBounds to Widget - replacing usage of MoveWindow in StatusBubbleViews with call to new SetBounds method. BUG=none TEST=make sure transparency still works for floating widgets like - status bubble, full screen exit bubble, dragged tabs Review URL: http://codereview.chromium.org/113846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16948 0039d316-1c4b-4281-b951-d872f2087c98
* Change actual pref for stats reporting when selected.kuchhal@chromium.org2009-05-261-6/+7
| | | | | | | Review URL: http://codereview.chromium.org/113866 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where if user has focus follows mouse, moving out oftc@google.com2009-05-262-15/+29
| | | | | | | | | | | | | | | | | | | the chrome window closes content popups. We need to grab all X mouse events using gdk_pointer_grab. This prevents other windows from getting focus. We no longer need the focus-out-event signal handler because we'll get the mouse down outside the browser window, forward it to the renderer, and it will tell us to close. I verified manually that killing the renderer while the popup is showing results in gdk_display_pointer_ungrab getting called. If the renderer hangs, the user just needs to click outside the popup. Review URL: http://codereview.chromium.org/112052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16946 0039d316-1c4b-4281-b951-d872f2087c98
* Fleshes out more of BrowserFrameGtk.sky@chromium.org2009-05-268-22/+77
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16945 0039d316-1c4b-4281-b951-d872f2087c98
* Fix initial window placement when dragging a tab out of the tabstrip into ↵jhawkins@chromium.org2009-05-263-4/+10
| | | | | | | | | | its own window. This change also removes code that was overriding the requested size as a temporary workaround. BUG=none TEST=Open a browser window with two tabs. Drag one of the tabs out of the tabstrip. A new window should be created where the mouse is positioned. Review URL: http://codereview.chromium.org/113874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16944 0039d316-1c4b-4281-b951-d872f2087c98
* Add a single monitor implementation of WindowSizer for Linux. (try 2)thestig@chromium.org2009-05-264-16/+105
| | | | | | | BUG=10005 Review URL: http://codereview.chromium.org/115723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16940 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the password manager refactoring -- it failed reliability tests.evan@chromium.org2009-05-2618-1302/+155
| | | | | | | | | | | (For reference, it was committed with the wrong message: "Patch to make password patch build.") This reverts commit r16708. Review URL: http://codereview.chromium.org/113871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16939 0039d316-1c4b-4281-b951-d872f2087c98
* Rename bookmark_context_menu_win to *_views instead since it's technicallybrettw@chromium.org2009-05-262-1/+1
| | | | | | | cross-platform. Review URL: http://codereview.chromium.org/115799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last bits leftover from my frame window experiment.brettw@chromium.org2009-05-263-18/+1
| | | | | | Review URL: http://codereview.chromium.org/113863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more compilation errors in browser_view.cc and an error I introduced in abrettw@chromium.org2009-05-262-4/+4
| | | | | | | previous change that used the wrong parent variable when showing HTML dialogs. Review URL: http://codereview.chromium.org/113864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16929 0039d316-1c4b-4281-b951-d872f2087c98
* Make the contents of toolstrips center vertically by default.aa@chromium.org2009-05-262-3/+10
| | | | | | Review URL: http://codereview.chromium.org/115790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16924 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_bar_view.h hopefully compile on Linux.brettw@chromium.org2009-05-263-13/+11
| | | | | | Review URL: http://codereview.chromium.org/115795 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16920 0039d316-1c4b-4281-b951-d872f2087c98
* Make most of browser_view compile on Linux.brettw@chromium.org2009-05-261-5/+26
| | | | | | Review URL: http://codereview.chromium.org/115786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16918 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't trigger GCC 4.3 warningsagl@chromium.org2009-05-261-3/+3
| | | | | | | r16889 triggered some warnings with GCC 4.3: http://pastebin.com/m3a9415af git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16916 0039d316-1c4b-4281-b951-d872f2087c98
* SetInitialFocus() when there's no view to restore to.shess@chromium.org2009-05-261-0/+6
| | | | | | | | | | | | http://crbug.com/12555 TEST=Browse to a page. Bring up a new tab (Command-t), should be able to start typing in autocomplete. http://crbug.com/12556 TEST=With a partial URL entered, switch tabs, and switch back. Should be able to type to replace autocomplete. This does not fix the entire bug. Review URL: http://codereview.chromium.org/115734 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16906 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a corner case in tab dragging where we receive a drag-end signal before ↵jhawkins@chromium.org2009-05-261-0/+6
| | | | | | | | | | ever receiving a drag-motion signal. In this case we'd crash because dragged_tab_ isn't created yet. BUG=12473 TEST=Open a browser with three tabs. Rapidly click on the first and third tabs. This should not cause the browser to crash. Review URL: http://codereview.chromium.org/113854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16905 0039d316-1c4b-4281-b951-d872f2087c98
* Undelete the factory method for BackForwardMenuModelGtk.estade@chromium.org2009-05-261-1/+8
| | | | | | | | | | It's still used by the unit test. TBR=erg Review URL: http://codereview.chromium.org/115791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16904 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes BrowserView::GetBrowserViewForNativeView on linux.sky@chromium.org2009-05-261-2/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16901 0039d316-1c4b-4281-b951-d872f2087c98
* Gets a couple of download classes to compile on linux. Updates thesky@chromium.org2009-05-264-30/+56
| | | | | | | | | | | views build so that we only include the gtk classes we need. BUG=none TEST=none Review URL: http://codereview.chromium.org/115788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16899 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor back/forward buttons to their own class. Fix them so the menu pops ↵estade@chromium.org2009-05-268-174/+273
| | | | | | | | | | | up on drags and the buttons look depressed when the menu is showing. BUG=12427 TEST=back/forward button behavior should be as on windows (see bug desc. for details). Review URL: http://codereview.chromium.org/113806 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16898 0039d316-1c4b-4281-b951-d872f2087c98
* First phase of Mac Keychain integration. For the overall plan, see the ↵stuartmorgan@chromium.org2009-05-266-0/+1229
| | | | | | | | | | | | | | design doc linked from the bug. This implements the ability to read existing Keychain passwords, but no storage/updating yet, and no adding of our own metadata as passwords are used; all that will be done in follow-up patches. This also includes a Keychain wrapper for the functionality necessary so far, and a mock Keychain sufficient to unit-test essentially all of the code. This patch deliberately excludes the step of instantiating a PasswordStoreMac and hooking it up to the profile, because a bug in autocomplete itself prevents passwords we load from actually being used, and we don't want to trigger Keychain UI for passwords that will be ignored. So this won't be used in builds yet, but it will be unit tested. BUG=11745 TEST=none (no user-visible effect yet) Review URL: http://codereview.chromium.org/115658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16897 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging a tab out of a TabStripGtk into its own browser window.jhawkins@chromium.org2009-05-269-48/+230
| | | | | | | | BUG=none TEST=Open a browser window with two tabs, pull one of the tabs out of the tab strip. On release, a new window should be created with the dragged tab contents. Review URL: http://codereview.chromium.org/113787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16894 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead code in TabContentsViewGtk and makes it compile forsky@chromium.org2009-05-263-39/+6
| | | | | | | | | | views. BUG=none TEST=none Review URL: http://codereview.chromium.org/113849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16892 0039d316-1c4b-4281-b951-d872f2087c98
* Move the BookmarkMenuController out of bookmarks to the platform-specific partbrettw@chromium.org2009-05-269-26/+27
| | | | | | | | of chrome. This renames the _win version to _views and makes the header compilable on non-Windows. Review URL: http://codereview.chromium.org/113844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16891 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement 16-bit visuals without Xrender.agl@chromium.org2009-05-261-0/+30
| | | | | | | | | | Some VNC users still have this setup. BUG=10616 http://codereview.chromium.org/113848 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16889 0039d316-1c4b-4281-b951-d872f2087c98
* Make OffTheRecordObserver a Singleton.mpcomplete@google.com2009-05-261-8/+6
| | | | | | | BUG=12560 Review URL: http://codereview.chromium.org/115785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16887 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the unpacking of the extension system.finnur@chromium.org2009-05-261-0/+4
| | | | | | | | | | | | | | | After asking for an extension to be unpacked, sometimes the temp directory gets cleaned up before the unpacker can do its work (in LoadExtensionsFromInstallDirectory, because the dir contains no current version). BUG=None TEST=Add a reg key to HKLM to install an external extension and make sure the extension gets installed. Review URL: http://codereview.chromium.org/113795 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16884 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the --proxy-bypass-urls command-line switchwtc@chromium.org2009-05-262-5/+5
| | | | | | | | | | | --proxy-bypass-list. R=robertshield,eroman BUG=http://crbug.com/266 TEST=N/A Review URL: http://codereview.chromium.org/115725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16883 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BrowserView::GetBrowserViewForHWND tosky@chromium.org2009-05-266-24/+38
| | | | | | | | | | | | | GetBrowserViewForNativeView and implements the GTK side. I could have went with NativeWindow here, but we end up with more flexibility if we keep this as NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/113842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16882 0039d316-1c4b-4281-b951-d872f2087c98
* Makes DockInfo usable on Linux. It doesn't implementsky@chromium.org2009-05-261-3/+32
| | | | | | | | | | | GetDockInfoAtPoint, but that's not important for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/115776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16881 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from ExtensionsService.mpcomplete@google.com2009-05-2633-1534/+29
| | | | | | | | Move extension.* from browser to common, so it can be included by the utility process. Review URL: http://codereview.chromium.org/115716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16880 0039d316-1c4b-4281-b951-d872f2087c98
* File bug for a NOTIMPLEMENTED, remove a couple others.pinkerton@chromium.org2009-05-261-3/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16876 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the hit testing so that the window controls and title bar will get ↵pinkerton@chromium.org2009-05-261-0/+13
| | | | | | | | | | targeted when the window isn't the foreground window. BUG=12505 TEST=closing and minimizing background windows. all mouse interactions with foreground tabs. Review URL: http://codereview.chromium.org/112059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16875 0039d316-1c4b-4281-b951-d872f2087c98