summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue 8589: Disable spellcheck field from the context menu when spell ↵sidchat@google.com2009-04-061-3/+9
| | | | | | | | | check is disabled from the options menu. Issue=8589 Review URL: http://codereview.chromium.org/60097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13162 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include guards in GTK tabstrip (chrome/browser/gtk/tabs/).deanm@chromium.org2009-04-063-9/+9
| | | | | | | | | The include guards should now match the file paths. Review URL: http://codereview.chromium.org/62051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when canceling a save page operation.paulg@google.com2009-04-061-3/+11
| | | | | | | | | | | | | | | | | This crash occurs under the following conditions: 1. Launch Chrome and navigate to any web page 2. Save that page (via ctrl+s or menu option) 3. Click cancel in the Save As dialog box that appears 4. Save the page again This fix checks to see if the SavePackage was initialized when handling a stop operation, and skips it if nothing has started. BUG=9738 (http://crbug.com/9738) Review URL: http://codereview.chromium.org/62048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13148 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, #ifdef = #ifnsylvain@chromium.org2009-04-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/63005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13144 0039d316-1c4b-4281-b951-d872f2087c98
* It looks like the local files are not built anymore on linuxnsylvain@chromium.org2009-04-061-0/+4
| | | | | | | | | in debug. I'm disabling these tests since they fail. Bug: 9758 Review URL: http://codereview.chromium.org/62047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13142 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13136.brettw@chromium.org2009-04-051-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13137 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the NavigationControllerHistory test.brettw@chromium.org2009-04-051-5/+1
| | | | | | Review URL: http://codereview.chromium.org/62040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13136 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more reliance on tab contents types.brettw@chromium.org2009-04-056-571/+397
| | | | | | Review URL: http://codereview.chromium.org/62041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13135 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the Find bar ownership to the Browser object for portability and ↵finnur@chromium.org2009-04-0515-122/+178
| | | | | | | | testability purposes.BUG=None.TEST=No new functionality, just moving stuff around and as such it is covered by pre-existing tests. Review URL: http://codereview.chromium.org/60105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13134 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of custom tab contents types from some tests.brettw@chromium.org2009-04-0424-951/+786
| | | | | | | | | | | | | | | This required redoing the tests that used it to use the new RenderViewHost test harness. This is mostly straightforward, but required more work for the NavigationController tests. I removed a few random places that were testing for the tab types. I also made different versions of a few functions that don't take tab contents types next to the existing ones that do, so my touched code won't have to be changed again when I remove the tab contents types. Review URL: http://codereview.chromium.org/62039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13132 0039d316-1c4b-4281-b951-d872f2087c98
* Make the throbber throb sooner after you navigate. This fixes the new tab page,brettw@chromium.org2009-04-0411-34/+60
| | | | | | | | | | | | | | which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Review URL: http://codereview.chromium.org/60066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13131 0039d316-1c4b-4281-b951-d872f2087c98
* Callbacks through ChromeClient->RenderView->RenderViewHost for ↵rafaelw@chromium.org2009-04-045-2/+45
| | | | | | | | ContentsDidChangeSize so that extensions can change their toolbar size when the contained contents changes size. Review URL: http://codereview.chromium.org/56122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13130 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: pass the correct event time when we show right click context menus in ↵estade@chromium.org2009-04-036-10/+33
| | | | | | | | the render view. Review URL: http://codereview.chromium.org/62024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13127 0039d316-1c4b-4281-b951-d872f2087c98
* Change the size of media cachehclam@chromium.org2009-04-031-3/+4
| | | | | | | | | | | Setting media cache too large caused creation of cache backend failed because rvargas is performing a experiment that limits cache size to ~240MB, respect such change. TBR=rvargas Review URL: http://codereview.chromium.org/62028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13123 0039d316-1c4b-4281-b951-d872f2087c98
* - Added support for keeping track of load times.davemoore@chromium.org2009-04-031-0/+2
| | | | | | | | | | | | | | | | | For each document loaded we record the time the page was requested by the user (or as close as we can get to that), the time the load process started, the time the document and it's dependent resources (scripts) have been loaded (before onload()) and the time all the document's resources have been loaded. We use this data for two things: 1) We histogram the deltas between the time marks 2) We expose the times to javascript running on the page which was loaded Review URL: http://codereview.chromium.org/42527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13116 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font family and the font size used in dom UI localizable. This is a ↵jungshik@google.com2009-04-039-26/+33
| | | | | | | | | | | | | | | | | | | | | | | part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI. For some Indian languages (Malayalam, Bengali and Telugu), we have to use a bigger size and a font family for that script on Windows. This is because Windows' stock fonts for those scripts are smaller than fonts for other scripts at a given size. I removed 'WEB' style in chrome_font.h because it's not used anywhere any more after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is recycled to localize the font family (or the list of font families) for html UI. I also back-ported the support for setting 'style.fooBar' property to our copy of Jstemplate (JstProcessor.prototype.jstValues_). BUG=7319 Review URL: http://codereview.chromium.org/57025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
* NULL check web_contents_ to prevent a crash.tc@google.com2009-04-031-2/+3
| | | | | | | | | | | | In the notification observer, web_contents_ can be set to NULL so check for a NULL web_contents_ in GetWindowTitle. All the other methods check web_contents_ before using it too. BUG=9672 Review URL: http://codereview.chromium.org/56205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13113 0039d316-1c4b-4281-b951-d872f2087c98
* Create a well-defined region that closely matches the shape of the tab to ↵jhawkins@chromium.org2009-04-034-36/+35
| | | | | | | | use for hit testing in the Linux tabstrip. Review URL: http://codereview.chromium.org/62013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13112 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProxyResolverV8 the default.ericroman@google.com2009-04-031-3/+3
| | | | | | | | | Replace the flag --v8-proxy-resolver with --winhttp-proxy-resolver to reflect new default. BUG=74,2764 Review URL: http://codereview.chromium.org/62022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13110 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Insert a border at the bottom of the toolbar.estade@chromium.org2009-04-031-0/+10
| | | | | | Review URL: http://codereview.chromium.org/62021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13109 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in dragging bookmark bar. The bookmark bar would notsky@chromium.org2009-04-031-2/+3
| | | | | | | | | | | allow drags when on the new tab page. BUG=9674 TEST=see bug, but make sure dragging from bookmark bar works in all modes. Review URL: http://codereview.chromium.org/60096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13106 0039d316-1c4b-4281-b951-d872f2087c98
* Add some hysterisis to tab dragging on Mac.shess@chromium.org2009-04-031-0/+19
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=9670 Review URL: http://codereview.chromium.org/60072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13104 0039d316-1c4b-4281-b951-d872f2087c98
* Adds temporary warning when installing Chrome extensions. The warninggeorged@chromium.org2009-04-031-0/+16
| | | | | | | | | will be replaced with the final extension installation UI when available. Review URL: http://codereview.chromium.org/60079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13103 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/pickle.h. Add some explicit #includes.thestig@chromium.org2009-04-034-7/+16
| | | | | | Review URL: http://codereview.chromium.org/60095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13093 0039d316-1c4b-4281-b951-d872f2087c98
* Put a border around the find bar text entry field.estade@chromium.org2009-04-031-5/+6
| | | | | | Review URL: http://codereview.chromium.org/56207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13091 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded temp_scaffolding_stubs.h includes. Remove ConstrainedWindow ↵thestig@chromium.org2009-04-039-24/+12
| | | | | | | | from the scaffold. Added a bunch of explicit #includes that used to be implicitly included through temp_scaffolding_stubs.h. Review URL: http://codereview.chromium.org/60077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13090 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring ctor of JSONFileValueSerializer.phajdan.jr@chromium.org2009-04-035-16/+12
| | | | | | | | Switched callers to FilePath. Review URL: http://codereview.chromium.org/62009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13089 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds unit-tests for the SafeBrowsingBlockingPage class.jcampan@chromium.org2009-04-039-23/+448
| | | | | | | | | | | | | | | | | This required: - creating a factory to create SafeBrowsingBlockingPage instances (so unit-tests can provide their own sub-classes). - making the code posts tasks on the current message loop when there is no IO thread. This should only happen in tests scenarios where we only have 1 thread. BUG=6731 TEST=Run the unit-tests. In Chrome, navigate to pages flagged as malware (ex: ianfette.org) and make sure the safe browsing feature still works as expected. Review URL: http://codereview.chromium.org/56135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13088 0039d316-1c4b-4281-b951-d872f2087c98
* Make OpenProcessHandle report an error when it couldn't open the handle.phajdan.jr@chromium.org2009-04-032-3/+7
| | | | | | | | One more step to land http://codereview.chromium.org/54003 (chrome_process_util). Review URL: http://codereview.chromium.org/62004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13086 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add devtools messages into the about:ipc dialog.pfeldman@chromium.org2009-04-031-1/+15
| | | | | | Review URL: http://codereview.chromium.org/60090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13082 0039d316-1c4b-4281-b951-d872f2087c98
* Remove two unneeded uses of std::floor in the GTK tab code.deanm@chromium.org2009-04-031-3/+2
| | | | | | | | | | | | | | | - <cmath> was not included, breaking some builds - one floor was used without the std:: prefix These floor calls should have been redundant, the result was assigned to an int, which will cause the same truncation anyway. Pointed out by Hironori Bono and Craig Schlenter. Review URL: http://codereview.chromium.org/60088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13080 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: move devtools messages to common.pfeldman@chromium.org2009-04-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/60087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13079 0039d316-1c4b-4281-b951-d872f2087c98
* Move code to allow dns queries (and accompanyingaa@chromium.org2009-04-033-38/+0
| | | | | | | | | | | TODO) from each in-process ui test into the base class, since it is really the base class that is initiating these queries (by way of starting the browser). Review URL: http://codereview.chromium.org/56173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13069 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-0334-293/+235
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move IPC code to ipc/"agl@chromium.org2009-04-0316-17/+17
| | | | | | | This reverts commit r13062 which, unsurprisingly, broke the build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPC code to ipc/agl@chromium.org2009-04-0316-17/+17
| | | | | | | (No review URL: Rietvelt couldn't cope) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to support 2-way communication between extensions and renderers. ↵mpcomplete@google.com2009-04-025-114/+128
| | | | | | | | The code is almost fully symmetrical, except that right now a channel can only be opened to an extension (by ID). It should be trivial to open a channel to a tab, once we have a solid tab API. Review URL: http://codereview.chromium.org/56037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13057 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic mouse input handling for Linux TabStrip.jhawkins@chromium.org2009-04-024-4/+134
| | | | | | Review URL: http://codereview.chromium.org/56200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13053 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a crash in resource handlers.paulg@google.com2009-04-022-0/+8
| | | | | | | | | | | | | | Investigating the crash dumps for this bug, it looks like under certain network error conditions, the resource handlers are freed before the SafeBrowsing check has completed. When the check runs, it calls into invalid memory and crashes. BUG=8544 (http://crbug.com/8544) Review URL: http://codereview.chromium.org/60043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13052 0039d316-1c4b-4281-b951-d872f2087c98
* Only create one downloads tab per window. If there is already a Downloadsestade@chromium.org2009-04-023-2/+6
| | | | | | | | | | tab, then switch to it instead of creating new one. Introduce FOCUS_SINGLETON_TAB disposition. patch by Mohamed Mansour <http://codereview.chromium.org/50003/show> Review URL: http://codereview.chromium.org/60062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13045 0039d316-1c4b-4281-b951-d872f2087c98
* Copy selection to x clipboard.estade@chromium.org2009-04-025-21/+146
| | | | | | Review URL: http://codereview.chromium.org/55052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13044 0039d316-1c4b-4281-b951-d872f2087c98
* Revert until sequencing issue fixed.ben@chromium.org2009-04-023-105/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13039 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a case where non-tabbed browser windows could open tabs. Also includes ↵ben@chromium.org2009-04-023-16/+105
| | | | | | | | | | UI test for this. http://crbug.com/8472 Review URL: http://codereview.chromium.org/56094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13036 0039d316-1c4b-4281-b951-d872f2087c98
* Paste from the x clipboard into webkit.estade@chromium.org2009-04-025-0/+34
| | | | | | Review URL: http://codereview.chromium.org/51008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13031 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 2220 lists two cases where the inactive highlighting doesn't reappear on ↵finnur@chromium.org2009-04-022-6/+18
| | | | | | | | | | FindNext. This is a simple fix for one of those cases (user presses Refresh after Find). BUG=2220 TEST=Open google.com, press Find, press e, press Refresh, press F3 (or FindNext button in UI). Then make sure the inactive matches are highlighted (not just the active match). Review URL: http://codereview.chromium.org/56193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13028 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow hotkeys to activate un-activatable menu items on linux.estade@chromium.org2009-04-021-2/+6
| | | | | | | BUG=9400 Review URL: http://codereview.chromium.org/56184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13025 0039d316-1c4b-4281-b951-d872f2087c98
* A file I left out of rietveld issue 56153estade@chromium.org2009-04-021-1/+1
| | | | | | | | TBR=paul Review URL: http://codereview.chromium.org/56182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13019 0039d316-1c4b-4281-b951-d872f2087c98
* Installing extensions (drag/drop, download crx file) will now begeorged@chromium.org2009-04-016-9/+74
| | | | | | | | | handled by the Chrome instance w/o shell execute. This will install the extension in the proper profile using the running bits. Review URL: http://codereview.chromium.org/55046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13000 0039d316-1c4b-4281-b951-d872f2087c98
* Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.hdarin@chromium.org2009-04-012-6/+18
| | | | | | | | | | | | | This also eliminates webkit_glue::GetScreenInfo and webkit_glue::GetScreenInfoHelper. As part of this CL, I also extracted all of the ParamTraits for WebKit API types into chrome/common/webkit_param_traits.h. R=dglazkov Review URL: http://codereview.chromium.org/58008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12993 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-013-1574/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98