summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix a crash in chrome.exe caused by the external tab container instance ↵ananta@chromium.org2009-03-052-7/+18
| | | | | | | | | | | | | | getting destroyed without going through the proper window shutdown sequence when the external host crashes. The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB. Bug=1688967 Review URL: http://codereview.chromium.org/39086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10962 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we display a sad face for a windowed plugin when the plugin ↵ananta@chromium.org2009-03-052-21/+45
| | | | | | | | | | | | | | | process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes. The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows. This fixes http://code.google.com/p/chromium/issues/detail?id=7673 Bug=7673 Review URL: http://codereview.chromium.org/40120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10960 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a bug about full screen mode.tc@google.com2009-03-051-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/40142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10956 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a toolbar width TODO.evan@chromium.org2009-03-051-4/+3
| | | | | | Review URL: http://codereview.chromium.org/39168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10954 0039d316-1c4b-4281-b951-d872f2087c98
* Changes spellcheck_unittest to read dictionaries directly from the src tree. ↵shess@chromium.org2009-03-051-12/+20
| | | | | | | | | Removes the build rules to copy test dictionaries to Dictionaries/. Review URL: http://codereview.chromium.org/40082 Patch from rohitrao. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10951 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark manager would show black backgroundsky@google.com2009-03-051-3/+6
| | | | | | | | | | | | when not results are found for a search string. Using your halo methods does the trick. BUG=8367 TEST=see bug Review URL: http://codereview.chromium.org/39165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10944 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the browser about URL handler to not derive from WebContents. It isbrettw@chromium.org2009-03-048-353/+343
| | | | | | | | | | | | | | | | | | | | instead integrated in the BrowserURLHandler for special schemes. This solves a number of problems and cleans things up nicely. Most of the functions were not necessary to have in the header file of the browser about handler, so I made them local to the .cc file. I moved everything around, but there was no change to any of the About...() functions. This improves the about:memory page to not include the memory of the new tab page it replaced. The entry for itself also has the proper title. This works by using a meta refresh to the actual page, the the process transition no longer happens at the same time as the about:memory page computation. This also fixes problems with the about:network and about:ipc dialogs opening blank pages and also re-opening the dialog when you close the browser. Review URL: http://codereview.chromium.org/27238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10941 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of backing_store_win.cccpu@google.com2009-03-042-60/+42
| | | | | | | | | | | | | | | | | | - Fix a small leak (solved by re-selecting the initial bitmap into the dc at dtor time) - Remove one set of GetDC(NULL) + GetDeviceCaps() + ReleaseDC() - Remove some dead code The removal of GetDC(NULL) might speed up Vista drawing a little bit, as is rummored that this operation is expensive when DWM + Aero is enabled. The integer overflow check is no longer possible. I'll file a bug so it is not lost. TEST= existing test suffice Review URL: http://codereview.chromium.org/21516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10938 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at hooking up title bar on linux.tc@google.com2009-03-042-24/+24
| | | | | | | | | | | | The only change from before is moving a method from a windows #ifdef section to outside it. TBR=evan Review URL: http://codereview.chromium.org/39158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10937 0039d316-1c4b-4281-b951-d872f2087c98
* Add download items to the download shelf in linux.estade@chromium.org2009-03-046-5/+182
| | | | | | Review URL: http://codereview.chromium.org/40136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transparency for dragged downloads and links by using the halo textbrettw@chromium.org2009-03-042-62/+9
| | | | | | | routines. This also removes CreateDragImageForLink which is never called. Review URL: http://codereview.chromium.org/39082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10934 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-042-0/+6
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential crash if the saved options tab is ever out of bounds.ben@chromium.org2009-03-041-1/+4
| | | | | | | | http://crbug.com/8342 Review URL: http://codereview.chromium.org/40090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10928 0039d316-1c4b-4281-b951-d872f2087c98
* Basic download shelf implementation on linux.estade@chromium.org2009-03-047-22/+175
| | | | | | | | | | It shows and hides at appropriate times, and that's about it. TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again. Review URL: http://codereview.chromium.org/38004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10927 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up the app title to the page title."tc@google.com2009-03-042-9/+9
| | | | | | | | | This reverts commit 10923. Review URL: http://codereview.chromium.org/40130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10924 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the app title to the page title.tc@google.com2009-03-042-9/+9
| | | | | | | Review URL: http://codereview.chromium.org/39114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10923 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing WebKeyboardEvent.avi@chromium.org2009-03-045-14/+8
| | | | | | Review URL: http://codereview.chromium.org/39075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10918 0039d316-1c4b-4281-b951-d872f2087c98
* Add trivial theming support in extensions.erikkay@google.com2009-03-042-3/+55
| | | | | | | NOTE: This is not final API. It *will* change. It's purely for testing purposes. Review URL: http://codereview.chromium.org/40042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another regression. Coordinate calculation in the ↵ben@chromium.org2009-03-041-1/+5
| | | | | | | | | | OpaqueBrowserFrameView::HitTest method was wrong. http://crbug.com/8365 Review URL: http://codereview.chromium.org/37008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10907 0039d316-1c4b-4281-b951-d872f2087c98
* Register SSLManager preferences on linux and mac.evan@chromium.org2009-03-041-3/+3
| | | | | | | | | This should fix the following error: FATAL:common/pref_service.cc(314)] Check failed: false. Trying to read an unregistered pref: security.mixed_content_filtering Review URL: http://codereview.chromium.org/39006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10903 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r10674, which got lost during Ben's reorg of the frame code.pkasting@chromium.org2009-03-042-7/+7
| | | | | | | | | I guess CalculateWindowSizeForClientSize() disappeared in that reorg? That's the one part of the old change I can't find where to put. BUG=8151 Review URL: http://codereview.chromium.org/39074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10896 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in InitCurrentUI.glen@chromium.org2009-03-041-2/+8
| | | | | | | | | | Also fix a leak while I'm here. TBR=brettw Review URL: http://codereview.chromium.org/40112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10891 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a Purify UMR error. This isn't great, but it's better than nothing.deanm@chromium.org2009-03-041-2/+5
| | | | | | | | BUG=8314 Review URL: http://codereview.chromium.org/39125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10889 0039d316-1c4b-4281-b951-d872f2087c98
* Also fixes a bug where an externally installedaa@chromium.org2009-03-043-197/+194
| | | | | | | | | | | | | | | | | | | | | | | extension was loaded twice the first run after installation. I still ExtensionServiceBackend is begging to be split apart into individual tasks, this was just a quick spruce-up while I was in the file. The main things I changed are: * Moved extension_path_ from a member back into parameters where relevant. This just didn't feel right as state to me. It isn't relevant to all the methods the way alert_on_error_ and frontend_ are. This created the majority of the noise in the change, but is the least important. * Renamed OnExtensionsLoadedFromDirectory to OnExtensionsLoaded since it is called in response to LoadExtension() too. * Made install_directory_ be a parameter to backend's constructor instead of passed into each appropriate method. Again, this felt more appropriate because the install directory is relevant to the whole object. * Hoisted checking for uninstalled external extensions up out of LoadExtension() into LoadExtensionsFromInstallDirectory(). It wasn't doing any harm in LoadExtension(), but it didn't seem relevant to other places where LoadExtension() is used (for example --load-extension and --install-extension). * Hoisted installation success notification up out of InstallOrUpdateExtension() into InstallExtension(). This prevented having to pass around a be_noisy argument since InstallExtension() is only used for handling --install-extension, and InstallOrUpdateExtension() is just the private impl. Review URL: http://codereview.chromium.org/40002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10885 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bone-headed bug where ExtensionErrorReporteraa@chromium.org2009-03-042-2/+9
| | | | | | | | | gets deleted after first message is sent from a background thread. Review URL: http://codereview.chromium.org/39034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux buildbrettw@chromium.org2009-03-041-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10878 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stupid typo causing the navigation entry unit tests to fail.brettw@chromium.org2009-03-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/39117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 16/wide build bustange on non-Windows.brettw@chromium.org2009-03-045-5/+5
| | | | | | Review URL: http://codereview.chromium.org/39116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10876 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build with some forgotten string conversions on non-Windows.brettw@chromium.org2009-03-048-14/+15
| | | | | | Review URL: http://codereview.chromium.org/40099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10875 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving SupportsWindowFeature from BrowserViewtc@google.com2009-03-044-39/+40
| | | | | | | | | | | | | | | | | | to Browser. Turns out the test regression was actually caused by r10806 which removed an anonymous namespace causing the TestView class to collide with the same class in render_widget_host_unittest.cc. For now, fix by adding the TestView in the view unittest to the anon namespace. shess is going to try to re-add the namespace to render_widget_host_unittest.cc too. TBR=pkasting Review URL: http://codereview.chromium.org/40058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10873 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NavigationEntry title to string16. TabContents::GetTitle no longer needsbrettw@chromium.org2009-03-0428-77/+113
| | | | | | | | | | | | | | | to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Review URL: http://codereview.chromium.org/39022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
* Fix back button behavior for DOMUI contents (or at least make it as ↵glen@chromium.org2009-03-041-0/+1
| | | | | | | | | | | not-broken as before) - I forgot to add this line to the nav controller. BUG=8212 Review URL: http://codereview.chromium.org/40076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10865 0039d316-1c4b-4281-b951-d872f2087c98
* Show icons for exe files in download manager. Issue was that the paths were ↵glen@chromium.org2009-03-041-2/+9
| | | | | | | | | | coming in with the wrong slash direction and escaping, which was OK for non-exes, but strangely bad for exes. BUG=8327 Review URL: http://codereview.chromium.org/40068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10864 0039d316-1c4b-4281-b951-d872f2087c98
* * Make the download page focus the input field onload.* Fix spacing between ↵glen@chromium.org2009-03-042-18/+56
| | | | | | | | | controls (Pause/Cancel).* Help deblock download UI creation (timeout in downloads.html, kMaxDownloads in downloads_ui.cc)* Allow resume for paused downloads BUG=8271,8270,8130,8330 Review URL: http://codereview.chromium.org/40047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10863 0039d316-1c4b-4281-b951-d872f2087c98
* Make New Tab Page work correctly in incognito mode (8294)glen@chromium.org2009-03-046-48/+69
| | | | | | | | | | | | | | | Add a workaround to force the New Tab Page title to 'New Tab' (8282) Make DOMUI Pages get focus correctly (8271) Please also sanity-check DOMUI/DOMUIContents integration. BUG=8294,8282,8271 Review URL: http://codereview.chromium.org/39057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10862 0039d316-1c4b-4281-b951-d872f2087c98
* Update clipboard classes to use string16 and FilePath instead of wstring.estade@chromium.org2009-03-046-13/+16
| | | | | | | | | | Update callers as well. This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294 Review URL: http://codereview.chromium.org/27370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10860 0039d316-1c4b-4281-b951-d872f2087c98
* Add a set of long-running metrics to Chrome that are sent up only at ↵robertshield@google.com2009-03-042-18/+43
| | | | | | | | uninstall time via the uninstall survey page.These uninstall metrics are collected according to the same opt-in policy as the existing UMA code. They are stored along with other prefs in the browser's Local State file. At uninstall time, the Local State file is copied to a temporary location during the file deletion stage and then read to extract the uninstall metrics. If the user selected to have metrics reported, the uninstall metrics are then sent up to the uninstall survey page that is currently opened. Review URL: http://codereview.chromium.org/27092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10859 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where the window caption buttons weren't clickable when ↵ben@chromium.org2009-03-042-17/+14
| | | | | | | | | | | | maximized. This is because of the nonclient frameview/clientview hierarchy changes. Make sure that the frame gets a chance to respond to GetViewForPoint before the client view if the client view does not visually overlap. http://crbug.com/8312 Review URL: http://codereview.chromium.org/40062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10857 0039d316-1c4b-4281-b951-d872f2087c98
* Add comment regarding why single-process and in-process-plugins are disabled ↵jam@chromium.org2009-03-041-0/+2
| | | | | | | | for Chrome Release builds. Review URL: http://codereview.chromium.org/39046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10852 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release-only build break.pkasting@chromium.org2009-03-041-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10848 0039d316-1c4b-4281-b951-d872f2087c98
* Initial checkin of the out of process worker implementation.jam@chromium.org2009-03-048-0/+323
| | | | | | | | | | | WebWorkerClient/WebWorker are parallel interfaces of WebCore::{WorkerObjectProxy, WorkerContextProxy} that use Chrome data types. When WebKit requests a WorkerObjectProxy, we create an instance of WebWorkerClientImpl. This class creates an object that implements a Chromium version of WorkerObjectProxy (i.e. with Chrome data types) through WebViewDelegate. That object is a WebWorkerProxy and talks over IPC to a WebWorker object in the worker process. The WebWorker object creates the actual WebCore::Worker object using another class in glue: WebWorkerImpl. When the WebCore::Worker object running in the worker process wants to talk back to the code running in the renderer, it talks to WebWorkerImpl which implements WebCore::WorkerObjectProxy. WebWorkerImpl converts the data types to Chrome compatible ones, and then calls the WebWorkerClient version which does IPC to get to the renderer process. This ends up at WebWorkerProxy, which calls WebWorkerClientImpl (the original class). In future changes, sandboxing, multiple worker processes etc will be added. Note that I also had to make two small changes to WebKit, since WorkerMessagingProxy couldn't be created as is for the nested worker case. I'll either check it in myself or work with Jian to do so. Review URL: http://codereview.chromium.org/27157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10847 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium windows not hide auto-hide taskbars.pkasting@chromium.org2009-03-045-37/+69
| | | | | | | | | | | | | | | There are a few caveats here: * On Aero glass, if the auto-hide taskbar is at the top of the screen, we get one row of nonclient pixels along the bottom of the screen (not too noticeable for light-colored pages, looks a bit odd with a dark page). I can't find a way around this. * Switching between fullscreen and normal mode can leave things a bit confused until you click another app and then reactivate Chromium. This seems to happen with other applications too (e.g. Firefox fullscreen mode) so I'm not too worried. * Chromium does not deal well with toggling the taskbar's auto-hide setting (or, I think, its position?) unless you restore and remaximize the window. I tried to fix this via modified handling of WM_SETTINGCHANGE but only made things worse and so gave up. BUG=20 Review URL: http://codereview.chromium.org/28338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10845 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath setter/getter to pref service. Change callers to use it rather ↵estade@chromium.org2009-03-047-14/+13
| | | | | | | | | | | | | than the string methods. Update the pref service unit test and enable it on linux. Also switch over some wstrings to filepaths where appropriate. BUG=8154 Review URL: http://codereview.chromium.org/27354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10844 0039d316-1c4b-4281-b951-d872f2087c98
* revert broken change 10833nsylvain@chromium.org2009-03-0321-542/+403
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10837 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an include of a header that was removed in r10832.jhawkins@chromium.org2009-03-031-1/+0
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/39069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10835 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser.scons and chrome.gyp to match files removed in r10832.jhawkins@chromium.org2009-03-031-20/+0
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/39067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10834 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-0321-403/+542
| | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818 Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10833 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeUI, HistoryTabUI, DownloadsTabUI since they've been superceded.ben@chromium.org2009-03-0318-5165/+4
| | | | | | Review URL: http://codereview.chromium.org/39005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10832 0039d316-1c4b-4281-b951-d872f2087c98
* Move RemoveTabAt to the TabStrip interface from RemoveTabAnimation.jhawkins@chromium.org2009-03-032-23/+21
| | | | | | | | * This change is needed to allow a clean refactoring of TabStrip. The animation classes should be as cross-platform as possible. * RemoveTabStrip animation now requests the TabStrip to remove a tab for it. Review URL: http://codereview.chromium.org/27366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10830 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag --v8-proxy-resolver, to select the new PAC ↵ericroman@google.com2009-03-032-6/+35
| | | | | | | | | | | | | | | | | | implementation. When running in single process mode, this flag has no effect (since we can't run side by side with the renderer's V8). In regular mode, the v8 resolver is currently running in the browser process. This means it has to share with the v8 debugger shell. Added locking around the debugger shell so they can peacefully co-exist. When this flag is enabled, PAC scripts are downloaded through the browser. BUG=74,2764 Review URL: http://codereview.chromium.org/27365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10827 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 08:53:00 +0000