summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Add getFileSize support to chromiumvictorw@chromium.org2009-07-038-0/+281
| | | | | | | | | | | | | | | | | The current implementation only allows getting file size if the child process has been granted permission to upload file. May need to update the policy checking code if getFileSize is needed in other cases. Here is the webkit implementation to support this: https://bugs.webkit.org/show_bug.cgi?id=26521 TEST=none BUG=9102 Review URL: http://codereview.chromium.org/131082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 19829.mirandac@chromium.org2009-07-026-223/+9
| | | | | | | | BUG= http://crbug.com/1455 Review URL: http://codereview.chromium.org/149156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with extension messaging:mpcomplete@chromium.org2009-07-024-18/+25
| | | | | | | | | | | | | | - Disconnect ports properly (javascript mistake). - Use the right port ID when dispatching the disconnect event. - Fix a bug with 2 extensions loaded in the same process. BUG=12686 BUG=15798 TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting. Review URL: http://codereview.chromium.org/152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux2 build.brettw@chromium.org2009-07-023-3/+3
| | | | | | | | I removed the extra argument from WidgetGTK::Init but didn't update these sites. Review URL: http://codereview.chromium.org/155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: when doing a drag from a web page, pass a recent mouse down to ↵estade@chromium.org2009-07-022-6/+12
| | | | | | | | | | | | | | | | | | | gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer(). I believe the following was happening: - render view gets mouse down, forwards to webkit - render view gets motion, forwards to webkit - user releases mouse button, that event is added to the queue - browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event - gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue - mouse release comes up in queue; passed to render view rather than the drag widget TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer. BUG=http://crbug.com/15768 Review URL: http://codereview.chromium.org/150204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark util crashestade@chromium.org2009-07-021-0/+4
| | | | | | | | | BUG=http://crbug.com/15853 TEST=none Review URL: http://codereview.chromium.org/155004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19838 0039d316-1c4b-4281-b951-d872f2087c98
* Pop-up chrome.jrg@chromium.org2009-07-024-6/+54
| | | | | | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/15727 TEST=Load a web page that has a popup. Example: <!DOCTYPE html> Click button to open a new window. <br> <button onclick="w = window.open('http://www.google.com', 'New Window', 'width=512,height=512'); w.moveTo(300,300);">Open with w,h</button> Now click on the button to get a pop-up. In the new window, make sure there is no "tab" area above the URL bar, and no "new tab" button. Hit Cmd-T to create a new tab, and make sure it gets created in the OTHER window. More work is needed to minimize pop-up chrome more, but this'll prevent the most brutal failures (e.g. team meeting "demo" today). Review URL: http://codereview.chromium.org/151135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19837 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I came across while debugging.eroman@chromium.org2009-07-022-3/+3
| | | | | | | | | | BUG=None TEST=None TBR=brettw Review URL: http://codereview.chromium.org/149128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19832 0039d316-1c4b-4281-b951-d872f2087c98
* Add more functionality to the gtk task manager:jhawkins@chromium.org2009-07-023-14/+64
| | | | | | | | | | * Columns are resizable. * Resource icon displayed by resource name. BUG=11392 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19830 0039d316-1c4b-4281-b951-d872f2087c98
* Change status bubble so that it expands to accommodate URL's that are ↵mirandac@chromium.org2009-07-026-9/+223
| | | | | | | | | | | abridged in the standard width. BUG= http://crbug.com/1455 TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained. Review URL: http://codereview.chromium.org/146043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Clean up some bookmark related UI hacks.estade@chromium.org2009-07-023-57/+34
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/150203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19827 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Add and Update for PasswordStoreMac.stuartmorgan@chromium.org2009-07-028-49/+148
| | | | | | | | | | | Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing. Add creator code for keychain items we create, and unit tests to make sure. BUG=11745 TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction. Review URL: http://codereview.chromium.org/151176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98
* Convert menu strings to UTF16, fix some views-GTK build errors.brettw@chromium.org2009-07-0217-76/+76
| | | | | | Review URL: http://codereview.chromium.org/150171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:rafaelw@chromium.org2009-07-021-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19817 0039d316-1c4b-4281-b951-d872f2087c98
* reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ↵rafaelw@chromium.org2009-07-021-4/+12
| | | | | | | | | | ui_test_utils. R=aa Review URL: http://codereview.chromium.org/151189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19811 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts 2 CLs that worked around a problem with NSGradient on 10.6,jeremy@chromium.org2009-07-021-34/+5
| | | | | | | | | | | the underlying issue is fixed in the latest seed so we don't need the workaround anymore: * r16073 "Fixup colors for inactive tab." * r15328 "Fixes for 10.6" (only the changes to tab_cell.mm) Review URL: http://codereview.chromium.org/151197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19810 0039d316-1c4b-4281-b951-d872f2087c98
* Add split with devtools container into the browser view.pfeldman@chromium.org2009-07-022-6/+55
| | | | | | Review URL: http://codereview.chromium.org/151150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Spurious SQL error message is logged in priming SQLite database cache.yuzo@chromium.org2009-07-022-21/+2
| | | | | | | | | | | | | | | | | | | | This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19803 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor MetaTableHelper to remove redundant table name prefixing with databaseyuzo@chromium.org2009-07-023-17/+74
| | | | | | | | | | | | name. Also, PrimeCache logic duplicated in HistoryBackend and SQLitePersistentCookieStore is moved to this class. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19802 0039d316-1c4b-4281-b951-d872f2087c98
* Paint infobar background as gradient.estade@chromium.org2009-07-021-5/+33
| | | | | | | | | TEST=look at an infobar BUG=none Review URL: http://codereview.chromium.org/151162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19801 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer arraysize() over sizeof().cmp@google.com2009-07-021-1/+1
| | | | | | | | | | | | | Fix a call to sizeof() on a static array to use arraysize() instead. Maybe fixes a coverity issue, too. BUG=none TEST=none Review URL: http://codereview.chromium.org/150202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix performance issues with NNTP.arv@google.com2009-07-023-33/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My tests show it as not as fast as the old NTP but it is a lot better than before these changes: Old NTP: 208 223 211 205 211 Average: 211.6 NNTP before this change: 732 718 718 713 Average: 720.25 NNTP with this change: 255 248 257 254 257 Average: 254.2 There is still room for improvements but this brings the NNTP perf closer to being acceptable. BUG=13362 TEST=Perf test at http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-cold/report.html?history=200 Review URL: http://codereview.chromium.org/150194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of tracking down asky@chromium.org2009-07-012-0/+5
| | | | | | | | | | | | | | | | crash. Specifically: . Adds a CHECK to IDMap that evaluates to true if adding NULL. The default isn't to do this check. . browser_shutdown CHECKs if the # RPHs changes while iterating through the RPHs. BUG=15615 TEST=none Review URL: http://codereview.chromium.org/150181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19779 0039d316-1c4b-4281-b951-d872f2087c98
* Adds user metrics for tab overview.sky@chromium.org2009-07-014-2/+22
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19776 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of low-level keychain helper tests that are now redundant ↵stuartmorgan@chromium.org2009-07-013-426/+252
| | | | | | | | | | | | with tests of the newer higher-level methods. Start collecting the helpers into a cohesive class that serves as a translation layer between keychain items and password forms. BUG=none TEST=Keychain passwords should still fill after a username is typed on the Mac (no change in behavior). Review URL: http://codereview.chromium.org/151164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19773 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions can now specify multiple icons and switch between themfinnur@chromium.org2009-07-019-44/+132
| | | | | | | | | | | using optional parameters to enableForTab. BUG=http://crbug.com/11906 TEST=None Review URL: http://codereview.chromium.org/149046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98
* Call superclass's TearDown to avoid leaks.pinkerton@chromium.org2009-07-011-4/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/150183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19771 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux restore Omnibox contents on tab switch.evan@chromium.org2009-07-013-30/+166
| | | | | | | | | | | | | | | | | | | | | | | Tested as follows: Create a new window with two tabs. Type a bunch of 'a' characters into tab A's omnibox and a bunch of 'b's into tab B. Then, 1. Select tab A. Left-click in the omnibox and highlight a few characters in the middle. Left-click in the empty space to the right of the text to unhighlight it, then middle-click to make sure that the previously-highlighted text still gets pasted. 2. Repeat 1, but hit a key to remove the selection instead of clicking the mouse. The old highlighted text should still be available as the primary selection. 3. Highlight A's text as in 1. Select tab B and see that the omnibox is updated to B's string and highlighting is removed. Middle-click and confirm that the previously-highlighted text from A is pasted. 4. Select A and left-click in the middle of its string to position the cursor there. Click on tab B and then back on A to check that A's cursor position is restored. 5. Highlight text in A. Select tab B and then highlight text from a different window. Switch back to A and middle-click. The text from the different window, rather than A's previously-highlighted text, should be pasted. BUG=9225 Review URL: http://codereview.chromium.org/151006 Patch from Dan Erat <derat@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19770 0039d316-1c4b-4281-b951-d872f2087c98
* Moved typedef of RedirectList from HistoryService class to history namespace.meelapshah@chromium.org2009-07-0120-60/+62
| | | | | | Review URL: http://codereview.chromium.org/151168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19758.mirandac@chromium.org2009-07-014-49/+17
| | | | | | Review URL: http://codereview.chromium.org/150180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19763 0039d316-1c4b-4281-b951-d872f2087c98
* Improves tab overview.sky@chromium.org2009-07-018-25/+153
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19761 0039d316-1c4b-4281-b951-d872f2087c98
* Diable Broken RenderViewHostManager browsertest from ↵rafaelw@chromium.org2009-07-011-1/+1
| | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=19752 R=ojan Review URL: http://codereview.chromium.org/150179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19759 0039d316-1c4b-4281-b951-d872f2087c98
* Theme window control buttons.mirandac@chromium.org2009-07-014-17/+49
| | | | | | | | | BUG= http://crbug.com/14579 TEST= Install a theme with themed window control buttons. Observe that WCB's are themed. Review URL: http://codereview.chromium.org/150041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19758 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to allow browser close after download initiated from chrome:// url.rafaelw@chromium.org2009-07-013-1/+71
| | | | | | | | | R=brettw BUG=12745 Review URL: http://codereview.chromium.org/150122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19752 0039d316-1c4b-4281-b951-d872f2087c98
* Allow getting the theme tint as a value so that it can be applied ↵avi@chromium.org2009-07-014-31/+96
| | | | | | | | | | | independent of the theme provider. Since the Mac needs it to tint its vector resources it's added to the Mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/151153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19751 0039d316-1c4b-4281-b951-d872f2087c98
* Create an interface just for update-related functions in ExtensionsService.asargent@chromium.org2009-07-013-15/+31
| | | | | | | | | | | This abstracts out the pieces that ExtensionUpdater will depend on, to allow easy mocking. BUG=http://crbug.com/12117 TEST=none Review URL: http://codereview.chromium.org/151127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19747 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for page_cycler perf regression.meelapshah@chromium.org2009-07-011-1/+3
| | | | | | Review URL: http://codereview.chromium.org/151159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19745 0039d316-1c4b-4281-b951-d872f2087c98
* Try to track down the cause of the Drag&Drop crash seen in bug 12524.finnur@chromium.org2009-07-011-0/+5
| | | | | | | | | BUG=12524 TEST=None, we just need to monitor the crash reports from the field. Review URL: http://codereview.chromium.org/150136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19744 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to the History to return a list of the top n visited URLs ↵meelapshah@chromium.org2009-07-016-0/+68
| | | | | | | | where and the list of most recent redirects for each of those URLs. Review URL: http://codereview.chromium.org/151057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19743 0039d316-1c4b-4281-b951-d872f2087c98
* Remove null link from "welcome to tips" default suggestion. Also make some ↵mirandac@chromium.org2009-07-015-6/+31
| | | | | | | | | | | hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556. BUG= http://crbug.com/15467 TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link. Review URL: http://codereview.chromium.org/147247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the core functionality of the gtk task manager.jhawkins@chromium.org2009-07-012-52/+273
| | | | | | | | BUG=11392 TEST=none Review URL: http://codereview.chromium.org/151154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19738 0039d316-1c4b-4281-b951-d872f2087c98
* More new tab button tweaks. I'm leaving tab_start_x as I suspect I'msky@chromium.org2009-07-011-15/+5
| | | | | | | | | | | going to need it again shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/151126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19736 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. ↵pinkerton@chromium.org2009-07-018-20/+360
| | | | | | | | | | Implement displaying of notification, menu of popups still to come. BUG=13160 TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab. Review URL: http://codereview.chromium.org/150132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19735 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tabs open on the left like normal.brettw@chromium.org2009-07-011-4/+0
| | | | | | Review URL: http://codereview.chromium.org/151117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19733 0039d316-1c4b-4281-b951-d872f2087c98
* The real unit test for bug 12902, which didn't land before (computers are ↵pinkerton@chromium.org2009-07-011-0/+110
| | | | | | | | | hard, mmkay?). BUG=12902 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19731 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to getting theme images via SkBitmap.avi@chromium.org2009-07-011-18/+32
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19729 0039d316-1c4b-4281-b951-d872f2087c98
* Whoops, accidentally committed a debug linepinkerton@chromium.org2009-07-011-1/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19728 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for ClearBrowsingDataController.pinkerton@chromium.org2009-07-013-13/+23
| | | | | | | | | Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end up deleting passwords instead. Patch from Jens Alfke (snej@google.com). BUG=12902 TEST=deleting form data should actually delete the form data. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19727 0039d316-1c4b-4281-b951-d872f2087c98
* Converts BaseView to be non-opaque, which will fix drawing ofrohitrao@chromium.org2009-07-012-4/+10
| | | | | | | | | | | | | | overlapping views, including the findbar and resize widget. Three classes currently inherit from BaseView: TabContentsViewCocoa, RenderWidgetHostViewCocoa, and SadTabView (Mac). BUG=http://crbug.com/10887 BUG=http://crbug.com/13150 TEST=Findbar should never disappear when searching. Resize widget should never disappear. Clicking and dragging in a webpage should not move the window around. Review URL: http://codereview.chromium.org/150104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19725 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add docked pane into the browser view.pfeldman@chromium.org2009-07-0114-109/+91
| | | | | | Review URL: http://codereview.chromium.org/150160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 00:57:02 +0000