summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* gdata:: Add GDataFileSystem::GetFile().satorux@chromium.org2012-03-033-13/+105
| | | | | | | | | | | | | | | | | | This function is used to get files from the file system. For now, it always download files from the cloud. We should have the caching layer in-pace here. Along the way, a mssing 'return' to Remove(). Change GetDocumentUrlFromPath() to GetGDataFileInfoFromPath, and wrote a test for it. BUG=chromium-os:27174 TEST=unit_tests Review URL: http://codereview.chromium.org/9583031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation error on win_aura which is the side effect of 124852oshima@chromium.org2012-03-032-0/+2
| | | | | | | | | | | | Include base/logging explicitly TBR=thestig@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9586029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124856 0039d316-1c4b-4281-b951-d872f2087c98
* more logs in login.js|htmloshima@chromium.org2012-03-032-10/+24
| | | | | | | | | | TBR=xiyuan@chromium.org BUG=chromium-os:26646 TEST=none Review URL: https://chromiumcodereview.appspot.com/9580039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124853 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: IWYU for BrowserThread.thestig@chromium.org2012-03-0312-30/+45
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9558012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124852 0039d316-1c4b-4281-b951-d872f2087c98
* Replace void* with int32 for passing download_id to SelectFileDialog::Listener.achuith@chromium.org2012-03-035-10/+12
| | | | | | | | | BUG=NONE TEST=trybot runs. Review URL: http://codereview.chromium.org/9589003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124851 0039d316-1c4b-4281-b951-d872f2087c98
* Don't set ion=1 for hidden Instant modes.sreeram@chromium.org2012-03-035-6/+42
| | | | | | | | | | | | | | Setting ion=1 overrides google.com preferences, which can be a surprise. Visible Instant is not such a surprise, since the user can actually see the previews and thus associate it with Chrome Instant. BUG=105390 TEST=Start with --instant-field-trial=hidden and observe that the Instant homepage requests don't have ion=1. Turn off Google Instant (using google.com/preferences) and observe that Google Instant remains turned off on an omnibox-initiated search. Review URL: http://codereview.chromium.org/9581026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124850 0039d316-1c4b-4281-b951-d872f2087c98
* [refactor] Split up SourceTracker into SourceTracker + EventsTracker.eroman@chromium.org2012-03-0312-76/+118
| | | | | | | | | This is in preparation for adding some extra functionality at the EventsTracker layer (max events throttling). Review URL: http://codereview.chromium.org/9581021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124847 0039d316-1c4b-4281-b951-d872f2087c98
* css hack n' slash, continued: New styles for buttons and selects.estade@chromium.org2012-03-0317-134/+138
| | | | | | | | | | | | | | I am moving all widget styles into button.css. I will later rename it widget.css. This way, the rules that are common can be shared. The next step will be to update/merge checkbox.css into button.css. BUG=103688,115404 TEST=visual Review URL: http://codereview.chromium.org/9579001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124845 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Simplify GetSessionName interfaceakalin@chromium.org2012-03-0312-192/+154
| | | | | | | | | | | | | | | | Turn the GetSessionNameTask class into a simple GetSessionName function. Use the browser thread blocking pool instead of the FILE thread. Remove dependency on BrowserThread from internal_api. BUG=113723 TEST= Review URL: http://codereview.chromium.org/9565050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124838 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some GData private API to the file managergspencer@chromium.org2012-03-032-0/+216
| | | | | | | | | | | | for fetching the GData file properties and for pinning files. BUG=chromium-os:27030,chromeium-os:27078 TEST=none Review URL: http://codereview.chromium.org/9545006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124837 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Fix gray line at top of toolbar with translucent framesjamescook@chromium.org2012-03-033-89/+62
| | | | | | | | | | | | | The toolbar background painting code was copying pixels out of the toolbar background image with the wrong vertical offset. I also moved the paint code into BrowserNonClientFrameViewAura so it can get the proper tabstrip vertical offset, and also because that's a more appropriate place for the logic. BUG=113075 TEST=visual, ensure no "step" in the gradient at the bottom of the active tab or the top of the toolbar, for both maximized and restored windows TBR=ben@chromium.org Review URL: http://codereview.chromium.org/9583032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124836 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124832 - Update the tcmalloc chromium branch to r144 (gperftools ↵dmikurube@google.com2012-03-034-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2.0), and merge chromium-specific changes. The major reason for us is to enable a fix for HEAP_PROFILE_MMAP. This change merges tcmalloc r144 (gperftools 2.0 f.k.a. google-perftools) with the tcmalloc/chromium branch, which is the forked Chromium version of tcmalloc. The change is created by 3-way merge from 1) the original google-perftools r109 ( = vendor base), 2) the original gperftools 2.0 r144 ( = branch), and 3) the chromium branch ( = another branch) with the following additional changes : * base/allocator/allocator.gyp is modified. * Many [#include "third_party/tcmalloc/chromium/src/google/..."] are replaced with "gperftools/". (Many files in Chromium) * gperftools/tcmalloc.h (formerly google/tcmalloc.h) is replaced with the original (generated) one. * windows/gperftools/tcmalloc.h (formerly windows/google/tcmalloc.h) is replaced with the original (generated) one. * malloc_hook-like functions are moved to libc_override*.h in gperftools 2.0. Some changes due to it. * MALLOC_HOOK_MAYBE_VOLATILE is redefined using __MALLOC_HOOK_VOLATILE. (config.h, tcmalloc.cc and libc_override_glibc.h) * The macro "CRASH(...)" is replaced with "Log(kCrash, __FILE__, __LINE__, ...)". (Many files) * LARGE_PAGE-related parameters (which may affect performance?) are merged. (common.h) * RAW_VLOG() calls are removed. (base/googleinit.h) * sys_{mmap|munmap|mremap}(...) calls are tentatively replaced with syscall(SYS_{mmap|munmap|mremap}, ...). (malloc_hook_mmap_linux.h) * tc_mallinfo is declared only when HAVE_STRUCT_MALLINFO is defined. (gperftools/tcmalloc.h) * "libc_override_redefine.h" is not included in Windows. (libc_override.h) * Chromium-original "sys_alloc" is not declared. (windows/port.cc) * base/spinlock_win32-inl.h is reverted from r144 because 64-bit atomicops are not implemented on Windows. (base/atomicops-internals-windows.h) The vendor branch is updated in another change. BUG=114302 TEST=run all existing tests. Review URL: https://chromiumcodereview.appspot.com/9311003 TBR=dmikurube@google.com Review URL: https://chromiumcodereview.appspot.com/9581043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124833 0039d316-1c4b-4281-b951-d872f2087c98
* Update the tcmalloc chromium branch to r144 (gperftools 2.0), and merge ↵dmikurube@google.com2012-03-034-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium-specific changes. The major reason for us is to enable a fix for HEAP_PROFILE_MMAP. This change merges tcmalloc r144 (gperftools 2.0 f.k.a. google-perftools) with the tcmalloc/chromium branch, which is the forked Chromium version of tcmalloc. The change is created by 3-way merge from 1) the original google-perftools r109 ( = vendor base), 2) the original gperftools 2.0 r144 ( = branch), and 3) the chromium branch ( = another branch) with the following additional changes : * base/allocator/allocator.gyp is modified. * Many [#include "third_party/tcmalloc/chromium/src/google/..."] are replaced with "gperftools/". (Many files in Chromium) * gperftools/tcmalloc.h (formerly google/tcmalloc.h) is replaced with the original (generated) one. * windows/gperftools/tcmalloc.h (formerly windows/google/tcmalloc.h) is replaced with the original (generated) one. * malloc_hook-like functions are moved to libc_override*.h in gperftools 2.0. Some changes due to it. * MALLOC_HOOK_MAYBE_VOLATILE is redefined using __MALLOC_HOOK_VOLATILE. (config.h, tcmalloc.cc and libc_override_glibc.h) * The macro "CRASH(...)" is replaced with "Log(kCrash, __FILE__, __LINE__, ...)". (Many files) * LARGE_PAGE-related parameters (which may affect performance?) are merged. (common.h) * RAW_VLOG() calls are removed. (base/googleinit.h) * sys_{mmap|munmap|mremap}(...) calls are tentatively replaced with syscall(SYS_{mmap|munmap|mremap}, ...). (malloc_hook_mmap_linux.h) * tc_mallinfo is declared only when HAVE_STRUCT_MALLINFO is defined. (gperftools/tcmalloc.h) * "libc_override_redefine.h" is not included in Windows. (libc_override.h) * Chromium-original "sys_alloc" is not declared. (windows/port.cc) * base/spinlock_win32-inl.h is reverted from r144 because 64-bit atomicops are not implemented on Windows. (base/atomicops-internals-windows.h) The vendor branch is updated in another change. BUG=114302 TEST=run all existing tests. Review URL: https://chromiumcodereview.appspot.com/9311003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124832 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124817 - Take extensions out of Profile into a profile-keyed service, ↵vandebo@chromium.org2012-03-0335-955/+359
| | | | | | | | | | | | | | | | | | | | | | | | | | | ExtensionSystem. This may be causing this crash: Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from PrerenderBrowserTest, where TypeParam = [ RUN ] PrerenderBrowserTest.PrerenderUnload [2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. BUG=104095 TEST=Open and close an incognito window; should not crash. Review URL: http://codereview.chromium.org/9369013 TBR=yoz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9583036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124831 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Minor changes to use SkPoint::iset() function.tfarina@chromium.org2012-03-033-26/+20
| | | | | | | | | R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9588003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124820 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Deprecate wstring version of file_util::CopyDirectory().thestig@chromium.org2012-03-031-5/+17
| | | | | | | | BUG=24672 TEST=none Review URL: https://chromiumcodereview.appspot.com/9484003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124819 0039d316-1c4b-4281-b951-d872f2087c98
* Take extensions out of Profile into a profile-keyed service, ExtensionSystem.yoz@chromium.org2012-03-0335-359/+955
| | | | | | | | | | | | | Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. BUG=104095 TEST=Open and close an incognito window; should not crash. Review URL: http://codereview.chromium.org/9369013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124817 0039d316-1c4b-4281-b951-d872f2087c98
* test http auth-basic handling and implement headers.binaryValue for ↵benjhayden@chromium.org2012-03-031-5/+37
| | | | | | | | | | downloads.download() BUG=115629 Review URL: http://codereview.chromium.org/9460010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124814 0039d316-1c4b-4281-b951-d872f2087c98
* The implementation of AndroidCacheDatabase.michaelbai@chromium.org2012-03-033-0/+344
| | | | | | | | | | | | | | | | | | | | It is used to support the Android Bookmark Provider; It caches the favicon id, visit time, created time, bookmark information from thumbnail database, url database and BookmarkModel. The database is created in first access of AndroidProviderBackend, and deleted after history backend shutdown, synced before AndroidProviderBackend's Query, Insert, Update or Delete method called. BUG= TEST= Review URL: http://codereview.chromium.org/9549031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124811 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Another round of unused forward declaration cleanup.thestig@chromium.org2012-03-033-5/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8598030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124808 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup to keep panel from manipulating its panel strip assignment directly.jennb@chromium.org2012-03-0313-148/+216
| | | | | | | | | | | | | Only PanelManager adds/removes panels from panel strips. Only exception is in tests. BUG=None TEST=Existing tests. Review URL: http://codereview.chromium.org/9560002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124806 0039d316-1c4b-4281-b951-d872f2087c98
* bluetooth: add function to hide Bluetooth settingskeybuk@chromium.org2012-03-031-0/+9
| | | | | | | | | | | | | | | | | We support USB Bluetooth adapters being inserted and removed from our older Chromebooks, so as well as showing the Bluetooth settings on insertion we need a function to hide the settings pane again when the adapter is pulled out. BUG=chromium-os:27103 TEST=(with plumbing from later CL) removed adapter, verified the settings section vanished Change-Id: I1e820e4f660787e4f74c28761114459fc29352c5 Review URL: http://codereview.chromium.org/9568054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124802 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the auto-logout on idle feature for Kiosk mode.rkc@chromium.org2012-03-0314-7/+617
| | | | | | | | | | | | | | | | This CL implements the auto-logout feature for Kiosk mode. The timeouts are pulled from the kiosk_mode_helper class. This CL implements parts of the code for http://codereview.chromium.org/9265026/ Though this code is vastly refactored and reduced. R=xiyuan@chromium.org BUG=chromium-os:26045 TEST=Tested with the flag to ensure the feature works correctly. Review URL: http://codereview.chromium.org/9568038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124799 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124790 - Minimized panels should not open on Windows when activated ↵yzshen@chromium.org2012-03-0317-69/+8
| | | | | | | | | | | | | | | | | by the OS Minimized panels are not "minimized" from the OS point of view so they may receive focus when other windows are minimized or closed. This patch sets the flags on the minimized panels in such way that they are not activated by the OS but still appear in the Alt-Tab menu and on the taskbar. BUG=102721 TEST=Manually verify that minimized panels do not open spontaneously when other windows are closed, but are accessible through the taskbar and Alt-Tab. Review URL: http://codereview.chromium.org/9463022 TBR=aburago@chromium.org Review URL: https://chromiumcodereview.appspot.com/9593001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124795 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure pipelined requests are sent in the same order they're queued. Also, ↵simonjam@chromium.org2012-03-032-26/+18
| | | | | | | | | | | | ensure HttpPipeliningCompatibilityClient closes the stream when it's done with a request. BUG=110794 TEST=net_unittests and unit_tests Review URL: http://codereview.chromium.org/9567025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124793 0039d316-1c4b-4281-b951-d872f2087c98
* Minimized panels should not open on Windows when activated by the OSaburago@chromium.org2012-03-0317-8/+69
| | | | | | | | | | | | Minimized panels are not "minimized" from the OS point of view so they may receive focus when other windows are minimized or closed. This patch sets the flags on the minimized panels in such way that they are not activated by the OS but still appear in the Alt-Tab menu and on the taskbar. BUG=102721 TEST=Manually verify that minimized panels do not open spontaneously when other windows are closed, but are accessible through the taskbar and Alt-Tab. Review URL: http://codereview.chromium.org/9463022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ph error on about:tracnig startup.nduca@chromium.org2012-03-034-6/+38
| | | | | | | | | BUG=116189 Review URL: http://codereview.chromium.org/9584022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124789 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124674 - Improving file manager js/css performancezelidrag@chromium.org2012-03-034-93/+27
| | | | | | | | | | | | | | | | | | | | | | | This change attempts to reduce the load time of the file manager (especially on slow Alex devices) by trimming unnecessary work done in javascript and reducing layouts. - Enable batch updating in cr.ui.Table (exactly how it's done in cr.ui.List). - Add more 'on complete' callbacks to some of the FileManager infrastructure so we know when to stop batch UI updates. - Use batch updates for some operations which profiling indicates causes non-trivial amounts of duplicated work. In particular, in my testing this reduces the number of (sometimes expensive) List.redraw() calls on startup for the table from 6 down to 1, and for the roots list from 4 down to 2. Measurements on alex are quite variable, but these changes result in about 70ms savings on startup (or about 17% of the time spent under 'v8.callChromeHiddenMethod' - i.e. JS callbacks through the extension system, which itself is about 1/3rd of total load time). The majority of file manager load time is spent inside of v8, and there are many more opportunities like these to trim various code paths. But it seems clear that major improvements are going to require more drastic approaches (eg. I'm experimenting with painting the initial UI after parsing/running a small fraction of the JS). BUG=105181 TEST= Review URL: http://codereview.chromium.org/9379023 TBR=rbyers@chromium.org Review URL: https://chromiumcodereview.appspot.com/9580035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124786 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to the sign in manager in preparation for one-click sign in. This CLrogerta@chromium.org2012-03-023-32/+247
| | | | | | | | | | | depends on http://codereview.chromium.org/9465018/ BUG=110050 TEST=No user visible changes, see unit tests. Review URL: http://codereview.chromium.org/9466022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124781 0039d316-1c4b-4281-b951-d872f2087c98
* Add about:flags flag for the Suggestions NTP.georgey@chromium.org2012-03-021-0/+7
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9566046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124780 0039d316-1c4b-4281-b951-d872f2087c98
* Update visit analysis code:tburkard@chromium.org2012-03-021-24/+62
| | | | | | | | | | | -- limit visit history considered to 100k entries to avoid out of memory crashes -- exclude backforward/homepage/intermediate pages in redirect chain -- reduce minimum spacing of pages considered from 1s to 500ms -- collect histogram of core transition type of qualifying page views R=brettw, dominich Review URL: https://chromiumcodereview.appspot.com/9572021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory failures in PasswordManager testsisherman@chromium.org2012-03-022-5/+9
| | | | | | | | | | BUG=none TEST=happy heapcheck bots TBR=mdm@chromium.org Review URL: https://chromiumcodereview.appspot.com/9586023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124778 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial to extend prerender expiration to 5 minutes.dominich@chromium.org2012-03-025-23/+49
| | | | | | Review URL: http://codereview.chromium.org/9463026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124777 0039d316-1c4b-4281-b951-d872f2087c98
* Added proper extensions for hosted documents.zelidrag@chromium.org2012-03-028-24/+68
| | | | | | | | BUG=chromium-os:27223 TEST=GDataFileSystemTest.SearchExistingDocument Review URL: https://chromiumcodereview.appspot.com/9581024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124775 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix EncryptString call that should be a DecryptString callakalin@chromium.org2012-03-021-1/+1
| | | | | | | | | | | Unit tests to catch this will come in another CL. BUG=116607 TEST= Review URL: https://chromiumcodereview.appspot.com/9585025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124772 0039d316-1c4b-4281-b951-d872f2087c98
* Make NTP other sessions menu off disabled by default.dubroy@chromium.org2012-03-023-5/+4
| | | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/9582022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124769 0039d316-1c4b-4281-b951-d872f2087c98
* Add an android specific ntp resource cache.tedchoc@chromium.org2012-03-022-3/+114
| | | | | | | | | | | | | | | | | This is a minimal starting point for merging our upstream android ntp resource changes into a somewhat clean slate. Based on how little of the shared resource cache code we used, it seems cleaner to start our own and not muddle that file with a ton of ifdefs. This is all in the hopes of getting sync_unit_tests linking upstream. BUG=113487 TEST= Review URL: http://codereview.chromium.org/9558014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124767 0039d316-1c4b-4281-b951-d872f2087c98
* TabFirstRenderWatcher -> TabRenderWatcher.derat@chromium.org2012-03-028-59/+52
| | | | | | | | | | | | | | | | | Page content often isn't completely loaded or laid out when the tab is first rendered. This makes the class additionally notify about subsequent renders so the delegate can hold off until it sees one after it's e.g. received notification via a WebUI message that the page is truly ready. BUG=chromium-os:26210 TEST=manual; also un-disabled the tests and checked that they still pass TBR=ben@chromium.org Review URL: http://codereview.chromium.org/9582012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124765 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing highlight & autocomplete colors according to specskuhne@chromium.org2012-03-021-0/+5
| | | | | | | | | | | | | Changing some highlight / autocomplete colors BUG=115861 TEST=Visually tested Review URL: http://codereview.chromium.org/9585015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124761 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Remove user pod container height animation.derat@chromium.org2012-03-021-1/+0
| | | | | | | | | | | | | | This removes an animation that adds a bit of jank at startup. It doesn't have a significant effect on boot time in either direction, from my measurements. BUG=chromium-os:26210 TEST=manual: booted and checked that animation is gone Review URL: http://codereview.chromium.org/9568044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124760 0039d316-1c4b-4281-b951-d872f2087c98
* Move TestURLRequestContextGetter to url_request_test_util.{h,cc}akalin@chromium.org2012-03-0213-35/+43
| | | | | | | | | | | Make everything use this instead of rolling their own. BUG=113723 TEST= Review URL: https://chromiumcodereview.appspot.com/9562037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124758 0039d316-1c4b-4281-b951-d872f2087c98
* Don't suppress HW compositing on the new file manager (chrome://files).fischman@chromium.org2012-03-022-1/+12
| | | | | | | | | | BUG=chromium-os:26939 TEST=--allow-webui-compositing no longer needed to get HW-accelerated decode & render on ARM crosbook. Review URL: http://codereview.chromium.org/9583022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124756 0039d316-1c4b-4281-b951-d872f2087c98
* Rename chrome/browser/ui/views/{aura => ash}/erg@chromium.org2012-03-0257-132/+132
| | | | | | | | | | BUG=116458 R=ben TBR=davemoore Review URL: http://codereview.chromium.org/9570044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124752 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the disk cache timeline view entries.mmenke@chromium.org2012-03-021-2/+4
| | | | | | | | BUG=116501 Review URL: http://codereview.chromium.org/9582020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix keyword search erroneously not triggering in two obscure cases:pkasting@chromium.org2012-03-027-81/+138
| | | | | | | | | | | | | | | | | (1) User types something that doesn't look at all like a keyword (e.g. "go om") and gets a non-default dropdown result that does look like a keyword ("google.com"). Arrowing down to this result, the user then presses space after the keyword name. (2) Similar to the case above, but this time the non-default result in question looks like a keyword + some more text, with no whitespace between ("google.comxxx"). The user arrows to this result, arrows back to just after the keyword, and presses space. Item (2) was happening because ShouldAllowExactKeywordMatch() (which has now been renamed) was always looking at the old |user_text_| as the "before change" text, which was wrong if there was temporary text, since the user text was not visible at that point. Fixed by getting the actual displayed text in that case. Item (1) was happening for similar reasons, but in MaybeAcceptKeywordBySpace() instead. This could have been fixed by the same change as above. However, I elected to change this function to look at the |keyword_| instead of the previously-displayed text, as in https://chromiumcodereview.appspot.com/9289034/ patch set 1. Not only is this slightly simpler, it is more robust against future changes. Let's say that someday we want to allow a provider to show a keyword hint for keyword "foobar" on input of "foo ". By checking against |keyword_| in this function, we ensure that in that future case, the space after "foo" will never trigger keyword search mode for "foobar". (If we ever bother to fix our bugs with keywords containing spaces, this might apply today for those as well.) I also tried to change the naming and comments of some things for clarity. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9570064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124745 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Update window frames, allow resize from outside windowjamescook@chromium.org2012-03-024-571/+477
| | | | | | | | | | | | | | | * New window frames, still behind a flag as there's more refinement to do for incognito, popups, and maximized windows. * Translucent frames now only require a single layer the size of the window instead of two. We may be able to cut the layer size in the future to the area of the window header + toolbar * Rewrite BrowserNonClientFrameViewAura * Use updated art assets from crrev.com/124602 * Allow windows optionally to specify that hit tests should include a region a few pixels outside the window. For Aura browser windows this area acts as non-client area resize handles which we need because the window frame borders are now very thin or not present at all. BUG=113075 TEST=manual, visual inspection of browser active, inactive, incognito, popup, hosted, and app windows. Updated aura_unittest for Window to check the expanded bounds. Review URL: https://chromiumcodereview.appspot.com/9580001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124743 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed remaining CL comments from review of ↵zelidrag@chromium.org2012-03-024-71/+90
| | | | | | | | | | http://codereview.chromium.org/9561009/ BUG=chromium-os:26961 TEST=none Review URL: https://chromiumcodereview.appspot.com/9580016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124742 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124583 (See crbug.com/114259) Original info for r124583 is:tbreisacher@chromium.org2012-03-026-42/+26
| | | | | | | | | | | | | | | Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it BUG=111139 TEST=SessionStartupPrefTest.HomePageMigration TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9559002 TBR=tbreisacher@chromium.org Review URL: https://chromiumcodereview.appspot.com/9583025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124740 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up password manager code.isherman@chromium.org2012-03-0211-95/+124
| | | | | | | | | | BUG=none TEST=password saving should continue to work Review URL: http://codereview.chromium.org/9564001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124735 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the XXX_sync builders to using directly sync_integration_tests.maruel@chromium.org2012-03-021-2/+6
| | | | | | | | | | | TBR=nsylvain@chromium.org BUG=109517 TEST=sync_integration_tests is properly run. NOTRY=true Review URL: http://codereview.chromium.org/9513008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124732 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 20:43:09 +0000