| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
This revision changes half of the source files!".
Review URL: http://codereview.chromium.org/20378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a locale_settings.h file that we use on all platforms. However,
the rc generation isn't correct yet, so for now, use the existing
locale_settings_*.rc files.
Also go ahead and generate the en-US locale pak on linux.
Review URL: http://codereview.chromium.org/20447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/20463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler.
Review URL: http://codereview.chromium.org/21268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
There is no UI for this (yet), just F11 to toggle in and out.
BUG=534
Review URL: http://codereview.chromium.org/20423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change broke ui, interactive and Vista Perf tests. I felt like reverting.
Review URL: http://codereview.chromium.org/24020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process.
On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object.
On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.
This change is a slightly modified version of http://codereview.chromium.org/20221/show
Review URL: http://codereview.chromium.org/20430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ChildProcessHost.
Review URL: http://codereview.chromium.org/21443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...)
Review URL: http://codereview.chromium.org/21438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific.
Review URL: http://codereview.chromium.org/20442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They would not be focused when shown and tab traversal was not working.
This was caused by several issues:
- HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default.
- DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab.
- DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view).
Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method.
BUG=6859
TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields
Review URL: http://codereview.chromium.org/21439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
callback to use GearsShortCutData2.
Review URL: http://codereview.chromium.org/20412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
circumstances this might be NULL if we opened the file after initialization and
it failed. In this case, we should just silently fail rather than throwing
an invalid parameter exception.
I'm not 100% sure this will fix the bug below, I did this by inspection.
BUG=7566
Review URL: http://codereview.chromium.org/21425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active.
- But rather than guessing the profile, get it from the guts of the location bar.
- crasher is ranked #34 by Laforge
BUG=6211
Review URL: http://codereview.chromium.org/20381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=6538
Review URL: http://codereview.chromium.org/21432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DNS pre-resolution system already "learns" what domains are commonly
needed when rendering sub-resources of a page at a given domain.
This patch saves (some of) the information learned into a persistent
pref, and restores it on startup.
For now, I put in a wimpy pruning of the list each time I save, so that
the list will not grow endlessly from session to session. I probably need
a better pruning algorithm, such as one that prunes after a given amount
of time, rather than only during shutdown. For now, this should get
a lot of nice results, and provide slightly larger than needed lists to
users that have long lived sessions, which is similar to the current
performance, where I didn't persist any info, and only pruned (actually
discarded) all learned info at shutdown.
r=mbelshe
Review URL: http://codereview.chromium.org/21374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Go ahead and convert our toolbar buttons to using the theme data
pack file.
Review URL: http://codereview.chromium.org/20433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Stop watching extension dirs for user script changes.
* Stop supporting unversioned extension dirs.
Also a few minor related cleanups.
Review URL: http://codereview.chromium.org/20390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
code from browser.cc to go along with it as well as enabling more functionality.
Review URL: http://codereview.chromium.org/21424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows. It was rather bogus that we were doing this before as there
is nothing for the window to link to.
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
redraw and scrolling issues.
Review URL: http://codereview.chromium.org/20435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I added more TODOs than I removed, but they're now for more subtle cases:
- the web page didn't handle a keystroke and our accelerators should;
- you tab off the end of the list of tabbable things on the page.
Review URL: http://codereview.chromium.org/21428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
advanced gestures. Returning to create a new tab is just wrong.
Review URL: http://codereview.chromium.org/20434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the version to 20.
BUG=7271
TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" and set the default
search engine to tapuz (it's in Hebrew) and type a keyword in the omnibox and select search with 'tapuz'.
Search result should come up with multiple hits.
Review URL: http://codereview.chromium.org/20315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
without registering its prefs.
Review URL: http://codereview.chromium.org/20431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a class for managing images for scalable themed widgets, and then
implement the toolbar on top of this.
Review URL: http://codereview.chromium.org/21390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
menus.
Review URL: http://codereview.chromium.org/20245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the delegate of the TabContents object. That allows page-load notifications to make their way through the browser UI layer. Hook up notification to Mac tab strip to set the title as it's changed.
Review URL: http://codereview.chromium.org/20429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/20424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/21416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
focusable, and clear the focus if it's not. This shouldn't kick in in any cases today (I don't think), but it will matter in fullscreen mode, where creating a new tab should not attempt to focus the (unfocusable) location bar, but should not do nothing either, since these leaves focus in a hosed state.
There are other choices here. I could make View::RequestFocus() try and clear the focus if the view is not focusable. That seems likely to cause side-effects unless I restore a lot of the calls to IsFocusable() that I previously removed. I also don't know whether sticking this on BrowserWindow was the right approach; if there's a better spot architecturally, speak up.
Review URL: http://codereview.chromium.org/21368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
happens.)
Review URL: http://codereview.chromium.org/21415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AudioRendererHost were assigning ids in the browser process, that means
CreateStream has to be done in a synchronous IPC call. To avoid that we
allow renderer processes to provide the stream id when they do
CreateStrea. Then to identify a IPCAudioSource inside AudioRendererHost
we need a tuple of (render_view_id, stream_id). By doing this we can
create stream asynchronously just like BeginRequest in
ResourceDispatcherHost.
Review URL: http://codereview.chromium.org/21319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer to browser.
Defined IPC messages that maps to methods exposed by
AudioRendererHost that serves audio related requests.
Also with handlers in ResourceMessageFilter for the newly
added IPC messages.
Review URL: http://codereview.chromium.org/21340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=?
Review URL: http://codereview.chromium.org/21399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer to browser.
Defined IPC messages that maps to methods exposed by
AudioRendererHost that serves audio related requests.
Also with handlers in ResourceMessageFilter for the newly
added IPC messages.
Review URL: http://codereview.chromium.org/21340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, ChromeURLDataManager::RemoveFileSource triggers a DCHECK for
the "inspector" source since that's being called during shutdown lately.
Review URL: http://codereview.chromium.org/20399
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change didn't have any description and it broke the tree
Review URL: http://codereview.chromium.org/21393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20392
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mac build.
Review URL: http://codereview.chromium.org/20393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r9835: Make browser_shutdown.cc compile on Posix.
Review URL: http://codereview.chromium.org/20384
r9837: Fix the mac build. Add a stubbed ResourceBundle::CleanupSharedInstance.
Review URL: http://codereview.chromium.org/20387
TBR= jhawkins
Review URL: http://codereview.chromium.org/21385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9840 0039d316-1c4b-4281-b951-d872f2087c98
|