summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Move clock menu button to the right as per UI design.chocobo@chromium.org2010-03-181-6/+6
| | | | | | | | BUG=none TEST=The order of status menu buttons from left to right are: language, network, power, clock Review URL: http://codereview.chromium.org/1134003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42019 0039d316-1c4b-4281-b951-d872f2087c98
* [Accessibility] Chrome's main window is missing an accessible namectguil@chromium.org2010-03-182-3/+19
| | | | | | | | | BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42018 0039d316-1c4b-4281-b951-d872f2087c98
* Plumbing for providing a cache thread MessageLoop to the DiskCache backend.michaeln@chromium.org2010-03-181-1/+2
| | | | | | | | | BUG=26730 TEST=none Review URL: http://codereview.chromium.org/1115002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42014 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the incognito extension toggle by default. No more flag.mpcomplete@chromium.org2010-03-187-52/+5
| | | | | | | | BUG=32365 Review URL: http://codereview.chromium.org/1075005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42013 0039d316-1c4b-4281-b951-d872f2087c98
* Fix so that encrypted networks are marked as such.chocobo@chromium.org2010-03-181-1/+1
| | | | | | | | BUG=none TEST=After connecting to a secure network, the network still shows up as secure. (lock icon is still there) Review URL: http://codereview.chromium.org/1128003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42011 0039d316-1c4b-4281-b951-d872f2087c98
* When updating timezone, the clock now updates right away.chocobo@chromium.org2010-03-186-1/+49
| | | | | | | | BUG=1650 TEST=none Review URL: http://codereview.chromium.org/1081005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42009 0039d316-1c4b-4281-b951-d872f2087c98
* Disable XSSAuditor on trunk until perf issues are resolvedjamesr@google.com2010-03-181-1/+1
| | | | | | | | | BUG=35723 TEST=none Review URL: http://codereview.chromium.org/1068001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42008 0039d316-1c4b-4281-b951-d872f2087c98
* Update allow-extension-in-incognito warning dialog text based on UI feedback.mpcomplete@chromium.org2010-03-181-0/+6
| | | | | | | | | | Also fix a small issue with double-clicking a link in the extensions UI. BUG=37789 Review URL: http://codereview.chromium.org/1042009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42004 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: tweak visibility calculation for bookmark bar items.estade@chromium.org2010-03-181-9/+23
| | | | | | | | | | | | | Also vastly simplify the code for the common case where |extra_space| is 0. Also fix a graphical imperfection that's been nagging me for a while where the bookmark bar looks kind of weird when you start dragging out of it. (the buttons jiggle around) BUG=38186 TEST=manual Review URL: http://codereview.chromium.org/1101003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42001 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement a basic overflow menu for hidden Browser Action buttons.andybons@chromium.org2010-03-1812-187/+194
| | | | | | | | | | | | | Known issues: o The ordering of the Browser Actions is not consistent within the menu. o Icons for the actions within the menu are not implemented yet. o It is a standard NSMenu, so drag and drop will not work and right click does not work for now. TEST=none BUG=32101 Review URL: http://codereview.chromium.org/1083001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42000 0039d316-1c4b-4281-b951-d872f2087c98
* Update timezone with a default list of timezones.chocobo@chromium.org2010-03-181-11/+51
| | | | | | | | BUG=none TEST=manually change timezones in the options page and see the clock change to the correct timezone (after a minute) Review URL: http://codereview.chromium.org/1107004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41998 0039d316-1c4b-4281-b951-d872f2087c98
* Uses new libcros network monitoring.chocobo@chromium.org2010-03-183-136/+142
| | | | | | | | | Fixes enable/disable network devices. BUG=chromium-os:1818,chromium-os:1682 TEST=none Review URL: http://codereview.chromium.org/1016003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41997 0039d316-1c4b-4281-b951-d872f2087c98
* Force an app's orgin to be the origin of the URL the crx isaa@chromium.org2010-03-1811-17/+91
| | | | | | | | | | | | downloaded from. Added machinery to be able to switch this behavior off, so that in the future, we can turn it off for the gallery. BUG=32361 Review URL: http://codereview.chromium.org/890002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41994 0039d316-1c4b-4281-b951-d872f2087c98
* Minor extension infobar changes.finnur@chromium.org2010-03-186-9/+12
| | | | | | | | | | | Addressing review comments that were submitted after I checked in. BUG=26463 TEST=None Review URL: http://codereview.chromium.org/1097002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41990 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use the TabContents in the AutoFillInfoBarDelegateTest. Fixes a few ↵jhawkins@chromium.org2010-03-184-12/+16
| | | | | | | | | | leaks. BUG=38481 TEST=none Review URL: http://codereview.chromium.org/1109005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41989 0039d316-1c4b-4281-b951-d872f2087c98
* Create new GMail account on OOBE screen and set user name on login screen.dpolukhin@chromium.org2010-03-1810-78/+327
| | | | | | | | | BUG=35157 TEST=Run chrome with --login-manager and press button create an account. Review URL: http://codereview.chromium.org/910003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41980 0039d316-1c4b-4281-b951-d872f2087c98
* Disables browser test on chromeos as chromeos defaults to restoringsky@chromium.org2010-03-181-0/+4
| | | | | | | | | | | | | last session, which means my test doesn't test what I want it to. I could make the test exercise the paths I want on chromeos by changing what to do on startup, but it didn't seem worth it given the default. BUG=NONE TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/1079002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41977 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Work around NSOutlineView column-width bug.snej@chromium.org2010-03-181-0/+1
| | | | | | | | | BUG=35031 TEST=see steps to reproduce in bug report Review URL: http://codereview.chromium.org/1023009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41976 0039d316-1c4b-4281-b951-d872f2087c98
* Drop bookmark onto a folder --> goes in folder.jrg@chromium.org2010-03-183-26/+72
| | | | | | | | | | | | | | | | BUG=36955 TEST=\ Drop some bookmarks onto folders; make sure they go in (at the end). Try both bookmark bar folders and sub-sub-folders. Try marks from a folder onto a bar folder. Drop a mark onto it's own parent folder. Go both quick (before hover-open) and slow (after). Review URL: http://codereview.chromium.org/1002012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41966 0039d316-1c4b-4281-b951-d872f2087c98
* Marks new browser test as flakey on mac as it seems to tickle a macsky@chromium.org2010-03-181-0/+4
| | | | | | | | | | | bug unrelated to my cl. TBR=erikkay@chromium.org BUG=38522 Review URL: http://codereview.chromium.org/1118003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41965 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that a Save As dialog pops up on drag-out when "Ask where to ↵jianli@chromium.org2010-03-181-4/+7
| | | | | | | | | | | save each file before downloading" option is checked. BUG=none TEST=none Review URL: http://codereview.chromium.org/1050006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41962 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement extension bookmark manager drag api.estade@chromium.org2010-03-1820-217/+376
| | | | | | | | | | | Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData. BUG=37702 TEST=manual Review URL: http://codereview.chromium.org/1029004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41959 0039d316-1c4b-4281-b951-d872f2087c98
* Makes pinned tab restore on startup if you haven't enabled sessionsky@chromium.org2010-03-1816-79/+607
| | | | | | | | | | | | restore. BUG=23613 TEST=turn off session restore, pin a tab, restart chrome and make sure you get back the pinned tab. Review URL: http://codereview.chromium.org/1026005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41958 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree: makes correct fix (in follow up to r41955)joth@chromium.org2010-03-181-1/+2
| | | | | | | | | | | (sigh) BUG=none TEST=unit_tests TBR=bulach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41956 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind failure: member used before set.joth@chromium.org2010-03-181-1/+1
| | | | | | | | | | | http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/3821/steps/valgrind%20test:%20unit/logs/stdio BUG=none TEST=unit_tests (Mac valgrind) TBR=bulach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GtkThemeProviderTest.UsingGtkValues unittestdanno@chromium.org2010-03-181-1/+1
| | | | | | | | | | | Check against the correct color field when validating the colors loaded from GTK. BUG=http://crbug.com/38420 TEST=verified with unit tests Review URL: http://codereview.chromium.org/985008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41954 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r41799:estade@chromium.org2010-03-1821-26/+115
| | | | | | | | | | | | | | | | | | | | Basic DragImage implementation. Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit. TODO later: - use the image on windows, mac - implement the other DragImageRef functions TEST=drag an image from the render view in GTK BUG=11457 Review URL: http://codereview.chromium.org/668125 The problem was an incorrect method signature in RenderView. Review URL: http://codereview.chromium.org/1037008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41953 0039d316-1c4b-4281-b951-d872f2087c98
* Finish implementing the geolocation infobar; adds a Learn more link pointing ↵joth@chromium.org2010-03-184-15/+92
| | | | | | | | | | | | | | | | | to the (placeholder) help center page. This extends ConfirmInfoBar to support to have optional link support (simple support, i.e. not the inserted mid-label link that LinkInfoBar sports) Note 1: this does not exactly match the mock; the allow/deny buttons and link are swapped. I think this looks nicer, is more consistent with other confirm infobars, and happens to be easier to code Note 2: linux & mac will need follow-up CLs, but will simply ignore the link in the meantime BUG=11246 TEST=browser_tests.exe --gtest_filter=Geol* Review URL: http://codereview.chromium.org/1037006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41951 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Better code sharing between cookie tree and cookie promptdanno@chromium.org2010-03-187-459/+591
| | | | | | | | | | | | | | Refactored code so that the class that encapsulates cookies details is shared between the cookie tree and cookie prompt on the mac. xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL. BUG=http://crbug.com/38348 TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog Review URL: http://codereview.chromium.org/1025003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41949 0039d316-1c4b-4281-b951-d872f2087c98
* Allow DomView derived classes to substitute TabContents with derived class.dpolukhin@chromium.org2010-03-182-2/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1089002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41948 0039d316-1c4b-4281-b951-d872f2087c98
* Major rework of the language settings dialog.satorux@chromium.org2010-03-182-128/+340
| | | | | | | | | | | | With this changes, users can add and remove preferred languages using the table on the left, that used to be just saying "Not yet implemented". TEST=manually BUG=crosbug.com/1688 Review URL: http://codereview.chromium.org/1104001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41943 0039d316-1c4b-4281-b951-d872f2087c98
* Change the mac content blocked bubble to use the new bubble model rather ↵joth@chromium.org2010-03-184-152/+95
| | | | | | | | | | | | | than duplicate its logic This is a follow up to http://codereview.chromium.org/668075 which made the corresponding changes in win & linux BUG=none TEST=chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm Review URL: http://codereview.chromium.org/1018003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41940 0039d316-1c4b-4281-b951-d872f2087c98
* Delete an out of date comment and include header cleanup.thestig@chromium.org2010-03-181-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/838008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41934 0039d316-1c4b-4281-b951-d872f2087c98
* Repair remote debuggingyurys@chromium.org2010-03-181-2/+2
| | | | | | | | | | | | | | | | Original change http://codereview.chromium.org/982008 by luoyx. Change the first letter of two const strings to lowercase, to make them consistent with message from WebKit. Otherwise, debugger output messages won't be pushed out to remote clients. Contributed by Yuxiang Luo (luoyx@google.com) BUG=38387 TEST=Attach a remote debugger client to chrome, then open a testing page that has exception. Make sure exception information can be received. Review URL: http://codereview.chromium.org/1103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41928 0039d316-1c4b-4281-b951-d872f2087c98
* Added actual GoogleUpdate functionality to the OOBE update screen.denisromanov@chromium.org2010-03-186-27/+147
| | | | | | | | | | | Added AddProgress method to the progress bar control. BUG=35249 TEST=Run out/Debug/chrome --login-manager --login-screen=update. Update screen should remain visible for at least 3 seconds. As there is no network available in this mode yet, login wizard should return back to the network selection screen. Review URL: http://codereview.chromium.org/1061004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41920 0039d316-1c4b-4281-b951-d872f2087c98
* In release mode, trigger a SIGABRT rather than a SIGTRAP for fatal log ↵thestig@chromium.org2010-03-181-0/+3
| | | | | | | | | | errors, i.e. CHECK(false). Also enable tests to make sure we assert/crash as expected. BUG=none TEST=Chrome in release mode generates crash dumps when CHECK() fails. See UI tests: AssertionTest.*:CheckFalseTest.*:RendererCrashTest.* Review URL: http://codereview.chromium.org/830003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41912 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-1832-32/+32
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Implement AutoFillXmlParser, used to parse responses from the AutoFill server.jhawkins@chromium.org2010-03-185-0/+409
| | | | | | | | BUG=none TEST=AutoFillQueryXmlParserTest Review URL: http://codereview.chromium.org/1014008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41904 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark context menus reference bookmark IDs, not pointers, in casejrg@chromium.org2010-03-188-56/+138
| | | | | | | | | | | | | | | they go away while the menu is open. BUG=34522 TEST=\ 1) Confirm bookmark context menus continue to work (e.g. rename, delete). 2) Repeat the "sync and delete while context menu" is open test from the bug; make sure the op is ignored (and we don't crash). Review URL: http://codereview.chromium.org/1041003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41903 0039d316-1c4b-4281-b951-d872f2087c98
* Update sync to support syncing of typed urlszork@chromium.org2010-03-1832-23/+2086
| | | | | | Review URL: http://codereview.chromium.org/896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41901 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Mac.bauerb@chromium.org2010-03-189-43/+177
| | | | | | | | | | | | | | Reloading a page for the second time dismisses the warning before showing it again. CLs for other platforms forthcoming. BUG=26271 TEST=RepostFormWarningTest.TestDoubleReload Manual test: Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then reload. The warning sheet should be tab-modal, not window-modal. Hit reload again. The warning sheet should close and immediately reopen. Review URL: http://codereview.chromium.org/969003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41898 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix context menu positioning, take 2.estade@chromium.org2010-03-171-3/+7
| | | | | | | | | Find correct screen (based on current position of mouse pointer) and monitor. BUG=27800 Review URL: http://codereview.chromium.org/399101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41894 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass --user-data-dir to the Zygote. (Reland r41369 now that the ↵thestig@chromium.org2010-03-171-0/+6
| | | | | | | | | | | | | directory creation race has been fixed.) BUG=none TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME. TBR=evan Original review: http://codereview.chromium.org/885003 Review URL: http://codereview.chromium.org/1060002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41891 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for showing NaCl 64-bit processes in Chrome's task manager and ↵gregoryd@google.com2010-03-172-2/+12
| | | | | | | | | | about:memory page BUG=37732 TEST=none Review URL: http://codereview.chromium.org/807005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when reloading/unloading extension after an infobar has been shown.finnur@chromium.org2010-03-171-4/+28
| | | | | | | | | | BUG=26463 TEST=Reload/shoot down the extension process hosting the extension/infobar and make sure the browser doesn't crash. Review URL: http://codereview.chromium.org/1001004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for ExtensionApiTest.Popup flakinessrafaelw@chromium.org2010-03-171-1/+8
| | | | | | | | | | | This fires the OnPopupClosed event in a later event via PostTask. This gives the popup time to complete closing before the OnPopupClosed is received by the extension BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1041004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41888 0039d316-1c4b-4281-b951-d872f2087c98
* Enable AutoFill when in incognito mode. The infobar will not be shown, but ↵jhawkins@chromium.org2010-03-173-20/+12
| | | | | | | | | | profiles can be manipulated in the AutoFill dialog, and the data from those profiles can be used to fill forms in an incognito window. BUG=38009 TEST=none Review URL: http://codereview.chromium.org/1064002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41887 0039d316-1c4b-4281-b951-d872f2087c98
* translate infobar: modify options menukuan@chromium.org2010-03-177-82/+53
| | | | | | | | | | | | | | | - show the same options menu regardless of infobar's states - changes are made for win, linux and mac - modified mac unittest so that it passes: - provide testing api to create options menu items - modify testing of menu items BUG=38109 TEST=verify per bug report. Review URL: http://codereview.chromium.org/976009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41886 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41882 - [Accessibility] Chrome's main window is missing an accessible ↵ctguil@chromium.org2010-03-171-13/+1
| | | | | | | | | | | | | | | | name checkdeps.py failed BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/1063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41885 0039d316-1c4b-4281-b951-d872f2087c98
* Pause the sync thread while starting data types.skrul@chromium.org2010-03-1719-51/+339
| | | | | | | | | | | | | A few things to note: - I ended the plubming (it's-a me, mario!) at the SyncBackendHost (the PSS does not know about pausing). The SyncBackendHost now has RequestPause/RequestResume methods. The notifications that are sent when pause and resume is complete are dispatched to the notification service by the SyncBackendHost. - Calls to SHB::Request(Pause|Resume) go directly to the similar named methods on the SyncerThread. This is unlike other methods on the SHB which are usually dispatched to the "core" thread before calling deeper into the onion. I did this to avoid having to deal with callbacks to carry the result value of pause/resume (since the methods can fail and return false). If this is a problem I can change the way it works. - There is a little trickery regarding the integration unit tests since we typically use a specially initialized SBH for these tests, and the syncer thread does not really run for these tests. Since the thread is not running, pause and resume won't work properly. To get around this, the DataTypeManagerImpl in these tests is constructed with a mock SBH that will respond properly to pause and resume requests. BUG=37154,37553 Review URL: http://codereview.chromium.org/1063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41883 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 00:45:38 +0000