summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Misc proxy service changes.ericroman@google.com2008-12-103-4/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (1) Changed the proxy service ownership model -- rather than being a detail of the HTTP stack, it is now a dependency owned by UrlRequestContext. - ProxyService is owned by UrlRequestContext (before was HttpNetworkSession) - ProxyResolver is owned by ProxyService (before was HttpNetworkSession) Being able to share the proxy service is needed in several places, including incognito mode http context (http://crbug.com/3564), and for proxy resolving in the new FTP stack. (2) Added an IPC for getting of the ProxyResolverWinHttp dependency in the plugin process. Not hooked up yet, but intent is to route the proxy resolve requests through the browser process. (3) Changed some unit tests which were depending on the system proxy settings (this was a sideffect of their calling HttpNetworkLayer::CreateFactory(NULL)). (4) Moved the first-time ProxyService::UpdateConfig out of the constructor and into the initial request. Done to avoid startup perf regressions, since the ProxyService construction is now done earlier (on the startup critical path). BUG=3564 Review URL: http://codereview.chromium.org/12938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6693 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4687: Enter in FirstRun UI starts import when Customize link is focued.finnur@google.com2008-12-101-1/+1
| | | | | | | We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior. Review URL: http://codereview.chromium.org/13321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6670 0039d316-1c4b-4281-b951-d872f2087c98
* First run is going into infinite recursion if started from master prefscpu@google.com2008-12-091-1/+6
| | | | | | | | | | | | - keeps creating importer processes - the issue is the creation of the first run sentinel file needs to happen before starting the new process. BUG=1535947 Review URL: http://codereview.chromium.org/13312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6651 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a link in the about_credits.htmllaforge@chromium.org2008-12-091-1/+1
| | | | | | | Bug: 4793: about:credits LIBXSLT bad homepage link TBR=laforge@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6633 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 4.pkasting@chromium.org2008-12-097-97/+26
| | | | | | | | | Remove dead/unnecessary resources/identifiers/code. The trickiest bit of this to review are the browser.cc changes, where various commands are no longer initialized multiple times. Review URL: http://codereview.chromium.org/13648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6628 0039d316-1c4b-4281-b951-d872f2087c98
* step one of some refactoring to allow other platforms to re-use the app ↵pinkerton@google.com2008-12-095-152/+275
| | | | | | | | initialization code. Review URL: http://codereview.chromium.org/13295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
* Now we know the delete iter->second call inwtc@google.com2008-12-092-1/+12
| | | | | | | | | | | | RemovePendingRequest causes a request to be removed from pending_requests_. Add the removing_pending_request_ member and some DCHECKS to catch that in action. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6622 0039d316-1c4b-4281-b951-d872f2087c98
* Let the debugger work again. Error was due to me not noticing the change in ↵glen@chromium.org2008-12-091-1/+2
| | | | | | | | | | | debugger URL. BUG=5287 Review URL: http://codereview.chromium.org/13298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6615 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in the StatusBubble. We were leaking afinnur@google.com2008-12-092-20/+15
| | | | | | | | | | | WidgetWin for the popup. I observed this in Purify and confirmed in the debugger that the destructor for WidgetWin was never called. Review URL: http://codereview.chromium.org/13672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6606 0039d316-1c4b-4281-b951-d872f2087c98
* Adds QueryParser::ExtractQueryWords. For consistent this shouldsky@google.com2008-12-093-15/+71
| | | | | | | | | | | | probably be ParseQuery, but I couldn't bring myself to another ParseQuery method. I'm going to need this for bookmark queries. BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6604 0039d316-1c4b-4281-b951-d872f2087c98
* Slightly updated about:credits from dannyb.glen@chromium.org2008-12-091-7/+12
| | | | | | Review URL: http://codereview.chromium.org/13292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6599 0039d316-1c4b-4281-b951-d872f2087c98
* Changes query parser to sort and coalesce overlapping match positions.sky@google.com2008-12-092-2/+53
| | | | | | | | | BUG=5305 TEST=see bug Review URL: http://codereview.chromium.org/13666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6595 0039d316-1c4b-4281-b951-d872f2087c98
* Moves some utility functions out of bookmark model intosky@google.com2008-12-0910-175/+185
| | | | | | | | | | | | bookmark_utils. In addition I've converted to using TreeNodeIterator. This doesn't contain any functionality changes. BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6589 0039d316-1c4b-4281-b951-d872f2087c98
* I tried running the browser in Purify and the browser crashed on me. finnur@google.com2008-12-091-8/+11
| | | | | | | | | | | | | | | | | | | | Basically, the animations were really slow and at one point I got a NULL pointer read because TabContents was NULL while updating the animations. Call stack: TabContents::is_loading(void)const [browser\tab_contents.h:214] Browser::IsCurrentPageLoading(void)const [browser\browser.cc:400] BrowserView::LoadingAnimationCallback(void) [browser\views\frame\browser_view.cc:1325] ... removed Timer calls for clarity... We already check the return value of GetSelectedTabContents in many places. It makes sense to do it here also, I think. Review URL: http://codereview.chromium.org/13647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6587 0039d316-1c4b-4281-b951-d872f2087c98
* Make the spellcheck-context-menu generation code more robust/future-proof ↵jungshik@google.com2008-12-091-10/+17
| | | | | | | | | | | | | | | | | | (fil and fil-PH will match each other). Currently, en-AU, de-CH, fr-CA do not match any spellcheck language. With this change, they will match en-US, de-DE, fr-FR, respectively unless there's an exact (more specific) match. Matching en-{AU,NZ,ZA} with en-US is not ideal. BUG=5251 TEST=Add 'fr-CA' (but NOT fr or fr-FR) to the accept-language list and see if 'fr-FR' comes up in the list of spell-check languages in the context menu of a textarea. Add 'de' (but not de-DE) to a-l list and see if 'de-DE' comes up in the list of spell-check languages in the context menu. Review URL: http://codereview.chromium.org/13262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6562 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 3.pkasting@chromium.org2008-12-081-69/+68
| | | | | | | | | | | This changes only whitespace, no code change at all. Attempt to make a couple of long multi-column chunks of text more readable by putting everything within the block at the same offsets. In the case of the .rc file, the entire file is now consistently indented. No lines I'm touching go over 80 columns. What I'm doing to browser.cc here we already do in a few (shorter) cases elsewhere, I think to good effect. Review URL: http://codereview.chromium.org/13641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6551 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 2.pkasting@chromium.org2008-12-081-30/+20
| | | | | | | | | Add appcommands that we have browser commands for. BUG=1113069 Review URL: http://codereview.chromium.org/13639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6549 0039d316-1c4b-4281-b951-d872f2087c98
* The CHECK I added in r6458 fails. So I'm refining thatwtc@google.com2008-12-081-2/+4
| | | | | | | | | | CHECK to narrow down where it starts to fail. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6545 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1955: Show Chromium build number after version (Chromium only)finnur@google.com2008-12-081-0/+5
| | | | | | | | | | | | People download random builds of Chromium off our server. This makes it easier for them to figure out what build number they are using by showing it in the About box (in parenthesis right after the version number). This change does not change the way we display versions in Google Chrome. Review URL: http://codereview.chromium.org/13194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6536 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, part 1.pkasting@chromium.org2008-12-0814-169/+167
| | | | | | | | | | | | | | * Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB) * Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU) * Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation. * As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code) * Fix 80-column issues This patch touches move files than any subsequent patches, but should be the most rubber-stampable. Review URL: http://codereview.chromium.org/13633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 5132: Find-in-page reports wrong ordinal when restarting search in ↵finnur@google.com2008-12-081-0/+30
| | | | | | | | | | | | sub-frame ReportFindInPageSelection calls OrdinalOfFirstMatchForFrame internally, so we don't need to do it again at the call site. Added a test to catch this in the future. Review URL: http://codereview.chromium.org/13190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6532 0039d316-1c4b-4281-b951-d872f2087c98
* bad merge, no need to delete a scoped_ptrtc@google.com2008-12-081-1/+0
| | | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/13252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6528 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug during tab close that results in all tabs after closed tabsky@google.com2008-12-081-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | getting shifted to the left by one pixel. Forcing another layout (by resizing window or such) results in everything fixing itself. When closing a tab we resize the closed tabs width to Tab::GetMinimumUnselectedSize().width(). Subsequent tabs are positioned at width + kTabHOffset. Tab::GetMinimumUnselectedSize().width() is 15, where as kTabHOffset is -16, resulting in all subsequent tabs shifting to the left by 1. You'll have to tell me if this is the right fix. I suspect this could also be fixed by changing Tab::GetMinimumUnselectedSize().width() to be kTabHOffset, but I'm not sure what the effects of that are. We could also enforce next x not shifting back in AnimationLayout BUG=none TEST=create two tabs, select the first and close it. Resize the window a bit and make sure the tab doesn't shift to the right. Review URL: http://codereview.chromium.org/13625 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in ExtensionsService and another in ExtensionsServiceTest.aa@chromium.org2008-12-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/13610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6524 0039d316-1c4b-4281-b951-d872f2087c98
* Report errors during extension load. Change all the error strings to utf-8.aa@chromium.org2008-12-086-52/+60
| | | | | | Review URL: http://codereview.chromium.org/13229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6522 0039d316-1c4b-4281-b951-d872f2087c98
* Reupload of 12418glen@chromium.org2008-12-0730-211/+1801
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Capitalize the 'Extensions' folder in the visual studio project for consistency.aa@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6496 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-072-135/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service persist closed tabs/windows to disk andsky@google.com2008-12-0638-1204/+2174
| | | | | | | | | | | | | | | | | reload them when asked. Sorry for largish looking change. It's made big by refactoring common code between TabRestoreService and SessionService into a common superclass. At the same time I removed some dead code and shuffled the session related classes into a single directory for easier perusal. BUG=384 TEST=close the browser, start the browser and make sure the new tab page shows closed windows/tabs from the previous session. Review URL: http://codereview.chromium.org/13152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible flicker when tab finishes animating back to draggedsky@google.com2008-12-061-1/+5
| | | | | | | | | | | position. BUG=NONE TEST=none Review URL: http://codereview.chromium.org/13221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6489 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-054-4/+5
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK to assert that each invocation ofwtc@google.com2008-12-051-0/+5
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest removes exactly one URLRequest from pending_requests_. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOTerikkay@google.com2008-12-051-5/+3
| | | | | | | | | | | | | | rather than chrome::DIR_APP. DIR_APP is in different relative locations on different platforms while DIR_SOURCE_ROOT is the same, so this allows us to share code and be correct on all platforms. Also, enable extensions_service_unittest for Mac and Linux and add an NSAutoreleasePool to ChromeTestSuite (which is now being used by run_all_unittests on Mac and Linux per my earlier checkin). Review URL: http://codereview.chromium.org/13177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-052-3/+20
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
* Change "client" parameter in RLZ ping to "referral" gwilson@google.com2008-12-051-5/+5
| | | | | | | | | | to match Omaha's changes. BUG=1520348 Review URL: http://codereview.chromium.org/12975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the layout of the Spell Check Options part, in the languages tab, in the ↵sidchat@google.com2008-12-051-18/+20
| | | | | | | | | Fonts and Languages Options Menu, to match with the Mock. Issue=4401 Review URL: http://codereview.chromium.org/12957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bogus initialization of string constants. The stack allocated ↵erikkay@google.com2008-12-051-12/+6
| | | | | | | | | | | string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests. Sorry I missed this in the initial code review. Review URL: http://codereview.chromium.org/13204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
* We should let binary/octet-stream have an EXE extension to fix compat with ↵abarth@chromium.org2008-12-052-0/+9
| | | | | | | | | | | digsby.com and ohloh.net BUG=1573 R=darin Review URL: http://codereview.chromium.org/13165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6424 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the content sniffing algorithm if the server instructs us to do so ↵abarth@chromium.org2008-12-052-1/+9
| | | | | | | | | | | | with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Review URL: http://codereview.chromium.org/12982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
* Add new multiprofile files to the SCons build:sgk@google.com2008-12-052-0/+3
| | | | | | | | | chrome\browser\user_data_manager.cc chrome\browser\view\new_profile_dialog.cc chrome\browser\view\select_profile_dialog.cc Review URL: http://codereview.chromium.org/12948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6410 0039d316-1c4b-4281-b951-d872f2087c98
* Add new debugger_host_impl.cpp to the SCons build.sgk@google.com2008-12-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/12947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6408 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ExtensionsService. Load extensions on startup from a directory inaa@chromium.org2008-12-0510-32/+408
| | | | | | | | | | the profile if a command-line flag is present. Please carefully scrutinize the threading/ref-counting schenanigans. Review URL: http://codereview.chromium.org/12876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6403 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the capacity to interact with modal dialogs to the automation framework.jcampan@chromium.org2008-12-055-36/+57
| | | | | | | | | This change will be used by Ojan to implement some unload handler tests. TEST=Run the ui tests. Review URL: http://codereview.chromium.org/13113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6402 0039d316-1c4b-4281-b951-d872f2087c98
* * Do not try to update distribution other than Google Chrome.kuchhal@chromium.org2008-12-051-4/+7
| | | | | | | | BUG=5109 Review URL: http://codereview.chromium.org/13140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6400 0039d316-1c4b-4281-b951-d872f2087c98
* Do not add the Content-Length header in the URLFetcher,paulg@google.com2008-12-041-2/+1
| | | | | | | | | | | since that header will be added later in HttpNetworkTransaction::BuildRequestHeaders. This change prevents POST requests from having a duplicate Content-Length header. Review URL: http://codereview.chromium.org/12965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6394 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of kPathSeparator on windows. Port some wstring function to take ↵estade@chromium.org2008-12-0415-43/+45
| | | | | | | | FilePaths. Re-enable relevant posix unit tests. Review URL: http://codereview.chromium.org/12893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-045-3606/+3606
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-pagefinnur@google.com2008-12-042-51/+121
| | | | | | | | | | | | | | | I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden). Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it. I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious). Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test. Review URL: http://codereview.chromium.org/13130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
* Add support in spell check options sub-context menu to pop up fonts and ↵sidchat@google.com2008-12-042-3/+18
| | | | | | | | languages options menu. Review URL: http://codereview.chromium.org/12908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6364 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we end the update process if we get an errorfrom the servers. ↵paulg@google.com2008-12-043-8/+18
| | | | | | | | Previously, if we got a 400 (or other)error response, we'd leave the database and transactionopen.BUG=5060 (http://crbug.com/5060) Review URL: http://codereview.chromium.org/12918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6337 0039d316-1c4b-4281-b951-d872f2087c98