| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This removes a dependency cycle and should also make life easier for DRT.
Revert http://codereview.chromium.org/1658012
Review URL: http://codereview.chromium.org/2358001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2486004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm making an educated guess that the TemplateURLModel wasn't loaded by the
time we needed a keyword, so let's just wait for it to load.
BUG=45588
Review URL: http://codereview.chromium.org/2485004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
container view.
TEST=BrowserActionsContainerViewTest
BUG=none
Review URL: http://codereview.chromium.org/2426002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
loaded when a delay is reached (which is doubled with time) or after a
tab finishes loading.
BUG=none
TEST=make sure session restore still works.
Review URL: http://codereview.chromium.org/2470003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/2484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3289
TEST=Connect to the network that requires web base login and open "Create account". It should timeout after 10 secs or earlier.
Review URL: http://codereview.chromium.org/2465001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
canonicalization of non-standard urls in CanonicalizeUrl function. Add CanCheckUrl to a more central location. Added the null check in GeneratePathsToCheck. Remove redundant checks from resource dispatcher host.
BUG=40605
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/2471002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(this is a follow up on http://codereview.chromium.org/2474002/show)
BUG=29424
TEST=GeolocationBrowserTest.*
Review URL: http://codereview.chromium.org/2459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockLocationProvider::OnPermissionGranted.
(this generated an extra alert, which is closed when test finishes on gtk/win, but hangs on mac).
BUG=29424
TEST=GeolocationBrowserTest.*
Review URL: http://codereview.chromium.org/2474002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used therein.
BUG=http://crbug.com/45344
TEST=no change
Review URL: http://codereview.chromium.org/2387003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added alpha channel for spinner.
BUG= http://crosbug.com/3299
TEST=If the Sign in is longer than 500ms spinner will be shown.
Review URL: http://codereview.chromium.org/2438001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- InformListenersOfMovement not required as WebKit has no way to trigger timeouts when movement is detected but cannot be resolved to a location.
- Error message in gps_open() does not have any additional information
Review URL: http://codereview.chromium.org/2450002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=patches containing this file work on the trybots
Review URL: http://codereview.chromium.org/2494002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
especially helps when the scheme has also been stripped, as it makes the hostname look less unbalanced. We're careful to avoid stripping the slash when doing so would confuse the omnibox.
This also moves to more aggressive stripping and/or unescaping in several places. In general, it seems like we should be as aggressive as is feasible.
BUG=43587
TEST=Visit google.com. There should be no slash in the address bar.
Review URL: http://codereview.chromium.org/2389002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2760
TEST=Use any IME, and examine the candidate window.
Review URL: http://codereview.chromium.org/2450001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots and manually
Review URL: http://codereview.chromium.org/2448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new AutoFill dialog mocks eliminate the need for a "default" address and credit card. Removing code related to UI for these defaults. Nib changes: Removed the "Default" radio button from each of the Nibs.
BUG=44621
TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic
Review URL: http://codereview.chromium.org/2466002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use new WM parameter to control initial focus of the panel window. (see http://codereview.chromium.org/2474001)
BUG=chromium-os:3408
TEST=none. This requires WM change to function properly.
Review URL: http://codereview.chromium.org/2254005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occassionally, but when it does, FLAKY prefix does not help because it
turns the tree red. By disabling this test, we lose the coverage for this
test on Mac. Until we have a better way to handle flaky crashes, it's better
to disable it.
BUG=45079
TEST=Mac bots don't turn red due to this test crashing.
TBR=jrg
Review URL: http://codereview.chromium.org/2485003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.Bookmarks on Windows
BUG=45594,45595
TEST=Windows bot don't turn red with browser_test failure
TBR=jrg
Review URL: http://codereview.chromium.org/2433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
core thread only.
BUG=none
TEST=unit tests, manual testing of notifications
Review URL: http://codereview.chromium.org/2326001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45562
TEST=tree green
TBR=jshin
Review URL: http://codereview.chromium.org/2449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2455005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Any error during checking for update or updating returned OOBE wizard to network selection screen.
Now error checking for update causes the OOBE wizard to proceed to the login screen, and error updating - to the network selection screen.
BUG=cros:3676
TEST=Try to reproduce bug http://crosbug.com/3676. It should not reproduce.
Review URL: http://codereview.chromium.org/2470002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bookmark entry editor;
- GtkInputWindowDialog;
- Cert manager and viewer;
- Task manager;
BUG=None.
TEST=Verify bookmark new/rename folder, add page, task manager, cert manager and viewer are inside a chrome window.
Review URL: http://codereview.chromium.org/2472003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752
to work.
BUG=3404
TEST=See bug.
Review URL: http://codereview.chromium.org/2260004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Simplified handling of TalkMediator events.
BUG=none
TEST=unittests + manual testing of notifications
Review URL: http://codereview.chromium.org/2232004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSLClientSocketMac. Specify the --use-nss-for-ssl command-line
option to use SSLClientSocketNSS.
The nss.gyp in src/net/third_party/nss is renamed ssl.gyp to avoid
a naming conflict with the nss.gyp in src/third_party/nss. The
GYP generator for Xcode project files disallows same-named .gyp files.
SSL client authentication doesn't work yet.
R=mark
BUG=30689
TEST=No build and test failures on Mac and Windows.
Review URL: http://codereview.chromium.org/2322008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(leave it enabled on non-valgrind Linux)
BUG=45562
TEST=green tree
Review URL: http://codereview.chromium.org/2428002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hovered.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2234008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes Linux valgrind unhappy
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(4)/builds/5866/steps/valgrind%20test:%20ui/logs/stdio
BUG=http://crbug.com/45562
TBR=jungshik@chromium.org
Review URL: http://codereview.chromium.org/2417003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've run into a couple of times this week when I needed one of these, for two different types besides bool. Time to fix the TODO.
TEST=trybots FTW, and built locally.
BUG=none
Review URL: http://codereview.chromium.org/2394001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2556
TEST=manually connect to network with wrong password and see notification.
Review URL: http://codereview.chromium.org/2074017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2249004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The notification that the focus changed in the page now uses webkit::WebViewClient::focusedNodeChanged() implemented by RenderView.
It was previously relying on the more general webkit::WebWidgetClient::didFocus() implemented in RenderWidget. (that should ideally only be fired when the frame gets focused, not everytime the focus in the frame changes).
BUG=None
TEST=Interactive UI tests should still pass (especially BrowserFocus*)
Review URL: http://codereview.chromium.org/2301001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also updated GPS timestamp's to be based on the host machine's own clock (avoids clock drift affecting freshness calculation) and updated Geoposition's docs to clarify this.
BUG=43868
TEST=Run gpsfake nmea.nme, then ./out/Debug/chrome-wrapper --log-level=1 http://maps.google.com/maps/m (map follows GPS track)
Review URL: http://codereview.chromium.org/2438003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mount tmpfs, start new session for incognito user.
Session manager change
http://codereview.chromium.org/2419001
BUG= http://crosbug.com/2849
TEST=Open BWSI mode.
Review URL: http://codereview.chromium.org/2371001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that works with all test prefixes (DISABLED, FLAKY, FAILS).
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/2439001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
lifted from)
BUG=38509
TEST=GeolocationLocationArbitratorTest.Arbitration
Review URL: http://codereview.chromium.org/2376001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebKit roll 60462:60647
Original review: http://codereview.chromium.org/2422001
Review URL: http://codereview.chromium.org/2459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As far as I've studied from the web, there seems to be no standard
keyboard layout for Filipino, and XKB does not have keybouard layouts
for Filipino. For now, associate Filipino with the US keyboard layout
as tt seems that US keyboard layout is widely used.
BUG=chromium-os:3644 3689
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/2456001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Users should not be able to remove a language that is set to the UI language
- Users should not be able to disable all input methods in Languages and Input dialog
- Languages and Input dialog should not crash even when there is no language
Along the way, associate Indonesian with the US keyboard.
This is nicer than showing "Display Chromium OS in this language" only.
BUG=chromium-os:3686 3687
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/2420002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2429001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Check that there is an options dialog next to Chewing, and click on it.
Review URL: http://codereview.chromium.org/2421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=out/Debug/base_unittests
Review URL: http://codereview.chromium.org/2445001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem with the original change was that it didn't call
in GetHorizontalOffset() in OnSetLocationCursor().
Outside web contetns in Chrome, UpdateLookupTable signal is
followed by SetLocationCursor signal. This caused:
1. OnUpdateLookupTable() to move the candidate window
with the offset computed
2. Then OnSetLocationCursor() to move the candidate window
without the offset.
This resulted in a flicker of the candidate window.
BUG=chromium-os:2720
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/2423001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3643
TEST=manually
Review URL: http://codereview.chromium.org/2425001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48603 0039d316-1c4b-4281-b951-d872f2087c98
|