| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the extension popup API when using borderStyle=rectangle.
I will submit a follow-up CL containing tests that will catch future regressions on the positioning of the pop-up.
BUG=39235
TEST=None
Review URL: http://codereview.chromium.org/1217009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(r42471) which made the interface a lot cleaner.
TEST=none
BUG=38521
Review URL: http://codereview.chromium.org/1251004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem:
Extension popups can take a while to appear after the user clicks the icon. If the user clicks something else that causes a grab (like a context or dropdown menu, or another info bubble), then that grab is shadowed and the widget behaves oddly (having two info bubbles open simultaneously, having an unclosable menu, etc.)
Solution:
Hide any widget that has a grab when the info bubble is being created. Delete info bubbles that get hidden.
Etc.:
You can still pretty easily get into a weird trapped state when the delayed info bubble interacts with tab dragging.
BUG=none
TEST=left click then quickly right click a browser action with extension popup
Review URL: http://codereview.chromium.org/1317001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual step-through of code
Review URL: http://codereview.chromium.org/1344001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
add tooltips and implementations on other platforms.
BUG=29633
Review URL: http://codereview.chromium.org/1299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=mmoss
Review URL: http://codereview.chromium.org/1341001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38992
Review URL: http://codereview.chromium.org/1310001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so we can still build & run whilst the full implementation is being worked on (in parallel)
(Some code taken from http://codereview.chromium.org/650180)
BUG=11246
TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog.
Review URL: http://codereview.chromium.org/1241006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1076004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes the behavior slightly. We used to skip creation of the
metrics service at all if it was disabled on the command line. But this was
pretty confusing because it was still possible for it to be disabled by way of
not uploading any data. And there were two places in the rest of the function
that would crash if the metrics service was NULL (because you used the command
line switch).
After some archaeology, I discovered the command line switch was from before
we had preferences and was then the only way to disable the metrics. Since we
have prefs now and it defaults to off, I think the command line switch isn't
useful, and the fact that it crashes sometimes further indicates this. So I
just removed it.
This does not remove the actual constant since that's used by ChromeFrame:
once to make sure it's passed through when Chrome is spawend, and once in a
test that command line switches are passed through. We'll have to remove these
in a separate patch before removing the constant declaration.
This also moves the WebSocketExperimentRunner starting from outside the
"disable metrics" block. I think the intent was that it wouldn't be enabled
if we weren't collecting metrics, but it wasn't actually working that way,
so I just pulled it out to the top level of BrowserMain.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1251007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder right after the selected item (when possible) rather than as
the last element.
BUG=9240
TEST=see bug
Review URL: http://codereview.chromium.org/1253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2039
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerTest.SwitchLanguage
Review URL: http://codereview.chromium.org/1239005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with opened devtools window.
BUG=31081
Review URL: http://codereview.chromium.org/1328003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move model and controller logic to NetworkScreen class.
Move Refresh() method out of view to controller.
Make network selection obligatory on OOBE even if Ethernet is connected.
BUG=37070
TEST=Running with --login-manager --login-screen=oobe should initiate normal out of box flow. After selecting network from combobox update is initiated.
Review URL: http://codereview.chromium.org/1058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avayvod
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also pre-emptively fixes a reported issue with NULL bss list being returned from WlanGetNetworkBssList
BUG=39300
TEST=run browser on desktop with dodgy wifi adapter....
Review URL: http://codereview.chromium.org/1256005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets uninstalled.
BUG=27938,39177
TEST=Unittest in extension_service_unitttest.cc
Review URL: http://codereview.chromium.org/1257005
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On Chrome OS login screen edge is sharp and blue.
Review URL: http://codereview.chromium.org/1278002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the way the location arbitrator is obtained by the dispatched host, so that it is co-ordinated by the permission context.
BUG=39171
TEST=none
Review URL: http://codereview.chromium.org/1283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
registry, and adding them to whatever is in the command line.
Added a basic IsIntranetHost() member function to HttpNetworkTransaction.
Removed it until we figure out what to do with it.
Added unit tests.
Refactored SetFilters() to be less confusing.
Unit tests now use a dummy registry key.
BUG=29596
TEST=net_unittests.exe --gtest_filter=HttpAuthFilterTest.*
Review URL: http://codereview.chromium.org/669068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular.
Also added unit tests.
xib changes:
- Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly.
- Change the size of the radio buttons in the "remember" choice to be small rather than regular.
- Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string
- Move the details view to be below the accept/block buttons.
- Change the style of the disclosure control to be a button rather than triangle.
Before: http://img257.yfrog.com/img257/3066/picture3fx.png
After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png
BUG=38208
TEST=manual testing, added unit test for remember/block/accept controls
Review URL: http://codereview.chromium.org/1102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that CommandLine::ForCurrentProcess() was called
despite candidate_window did not parse the command line flags.
StackTrace::StackTrace() [0x45a312]
logging::LogMessage::~LogMessage() [0x40abb7]
CommandLine::ForCurrentProcess() [0x40b3b5]
l10n_util::GetApplicationLocale() [0x4cd3f7]
ResourceBundle::LoadResources() [0x4c935d]
ResourceBundle::InitSharedInstance() [0x4c5ed7]
main [0x402a5f]
0x7ffff2aa6abd
0x4002a9
BUG=crosbug.com/2254
TEST=manually
Review URL: http://codereview.chromium.org/1238008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*
Review URL: http://codereview.chromium.org/1123008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This data structure and the notification flow will be used to populate the location bar icon and its bubble.
- this was originally part of http://codereview.chromium.org/650180
- Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf
TBR=bulach
BUG=11246
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1320005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the necessary code and madde xib changes to make it possible to select "When I close my browser" as the expiration for a cookie in the cookie prompt dialog.
xib changes:
- Add explicit outlet to details view controller for the layout tweaker so that can be called explicitly from code.
- Modify already existing popup menu for selecting cookie expiration to have the right menu items: item 1 is content.details.expires and item 2 is ^IDS_COOKIES_COOKIE_EXPIRES_SESSION.
- Wire the hidden binding of the expiration menu to the key value path content.details.canEditExpiration with a NSNegateBoolean transformer.
- Wire the visibility of the "expires" text in cookie details to the key value path content.details.canEditExpiration.
BUG=http://crbug.com/38405
TEST=manual testing, new units tests
Review URL: http://codereview.chromium.org/1134005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about changes to cookies.
This change will allow implementing the experimental cookie extension API, specifically the cookies.onChaned event
BUG=none
TEST=net_unittests
TBR=jochen@
Review URL: http://codereview.chromium.org/1287001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when it is not showing.
BUG=35480
TEST=Open a page so that the translate infobar is shown. Close the
infobar. Use the page translate context menu, make sure it
works. Do the same thing but make sure you translate the page
first.
Make sure the menu is not enabled on Chrome specific pages (new
tab, history, downloads...) as well as on interstitials.
Review URL: http://codereview.chromium.org/1151003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1685
TEST=Selecting "Disable Wifi" in networm menu does not crash Chrome
Review URL: http://codereview.chromium.org/1305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by DCHECKing based on the thread type.
TEST=Extensions and automated tests should work as before
BUG=http://crbug.com/38521
Review URL: http://codereview.chromium.org/1293001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherHost::~ResourceDispatcherHost() to ResourceDispatcherHost::OnShutdown().
This causes the requests to be cancelled on the IO thread rather than the UI thread, which is important since cancellation may delete the URLRequest (and URLRequests should not outlive the IO thread).
BUG=39243
Review URL: http://codereview.chromium.org/1213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=valgrind test: unit should turn green
BUG=none
Review URL: http://codereview.chromium.org/1313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=valgrind test: unit should turn green
BUG=38398
BUG=39177
Review URL: http://codereview.chromium.org/1313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=The WebKit Layout test.
Review URL: http://codereview.chromium.org/594036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1222003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- See the bug, it has a screenshot
The problem is that we need to recourse over the directory.
TEST=none
BUG=39130
Review URL: http://codereview.chromium.org/1252002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=39196
TEST=bookmarks in the chevron "off the side" menu now work.
Context menu over a folder of bookmarks has "open all..." enabled.
Context menu over an empty bookmark folder has "open all..." DISabled.
Review URL: http://codereview.chromium.org/1223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39071
TEST=NTP, detach bookmark bar. Drag and drop something.
Review URL: http://codereview.chromium.org/1315004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The download step invokies SBH::ConfigureDataTypes() and waits for the task callback. Currently SBH::ConfigureDataTypes() is stubbed out, it will be implemented in the next change.
I also added some additional unit tests to the DTMImpl to make sure Stop() works while pasue and resume are pending, and to make sure the SYNC_CONFIGURE_DONE notification is always sent.
Review URL: http://codereview.chromium.org/1311001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.
BUG=36798, 32845
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.
Review URL: http://codereview.chromium.org/1119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor code for better sharing.
BUG=http://crbug.com/26380 (cmd-click in subfolders now opens all)
BUG=http://crbug.com/35966 (code dup reduced)
TEST=\
Cmd-click a folder in the bar --> open all
Cmd-click a folder in a SUBfolder of the bar --> open all
Review URL: http://codereview.chromium.org/1134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sliently import bookmarks from file in first run.
BUG=32728
TEST=unit test
Review URL: http://codereview.chromium.org/1257001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is meant to test to see if AI_ADDRCONFIG is doing its
job in windows, or if we have to do the scans when there is
a network change.
Also switch to always doing probe support on Mac/Linux platforms.
There appears to be (on aggregate) around a 40% degradation of
DNS resolution times on the Mac, and about 17% degration on
Linux, when we don't probe. It is likely that a few users
are greatly impacted by this, and are able to move the average
of the whole user population.
BUG=12754
BUG=25680
r=wtc
Review URL: http://codereview.chromium.org/1210003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor existing status icon code to allow platform-specific StatusTray implementation to
track common state for all status icons.
BUG=37375
TEST=new unit tests
Review URL: http://codereview.chromium.org/1136005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25442
TEST=hover the mouse through either the tab strip close button or the new tab button, see if a tooltip appears.
Patch by Thiago Farina
original review: http://codereview.chromium.org/669246
Review URL: http://codereview.chromium.org/1254002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Windows/Views part).
BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.
Review URL: http://codereview.chromium.org/1309001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
links.
The link itself was added to the nib as an NSButton; the link and "no bookmarks" text were both embedded in a GTMWidthTweaker to keep them nicely positioned when localized.
BUG= 28753
TEST= create browser with empty profile or remove all bookmarks. Link should appear that creates a dialog box which allows you to import data from other browsers, as in Windows version.
Review URL: http://codereview.chromium.org/1246001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Under "Inspect Active Views", any extension that has a browser or page action will show grayed text directing the developer to right click on the icon and select 'Inspect Popup'
BUG=24477
TEST=Install an extension with a page or browser action. Go to chrome://extensions, turn on developer mode. Verify that under "inspect active views", the new instructions appear.
Review URL: http://codereview.chromium.org/1198002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run UI stuff to new helper functions. It renames CheckForWin2000 to a generic
one that each platform can implement according to its needs. I removed the
Platform namespace which was improperly named, and didn't seem to be helping
anything anyway.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1139009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42528 0039d316-1c4b-4281-b951-d872f2087c98
|