summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Reverts menu patch.sky@chromium.org2009-08-261-11/+10
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK on download item removal, take 2.estade@chromium.org2009-08-261-2/+14
| | | | | | | | We can't delay destroying the download item view because it has to be destoyed before the download model is destroyed. Insted we delay the execution of the command. Review URL: http://codereview.chromium.org/173458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24507 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX doesn't have reserved filenames; so don't worry about a download ↵estade@chromium.org2009-08-261-2/+0
| | | | | | | | | trying to use one. BUG=19456 Review URL: http://codereview.chromium.org/173238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24506 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple in-process bookmark manager test.estade@chromium.org2009-08-263-0/+45
| | | | | | Review URL: http://codereview.chromium.org/174494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24505 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of ToWStringHack in a few places.evan@chromium.org2009-08-261-4/+3
| | | | | | | | | | BUG=None TEST=run app_unittests.exe, browser_tests.exe and selenium_tests.exe Review URL: http://codereview.chromium.org/173418 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24504 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-261-10/+11
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Extension ports devtools remote service.sdoyon@chromium.org2009-08-266-40/+563
| | | | | | | | | | | Wires message ports to extensions through the devtools remote socket. BUG=none TEST=none Review URL: http://codereview.chromium.org/174226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaking gtk tree models.mattm@chromium.org2009-08-268-0/+12
| | | | | | | | | BUG=19750 TEST=none Review URL: http://codereview.chromium.org/174463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24497 0039d316-1c4b-4281-b951-d872f2087c98
* Tab strip should not resize on close (Vista).finnur@chromium.org2009-08-261-17/+13
| | | | | | | | | | | When you close a tab using the mouse, we synthesize a fake WM_MOUSEMOVE message so that the close button that slides under the mouse will highlight. We now use GetMessagePos to read the position of the cursor and SendMessage to dispatch it, otherwise the receiving GetMessagePos call will not calculate the coordinates correctly (coordinates will be relative to the Chrome main window top left point, not the monitor's top left point, causing the tabstrip to resize). BUG=18832 TEST=On Vista, open a bunch of tabs, then start closing the tab in the middle using the mouse. Don't move the mouse at all while doing this and observe that the tab strip doesn't resize. Also, the close button on the tab that slides under the mouse should be highlighted. Review URL: http://codereview.chromium.org/173433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24493 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use URL-encoded strings when user's input is in progress or the text isn'tjshin@chromium.org2009-08-261-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | HTTP/HTTPs. It seems that Firefox is doing the same thing. BUG=16534 (http://crbug.com/16534) TEST=Visit any website and append double-quote (") for the URL and invoke "Select All" by Control-A, then copy the URL by Control-C. Paste the result into notepad and check if the double-quote is NOT encoded. TEST=Access file:///" and select whole Omnibox and copy the URL. Paste the text into notepad and check if the double-quote is NOT URL encoded. TEST=Put " in Omnibox and type enter key so that you will be navigated to http://www.google.co.jp/search?sourceid=chrome&ie=UTF-8&q=%22. Copy whole content in Omnibox and paste it into notepad. Then, check if the double-quote is URL-encoded (%22). Original Review: http://codereview.chromium.org/155495/show Patch by hamaji@chromium.org (he's on vacation and asked me to land) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24472 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a FORWARD_NULL defect reported by Coverity.wtc@chromium.org2009-08-261-1/+1
| | | | | | | | | | | | | If 'profile' is NULL, we should return ResultCodes::NORMAL_EXIT so that we won't go on to dereference 'profile'. R=brettw,estade BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/171007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24469 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r24372 - Delay request loading until all user scripts that requestmpcomplete@chromium.org2009-08-267-3/+579
| | | | | | | | | | | | | depends on are ready. UMR should be fixed after setting new appcache variable. BUG=no TEST=no Review URL: http://codereview.chromium.org/173482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24459 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark bubble crash.jrg@chromium.org2009-08-261-0/+8
| | | | | | | | | BUG=http://crbug.com/20131 TEST=see bug; was very specific. Review URL: http://codereview.chromium.org/173428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24455 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another source of flakiness in ErrorPageTestphajdan.jr@chromium.org2009-08-264-145/+69
| | | | | | | | | | | | | | | | We need to wait for correct number of navigations when going back or forward to the LinkDoctor page. Re-enable previously disabled tests and remove the now-duplicate browser test. The test is still not very solid, because the LinkDoctor should be mocked. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24446 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 19081: Linux: Not able to switch input method correctly in web ↵suzhe@chromium.org2009-08-263-18/+55
| | | | | | | | | | | | | | page using SCIM This CL fixes issue 19081 by setting im context's client window when host view's native widget is realized rather than focused in. When setting im context's client window, GtkIMMulticontext will destroy and recreate its slave im context, which will cause this issue. BUG=19081: Linux: Not able to switch input method correctly in web page using SCIM TEST=Export GTK_IM_MODULE=scim then open chrome, open www.google.com and place cursor in search box, hit ctrl-space to open SCIM then click scim bar or tray icon and select another input method, then check if input method was switched correct. Review URL: http://codereview.chromium.org/174217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24442 0039d316-1c4b-4281-b951-d872f2087c98
* Cache GTMTheme across windows to avoid re-creating it every time we create a ↵pinkerton@chromium.org2009-08-263-10/+24
| | | | | | | | | | new window. Cache gradient to avoid re-creating it every time we draw a button cell. BUG=none TEST=switch themes, ensure it works. Make sure buttons draw correctly. Review URL: http://codereview.chromium.org/173445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24441 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux Extensions Install Prompt"rafaelw@google.com2009-08-262-148/+1
| | | | | | | | | | | This reverts 24426 TBR=yutak Review URL: http://codereview.chromium.org/173460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24429 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Extensions Install Promptrafaelw@google.com2009-08-262-1/+148
| | | | | | | | | BUG=19653 Review URL: http://codereview.chromium.org/174462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24426 0039d316-1c4b-4281-b951-d872f2087c98
* Improves key event handing code of BrowserWindowGtk.suzhe@chromium.org2009-08-263-97/+28
| | | | | | | | | | | This CL improves the key event handing code of BrowserWindowGtk. Issue 20118 is also fixed. BUG=20118: Typing a colon (:) into the address bar causes the browser to freeze TEST=Run chrome with a XIM input method, chrome and x server's cpu usage shall be very low after pressing shift key (or any other modifier key) in omnibox. Review URL: http://codereview.chromium.org/173344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24422 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my download item change.estade@chromium.org2009-08-262-20/+3
| | | | | | | | Turns out download item views need to be destroyed before the associated download item is destroyed. Review URL: http://codereview.chromium.org/173456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24421 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of tweaks to ui_controls_linux:sky@chromium.org2009-08-263-12/+77
| | | | | | | | | | | | | | | | | | . Moves listening from DidProcess to WillProcess. This is necessitated by the bookmark bar (chrome menu) tests that spawn a nested run loop, which results in DidProcess not getting sent and the test wedging. This brings the code closer in line with Windows. . If there is a mouse/keyboard grab, mouse/keyboard events are sent to the grabbed widget. . Deals with a NULL widget for sending keyboard events (tries to find focused widget). BUG=none TEST=none Review URL: http://codereview.chromium.org/173392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24420 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 24372 - Delay request loading until all user scripts that request ↵nick@chromium.org2009-08-267-577/+3
| | | | | | | | | | | | | | | depends on are ready. BUG=11547 TEST=See bug. Review URL: http://codereview.chromium.org/173239 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/174501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24419 0039d316-1c4b-4281-b951-d872f2087c98
* Turn tips on by default, and turn off tip loading during UI testing.mirandac@chromium.org2009-08-262-2/+2
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/173444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24418 0039d316-1c4b-4281-b951-d872f2087c98
* Convert internal time format to Windows 1601 epoch on Linux & Mac.brettw@chromium.org2009-08-265-6/+101
| | | | | | | | | | | Although we represent time internally starting from 1601, there are still things like time explosion that will not work before the year 1900. This limitation is the same as it was previously. BUG=14734 Review URL: http://codereview.chromium.org/173296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24417 0039d316-1c4b-4281-b951-d872f2087c98
* Move the compact navigation bar to the chromeos directory.brettw@chromium.org2009-08-263-5/+5
| | | | | | | Generalize the chromeos rules so we don't have to list every file in the exclusions. Review URL: http://codereview.chromium.org/174446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24416 0039d316-1c4b-4281-b951-d872f2087c98
* Make the task manager use the native default faviconestade@chromium.org2009-08-261-0/+10
| | | | | | | | | BUG=13320 Review URL: http://codereview.chromium.org/173432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24414 0039d316-1c4b-4281-b951-d872f2087c98
* Don't DCHECK when removing items from the download shelf.estade@chromium.org2009-08-262-2/+19
| | | | | | | | BUG=20186 Review URL: http://codereview.chromium.org/173407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24413 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce accesskeys for Chrome menus.mhm@chromium.org2009-08-2610-0/+52
| | | | | | | | | | | Added ALT+E for Chrome Page Menu Added ALT+F for Chrome App Menu BUG=906 (http://crbug.com/906) TEST=Triggered ALT+A and ALT+P from the keyboard which successfully opened the corresponding menu. Review URL: http://codereview.chromium.org/174044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24410 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24385.mirandac@chromium.org2009-08-262-2/+2
| | | | | | Review URL: http://codereview.chromium.org/173443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cases that initialized StringTokenizer with a temporary.mattm@chromium.org2009-08-262-2/+5
| | | | | | | | | | | Fix examples in StringTokenizer header that recommended doing that. BUG=none TEST=on linux, open options, click proxy configuration button a bunch. It should not fail intermittently. Review URL: http://codereview.chromium.org/174490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression issue 20066.suzhe@chromium.org2009-08-261-3/+14
| | | | | | | | | | | This CL fixes issue 20066, a regression issue caused by a change in CL 172041. BUG=20066: Regression: search keywords search with default search engine only. TEST=Assuming 'y' is associated to a search engine, type "y abc" in omnibox and press enter shall search abc with the search engine associated to 'y'. Review URL: http://codereview.chromium.org/173332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24388 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on tips by default.mirandac@chromium.org2009-08-262-2/+2
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/173371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24385 0039d316-1c4b-4281-b951-d872f2087c98
* Add single line of tips to NNTP.mirandac@chromium.org2009-08-2610-115/+195
| | | | | | | | | BUG= http://crbug.com/19162 TEST= Start browser with NNTP, note line of tips at bottom. Review URL: http://codereview.chromium.org/173087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24384 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS ↵thestig@chromium.org2009-08-261-2/+14
| | | | | | | | | | | | | support. (Try 2) TEST=none BUG=19663 Original Review URL: http://codereview.chromium.org/173095 Review URL: http://codereview.chromium.org/173397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24378 0039d316-1c4b-4281-b951-d872f2087c98
* Delay request loading until all user scripts that request depends on are ready.mpcomplete@chromium.org2009-08-257-3/+577
| | | | | | | | | BUG=11547 TEST=See bug. Review URL: http://codereview.chromium.org/173239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24372 0039d316-1c4b-4281-b951-d872f2087c98
* Theme the NTP attribution textglen@chromium.org2009-08-251-0/+1
| | | | | | | | | BUG=20262 TEST=Verify that the attribution 'theme created by' text matches the title color under the thumbnails Review URL: http://codereview.chromium.org/173409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24370 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ViewIDTest to browser_tests, where it belongs.phajdan.jr@chromium.org2009-08-251-0/+0
| | | | | | | | | | | | It carries state in singletons, which is evil. browser_tests launcher deals with that properly. TEST=none BUG=none Review URL: http://codereview.chromium.org/174470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24360 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Firefox Importer tests again due to Purify report of leaks.kuchhal@chromium.org2009-08-251-2/+2
| | | | | | Review URL: http://codereview.chromium.org/174414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24356 0039d316-1c4b-4281-b951-d872f2087c98
* Work around a WM work around where if the size of the chrometony@chromium.org2009-08-251-1/+10
| | | | | | | | | | | | | | window matches the desktop size on startup, the WM puts chrome in full screen mode that you can't get out of. Our workaround is to never restore to a size that matches the screen. This is better than telling people to edit their Local State file. Review URL: http://codereview.chromium.org/174457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24344 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Dropdown arrow size on download items should match font size.erg@google.com2009-08-251-4/+10
| | | | | | Review URL: http://codereview.chromium.org/174449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24336 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: port ButtonSeparatorViewestade@chromium.org2009-08-252-1/+62
| | | | | | | | BUG=13142 Review URL: http://codereview.chromium.org/173334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24327 0039d316-1c4b-4281-b951-d872f2087c98
* OSX: Fix the select-all-on-mouse-down in Omnibox.shess@chromium.org2009-08-252-19/+70
| | | | | | | | | | | | | | | Getting clicks in the decoration areas right caused a change to how clicks on the unfocused field worked. NSTextField also forwards the event to get click-drag selection right, this does the same thing for clicks in the decorations (other clicks are passed to super). http://crbug.com/20142 TEST=Browse to www.google.com. Click in page. Click in omnibox without releasing. You should get a caret insertion point. Review URL: http://codereview.chromium.org/173362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24325 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix bug where white logo wasn't showingglen@chromium.org2009-08-255-10/+23
| | | | | | | | | | | - Add attribution support back to the NTP BUG=20019 TEST=Install a theme with a white logo and attribution, and verify that both display correctly. Review URL: http://codereview.chromium.org/173372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24323 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Create an inactive tab text color based on the inactive tab.erg@google.com2009-08-252-4/+29
| | | | | | | | | (We were previously just grabbing a raw GTK color, which didn't work out very well in themes like High Contrast Inverse...) Review URL: http://codereview.chromium.org/174407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24316 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix linux UI frame regression introduced in r24170.erg@google.com2009-08-252-0/+11
| | | | | | Review URL: http://codereview.chromium.org/173389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24310 0039d316-1c4b-4281-b951-d872f2087c98
* linux: new socket/plug code for windowed pluginspiman@chromium.org2009-08-257-54/+17
| | | | | | | | | | | | | | | | | | | | | | | | This CL reworks the GtkSocket/GtkPlug code for windowed plugins on linux. Instead of having the plugin ask the browser to create a socket to plug into, it simply creates a plug and sends it to the browser. The browser creates a socket and attaches the plug when the socket becomes realized This fixes 2 main issues: - we can create windowed plugins in background tabs (Issue 16125) - we can detach tabs with windowed plugins and reattach them (Issue 17110) I reworked the IPCs, so it removes some amount of linux-specific things. We also need less synchronous IPCs to create/destroy plugins, so that should be a bit faster. In particular, I removed the plugin pid map, and instead made sure the renderer always destroys the plugin containers if the plugin process crashes - they will be destroyed if the renderer process crashes. Let me know if you have an issue with that. Also, the intermediate plug/socket creation now happens in webplugin_delegate_impl_gtk. That means test_shell uses it as well. It made the code a lot simpler, and means we're testing it as well, albeit with a bit of extra overhead. Bonus: I found a big bad bug in the GtkPluginContainer that made its width/height alias with some internal gtk structures. That was certainly causing some amounts of bugs. Bonus 2: scrolling now looks more in sync with the rest of the page, though I'm not exactly sure which part caused that. BUG=16125,17110 TEST=a lot of manual testing involving YouTube videos Review URL: http://codereview.chromium.org/174295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24309 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk Font options: Separate font family and size by comma to work around Gtk ↵mattm@chromium.org2009-08-251-1/+1
| | | | | | | | | | | issue. BUG=19823 TEST=see bug Review URL: http://codereview.chromium.org/173333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24287 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable importer unit tests since they do not seem to generate Purify ↵kuchhal@chromium.org2009-08-251-2/+2
| | | | | | | | errors locally. Review URL: http://codereview.chromium.org/174414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24269 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for WAI-ARIA roles application, document, radiogroup, region, ↵klink@chromium.org2009-08-251-0/+8
| | | | | | | | | | | separator, status and tooltip. BUG=19982 TEST=Assign @role application, document, radiogroup, region, separator, status or tooltip to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. Review URL: http://codereview.chromium.org/174382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24262 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the progress area go away when a download item is cancelled.estade@chromium.org2009-08-251-1/+3
| | | | | | | | BUG=20158 Review URL: http://codereview.chromium.org/174365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24255 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 17:51:04 +0000