summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix checkdeps by removing some include pathsnick@chromium.org2009-09-104-3/+9
| | | | | | | | | | | | | | and adding a DEPS rule to allow "talk/". This code is not yet compiled, but it is still subject to checkdeps. TEST=ran checkdeps.py BUG=none Review URL: http://codereview.chromium.org/201077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25851 0039d316-1c4b-4281-b951-d872f2087c98
* Initial commit of sync engine code to browser/sync.nick@chromium.org2009-09-10226-0/+40735
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code is not built on any platform yet. That will arrive as a subsequent checkin. This is an implementation of the interface exposed earlier through syncapi.h. It is the client side of a sync protocol that lets users sync their browser data (currently, just bookmarks) with their Google Account. Table of contents: browser/sync/ protocol - The protocol definition, and other definitions necessary to connect to the service. syncable/ - defines a data model for syncable objects, and provides a sqlite-based backing store for this model. engine/ - includes the core sync logic, including commiting changes to the server, downloading changes from the server, resolving conflicts, other parts of the sync algorithm. engine/net - parts of the sync engine focused on the business of talking to the server. Some of this is binds a generic "server connection" interface to a concrete implementation provided by Chromium. notifier - the part of the syncer focused on the business of sending and receiving xmpp notifications. Notifications are used instead of polling to achieve very low latency change propagation. util - not necessarily sync specific utility code. Much of this is scaffolding which should either be replaced by, or merged with, the utility code in base/. BUG=none TEST=this code includes its own suite of unit tests. Review URL: http://codereview.chromium.org/194065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25850 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 25770 after fixing Valgrind issue.huanr@chromium.org2009-09-103-3/+33
| | | | | | | | | | | | | Enable database logging on history thread. Original review: http://codereview.chromium.org/198011 BUG=16591 TEST=History UI test Review URL: http://codereview.chromium.org/194067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25842 0039d316-1c4b-4281-b951-d872f2087c98
* http://src.chromium.org/viewvc/chrome?view=rev&revision=25829 should have ↵mirandac@chromium.org2009-09-101-1/+1
| | | | | | | | | | | | | included this change to the signature of the SaveThemeBitmap method. BUG= none TEST= none TBR: glen Review URL: http://codereview.chromium.org/196073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25837 0039d316-1c4b-4281-b951-d872f2087c98
* Put the find bar back for mac and linux.estade@chromium.org2009-09-102-5/+1
| | | | | | | | BUG=21443 Review URL: http://codereview.chromium.org/192060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25836 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that tips change when the Chrome language changes.mirandac@chromium.org2009-09-102-13/+35
| | | | | | | | | BUG= http://crbug.com/21394 TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear. Review URL: http://codereview.chromium.org/199073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25834 0039d316-1c4b-4281-b951-d872f2087c98
* Clipboard:estade@chromium.org2009-09-102-3/+9
| | | | | | | | | | | | | - Move link construction logic to scoped_clipboard_writer.cc - Make callers use EscapeForHTML on the anchor text - Make WriteHyperlink just write html, and not a bookmark as well (only affects one caller, which I updated) - implement WriteBookmark for gtk BUG=18034,18035 Review URL: http://codereview.chromium.org/194052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25833 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: avoid a NOTREACHED() by not reaching it.mdm@chromium.org2009-09-101-2/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/195046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25832 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the gtk location bar padding and make it more consistent.mattm@chromium.org2009-09-102-63/+32
| | | | | | | | | | | | | | Sets the container border and box padding values, so that each widget doesn't need an alignment to pad itself. With this the horizontal padding is almost the same as windows (in a few cases we have 1 more pixel between elements.) The vertical padding should be unchanged. BUG=none TEST=none Review URL: http://codereview.chromium.org/195048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25831 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that inactive tab images line up correctly with frame image when ↵mirandac@chromium.org2009-09-101-6/+33
| | | | | | | | | | | themed. Also fix HasCustomImage so that it only returns true when the image is in the extension's original set, not just a generated theme for the cache. BUG= http://crbug.com/21134 TEST= install a theme with a detailed frame background. Open many tabs. Make sure the inactive tab image lines up with the frame image. Review URL: http://codereview.chromium.org/193030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25829 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Upload GdkPixbufs into cairo surfaces so they (hopefully) live on the Xerg@google.com2009-09-1013-296/+117
| | | | | | | | | | | | | server and have better performance. In the presence of XRender, let cairo do things smarter." Valgrind problems. This reverts commit 03871714c3e5b39ee0f8369ecc2313c02fe0ca08 (r25814). Review URL: http://codereview.chromium.org/200071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25828 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ViewIDTest.Basic.kuchhal@chromium.org2009-09-101-1/+3
| | | | | | | | | BUG=21443 TBR=davemoore Review URL: http://codereview.chromium.org/202036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25826 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarilly comment out SQLite load optimizationjar@chromium.org2009-09-101-1/+3
| | | | | | | | | | | | | This is meant to test to see if we can reduce SQL related crashes by removing the pre-load optimization. I also added a line of defensive code (initializing a pointer). r=brettw Review URL: http://codereview.chromium.org/203011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25822 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix bookmark bar regression:estade@chromium.org2009-09-091-3/+10
| | | | | | | | | show bookmark folder dropdowns even if there is no overflow BUG=21430 Review URL: http://codereview.chromium.org/203010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25821 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at implementation of FindBar for views / gtkdavemoore@chromium.org2009-09-0915-336/+402
| | | | | | | Also had to implement change notification for TextField on views / gtk Review URL: http://codereview.chromium.org/200035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25819 0039d316-1c4b-4281-b951-d872f2087c98
* Upload GdkPixbufs into cairo surfaces so they (hopefully) live on the X ↵erg@google.com2009-09-0913-117/+296
| | | | | | | | | | | | | | server and have better performance. In the presence of XRender, let cairo do things smarter. This is a big win performance wise. BrowserWindowGtk::OnCustomFrameExpose, a heavy user of images sped up from an average runtime of 20.5ms to 0.7ms. TEST=Run through valgrind, don't leak memory. TEST=Run both before and after using xtrace. Notice fewer XCreatePixmap requests and more XRender-CreatePicture requests. BUG=http://crbug.com/10499 Review URL: http://codereview.chromium.org/197046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25814 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix issue where dragged thumbnail had the wrong z-index.arv@google.com2009-09-091-2/+3
| | | | | | | | | | | | | BUG=20903 TEST=Drag a thumbnail and release the mouse where you drqagged the thumbnail from. Now, be quick, and drag the same thumbnail again. THe thumbnail should not be displayed behind any other thumbnails. Review URL: http://codereview.chromium.org/203006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25811 0039d316-1c4b-4281-b951-d872f2087c98
* Added chrome.i18n extension API.xji@chromium.org2009-09-094-0/+92
| | | | | | | | | | | | | | | | | | The API proposal doc is http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/i18n-api This CL only adds the getter of accept languages: chrome.i18n.getAcceptLanguages(). The setter of accept languages will be added in a separate CL. BUG=http://crbug.com/14574 TEST=TEST=There is an extension in chrome\test\data\extensions\samples\i18n. Load this extension. It creates a toolstrip button. Click this button, you should get chrome's accept languages. Review URL: http://codereview.chromium.org/174116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25810 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Disable tabbing to hidden elements.arv@google.com2009-09-092-11/+11
| | | | | | | | | | | | | | This is a work around since the WebKit fix is not on the M3 branch. BUG=15711 TEST=Tab around. At all times something on the page should have focus (unless the address bar got the focus). Review URL: http://codereview.chromium.org/201068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25789 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.jhawkins@chromium.org2009-09-091-5/+4
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25788 0039d316-1c4b-4281-b951-d872f2087c98
* Start a drag if the tab is dragged off the sides of the window.pinkerton@chromium.org2009-09-096-3/+36
| | | | | | | | BUG=14926 TEST=drag tabs and make sure nothing breaks. Review URL: http://codereview.chromium.org/195043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25787 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the os x spelling panel to chromium. Users canpinkerton@chromium.org2009-09-0917-61/+345
| | | | | | | | | | | now access it from the main menu and context menu and use it to perform spelling tasks. For more detail, see http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc Patch from pwicks86@gmail.com (Paul Wicks). BUG=None TEST=The spelling panel should work in os x. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r25770 due to valgrind failures on Linux.huanr@chromium.org2009-09-091-23/+3
| | | | | | | | | TEST=none. BUG=none. Review URL: http://codereview.chromium.org/199065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25781 0039d316-1c4b-4281-b951-d872f2087c98
* Use RECT instead of CRect to reduce dependencies on ATL.jhawkins@chromium.org2009-09-092-24/+16
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25780 0039d316-1c4b-4281-b951-d872f2087c98
* Simple fix of extension_l10n_util that allows folders in form ".some_name" ↵cira@chromium.org2009-09-093-2/+31
| | | | | | | | | | to exist in _locales folder. It helps testing/loading extensions from svn tree (skips .svn folder, doesn't fail). Review URL: http://codereview.chromium.org/196029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-097-43/+40
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* Don't do a default browser check when new tabs are opened via the command line.mdm@chromium.org2009-09-091-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/203001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25777 0039d316-1c4b-4281-b951-d872f2087c98
* Small comment updates. No code change.mdm@chromium.org2009-09-092-3/+4
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25773 0039d316-1c4b-4281-b951-d872f2087c98
* Enable database logging on history thread.huanr@chromium.org2009-09-091-3/+23
| | | | | | | | | BUG=16591 TEST=History UI test Review URL: http://codereview.chromium.org/198011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25770 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 more flavors of the try chrome toastcpu@chromium.org2009-09-093-23/+79
| | | | | | | | | | | | | - Different strings, pretty much the same deal. - One case removes the radio buttons. BUG=none TEST=none Review URL: http://codereview.chromium.org/198038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25769 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send the channel-disconnect message if the recipient is in the processmpcomplete@chromium.org2009-09-092-7/+15
| | | | | | | | | | | | | of closing. This is an attempt to fix a crash bug. TEST=no BUG=21201 Review URL: http://codereview.chromium.org/197054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25767 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix tabstrip index misalignment during tab removal.estade@chromium.org2009-09-093-3/+23
| | | | | | | | | | | | | | | | | | Repro steps: - open a gmail tab and get someone to message you such that the tab title keeps changing - put that tab to the right of a bunch of other tabs - close a bunch of the tabs to the left of gmail Each time you close a tab you have about a 10% chance of reproing. The solution is essentially copy-pasted from the windows tabstrip. The Browser change is somewhat unrelated. I noticed the comment "Do not dereference |contents|" and that we were in fact dereferncing |contents|, so I worked around it. BUG=13811 Review URL: http://codereview.chromium.org/199054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25766 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ATL headers.jhawkins@chromium.org2009-09-092-8/+0
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/194051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserView layout both extension shelf and bookmarks bar if toolstrips ↵sidchat@google.com2009-09-091-1/+2
| | | | | | | | | | | | change in the extension shelf. BUG=21269 BUG=21270 BUG=21274 TEST=none Review URL: http://codereview.chromium.org/192041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25760 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on ↵sidchat@google.com2009-09-091-0/+4
| | | | | | | | | | top. BUG=20936 TEST=none Review URL: http://codereview.chromium.org/194042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25752 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the flashing of the front tab.cpu@chromium.org2009-09-091-1/+7
| | | | | | | | | | | | | | | - The background tabs think they are visible causing paints to be executed. These steal the backing store from the visible tab Please read the bug for more info. BUG=20831 TEST= see bug for steps Review URL: http://codereview.chromium.org/199010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25739 0039d316-1c4b-4281-b951-d872f2087c98
* Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/show.mirandac@chromium.org2009-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/194057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25738 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22324. Reenables ↵rohitrao@chromium.org2009-09-091-2/+1
| | | | | | | | | | CustomHomePagesModelTest.ModelChangedNotification on Mac. BUG=http://crbug.com/17452 TEST=Test should not be flaky. Review URL: http://codereview.chromium.org/193058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25731 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Force-enable the find next/previous buttons when pressingrohitrao@chromium.org2009-09-091-0/+6
| | | | | | | | | | | Cmd-F to repeat a search. BUG=http://crbug.com/18762 BUG=http://crbug.com/20273 TEST=See test cases in bugs. Both should work now. Review URL: http://codereview.chromium.org/200050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25722 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: A quick fix to enable interactive_ui_tests.mnaganov@chromium.org2009-09-091-10/+10
| | | | | | | | | | | | Need to figure out why settings are inavailable through InspectorController. For now, just stub them. BUG=http://crbug.com/21277 TEST=none Review URL: http://codereview.chromium.org/196060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25711 0039d316-1c4b-4281-b951-d872f2087c98
* Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the ↵jshin@chromium.org2009-09-094-12/+12
| | | | | | | | | | | | | | | | | | references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up drag and drop for bookmark menus and cleans up a couple ofsky@chromium.org2009-09-092-0/+18
| | | | | | | | | | | minor painting issues. BUG=none TEST=none Review URL: http://codereview.chromium.org/199050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25701 0039d316-1c4b-4281-b951-d872f2087c98
* Include fixes for gcc >= 4.3evan@chromium.org2009-09-091-0/+2
| | | | | | | | Patch by Joel Stanley <joel@jms.id.au> Review URL: http://codereview.chromium.org/197055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25699 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't let the page widget(s) handle key events that webkit didn't handle.estade@chromium.org2009-09-091-7/+3
| | | | | | | | BUG=21165 Review URL: http://codereview.chromium.org/201047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25695 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break for chrome os.ukai@chromium.org2009-09-091-0/+1
| | | | | | | | | | | | | | | | Add #include <stdio.h> for fclose et al. Without stdio.h, we got errors like: In file included from /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:5: /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h: In destructor 'virtual PipeReader::~PipeReader()': /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h:33: error: 'fclose' was not declared in this scope /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc: In member function 'virtual std::string PipeReader::Read(uint32)': /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:11: error: 'fopen' was not declared in this scope /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:12: error: 'fgets' was not declared in this scope scons: *** [/usr/local/google/home/ukai/chrome/src/sconsbuild/Debug/obj/chrome/browser/chromeos/pipe_reader.o] Error 1 Review URL: http://codereview.chromium.org/199046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25693 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Switch the page/app menus over to the new menu bar helper class.estade@chromium.org2009-09-092-57/+34
| | | | | | | | BUG=19675 Review URL: http://codereview.chromium.org/193052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25692 0039d316-1c4b-4281-b951-d872f2087c98
* Remove jankiness from bookmark animation for --show-extensions-on-top.sidchat@google.com2009-09-081-4/+0
| | | | | | | | | BUG=20927 TEST=none Review URL: http://codereview.chromium.org/192039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25680 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark toolbar folders act like a menu bar.estade@chromium.org2009-09-086-33/+361
| | | | | | | | | | | | I didn't convert the page/app menu to use the new helper class in an effort to keep this patch small and reviewable. BUG=19675 BUG=15889 TEST=fiddled with it for while, and ran it under valgrind Review URL: http://codereview.chromium.org/200029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25677 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: work around broken dlsym's.agl@chromium.org2009-09-081-2/+40
| | | | | | | | | | | | | | | | It appears that Nvidia's libGL.so is overriding dlopen/dlsym with versions that don't fully function. So far, all the users reporting this have been running Gentoo, but it might just be that they have up-to-date drivers. The report[1] suggests that all drivers >= 180 have this issue. [1] http://www.nvnews.net/vbulletin/showthread.php?t=132259 BUG=16800 http://codereview.chromium.org/201055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25671 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-0810-71/+58
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 09:43:50 +0000