summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug when accessing g_browser_process->broker_services() at shutdown.jam@chromium.org2009-11-236-22/+38
| | | | | | | BUG=28501 Review URL: http://codereview.chromium.org/435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32832 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing GCC 4.4 build fix (landing a patch for hbono)ian@chromium.org2009-11-231-1/+1
| | | | | | | | | | | | | | This patch was written by hbono, landing for him as he can't land this until tomorrow, and it's a patch to fix a build. Reviewed at http://codereview.chromium.org/414025 BUG=none TEST=GCC 4.4 compiles Review URL: http://codereview.chromium.org/436003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Set initial size for js alert.estade@chromium.org2009-11-231-0/+12
| | | | | | | | BUG=28058 Review URL: http://codereview.chromium.org/426008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32828 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't dereference stale ConstrainedWindow pointer.estade@chromium.org2009-11-231-2/+4
| | | | | | | | BUG=28587 Review URL: http://codereview.chromium.org/436004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32827 0039d316-1c4b-4281-b951-d872f2087c98
* Default browser checking on start-up was broken.jcampan@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | ShellIntegration::IsDefaultBrowser() had been changed to return an enum instead of a bool. But the code in browser_init.cc calling it has not been updated. BUG=28429 TEST=Test that the default browser infobar is shown when Chrome is started and not the default browser. Review URL: http://codereview.chromium.org/426009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32825 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some missing accelerators to Linux toolkit views.jcampan@chromium.org2009-11-231-1/+10
| | | | | | | | BUG=28416 TEST=Tests all the accelerators found in chrome/browser/views/accelerator_table_gtk.cc work and are consistent Chrome on Windows. Review URL: http://codereview.chromium.org/426006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32824 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale as a parameter to the extension link.mirandac@chromium.org2009-11-231-4/+5
| | | | | | | | | BUG= 28433 TEST= click on puzzle piece and promo line "extension" links; chrome UI language should be included as a parameter in the link. Review URL: http://codereview.chromium.org/434002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32820 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the frame background image for ChromeOS to match gtk ↵oshima@chromium.org2009-11-231-3/+17
| | | | | | | | | | | | | | build. Gtk build is using non custom frame mode, which renders the frmae pixels 15 pixels above. I'll remove this hack once we migrate to views. BUG=28580 TEST=None Review URL: http://codereview.chromium.org/434011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32818 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "installer: clean up to use FilePath instead of std::wstring."kuchhal@chromium.org2009-11-232-9/+16
| | | | | | | | | | | This reverts commit 9da05365beb211e3879e6049547e5e92c4c0a5a2 (r32811). TBR=thiago.farina@gmail.com BUG=32811 Review URL: http://codereview.chromium.org/437011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32817 0039d316-1c4b-4281-b951-d872f2087c98
* Some small comment fixes for HostResolver and DnsMaster.eroman@chromium.org2009-11-231-1/+1
| | | | | | | | | | | Original patch by cbentzel@google.com (see http://codereview.chromium.org/437005) r=me BUG=NONE Review URL: http://codereview.chromium.org/437009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32816 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving NTP CSS resources into the NTP resource cache.tony@chromium.org2009-11-239-268/+291
| | | | | | | | | | | | | | | | | | Moving the HTML to the cache saved 8ms on New Tab Warm on Windows, maybe we can shave a few more ms off by moving the CSS. The last change had a regression on the mac new tab perf, so I suspect it's the extra round trip to the UI thread when trying to load the CSS (the UI thread is probably just busy at that time). Instead, I'm moving the generation of the CSS to the time the object is constructed, rather than when the resource is requested. This is like the code before, except sometimes we'll hit the cache. BUG=26228 Review URL: http://codereview.chromium.org/427003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32815 0039d316-1c4b-4281-b951-d872f2087c98
* Improve unit test robustness.mrossetti@chromium.org2009-11-231-1/+1
| | | | | | | | | BUG=28405 TEST=none Review URL: http://codereview.chromium.org/425007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32814 0039d316-1c4b-4281-b951-d872f2087c98
* installer: clean up to use FilePath instead of std::wstring.kuchhal@chromium.org2009-11-232-16/+9
| | | | | | | | | | BUG=24672 TEST=installer_util_unittests and setup_unittests Review URL: http://codereview.chromium.org/385129 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32811 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts font sizes to be readable on Chrome OS.sky@chromium.org2009-11-231-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32810 0039d316-1c4b-4281-b951-d872f2087c98
* Call FNNotify on download complete; this should help apps watching the ↵avi@google.com2009-11-231-1/+8
| | | | | | | | | | | | downloads folder. BUG=none TEST=If Transmission is watching the Downloads folder, it should catch a completed download immediately. Review URL: http://codereview.chromium.org/437006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32808 0039d316-1c4b-4281-b951-d872f2087c98
* Allow reentrant tasks on window close in in-proc browser test framework. ↵kkania@chromium.org2009-11-231-0/+14
| | | | | | | | | | Disable tests that are failing on Mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/425013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32804 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add UMA entry for inspect element action.pfeldman@chromium.org2009-11-232-2/+3
| | | | | | | | BUG=28563 Review URL: http://codereview.chromium.org/431009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32803 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix toolbar sizing bug upon unloading extension/theme.viettrungluu@chromium.org2009-11-221-0/+7
| | | | | | | | | BUG=28476 TEST=Install any theme (e.g., "Classic"); click "undo" in infobar; toolbar layout shouldn't change (and the toolbar's contents should be sized correctly). Review URL: http://codereview.chromium.org/418048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32792 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of status bubble flicker.derat@chromium.org2009-11-222-2/+20
| | | | | | | | | | | | | | | | | | | | | The bubble was appearing in its default location when getting shown while the mouse was nearby; it would move to the correct location on the next motion event. I think that there's still a flicker in the wrong location when closing the download bar and then triggering the bubble, but the fix is non-obvious to me. It's possible that it's not noticeable on anything faster than the slow DSL line that I'm using to run Chrome remotely to test this. BUG=28494 TEST=repeated steps from bug and checked that download bar behavior doesn't appear to have regressed either Review URL: http://codereview.chromium.org/431007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32789 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: minor cleanup of constants in toolbar_controller.mm.viettrungluu@chromium.org2009-11-221-12/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/418049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32779 0039d316-1c4b-4281-b951-d872f2087c98
* build fix: missing includeevan@chromium.org2009-11-221-0/+1
| | | | | | Not exactly sure why this was compiling for some people before. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32772 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change that disallowed content scripts access toaa@chromium.org2009-11-223-6/+29
| | | | | | | | | | | | | | | | | | file:// URLs. It turns out teams were already depending on this and we didn't want to break them. Instead, group file:// access with NPAPI in the extension install prompt. Note: this is a pure revert of r402029 and r402069 (sorry Finnur!) except the changes in extension_install_ui.cc, which are new. BUG=28456 Review URL: http://codereview.chromium.org/430003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32770 0039d316-1c4b-4281-b951-d872f2087c98
* Put the --type switch back as the first for renderers, for easy identification.mdm@chromium.org2009-11-221-6/+6
| | | | | | | | | BUG=28421 TEST=run ps auxw, see that --type is the first switch to renderer processes Review URL: http://codereview.chromium.org/414071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32766 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page. mirandac@chromium.org2009-11-212-10/+1
| | | | | | | | | | | Part 2: to be merged into 249. BUG=28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/414076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32759 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32754 - Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-212-1/+10
| | | | | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/414075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-212-10/+1
| | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
* Launch all child processes asynchronously so as not to block the IO thread.jam@chromium.org2009-11-2114-349/+369
| | | | | | | BUG=6844, 27935 Review URL: http://codereview.chromium.org/402097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32750 0039d316-1c4b-4281-b951-d872f2087c98
* Tommi, please review everything. John please review the changes to ↵ananta@chromium.org2009-11-212-0/+16
| | | | | | | | | | | | | | | | | | plugin_service.cc/.h The test automation provider registers itself as a protocol factory for http/https requests. This is to ensure that intercepts set by the url request network tests work correctly. I was seeing these tests fail consistently on my setup as their intercept function would never get called. The other change is to add a simple mechanism based on a boolean flag to disable browser side plugins like gears which also intercept network requests and expect to be called on the IO thread. The chrome frame network tests run in a relatively simple environment where the network tests run in a separate thread (not the IO thread) which causes a number of DCHECKS to fire in debug build test runs. The flag used to determine whether browser plugins are loaded defaults to true. Review URL: http://codereview.chromium.org/414017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32739 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement profile error dialog.thakis@chromium.org2009-11-211-1/+18
| | | | | | | | | | | | | | | The "active window" change was done for linux in http://codereview.chromium.org/147091 and might fix other problems too. Without this, BrowserList::GetLastActive() returns NULL in Browser::Observe(), which caused the new function not to be called. It looks something like http://imgur.com/6PHQm . BUG=26377 TEST= chmod -r ~/Library/Application\ Support/Chromium/Default/History* Then start chromium (release build, so that we survive some sqlite dchecks) and make sure it displays an error message (then chmod +r again) Review URL: http://codereview.chromium.org/418040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32738 0039d316-1c4b-4281-b951-d872f2087c98
* Mark Page404_GoBack as flaky on linuxtim@chromium.org2009-11-211-0/+6
| | | | | | | | | | TBR=phajdan.jr BUG=19361 TEST=ErrorPageTest Review URL: http://codereview.chromium.org/426011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32733 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser_sync 'sessions' to relieve SyncCycleState, SyncProcessState, ↵tim@chromium.org2009-11-2164-2880/+2473
| | | | | | | | | | | | | | | | | | | | SyncerSession, SyncerStatus, and ConflictResolutionView of duty. Main impact is factors all status munging to 'StatusController', adds SyncSessionContext to wrap various engine parts needed by different components, removes duplicated methods by a factor of ~3 making it easier to reason about, and adds a 'Controller' to the session object to give a way to delegate session-global (i.e affecting any session) occurrences such as throttling. Also adds testing for 'HasMoreToSync' and other session related code. BUG=25266 TEST=SyncSessionTest(added), StatusControllerTest(added) various sync_unit_tests in this CL Review URL: http://codereview.chromium.org/386030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32732 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix error message which mentions top instead of ps.viettrungluu@chromium.org2009-11-211-5/+6
| | | | | | | | | BUG=28357 TEST=none (unless you feel like mocking /bin/ps) Review URL: http://codereview.chromium.org/426010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32730 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32727 - Disable sync. (Will be committed on beta branch only, and ↵akalin@chromium.org2009-11-211-1/+1
| | | | | | | | | | | | | | this CL will be immediately reverted.) BUG=26712 TEST=trybot Review URL: http://codereview.chromium.org/425015 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/414069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32728 0039d316-1c4b-4281-b951-d872f2087c98
* Disable sync. (Will be committed on beta branch only, and this CL will be ↵akalin@chromium.org2009-11-211-1/+1
| | | | | | | | | | | immediately reverted.) BUG=26712 TEST=trybot Review URL: http://codereview.chromium.org/425015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32727 0039d316-1c4b-4281-b951-d872f2087c98
* posix: refactor duplicated path-handling codeevan@chromium.org2009-11-212-2/+2
| | | | | | | | | We had the same code in three headers, and an "if FREEBSD" in a _linux.cc file. Review URL: http://codereview.chromium.org/414063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32722 0039d316-1c4b-4281-b951-d872f2087c98
* Implement AutoFillType, the high-level description of AutoFill types.jhawkins@chromium.org2009-11-212-0/+187
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/418026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32716 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-205-16/+16
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Forces T*s to scoped_refptr<T> when PostTask()ing to a function expecting ↵jamesr@chromium.org2009-11-2011-42/+26
| | | | | | | | scoped_refptr<T> Review URL: http://codereview.chromium.org/418007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32706 0039d316-1c4b-4281-b951-d872f2087c98
* When you search for something, press F3, close the box and press F3 it would ↵finnur@chromium.org2009-11-203-10/+39
| | | | | | | | | | only open the Find box and not issue the search. This is because we set the prepopulate string to find_text and not find_text_ (the former is blank on F3). I have also changed the variable name to prevent this kind of confusion in the future. BUG=28306 TEST=Automated test added. Review URL: http://codereview.chromium.org/425003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32705 0039d316-1c4b-4281-b951-d872f2087c98
* Properly report blacklisted extension errors (currently, blacklisted ↵estade@chromium.org2009-11-201-3/+1
| | | | | | | | | | | extensions don't send an install error notification, so the loading bubble persists forever). BUG=none TEST=install a blacklisted extension Review URL: http://codereview.chromium.org/418031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32702 0039d316-1c4b-4281-b951-d872f2087c98
* Don't do work in the SharedIOBuffer constructor; use an Init method instead. ↵hawk@chromium.org2009-11-201-5/+11
| | | | | | | | | | | | This eliminates instances of allocated-but-invalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug. The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it. BUG=16371 TEST=none Review URL: http://codereview.chromium.org/391009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32701 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on HTML5 DBs by default.dumi@chromium.org2009-11-202-16/+6
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/414048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32698 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced HungRendererDialog class with hung_renderer_dialog namespace.akalin@chromium.org2009-11-205-24/+29
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/415006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures the renderer gets focus/blur message when switching tabs.jcampan@chromium.org2009-11-203-2/+21
| | | | | | | | | | | BUG=26610 TEST=Open a page in a teb that prints out when the window object gets focused blured. Switch to another tab then come back to that tab. A blur and focus events should have been fired. Review URL: http://codereview.chromium.org/402091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32696 0039d316-1c4b-4281-b951-d872f2087c98
* Allow folders to be created with empty names.mrossetti@chromium.org2009-11-202-9/+20
| | | | | | | | | BUG=28318 TEST=Bring up the Add Folder sheet by choosing Add Folder... from the contextual menu. The OK button should always be active. Click OK and a new, unnamed folder should be added. Review URL: http://codereview.chromium.org/414055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32693 0039d316-1c4b-4281-b951-d872f2087c98
* Apply theme color to bookmark button text.jrg@chromium.org2009-11-206-13/+129
| | | | | | | | | | | | | | | | BUG=http://crbug.com/17608 TEST=Add some bookmarks (you must use both folders and marks). Apply a theme and make sure theme color applies bookmark button text for all buttons (including "Other bookmarks"). Create new window and make sure bookmark buttons still fine in new window. Quit and restart Chrome. Make sure theme color still applied to bookmark button text in the same way as before quitting (e.g. same color and still applies to all). Change theme 1 more time and verify color. Review URL: http://codereview.chromium.org/424004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32690 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32608 - RESUBMIT of ↵ananta@chromium.org2009-11-206-47/+71
| | | | | | | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes. Reverting this as this caused a number of valgrind test failures. Make the WebKitThread object start the WebKit thread on construction (not lazily). NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144 Review URL: http://codereview.chromium.org/404025 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/427001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32687 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-201-28/+1
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* Change popup construction logic so that folders with empty name is no longer ↵mrossetti@chromium.org2009-11-202-2/+38
| | | | | | | | | | | used for excluding the root node from display, rather, user is_root() for that purpose. A folder with an empty name is now shown as a blank line in the popup. BUG=28313 TEST=Create a new folder with a blank name and add an URL to that folder. Select the new bookmark. Bring up the bubble and click either 'Edit' or 'Close'. It should not crash at this point. Also, click on the popup and a blank line should appear representing the newly created folder. Review URL: http://codereview.chromium.org/418027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32681 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK() failure when about:memory used.viettrungluu@chromium.org2009-11-202-14/+21
| | | | | | | | | BUG=28358 TEST=On a debug build (on any platform), go to about:memory and make sure it doesn't fail a DCHECK(). Review URL: http://codereview.chromium.org/418022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32677 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:54:19 +0000