summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-212-19/+19
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where NTP metrics for restored tabs weren't getting recorded ↵glen@chromium.org2008-11-212-4/+1
| | | | | | | | | | correctly. BUG=4668 Review URL: http://codereview.chromium.org/11356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5846 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in creating Browser. The crash could happensky@google.com2008-11-211-0/+5
| | | | | | | | | | | | | | | because its possible for the browserwindow to be null when SaveWindowPlacement is invoked (when the browserwindow is initially created). If the SessionService ends up asking the browser for the browserwindow it would get null and crash. BUG=4666 TEST=no direct way to test this as its rather random. But make sure you don't encounter any problems with session restore. Review URL: http://codereview.chromium.org/11567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5844 0039d316-1c4b-4281-b951-d872f2087c98
* Discard CHAR events if their corresponding KEY_DOWN events triggered ↵pkasting@chromium.org2008-11-212-2/+17
| | | | | | | | | | accelerators. Original patch by Alex Mendes de Costa (alexmdac@gmail.com) on http://codereview.chromium.org/11268, r=me. BUG=91 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5832 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb WebCore's windowResizerRect() through glue and renderer. Enables Mac ↵pinkerton@google.com2008-11-212-0/+7
| | | | | | | | scrollbars to not overlap the in-window resizer widget. Review URL: http://codereview.chromium.org/11353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5831 0039d316-1c4b-4281-b951-d872f2087c98
* Adds various docking positions when dragging around a tab. I've addedsky@google.com2008-11-2012-107/+1079
| | | | | | | | | | | | | | | | | | | | | | | the ability to dock to the following locations: Maximize the window on drop. Resize the window to fill up the left, bottom, or right half of the monitor. Tile the newly created window with an existing chrome window such that the two are on top of each other and fill the height of the monitor, or tiled such that they fill the width of the monitor. The graphics suxor. Glen says he'll come up with something better once its landed. BUG=none TEST=4628 Review URL: http://codereview.chromium.org/11325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5797 0039d316-1c4b-4281-b951-d872f2087c98
* * fix build errorkuchhal@chromium.org2008-11-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5794 0039d316-1c4b-4281-b951-d872f2087c98
* * fix build errorkuchhal@chromium.org2008-11-201-1/+2
| | | | | | Review URL: http://codereview.chromium.org/11548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5793 0039d316-1c4b-4281-b951-d872f2087c98
* - If the exe rename command fails try calling Google Update to do the same ↵kuchhal@chromium.org2008-11-201-6/+37
| | | | | | | | | | | | | | job. This works when we are logged into XP/Vista as limited rights user. - Update Google Update idl file that has the recently added COM object. - Add --system-level to the rename command that gets added to the registry. - Remove all the code to uninstall Gears MSI. Now most of the user have been upgraded to Chrome installer that includes gears.dll. BUG=1463346 Review URL: http://codereview.chromium.org/11255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5791 0039d316-1c4b-4281-b951-d872f2087c98
* Don't CHECK if we couldn't get a handle to the renderer process, it may have ↵jam@chromium.org2008-11-201-1/+1
| | | | | | | | | just died. BUG=4267 Review URL: http://codereview.chromium.org/11515 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5778 0039d316-1c4b-4281-b951-d872f2087c98
* Make the net resource interface use StringPiece instead of std::string. ↵deanm@chromium.org2008-11-201-3/+3
| | | | | | | | This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around. Review URL: http://codereview.chromium.org/11506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5740 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make the net resource interface use StringPiece instead oftc@google.com2008-11-201-3/+3
| | | | | | | | | | | | | | | std::string. This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around." This reverts commit r5735. TBR=deanm Review URL: http://codereview.chromium.org/11298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5736 0039d316-1c4b-4281-b951-d872f2087c98
* Make the net resource interface use StringPiece instead of std::string. ↵deanm@chromium.org2008-11-201-3/+3
| | | | | | | | This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around. Review URL: http://codereview.chromium.org/11296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5735 0039d316-1c4b-4281-b951-d872f2087c98
* Don't execute a NOTREACHED in TabStrip::DestroyDraggedSourceTab if thesky@google.com2008-11-201-1/+2
| | | | | | | | | | | | | | | tab strip contains the tab but the model is closing all. Normally the end of the animation removes the tab, but if we're closing all tabs the animation isn't run. I was hitting this when I have more than one window open and drag a tab in a window with a single tab and release it. BUG=none TEST=none Review URL: http://codereview.chromium.org/11294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5733 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the generated html for directory listings. This will allow the net ↵deanm@chromium.org2008-11-191-7/+26
| | | | | | | | resource provider system to return direct pointers into the resources instead of copying. Review URL: http://codereview.chromium.org/11501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5729 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation of 'open with' registry keys to installer. We should place ↵kuchhal@chromium.org2008-11-193-99/+1
| | | | | | | | | | nice and not create these keys on every Chrome start just in case user wants a customized open with list. So now we only create these keys at installation or when user choses to make Chrome default browser. Also we clean them up on uninstall. BUG=1190855 Review URL: http://codereview.chromium.org/11491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5726 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-193-5/+77
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this change: http://codereview.chromium.org/10967/showben@chromium.org2008-11-1919-71/+44
| | | | | | | | | Now with two improvements: - no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar - make sure overridden CreateView in NativeUIContents and StatusView have the correct signature. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5723 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome\browser\frame_util.cc from the SCons build.sgk@google.com2008-11-191-1/+0
| | | | | | Review URL: http://codereview.chromium.org/11485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5709 0039d316-1c4b-4281-b951-d872f2087c98
* Send the chrome.dll base address in the UMA initial log. This will help us ↵deanm@chromium.org2008-11-191-0/+9
| | | | | | | | detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address. Review URL: http://codereview.chromium.org/6540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5705 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce httponly on cookies coming from the renderer. This prevents ↵deanm@chromium.org2008-11-191-1/+2
| | | | | | | | | javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies. Patch from Marius Schilder. Review URL: http://codereview.chromium.org/11275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5700 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for developer0420@gmail.comjoshia@google.com2008-11-192-7/+53
| | | | | | | | | | | | | | | | | | | | | The LPITEMIDLIST returned from SHBrowseForFolder might not get released if SHGetPathFromIDList fails Added in the comment changes Added GetDisplayNameOf for getting selection, using old way if STRRET Structure type does not equal STRRET_WSTR as I was unable to get complete code coverage. Added BrowseCallbackProc and listen to MSG so that we can highlight existing value Added in the comment changes ( changed to smart pointer for managing COM interface pointers.) Review URL: http://codereview.chromium.org/11481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5686 0039d316-1c4b-4281-b951-d872f2087c98
* Change by Alex Mendes da Costa <alexmdac@google.com>beng@google.com2008-11-193-4/+28
| | | | | | | | | | | | Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history. BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293) Review URL: http://codereview.chromium.org/10743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5674 0039d316-1c4b-4281-b951-d872f2087c98
* Land this change again now I've fixed the crash.ben@chromium.org2008-11-1934-268/+186
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cf_html from webdropdata.h. This is windowstc@google.com2008-11-191-2/+2
| | | | | | | | | | | | | | | | | | specific code so we should handle it before we get to webkit. CF_HTML needs the source URL to resolve relative URLs so I added that to the format and plumb it through from webcore. I also did some small refactoring so we only have one implementation of converting to/from CF_HTML and regular markup. We can tweak these converters (and add unit tests) in follow up changes. Review URL: http://codereview.chromium.org/11247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5662 0039d316-1c4b-4281-b951-d872f2087c98
* put back this change now chromebot has had a chance to runben@chromium.org2008-11-191-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5653 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser window is visible, even if the startup info says that ↵ben@chromium.org2008-11-191-1/+3
| | | | | | | | | it should be hidden. This fixes the problem of invisible browser window when launched from bash. http://crbug.com/4438 Review URL: http://codereview.chromium.org/11454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that occurs during the browser shutdown process.paulg@google.com2008-11-181-8/+15
| | | | | | | | | | | | | | | | | It is possible that during the shutdown process, the database thread posts tasks back to the IO thread which result in calls to the SafeBrowsing protocol manager object. This object will have been deleted by the time the posted task runs, resulting in a crash. This change checks the enabled_ flag (which is set to false when the shutdown starts) for all tasks posted to the IO thread to protect against access to deleted objects. BUG = http://crbug.com/4531 Review URL: http://codereview.chromium.org/11245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5644 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2008-11-181-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5638 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back a bunch of changes to tab dragging that seem to not have helped ↵ben@chromium.org2008-11-184-156/+72
| | | | | | | | | | | reduce the crashiness any :-/ r5335 dragged_tab_controller.cc (delegate NULL setting) r5124 changes to make AutomationProvider::WindowSimulateDrag use SendInput instead of SendMessage r5117 dragged_tab_controller.cc (delegate NULL setting) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5636 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 5607 because it caused a base_unittest failure.maruel@chromium.org2008-11-183-136/+2
| | | | | | Review URL: http://codereview.chromium.org/11234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5608 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-183-2/+136
| | | | | | | Add more DCHECKs. Review URL: http://codereview.chromium.org/10957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5607 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 5596 because it broke the buildnsylvain@chromium.org2008-11-1834-182/+268
| | | | | | Review URL: http://codereview.chromium.org/11439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5598 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a friend test declaration.paulg@google.com2008-11-181-1/+2
| | | | | | Review URL: http://codereview.chromium.org/11431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5597 0039d316-1c4b-4281-b951-d872f2087c98
* Last couple of bits of new-frame related cleanup:ben@chromium.org2008-11-1834-268/+182
| | | | | | | | | | | | | - Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND) - Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon). - Replace BrowserType class with an enum on Browser. http://crbug.com/2320 http://crbug.com/3363 Review URL: http://codereview.chromium.org/10786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5596 0039d316-1c4b-4281-b951-d872f2087c98
* At Yahoo!'s request, add a "fr=crmas" identifier to their prepopulate ↵pkasting@chromium.org2008-11-171-69/+103
| | | | | | | | | entries.Also fix up some of the suggest URLs to be more consistent. BUG=4102 Review URL: http://codereview.chromium.org/11214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5577 0039d316-1c4b-4281-b951-d872f2087c98
* It's possible for GetOleInterface() to return NULL. Degrade gracefully in ↵pkasting@chromium.org2008-11-172-3/+10
| | | | | | | | | this case. BUG=3906 Review URL: http://codereview.chromium.org/11213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5576 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing possible crash in ModalHTMLDialogDelegate. It'ssky@google.com2008-11-172-9/+20
| | | | | | | | | | | | | | | | possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The first time ModalHTMLDialogDelegate gets a NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This is problematic because the destructor than removes the observer using a source of NULL. Instead we should remove the observer immediately, then NULL out the contents_. BUG=4129 TEST=covered by QEMU Review URL: http://codereview.chromium.org/11413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5575 0039d316-1c4b-4281-b951-d872f2087c98
* Changes about view to explicitly set the background to white. This waysky@google.com2008-11-171-0/+1
| | | | | | | | | | | | even though the field is disabled you get a white background. BUG=4511 TEST=Bring up about chrome and make sure background of version string is white. Review URL: http://codereview.chromium.org/11421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5574 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback! Now with 25% more HWND.ben@chromium.org2008-11-1715-35/+63
| | | | | | :-/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5573 0039d316-1c4b-4281-b951-d872f2087c98
* Makes opening a bookmark activate the window.sky@google.com2008-11-171-2/+4
| | | | | | | | | BUG=4447 TEST=see bug Review URL: http://codereview.chromium.org/10765 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5560 0039d316-1c4b-4281-b951-d872f2087c98
* fixing bustageben@chromium.org2008-11-172-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5555 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HWND from TabContents creation. ben@chromium.org2008-11-1713-60/+32
| | | | | | R=brettw ReviewURL: http://codereview.chromium.org/10967/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5554 0039d316-1c4b-4281-b951-d872f2087c98
* Quick test to locate position of crash on qemu. Will remove after one batch ↵ben@chromium.org2008-11-161-1/+2
| | | | | | of crashes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5546 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crashes in QEMU by (correctly) saying no commands are enabled when ↵ben@chromium.org2008-11-161-0/+4
| | | | | | | | | there is no selected tab. This is significantly simpler than NULL checking all over the place since no one should call ExecuteCommand without first calling IsCommandEnabled. TBR=sky Review URL: http://codereview.chromium.org/10783 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5545 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erase method usage on STL containers in Chrome. Invoking erase on the ↵ananta@chromium.org2008-11-153-4/+12
| | | | | | | | | | iterator renders it invalid. We were continuing to use this iterator. R=darin Review URL: http://codereview.chromium.org/10925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
* Open up SDCH for all sites, in preparation for latency testsjar@google.com2008-11-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Since the stability test is going well (so far) on ".google.com," this change will open up support for SDCH compression to all sites. This will allow for more international testing as well. I tightened down the restrictions on who can set up a dictionary for a given domain. I'm pretty sure it is at least as restrictive as the current SDCH spec. I also supplied a default expiration time for using an SDCH dictionary at 30 days (as per SDCH spec). To be safer with the latency histograms, I also tightened the period of time we measure, on the off chance that the page some-how asks for more bytes after everything has been read/rendered. r=openvcdiff,hunar Review URL: http://codereview.chromium.org/11009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of NULL checks that seem unnecessary, and document some ↵ben@chromium.org2008-11-152-66/+33
| | | | | | | | checks that are. Review URL: http://codereview.chromium.org/10962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5523 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Browser restore saved last size/position using the WindowDelegate ↵ben@chromium.org2008-11-154-21/+23
| | | | | | | | code rather than hand-rolling its own. Review URL: http://codereview.chromium.org/10959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5520 0039d316-1c4b-4281-b951-d872f2087c98
* RandUInt -> RandUint to match the style of other Uint functions.deanm@chromium.org2008-11-142-2/+2
| | | | | | Review URL: http://codereview.chromium.org/10767 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5517 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 19:45:07 +0000