summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Connect the 'changed' signal on the label entry and change the expander ↵jhawkins@chromium.org2010-01-201-2/+29
| | | | | | | | | | title as the user types. BUG=none TEST=none Review URL: http://codereview.chromium.org/554012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36602 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: don't crash when a dragged tab gets deleted.estade@chromium.org2010-01-201-0/+8
| | | | | | | | | | | Unfortunately, the more correct seeming gtk_grab_remove(gtk_grab_get_current()); doesn't seem to work. BUG=30592 TEST=see bug Review URL: http://codereview.chromium.org/542139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36598 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the bookmark manager out to the Gnome desktoptony@chromium.org2010-01-201-5/+6
| | | | | | | | | | | | | (nautilus). This should create a shortcut to the site rather than downloading the file to the desktop. I didn't do this before because of the menu crasher. BUG=24210 Review URL: http://codereview.chromium.org/553024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36592 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at landing this.jcampan@chromium.org2010-01-209-44/+99
| | | | | | | | | | | | | | | | | | | | | | It caused several tests to fails previously. There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac. That should hopefully make everything work now. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/552049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36589 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36586 - Implemented AddressWatchTask for OS X.akalin@chromium.org2010-01-204-169/+1
| | | | | | | | | | | | | | Added some utility methods to ServerConnectionManager. BUG=32430 TEST=Manual testing with a laptop Review URL: http://codereview.chromium.org/543098 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/546083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36588 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented AddressWatchTask for OS X.akalin@chromium.org2010-01-204-1/+169
| | | | | | | | | | | Added some utility methods to ServerConnectionManager. BUG=32430 TEST=Manual testing with a laptop Review URL: http://codereview.chromium.org/543098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36586 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the star, bookmarks bar, and bookmark bar menustony@chromium.org2010-01-206-27/+32
| | | | | | | | | | | to the Gnome desktop (nautilus). These should create shortcuts. Other drag operations should be the same as before. BUG=24210 Review URL: http://codereview.chromium.org/548067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36585 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanup of member variable in FindBarGtk.tony@chromium.org2010-01-202-4/+4
| | | | | | | | I missed this during review. Review URL: http://codereview.chromium.org/543112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36583 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Implemented new button bar.snej@chromium.org2010-01-204-29/+105
| | | | | | | | | | (Nib changes: Removed toolbar, added segmented control and pop-up button, removed focus highlighting for outline views.) BUG=32442 TEST=Verify activation and behavior of + and - buttons and 'gear' menu items. Review URL: http://codereview.chromium.org/543116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36582 0039d316-1c4b-4281-b951-d872f2087c98
* Indent menu items in add-bookmark pop-up, to show folder hierarchy.snej@chromium.org2010-01-202-4/+12
| | | | | | | | | BUG=32427 TEST=Click 'star' button; click 'Folder:' pop-up. Verify that menu item indentation matches folder nesting. Review URL: http://codereview.chromium.org/545094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36580 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: respect menu model's radio button groupings.estade@chromium.org2010-01-201-8/+11
| | | | | | | | | | | (don't just group by proximity) BUG=32222 TEST=see bug Review URL: http://codereview.chromium.org/548074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36579 0039d316-1c4b-4281-b951-d872f2087c98
* Posix: try to make signal handler async signal safe again.willchan@chromium.org2010-01-191-31/+104
| | | | | | | | | There used to be freezes in browser_tests and ui_tests on the trybots and buildbots, but I've tried the trybots many times and haven't seen this repro, so I'm going to try committing again. This change is mostly a revert of r35192. Review URL: http://codereview.chromium.org/546035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36577 0039d316-1c4b-4281-b951-d872f2087c98
* Added public copy constructor to AutoFillProfile to allow it to be used in ↵georgey@chromium.org2010-01-192-5/+32
| | | | | | | | | | std containers. TEST=no BUG=none Review URL: http://codereview.chromium.org/553019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36570 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark manager: Make URLs editable.snej@chromium.org2010-01-196-12/+80
| | | | | | | | | BUG=32028 TEST=BookmarkItemTest.URL*. Manually: click the URL of a selected item and it will become editable. Type new value and hit Return/Enter. Review URL: http://codereview.chromium.org/551055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36562 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix reference counting/destruction of GtkMenu* in MenuGtk. estade@chromium.org2010-01-191-0/+6
| | | | | | | | | | | | | regression caused by r35404 credit to Bryan Yeung for finding the bug BUG=31977, 31765, 32514, 31988 TEST=see bugs Review URL: http://codereview.chromium.org/552044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36559 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Save/restore task manager window pos and size.thakis@chromium.org2010-01-1913-190/+341
| | | | | | | | | | | | | Make window size remembering mechanism easier to use and more compatible with windows's chrome profiles. Nib changes: Unset "show at startup" so that the initial repositioning isn't visible. BUG=32147 TEST=Move & size taskman window, quit chrome, reopen chrome. Size & pos should've stayed. Same for keyword editor. Page info dialog should behave as it did before. Review URL: http://codereview.chromium.org/536086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36557 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r36541 (which went in without any commit log by some magic). Was ↵jshin@chromium.org2010-01-192-12/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reverted in r36550. Now I'm relanding with the full description. Port back CLD to Linux and Mac by replacing Windows API calls with ICU's equivalent APIs for normalization. I also fixed bug 23553 (Traditional Chinese is not detected) by calling LanguageCode instead of LanguageCode_ISO_639_1. The latter covers only ISO 639-1, but there are languages detected by CLD not covered by ISO 639-1. In that case, ISO 639-2 is used. In case even ISO 639-2 does not cover (e.g. Traditional Chinese), another fallback is taken by LanguageCode. The html file for CLD testing (french_sentence.html) is explicitly labelled with charset=ISO-8859-1. Original Review: http://codereview.chromium.org/523108 BUG=25206,23553 TEST=1. CLD is built on Linux/Mac 2. The following test pass: - unit_tests: Extension*.DetectTabLang* and CompactLangDet*.* - browser_tests: ExtensionBrowserTest.Toolstrip 3. Install the 'cld extension' in chrome/common/extensions/docs/examples/api/i18n/cld and go to http://news.google.com.tw and 'zh-TW' shows up in the language badge at the upper right (upper-left in he/ar Chrome) corner. TBR=jcampan Review URL: http://codereview.chromium.org/545123 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/551070 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/549091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36552 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36541 (which went in without any commit log by some black magic). jshin@chromium.org2010-01-192-1/+12
| | | | | | | | | | | | Reland it with the commit log for the record. Review URL: http://codereview.chromium.org/545123 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/551070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36550 0039d316-1c4b-4281-b951-d872f2087c98
* Use buildtime to ensure stability statsjar@chromium.org2010-01-193-12/+26
| | | | | | | r=huanr Review URL: http://codereview.chromium.org/548058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36549 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the remaining UI of the gtk AutoFill dialog.jhawkins@chromium.org2010-01-191-16/+246
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/551065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36547 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactors BrowserActionButton to be within its own file, also breaking ↵andybons@chromium.org2010-01-195-228/+255
| | | | | | | | | | a circular dependency on BrowserActionsController. BUG=none TEST=none Review URL: http://codereview.chromium.org/543117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36545 0039d316-1c4b-4281-b951-d872f2087c98
* Port BrowserActionApiTest.BrowserActionPopup to linux.estade@chromium.org2010-01-198-28/+83
| | | | | | | | | | | Also make the test proprely wait for the EXTENSION_HOST_DID_STOP_LOADING signal. BUG=29710 TEST=compiles Review URL: http://codereview.chromium.org/515065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36544 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/545123jshin@chromium.org2010-01-192-12/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the linux perf build by checking the return value on write()zork@chromium.org2010-01-191-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/542116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36540 0039d316-1c4b-4281-b951-d872f2087c98
* Add an implementation of AddressWatchTask for linux.zork@chromium.org2010-01-191-2/+64
| | | | | | | | BUG=32429 TEST=none Review URL: http://codereview.chromium.org/545114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36539 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Re-add keypad accelerators for zoom level.estade@chromium.org2010-01-191-0/+3
| | | | | | | | | | | these got lost in the shuffle. BUG=32592 TEST=zoom with keypad +,-,0 Review URL: http://codereview.chromium.org/549087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36534 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Allow the tracking of the "active" plugin delegate separate from the ↵avi@chromium.org2010-01-191-4/+3
| | | | | | | | | | | fake windows. BUG=http://crbug.com/20717 TEST=none; no visible change Review URL: http://codereview.chromium.org/549085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36533 0039d316-1c4b-4281-b951-d872f2087c98
* The test was failing in chromeos build.oshima@chromium.org2010-01-191-2/+3
| | | | | | | | | | TBR=evan@chromium.org BUG=none TEST=PageMenuModelTest.Basics shoud pass . Review URL: http://codereview.chromium.org/542100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36532 0039d316-1c4b-4281-b951-d872f2087c98
* Escape the '&' character in the back/forward menu entries.estade@chromium.org2010-01-192-4/+11
| | | | | | | | | | | | BUG=17660 TEST=See 17660 for reproduction steps. patch by Aaron Kemp <kemp [at] chromium> original review: http://codereview.chromium.org/541053/show Review URL: http://codereview.chromium.org/542113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36530 0039d316-1c4b-4281-b951-d872f2087c98
* New headline for the inactive toast dialogcpu@chromium.org2010-01-191-1/+7
| | | | | | | | | | | - features extensions for US only installs. BUG=32474 TEST= see bug for details Review URL: http://codereview.chromium.org/553010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36529 0039d316-1c4b-4281-b951-d872f2087c98
* Make a MenuModel for the popup favicon menu. For now only GTK uses it. ↵estade@chromium.org2010-01-1910-496/+364
| | | | | | | | | | | | Consolidate all accelerators for browser commands into one place. BUG=28212,27535 TEST=1. enable custom frame and a popup window and test that the popup contains all the same (non-system) menu items as windows. 2. all context menus still display the correct shortcuts and the shortcuts work Review URL: http://codereview.chromium.org/551032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36527 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't repaint render view on focus events.estade@chromium.org2010-01-191-2/+2
| | | | | | | | | | | similar to http://codereview.chromium.org/546051 BUG=none TEST=gtkparasite Review URL: http://codereview.chromium.org/536066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36526 0039d316-1c4b-4281-b951-d872f2087c98
* Move constants related to chrome.tabs.executeScript() from the .cc file torogerta@chromium.org2010-01-193-12/+14
| | | | | | | | | | | the .h file with all the other chrome.tabs.* constants. BUG=none TEST=none Review URL: http://codereview.chromium.org/545119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36525 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: prepare to injectiong inspector script into the inspected context.yurys@chromium.org2010-01-191-1/+1
| | | | | | | | BUG=29068 Review URL: http://codereview.chromium.org/552033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error from 36513.aa@chromium.org2010-01-191-1/+1
| | | | | | | BUG=32361 TBR=tony@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36514 0039d316-1c4b-4281-b951-d872f2087c98
* Only create a desktop shortcut for apps if the user requests.aa@chromium.org2010-01-1913-36/+99
| | | | | | | | BUG=32361 Review URL: http://codereview.chromium.org/551052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36513 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetSupportedLanguages(), ActiveLanguage(), and DeactivateLanguage().satorux@chromium.org2010-01-192-3/+46
| | | | | | | | | | | | | These are wrappers for functions added in libcros http://git.chromium.org/cgi-bin/gitweb.cgi?p=cros.git;a=commit;h=adc84eae83d75cc6c2a59c89e5276d072ca69c8d TEST=none BUG=none Review URL: http://codereview.chromium.org/542108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more case where we could theoretically intall an extensionaa@chromium.org2010-01-191-1/+1
| | | | | | | | without a prompt. See also r36501. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a case where we could theoretically install an extension without prompt.aa@chromium.org2010-01-191-1/+1
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in -[CookiesWindowContrller loadTreeModelFromProfile] from r36497.rsesek@chromium.org2010-01-191-1/+3
| | | | | | | | | | TBR=jrg BUG=none TEST=Mac Valgrind unit_tests Review URL: http://codereview.chromium.org/552036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36500 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] If a user clears browsing data with the cookie manager open, update the UIrsesek@chromium.org2010-01-186-32/+147
| | | | | | | | | BUG=32030 TEST=See repro steps in bug report. Review URL: http://codereview.chromium.org/551058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36497 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the page contents message processing to the RenderViewHost.jcampan@chromium.org2010-01-188-23/+51
| | | | | | | | | | | | | | | | | | It was currently processed as a control message. This is an actual part of the previous CLD related CL: http://codereview.chromium.org/548057 It kept failing on the bots for some tests, I am not sure why yet and cannot repro locally. Hopefully splitting it will help pinpoint the issue. TEST=All unit-tests, ui tests should still work. Navigate to a page with some specific words in it, then go to the history tab and search for pages with these specific words. Make sure the page you navigated is shown in the results. TBR=brettw Review URL: http://codereview.chromium.org/553012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36490 0039d316-1c4b-4281-b951-d872f2087c98
* Change default congestion limit for DNS preresolutionjar@chromium.org2010-01-181-2/+2
| | | | | | | | | | | | | | UMA data suggests that a 500ms limit on queue duration (before assuming congestion) provides better user experience. This change sets 500ms as the default, and reduces the percentage of users that have other experimental values. BUG=3041,15479 r=eroman Review URL: http://codereview.chromium.org/543083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36489 0039d316-1c4b-4281-b951-d872f2087c98
* Add GMT restriction to buildtime calculationjar@chromium.org2010-01-181-1/+1
| | | | | | | | | Make sure the buildtime is interpretted the same in all time zones. r=dpranke Review URL: http://codereview.chromium.org/546067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36488 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to reduce chromeos dependency in chrome.oshima@chromium.org2010-01-1811-469/+635
| | | | | | | | | | | | | | | * renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager. * Added factory method to create chromeos specific tab/tabstrip and layoutmanagers. * Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36452 Review URL: http://codereview.chromium.org/543095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36485 0039d316-1c4b-4281-b951-d872f2087c98
* Moving sandbox_policy files into chrome/common .gregoryd@google.com2010-01-173-478/+1
| | | | | | | | | | In the next CL (http://codereview.chromium.org/542030/show) NaCl broker code will need to include sandbox_policy.h from chrome/nacl, and without this move check_deps test fails. TEST=none BUG=none Review URL: http://codereview.chromium.org/543042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36468 0039d316-1c4b-4281-b951-d872f2087c98
* Reuse the existing tab when opening the Manage Extensions page and the ↵finnur@chromium.org2010-01-161-10/+3
| | | | | | | | | | | | | | | | Options page for an extension. Thanks to Phistuck for pointing this out. Also, use IDS_MANAGE_EXTENSIONS for all locales on dev (it will get translated in the next run). BUG=None TEST=Use the extension context menu and Manage Extensions and Configure should not open new tabs if that tab already exists. Review URL: http://codereview.chromium.org/551056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36463 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactoring to reduce chromeos dependency in chrome."oshima@chromium.org2010-01-1611-629/+469
| | | | | | | | | | | | This reverts commit 8ae39b4c6290397c03661b59619e125f416a9af8. TBR=sky@chromium.org BUG=none TEST=interactive_ui_tests on windows should pass with revert. Review URL: http://codereview.chromium.org/542098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36461 0039d316-1c4b-4281-b951-d872f2087c98
* revert the revertoshima@chromium.org2010-01-161-2/+2
| | | | | | | | | | | | | | Revert "Revert "Revert part of r35312 now that ChromeOS is fixed."" This reverts commit 6717ffb85f34b1de756f9a703a68ab7ef8336651. TBR=evan@chromium.org BUG=none TEST=unit_tests should pass except for chromeos build. Review URL: http://codereview.chromium.org/553007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36455 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert part of r35312 now that ChromeOS is fixed."oshima@chromium.org2010-01-161-2/+2
| | | | | | | | | | | | This reverts commit 78422af7d04c5a0244677f8f80258ee1173ba0d3. TBR=evan@chromium.org BUG=none TEST=Basic in ui_tests should pass Review URL: http://codereview.chromium.org/548065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36453 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 00:56:53 +0000