| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
TYPE_APP_PANEL. Otherwise we won't use the app icon that
ChromeLauncherDelegate fetches.
BUG=122010
TEST=see bug
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10008026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
way if you're in a maximized window you don't get kicked out.
BUG=121197
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10006021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10007015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=asargent
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9968103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=118491
TEST=
Review URL: http://codereview.chromium.org/9969134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have "protected"
virtual destructors, not "public".
By having a public destructor, it becomes possible to stack
allocate the derived class. Stack allocating a RCTS is a
dangerous behaviour, since there may still be a caller who
holds a reference when the object goes out of scope.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9958145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9956089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error.
BUG=122198
TEST=
Review URL: https://chromiumcodereview.appspot.com/10012014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus
Add chromeos/dbus/DEPS
Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests
Add CHROMEOS_EXPORT to classes
Move power related proto targets to chromeos.gyp
Rewrite and sort #includes
BUG=119583
TEST=component chromeos build success, checkdeps success
Review URL: https://chromiumcodereview.appspot.com/9838085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates some link errors when trying to remove browser.cc from the build.
BUG=117407
TEST=
Review URL: http://codereview.chromium.org/9546036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the Chrome Official win builder.
BUG=none
TEST=none
TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10007029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10005018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117407
Review URL: http://codereview.chromium.org/9701006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method only deletes the history, the row's visit count will
be reset if the row's URL is bookmarked.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9963097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/9791010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dbeam@chromium.org
BUG=113202
TEST=none
NOTRY=true
Review URL: http://codereview.chromium.org/9949029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use NetworkPropertiesGValueCallback only in cros_network_functions.cc
Add mock chromeos_network functions
Move GValue/GHashTable related code to gvalue_util.cc
BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctionsTest.*"
Review URL: https://chromiumcodereview.appspot.com/9981020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122012
TEST=none
Review URL: http://codereview.chromium.org/10012016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will agin wait for the entire feed before we report anythi
BUG=chromium-os:28381
TEST=Manual: make sure that we show either entire content of /gdata source or wait until we completely read it.
Review URL: https://chromiumcodereview.appspot.com/10010013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=117407
TEST=
Review URL: http://codereview.chromium.org/9959116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9956124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=121574,89173
Review URL: https://chromiumcodereview.appspot.com/9949028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=121774
TEST=manual (ignored the returnExtensionsData function and observed no message)
Review URL: http://codereview.chromium.org/9993001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the gesture-recognizer into ui/base/ makes it possible to be used by both
aura and views independently. This is the first step: add an interface for
touch-events and gesture-events so that the gesture recognizer does not have to
depend on aura or views events.
BUG=121744
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9958136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=121377
TEST=Crash on shutdown should not cause the browser to restart.
Review URL: https://chromiumcodereview.appspot.com/9939020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows us to eliminate the TemplateURL NULL constructor, most public non-const TemplateURL functions, and most TemplateURL friend declarations.
This is also a necessary precursor to changing TemplateURLService's APIs to convert most "const TemplateURL*" cases to "TemplateURL*", which I'll explain once I actually make the change.
There is some awkwardness here around keywords, as keyword autogeneration requires a TemplateURL but the state bits are kept on TemplateURLData. This will go away in the future when I remove keyword autogeneration from TemplateURL entirely.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9982018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122219
TEST=NaClGdbTest.Empty
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10012020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=121373
TEST=See bug, comment 24.
Review URL: https://chromiumcodereview.appspot.com/9992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
message port would result in an inconsistent lazy keepalive count.
BUG=no
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9961020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Modifid the existing test
Review URL: http://codereview.chromium.org/9984002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for communicating with the debugd service and enable access
to use systrace methods.
[resubmit of http://codereview.chromium.org/9700073]
TBR=satorux, keybuk
BUG=chromium-os:27809
TEST=use new about:tracing support to collect system event data
Change-Id: I19ec73d8f3aaebe534ad319e9914e61ff2a67d20
Review URL: http://codereview.chromium.org/10012008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows users to add an '--enable-asynchronous-spellchecking' flag, which uses the Spelling service for spellchecking text in the background. (This change allows to enable this flag only on Chrome to measure the actual QPS precisely.)
BUG=107371
TEST=manual
Review URL: http://codereview.chromium.org/9956106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10008021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
regularly on win_rel trybots.
BUG=12278
TEST=ExtensionWebRequestApiTest.WebRequestBlocking
TBR=battre@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10005015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119351
TEST=WebIntentsRegistryTest.CollapseIntents,WebIntentsRegistryTest.GetIntentsCollapsesEquivalentIntents
Review URL: https://chromiumcodereview.appspot.com/9958099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
Also add ExtensionSytem::Get(Profile*) convenience wrapper.
BUG=no
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9977019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Android manages persistence of sessions separately in Java code.
BUG=117407
Review URL: http://codereview.chromium.org/9985002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I changed --nacl-gdb meaning on Linux. On Windows it means path to nacl-gdb,
but on linux it means path to nacl-gdb and options/wrappers. Options and paths
can not contain spaces on Linux.
BUG= 117010
TEST= browser_tests --gtest_filter=NaClGdb*
Review URL: http://codereview.chromium.org/9950055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=121173
TEST=Back/forward button popups should show correct titles and favicons after navigating in uber pages
NOTRY=true
Review URL: http://codereview.chromium.org/9959057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks dpapad@ for fixing the style nits in print_preview!
BUG=113202
TEST=none
NOTRY=true
Review URL: http://codereview.chromium.org/9966010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initial step required for implementing the processes extension API.
BUG=32302
TEST=none
Review URL: http://codereview.chromium.org/9959101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It times out regularly on the win_rel trybots.
BUG=122154
TEST=ExtensionResourceRequestPolicyTest.WebAccessibleResources
TBR=cdn@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10008011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch moves a model used by BrowserFrameWin near where it's really used,
and into a place that looks more appropriated, which is to frame/ directory,
near to system_menu_model_delegate.*.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9966007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dcheck (not finding an installer string in browser_tests binary) to the fact that we were registering the protocol handler with the OS. It happened on the bots but not locally because it needs Chrome to be running as an admin. I have no idea why this only crashes on my new test but not the existing one on the bots, since locally they both hit the assert when running as an admin.
Review URL: https://chromiumcodereview.appspot.com/9998002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tab to avoid the race condition where the previous encoding is seen.
BUG=122053
Review URL: https://chromiumcodereview.appspot.com/9997002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119751
TEST=PlatformAppBrowserTest.*
Review URL: http://codereview.chromium.org/9963019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119196
TEST=See issue for crash repro on a ChromeOS device. (Note: also should not crash running with --user-data-dir=/tmp/foo on Linux/Ash).
Review URL: https://chromiumcodereview.appspot.com/9980013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destructor if the control_widget_ is non-NULL. Close is async, so
without this the control_widget_ still has the
AppNonClientFrameViewAura as an observer and could later call back to
AppNonClientFrameViewAura.
BUG=121666
TEST=see bug
R=davemoore@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9995001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
win_rel trybots.
BUG=121540
TEST=ErrorPageTest.IFrameDNSError_GoBack*
TBR=mmenke@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9990010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrong password.
BUG=121410
TEST=Manual. Connect to captive portal network, enter incorrect password in user pod.
Review URL: https://chromiumcodereview.appspot.com/10006007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130932 0039d316-1c4b-4281-b951-d872f2087c98
|