| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG= 27393, 26744
TEST= promotional messages should show up on NTP.
Review URL: http://codereview.chromium.org/394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
git cl dcommit somehow committed all my local changes in cygwin
TBR=evan
BUG=none
Review URL: http://codereview.chromium.org/396006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25459
TEST=none
TBR=amit
Review URL: http://codereview.chromium.org/394004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
activating other windows post-close correctly.
BUG=27711
TEST=See repro steps in bug.
Review URL: http://codereview.chromium.org/385119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27706
TEST=see bug description
Review URL: http://codereview.chromium.org/385118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/397001
TBR=michael@chromium.org
Review URL: http://codereview.chromium.org/397004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/397001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=27216
Review URL: http://codereview.chromium.org/394017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifications, so that is is available by default in Windows.
Security review at http://b/issue?id=2161143
BUG=25975
TEST=none
Review URL: http://codereview.chromium.org/391064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27674
TEST=included
Review URL: http://codereview.chromium.org/386035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26869
TEST=Activate Kotoeri, smash keys, confirm that arrow keys move caret. Confirm that rest of IME still works (hah!).
Review URL: http://codereview.chromium.org/386032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't as slick as other platforms, in that the bubble
just slides down and gets cropped instead of sliding down out
of the browser window -- doing the latter will probably
require reparenting the bubble into its own window when we
want to move it.
BUG=18311
TEST=ran "nc -l -p 8080", went to localhost:8080, and made sure that the bubble ran away with both LTR and RTL languages
Review URL: http://codereview.chromium.org/392007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/391042
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dispatcher unit test.
This fixes a UMR in resource_dispatcher host.
Bug=27649
Review URL: http://codereview.chromium.org/395004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove |resetting_| from the safe browsing service, it doesn't do anything useful.
* Add appropriate locks in a few places in the database that were missing them.
* Prevent potential infinite recursion in the database at one spot.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place).
Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController).
Not yet implemented: morphing between the detached bar (on the NTP) and anything else.
BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate.
Review URL: http://codereview.chromium.org/384105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appearing.
Change to BookmarkBubble.xib was to make the window not show on creation.
It will have more mods to it because of switching to IB on Snow Leopard.
BUG=27464
TEST=Make the bookmark bubble appear and disappear by clicking on the star.
Review URL: http://codereview.chromium.org/389027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the given group).
Refactored PreferencesWindowController a bit.
Made preferences_window_controller_unittest.mm use CocoaTest instead of CocoaTestHelper and reenabled disabled test which was crashing (likely due to interactions with CocoaTestHelper).
BUG=23073
TEST=manually,trybots
Review URL: http://codereview.chromium.org/391050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync_setup_wizard.cc
so that we can append the language code as a CGI parameter based on the locale.
BUG=26385
TEST=Make sure links on the sync login dialog open pages in the same language as the browser language.
Review URL: http://codereview.chromium.org/385103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
small one.
BUG=http://crbug.com/27652
TEST=With two monitors of different vertical sizes connected, make a chrome window on the larger monitor, as tall as the monitor. Drag it over to the smaller monitor and drop it. The window should not re-layout weirdly during the drag and should continue to have a tab strip after the drop.
Review URL: http://codereview.chromium.org/385106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes http://codereview.chromium.org/394008 which restores
interactive tests for devtools.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/386029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/395010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu is shown)
This also makes the chevron throb when no bookmarks is added during a sync and merge.
BUG=24306
TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible.
Patch by Bruno Calvignac<BrunoCalvignac@gmail.com>
Original Review: http://codereview.chromium.org/306054/show
Review URL: http://codereview.chromium.org/395005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the extensions API is not supported in content scripts for security
purposes. Instead the typical pattern is to use messaging between content
scripts and a background page which executes them on behalf of the script.
This is not immediately obvious to many extension developers, so this
change adds an error message to help them better understand what's going on.
BUG=26128
TEST=Try writing a content script that uses some of the extensions API stuff
in chrome.tabs, chrome.windows, etc. You should see errors in the console
telling you that it isn't supported in content scripts.
Review URL: http://codereview.chromium.org/366024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally submitted as:
http://codereview.chromium.org/386021
Reverted with:
http://codereview.chromium.org/384100
This new version only creates the tracking regions (and the associated
notifications) if the mouse is actually in the tab strip. Hoping this should
improve our startup performance.
BUG=27458, 13208, 21448
TEST=Create a pile of tabs.
Select a middle one.
Put your cursor in some other tab.
Hit cmd-w a couple of times
Watch to make sure highlights occur correctly in both the tabs and the
close buttons.
Review URL: http://codereview.chromium.org/385102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
everywhere.
BUG=27163
Review URL: http://codereview.chromium.org/384108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture, not arbitrary script.
Experimental fix for UI test, so checking in flaky at first to see if I have it...
BUG=27215
TEST=included
Committed as r31839... and reverted.
Review URL: http://codereview.chromium.org/387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome periodically reads the content of a well-know file,
and parses it into name-value pairs, each representing a
Chrome OS metrics event. The events are then logged using
the normal UMA mechanism. The file is then truncated to
zero size. Chrome uses flock() to synchronize accesses
to the file.
BUG=none
TEST=compiled and run Linux and Chrome OS versions.
Verified that uploaded Chrome OS events appear in about:histograms.
Also external_metrics_unittest.cc tests the collection of metrics
messages from the well-known file.
patch written by semenzato_google.com
original code review: http://codereview.chromium.org/378013
(plus http://codereview.chromium.org/346041)
Review URL: http://codereview.chromium.org/394010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when we follow a redirect, because WebKit's
MainResourceLoader::willSendRequest method may change the "first party for
cookies" URL of the resource request.
R=abarth
BUG=25133
TEST=In Options menu, change cookie policy to "Accept cookies only from
sites I visit" and then follow the instructions in issue 25133 comment 20.
Review URL: http://codereview.chromium.org/385024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* |database_loaded_| was entirely unnecessary. The only ways in which checking it differed from checking |database_| were that it took longer to be set, and if true it meant that ProtocolManager::Initialize() had been called. Erik and I determined that ProtocolManager::Initialize() was safe to call irrespective of whether the database had finished loading, and that this didn't add additional network burden in the case of a corrupt/unavailable database (especially since in those cases |database_loaded_| would still have been set true).
* |resetting_| can be set to false on the db thread, saving a little bit of code (due to a reorg) and allowing callers to proceed immediately when they happen to call the IO thread before the db thread calls back to it after finishing a reset.
I also made CheckUrl() queue the request when |database_| is NULL instead of just dropping it. This seems more correct given that |database_| is guaranteed to eventually become non-NULL, so this means we won't skip checking requests that happen right during startup. I am a bit concerned that this means we may slow startup by delaying all the network requests until the safe browsing DB spins up. Feedback desired.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/384110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tooltips.
BUG=25349
TEST=Browser test added.
Review URL: http://codereview.chromium.org/385096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a node *after* disassocating from the maps.
BUG=27580
Review URL: http://codereview.chromium.org/391056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a malware interstitial, the location bar would be empty (instead of showing
the malware URL).
This happens because when the second interstitial is shown,
TabContents::GetDOMUIForCurrentState() thinks the current DOMUI is the NTP
one, and therefore does not show the URL.
Instead of messing with the complicated logic of GetDOMUIForCurrentState(),
I made us always show the URL for interstitial, as it should be the case.
BUG=26082
TEST=See bug steps. Also make sure navigating to SLL and malware interstitial
works as expected and that the right URL is displayed everytime. Test
that clickicng Continue/Revert as well as navigating from an interstitial
works and that the right URL is displayed.
Review URL: http://codereview.chromium.org/384013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caught by purify.
BUG=27649
TEST=n/a
TBR=ananta
Review URL: http://codereview.chromium.org/387050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/385100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in chron's CL to avoid merge.
Review URL: http://codereview.chromium.org/393011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
expression isn't being used, something else is wrong.
Revert 31914 - Disable ChromeThreadTest.NotReleasedIfTargetThreadNonExistent until suppression is added.
BUG=27630
TEST=n/a
TBR=scherkus
Review URL: http://codereview.chromium.org/385095
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/384124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Std.Denis.
http://crbug.com/27291
TEST=Open fonts and languages dialog box and click OK. Should not crash.
Review URL: http://codereview.chromium.org/384123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead only expose base::ProcessHandle. Precursor to moving process startup off the UI thread.
Review URL: http://codereview.chromium.org/387047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/391045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26900
TEST=Go to http://www/~thakis/cgi-bin/test.html . Test that two sheets show up (the first expects "u" as user and no pass, the other "v" and no pass). The first sheet appears immediately, the second after 2 seconds. Try entering u for the first faster than 2 seconds and switch tabs, when coming back to the original tab, the 2nd sheet should wait for you. Try closing the window and the tab while a sheet is showing, both when the tab with the sheet is in the background and in the foreground.
Review URL: http://codereview.chromium.org/384113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27630
TEST=n/a
TBR=nick
Review URL: http://codereview.chromium.org/393012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31917 0039d316-1c4b-4281-b951-d872f2087c98
|