summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Implement Printer Preference Persistence (Step 1/3)maruel@chromium.org2009-04-093-3/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce new "Preferences" for printer overlays were added in PrefNames: - printing.page.header.left - printing.page.header.center - printing.page.header.right - printing.page.footer.left - printing.page.footer.center - printing.page.footer.right The prefs file will look like this: "printing": { "page": { "header": { "left": " ", "center": " ", "right": " " }, "footer": { "left": "{date}", "center": " ", "right": " " } } } The steps for Printer Preferences: Step 1: Introduce some sort of persistence for header/footer which is located in the Preference file. Step 2: Allow PrinterQuery to read those stored preferences and setup PrinterSettings so that it will apply it when printing. Step 3: Create a UI for the print preference, so that the users will easily change those printing settings. NOTE: I tested the following approach while doing a simple Hack with PrintJob (if you see the previous patch), and it works great, with some bad after effect. It was done for testing purposes. So I hope we are going in the right direction. BUG=947 (http://crbug.com/947) Patch contributed by Mohamed Mansour <m0.interactive@gmail.com> Review: http://codereview.chromium.org/60118/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13426 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Cache resources before attach, hide agents behind the flag.pfeldman@chromium.org2009-04-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/65010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13423 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13419.pfeldman@chromium.org2009-04-091-1/+0
| | | | | | Review URL: http://codereview.chromium.org/65008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13421 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Cache resource metainfo even when debugger agent is not attached.pfeldman@chromium.org2009-04-091-0/+1
| | | | | | | | - Cache 200 resources - Hide agent functionality behind the flag Review URL: http://codereview.chromium.org/62183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13419 0039d316-1c4b-4281-b951-d872f2087c98
* Move to custom painting the omnibox results with GDK.deanm@chromium.org2009-04-092-51/+168
| | | | | | | | | | | | | | | | | | | | - Don't draw with ChromeCanvas, we will have better text layout by using Pango directly, and better remote X performance by not blitting a bitmap. - Text is draw with Pango on top of GDK (no Cairo inbetween). - Double buffered server side, and just a few GDK operations for rects. - Improve our handling of InvalidateLine / PaintUpdatesNow. We previously always invalidated the entire window. We now communicate with the model the way we should, and only invalidate damaged lines, and then do a sync paint in PaintUpdatesNow to repaint them. This is a small step backwards, because we are no longer showing the description text. This easy to fix, but I'm going to try to implement the entire new results look and icons at the same time. Review URL: http://codereview.chromium.org/63119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13413 0039d316-1c4b-4281-b951-d872f2087c98
* Implement stop/go button for Linux.willchan@chromium.org2009-04-0910-40/+447
| | | | | | | | | | | | | Refactored code out of CustomDrawButton into CustomDrawButtonBase to be shared with GoButtonGtk. Replaced the existing non-togglable go button with GoButtonGtk. Note that tooltip support isn't done yet, as it changes based on the state of the location bar and the go/stop state. Add a simple test. Fix some minor lint errors. BUG=9381 Review URL: http://codereview.chromium.org/62154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13409 0039d316-1c4b-4281-b951-d872f2087c98
* Check that the ExtensionFunction has a callback for attempting to send a ↵rafaelw@chromium.org2009-04-091-1/+3
| | | | | | | | response. Review URL: http://codereview.chromium.org/63130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13406 0039d316-1c4b-4281-b951-d872f2087c98
* Add an insert tab animation for the Linux tabstrip.jhawkins@chromium.org2009-04-092-2/+264
| | | | | | Review URL: http://codereview.chromium.org/62170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13402 0039d316-1c4b-4281-b951-d872f2087c98
* linux: offset toolbar graphic so tabs merge in properly.evan@chromium.org2009-04-093-6/+7
| | | | | | Review URL: http://codereview.chromium.org/63148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13401 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in ChromeURLRequestContext. I read the code wrong; weaa@chromium.org2009-04-092-10/+2
| | | | | | | | always want to delete the cache instance. Review URL: http://codereview.chromium.org/63138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13399 0039d316-1c4b-4281-b951-d872f2087c98
* When a DOMUI dialog contains HTML with a select or a text-field which would ↵jcampan@chromium.org2009-04-091-1/+2
| | | | | | | | | | have auto-fill, bringing the popup crashes the browser. This is because the WebContentView may not have a delegate. BUG=None TEST=Requires code change, adding a select or a text-field to the Gears dialog for example. Review URL: http://codereview.chromium.org/63146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13398 0039d316-1c4b-4281-b951-d872f2087c98
* Copy text selection from renderer to browser every time it changes.estade@chromium.org2009-04-095-107/+9
| | | | | | | BUG=9848 Review URL: http://codereview.chromium.org/63145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a missing #include in the mac source.thestig@chromium.org2009-04-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/62169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13395 0039d316-1c4b-4281-b951-d872f2087c98
* Scaffolding cleanup.thestig@chromium.org2009-04-084-0/+7
| | | | | | Review URL: http://codereview.chromium.org/63142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13394 0039d316-1c4b-4281-b951-d872f2087c98
* Distributor logo and " - App Name" shouldn't be shown on app frame windows.ben@chromium.org2009-04-085-5/+25
| | | | | | | | http://crbug.com/6138 Review URL: http://codereview.chromium.org/62167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13393 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Hook up confirm info bar buttons. Session restore works.estade@chromium.org2009-04-081-2/+30
| | | | | | Review URL: http://codereview.chromium.org/62163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13390 0039d316-1c4b-4281-b951-d872f2087c98
* When the Find bar has focus it eats keypresses such as PageUp, PageDown and ↵finnur@chromium.org2009-04-0822-64/+112
| | | | | | | | | | | | | | | Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar. This patch forwards those selected keypresses to the page for its perusal. Known issues: Just like Firefox, the page doesn't scroll if it has frames. SONG=I like to fixit fixit. I like to fixit fixit. BUG=7079 TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F. Review URL: http://codereview.chromium.org/62129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13389 0039d316-1c4b-4281-b951-d872f2087c98
* Properly handle empty components when converting url_parse::Parsed object.estade@chromium.org2009-04-082-0/+4
| | | | | | | | | | Add a unittest for the below bug. BUG=9859 Review URL: http://codereview.chromium.org/62162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13388 0039d316-1c4b-4281-b951-d872f2087c98
* Implement mouse input handling for the close button in the Linux tabstrip.jhawkins@chromium.org2009-04-086-18/+131
| | | | | | Review URL: http://codereview.chromium.org/63136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13382 0039d316-1c4b-4281-b951-d872f2087c98
* Use histogram in AudioRendererHost to measure IPC audio latencyhclam@chromium.org2009-04-081-2/+17
| | | | | | | | Measure ICP audio latency using histogram. Review URL: http://codereview.chromium.org/63128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13378 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more unneeded scaffolding.thestig@chromium.org2009-04-0813-70/+13
| | | | | | Review URL: http://codereview.chromium.org/63129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13376 0039d316-1c4b-4281-b951-d872f2087c98
* Add aa's Event class to our javascript bindings and use it in our extensionmpcomplete@google.com2009-04-081-0/+1
| | | | | | | message passing API. Review URL: http://codereview.chromium.org/62069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13371 0039d316-1c4b-4281-b951-d872f2087c98
* Try one more time to check in http://codereview.chromium.org/60112aa@chromium.org2009-04-0810-122/+234
| | | | | | | | | | | | Added this test to the list of skipped purify tests as it is experience the same issue as ExtensionView test. I also found an unrelated memory leak and created a patch separately: http://codereview.chromium.org/63073 Review URL: http://codereview.chromium.org/63075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13369 0039d316-1c4b-4281-b951-d872f2087c98
* linux: temporarily disable a test due to flakiness.evan@chromium.org2009-04-081-0/+5
| | | | | | | | | | Relevant bugs have been filed. TBR=tony Review URL: http://codereview.chromium.org/64001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13367 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure the previous/next button don't get focused when clicked.jcampan@chromium.org2009-04-081-0/+5
| | | | | | | | | | We keep the button focusable so they can be tab traversed. BUG=9772 TEST=See bug Review URL: http://codereview.chromium.org/62144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13364 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix errors found during dogfooding.pfeldman@chromium.org2009-04-081-1/+2
| | | | | | Review URL: http://codereview.chromium.org/62152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13362 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 7337, where a file of mime type "text/x-registry" with extension ↵sidchat@google.com2009-04-082-1/+10
| | | | | | | | | "reg" was getting saved with extension "download" instead. Issue=7337 Review URL: http://codereview.chromium.org/58007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13361 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse wheel redirection when omnibox has focusamit@chromium.org2009-04-082-0/+13
| | | | | | | | | | | | | | Since focus manager subclass now no longer handlers mouse wheel redirection, handle WM_MOUSEWHEEL in autocomplete_edit_view_win and give other windows chance to handle mouse wheel. Bug 9647 Review URL: http://codereview.chromium.org/63061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13360 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix crash that I don't fully understand and can't repro :(pkasting@chromium.org2009-04-081-2/+13
| | | | | | | BUG=8933 Review URL: http://codereview.chromium.org/63085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13357 0039d316-1c4b-4281-b951-d872f2087c98
* Enable a bunch of ui tests on Mac.pinkerton@chromium.org2009-04-083-6/+6
| | | | | | Review URL: http://codereview.chromium.org/63122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove our only use of dynamic_cast, which is not needed.deanm@chromium.org2009-04-081-1/+1
| | | | | | | | | | | We don't want to ever use RTTI. This was casting a WebContents to a TabContents, which is a simple and safe upcase, since WebContents derives from TabContents. It should have just been a static_cast. Review URL: http://codereview.chromium.org/62147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13350 0039d316-1c4b-4281-b951-d872f2087c98
* Added restore and add tab to the system menu so that these operationsidanan@chromium.org2009-04-081-3/+12
| | | | | | | | | | can be done from there. BUG=2144 Review URL: http://codereview.chromium.org/62113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13348 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tab model observer for cocoa into a separate class so it can be ↵pinkerton@chromium.org2009-04-086-106/+212
| | | | | | | | re-used. Mark tab as visible when switching to it so tabs loaded in the background work. Review URL: http://codereview.chromium.org/63087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13346 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 12739, 12740, and 12741 because we're going to fix Issue 7448 purely ↵abarth@chromium.org2009-04-083-18/+0
| | | | | | in WebKit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13343 0039d316-1c4b-4281-b951-d872f2087c98
* Move location bar bridge out of tab_contents_controller.shess@chromium.org2009-04-085-75/+146
| | | | | | | | | | [So that I don't keep getting conflicts as I work to finish the omnibox change http://codereview.chromium.org/50074 ] Review URL: http://codereview.chromium.org/63096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13342 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for omnibox crash.estade@chromium.org2009-04-083-4/+60
| | | | | | | | BUG=9760 Review URL: http://codereview.chromium.org/63095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13340 0039d316-1c4b-4281-b951-d872f2087c98
* DNS prefetch experiment extension: Consider different connection count limitsjar@chromium.org2009-04-081-5/+19
| | | | | | | | | | | | This CL both enables selection of a run-time selected limit on the number of connections to a single host, and varies that limit to see how it relates to DNS prefetch latency in connections. r=wtc Review URL: http://codereview.chromium.org/62083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13339 0039d316-1c4b-4281-b951-d872f2087c98
* Stuff needed for alert info bars.estade@chromium.org2009-04-081-16/+4
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/63111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13336 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't crash on alert infobars.evan@chromium.org2009-04-081-6/+1
| | | | | | | | | | estade didn't sufficiently test his change. Luckily, the fix is trivial. TBR=estade Review URL: http://codereview.chromium.org/62138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13334 0039d316-1c4b-4281-b951-d872f2087c98
* posix: implement AutomationWindowTracker.evan@chromium.org2009-04-083-16/+37
| | | | | | Review URL: http://codereview.chromium.org/62135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13331 0039d316-1c4b-4281-b951-d872f2087c98
* More info bar implementation.estade@chromium.org2009-04-082-16/+101
| | | | | | Review URL: http://codereview.chromium.org/62136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13329 0039d316-1c4b-4281-b951-d872f2087c98
* Support the new popup and new window dispositions in the external tab ↵ananta@chromium.org2009-04-084-2/+34
| | | | | | | | | | | | | | | | container. Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently for the external tab container probably due to multiple WM_DESTROY messages received for the container, when the parent window is destroyed. Fixes bug http://b/issue?id=1747547 Bug=1747547 Review URL: http://codereview.chromium.org/63074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on tab closure. We now use our own model data and check that ↵jhawkins@chromium.org2009-04-081-4/+5
| | | | | | | | | the hovering index is not out of bounds. BUG=9803 Review URL: http://codereview.chromium.org/62133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13325 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement the bookmark bar to use a GtkToolbar.erg@google.com2009-04-082-29/+294
| | | | | | | | | | Add all bookmark buttons to a GtkToolbar. All bookmark buttons are draggable, though we don't accept drops yet since I still need to figure out how to communicate with the model. Review URL: http://codereview.chromium.org/63099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13322 0039d316-1c4b-4281-b951-d872f2087c98
* hclam: picked you for this review based on the revision log of ↵aa@chromium.org2009-04-083-6/+32
| | | | | | | | | | | | | | ChromeURLRequestContext, but feel free to redirect if there is someone better. Fix leak of media_request_context_. This is kind of a nasty fix though. I think that ChromeURLRequestContext needs to be refactored more, but not sure exactly how right now. If you don't like this fix, I won't feel bad nuking it and letting someone working on this area handle it. Review URL: http://codereview.chromium.org/63073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13320 0039d316-1c4b-4281-b951-d872f2087c98
* Greatly reduce the race window in ProcessSingletoncpu@google.com2009-04-081-8/+14
| | | | | | | | | | | - fix only for windows - Anantha has a good test to be commited RSN BUG=9593 Review URL: http://codereview.chromium.org/57082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13313 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton setup for new Automated UI test framework.huanr@chromium.org2009-04-081-12/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add automated_ui_test_base.{cc,h} that defines an AutomatedUITestBase class. This class can be used for both UI test suites and automated UI test running on ChromeBot. - Add automated_ui_test_test and include it in UI test suite so we can individually test all commands provided in AutomatedUITestBase. - Change AutomatedUITest to be a subclass of AutomatedUITestBase. Move RunCommandAsync(), RunCommand(), and NewTab() from AutomatedUITest to AutomatedUITestBase. The plan is moving all individual UI command functions (after they are converted to sync mode) to AutomatedUITestBase so they can be shared by UI test suites and automated UI test. - In automation_provider.cc, add a mapping mechanism from command to notification type. This will make it easy to add more command types. Review URL: http://codereview.chromium.org/56190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13312 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused database code.paulg@google.com2009-04-082-33/+0
| | | | | | | | | The new storage system doesn't check URLs on the DB thread any longer, so this code is never called. Review URL: http://codereview.chromium.org/62110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the findbar crash.tc@google.com2009-04-078-42/+40
| | | | | | | | | | | | | | | | FindBarController is no longer owned by the BrowserWindow, it is owned by Browser. So we can remove the FindBarController code in BrowserWindowGtk. Also, go ahead and implement BrowserWindow::CreateFindBar (which creates the gtk widget and adds it to the gtk widget hierarchy) and enable the code on linux. Since the widgets are created and added to the hierarchy later, we attach the signals after the widgets have been "realized". Review URL: http://codereview.chromium.org/62126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13310 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebDragData in WebView and WebViewDelegate.darin@chromium.org2009-04-071-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | I also cleaned up some of the WebView and WebViewDelegate methods to pass WebPoint instead of pairs of ints or gfx::Point. With this change, I am keeping webkit/glue/webdropdata.{h,cc}, which is what Chrome uses to pass around the equivalent data. Now, it is possible to construct a WebDropData from a WebKit::WebDragData and to also get a WebKit::WebDragData from a WebDropData. Hence, the conversion between WebDropData and ChromiumDataObject (see clipboard_conversion.{h,cc}) is now removed in favor of conversion between WebDropData and WebKit::WebDragData. Conversion between WebKit::WebDragData and WebCore::ChromiumDataObject is very cheap (just reference counting). Finally, this change also brings in WebData, which is now used by the return value of WebKitClient::loadResource. As a companion to that change, I also changed webkit_glue::GetDataResource to return StringPiece instead of std::string. That also saves on an unnecessary buffer copy. R=dglazkov Review URL: http://codereview.chromium.org/63084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13305 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 11:45:03 +0000