summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Entries in a form get recorded when the user submits the form. Database and ↵petersont@google.com2008-11-087-57/+98
| | | | | | | | pop-up menu talk to each other. Pop-up menu appears containing suggestions. Review URL: http://codereview.chromium.org/9462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
* * Create unique event in global namespacekuchhal@chromium.org2008-11-081-9/+3
| | | | | | | | so that we can detect Chrome instances across user sessions. Review URL: http://codereview.chromium.org/10234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5057 0039d316-1c4b-4281-b951-d872f2087c98
* Add history/history_publisher.cc and history/history_indexer.idl.sgk@google.com2008-11-081-0/+6
| | | | | | Review URL: http://codereview.chromium.org/9719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome\browser\autofill_manager.cc andsgk@google.com2008-11-081-0/+2
| | | | | | | chrome\browser\net\referrer.cc to the SCons build (on Windows). Review URL: http://codereview.chromium.org/9710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
* Roll this change back until I understand the crashes.ben@chromium.org2008-11-083-149/+58
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
* Removed lint problems. NO funcationality changes.brg@chromium.com2008-11-073-73/+71
| | | | | | Review URL: http://codereview.chromium.org/10219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
* We have a crash caused by view_ being NULL here.nsylvain@chromium.org2008-11-071-1/+1
| | | | | | | | | | | | | | Everywhere else in this class we look to see if view_ is NULL before dereferencing it, except in this case. This would fix a crash found in the distributed tests. BUG: 1074508 Review URL: http://codereview.chromium.org/9674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
* Update the SafeBrowsing protocol version to 2.2, which handlespaulg@google.com2008-11-071-3/+3
| | | | | | | | | | | - Zero sized chunks - Redirect URL format changes http://crbug.com/3418 Review URL: http://codereview.chromium.org/10222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
* Looks like a size method got left behind in the gfx update. Also make sure ↵glen@chromium.org2008-11-072-8/+17
| | | | | | | | | | | | that we only restore the page info window position, but not the size. Plus some dead code removal in options_window_view. BUG=3509 Review URL: http://codereview.chromium.org/10218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in building filter string for open dialog that resulted insky@google.com2008-11-071-1/+2
| | | | | | | | | | | | showing garbage in files types combobox. BUG=4211 TEST=bring up bookmark manager, click on import, click on 'files of type' and make sure you only see *.html. Review URL: http://codereview.chromium.org/10225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this again as I cannot reproduce the perf regression locally.jcampan@chromium.org2008-11-0713-19/+86
| | | | | | | | | | | Will investigate on the bot. TBR=nsylvain Review URL: http://codereview.chromium.org/9700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomationProvider::WindowSimulateDrag use SendInput instead of sending ↵ben@chromium.org2008-11-073-58/+149
| | | | | | | | | | | messages directly to the targeted window. http://crbug.com/4067 Review URL: http://codereview.chromium.org/9485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5014 0039d316-1c4b-4281-b951-d872f2087c98
* Updates one of the unit tests I disabled when I rewrote the popup blocker UI.erg@google.com2008-11-071-14/+61
| | | | | | Review URL: http://codereview.chromium.org/10206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5005 0039d316-1c4b-4281-b951-d872f2087c98
* Fix initialization order to fix Mac & Linux.brettw@google.com2008-11-071-2/+2
| | | | | | Review URL: http://codereview.chromium.org/10209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5003 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new interface IChromeHistoryIndexer which needs to be implemented bybrettw@google.com2008-11-0716-63/+447
| | | | | | | | | | | indexers which are interested in indexing Chrome's web history. These should register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and this is be used by Chrome to publish its index. Added code to publish the index too. Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5002 0039d316-1c4b-4281-b951-d872f2087c98
* Adds cut/copy/paste support to the bookmark manager tree/table andsky@google.com2008-11-077-5/+228
| | | | | | | | | | | | context menus. BUG=4186 TEST=try cut/copy/paste from table/tree in the bookmark manager as well as context menus in bookmark manager. Review URL: http://codereview.chromium.org/9481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in the icon manager. The decoding could be NULL, which would then getbrettw@google.com2008-11-073-2/+12
| | | | | | | | | | | dereferenced in specific cases. We would have to create the failed icon twice, so that it would think the icon was already in the cache, when in fact a NULL value was being cached. BUG=1259695 Review URL: http://codereview.chromium.org/9672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4988 0039d316-1c4b-4281-b951-d872f2087c98
* Adds import/export of bookmarks to bookmarks.html file.sky@google.com2008-11-0722-137/+1026
| | | | | | | | | | | | BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Review URL: http://codereview.chromium.org/9471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
* Potential fix for FF importing issuecpu@google.com2008-11-072-3/+6
| | | | | | | | | | | | | | | - Select the highest FF version, not just the the HCKU one. - I don't have a repro case, it is a blind fix Seems like leftovers of old FF installs in HCKU are tripping us, that is my guess, now we would find FF3 in HKLM. BUG=3109 Review URL: http://codereview.chromium.org/9675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4960 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the new mechanism we are going to use for handling Chromium updateskuchhal@chromium.org2008-11-072-8/+26
| | | | | | | | | | | | | | | | | | | | while it is in use. This should work for per user as well as system level installs (after some additional changes once Google Update changes are ready). The following scenarios should work now: - If Chromium is using two different profiles at the same time we do not switch chrome executables until all of them are closed. - The old version of Chromium can be run after a restart if the renaming of executables fails. - We will not use environment variable any more but we need to keep it until all the users get this change on their machines. - opv/rename registry keys and new_chrome.exe should always together. If one exist all three should exist because they are created and deleted as one atomic operation (as much as possible given laws of physics). BUG=1463346 Review URL: http://codereview.chromium.org/9436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4949 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher would happen if you donwload an exe and the download has completed ↵jcampan@chromium.org2008-11-072-2/+8
| | | | | | | | | | | | | by the time the download item is created, you have the download tab opened and you press on the discard button. This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer. We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item. BUG=4134 TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt. Review URL: http://codereview.chromium.org/9435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4940 0039d316-1c4b-4281-b951-d872f2087c98
* Continue with crosssite navigations if alerts are suppressedojan@google.com2008-11-075-6/+21
| | | | | | | in an unload handler (i.e. we have an infinite-ish alert loop). Review URL: http://codereview.chromium.org/9477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4935 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent window.close() working from Javascript when a blocked popup ↵erg@google.com2008-11-073-2/+15
| | | | | | | | | notification exists. This is a copy of Firefox's behaviour. BUG=crbug.com/4007 Review URL: http://codereview.chromium.org/9656 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4934 0039d316-1c4b-4281-b951-d872f2087c98
* Adaptively identify URL subresources and pre-resolve hosts via DNSjar@google.com2008-11-0611-157/+625
| | | | | | | | | | | | | | | | | | | | Use the HTTP "referer" header to identify subresources used during a page load. Store that info, and use it when next visiting the referenced hosts to pre-resolve the (probably) needed subresources. This set of changes will surely evolve as we see how it plays out on broader distribution (via histogram measurments), but this should be the foundation of the change. In design specs, this was previously referred to as "adaptive correlated DNS prefetching." r=mbelshe Review URL: http://codereview.chromium.org/9168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4929 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function for eliding filenames to a set pixel width while preserving ↵glen@chromium.org2008-11-0614-57/+38
| | | | | | | | the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208 Review URL: http://codereview.chromium.org/9613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the autofill popu CL as it creates perf regression.jcampan@chromium.org2008-11-0613-86/+19
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/9460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
* Enable unload UI tests again, but don't run them for single-process.ojan@google.com2008-11-061-4/+21
| | | | | | Review URL: http://codereview.chromium.org/9464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
* Changes parameters used by IME code to fix several issues caused by Japanese ↵hbono@chromium.org2008-11-068-30/+44
| | | | | | | | | | | | | | IMEs. Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect. Also, this change fixes cursor positions for Japanese IMEs. BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition" BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window." BUG=2775 "IME: Caret is always displayed at the last of IME composition." Review URL: http://codereview.chromium.org/7385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Large Font issues in About box (issue 2458).finnur@google.com2008-11-062-23/+63
| | | | | | Review URL: http://codereview.chromium.org/9432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4870 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar Importer Pass2brg@chromium.com2008-11-0612-259/+774
| | | | | | | | | | | | | Implements the following features 1. Toolbar import always available after first run 2. Deduping of imported favorites 3. Removes attempt to import favicons (not supported through Toolbar UI atm) 4. Always the user to cancel from the UI safely 5. Unittests for parsing (TODO Better UI for login) Review URL: http://codereview.chromium.org/9414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
* Disable new tests that are failing on buildbot.ojan@google.com2008-11-061-4/+4
| | | | | | Review URL: http://codereview.chromium.org/9446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4861 0039d316-1c4b-4281-b951-d872f2087c98
* Bandaid patch so that we continue with crosssite navigations instead of ↵ojan@google.com2008-11-068-24/+180
| | | | | | | | | | | | | | | closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions. There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run? Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO. Can I get help from a mac person on adding the UI test to the xcode project? BUG=3198 Review URL: http://codereview.chromium.org/8920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate CursorChromium's dependency on webkit/glue.darin@chromium.org2008-11-062-21/+19
| | | | | | | | | | | Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge. The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner. R=iyengar,eseidel Review URL: http://codereview.chromium.org/9072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace typo fix from CL 8722agl@chromium.org2008-11-051-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/9611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4839 0039d316-1c4b-4281-b951-d872f2087c98
* Add two UMA histograms for DNS prefetchingjar@google.com2008-11-051-2/+2
| | | | | | | | | | | I have a more complex change list, and wanted to be able to carefully constrast the before-and-after impact. r=mbelshe Review URL: http://codereview.chromium.org/9166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4833 0039d316-1c4b-4281-b951-d872f2087c98
* Quick and easy fix for vista taskbar auto hide issueamit@chromium.org2008-11-052-10/+67
| | | | | | | | | | | | | | | | | | | | | | In vista we designate the main frame border as a part of non-client area. This is similar to a popup window having resizing border. The default logic to maximize such a window, stretches the borders outside of the screen and the client area occupies the entire work area. As a result windows taskbar treats it as a 'full screen' application and hides itself in an auto-hide mode. An XP-like fix for this, that is to reduce client area vertically by one pixel, would most likely involve overriding WM_SYSCOMMAND of SC_MAXIMIZE. Hence, this is a cheap, although a bit ugly fix in WM_GETMINMAXINFO handling. BUG=20 Review URL: http://codereview.chromium.org/9305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4825 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when getting strings out of the database. column_text is a ↵brettw@google.com2008-11-052-3/+3
| | | | | | | | | little dangerous because it can return NULL. Most STL string stuff can't handle this. I changed the uses to column_string() which handles NULL properly and generates STL strings for us. BUG=3770 Review URL: http://codereview.chromium.org/9189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4811 0039d316-1c4b-4281-b951-d872f2087c98
* Added functions to WebDatabase and WebDataService for recording frequent ↵petersont@google.com2008-11-0512-6/+558
| | | | | | | | entries in text input elements in forms. Also added the class AutofillManager which gets instantiated once per WebContents and provides an API from which the database can be easily accessed to provide a list of possible desired values to be entered in a text field given what the user has already typed there. Review URL: http://codereview.chromium.org/8845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4809 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back. Sigh. Still not fixed.ben@chromium.org2008-11-052-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4808 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds the autofill UI in forms.jcampan@chromium.org2008-11-0513-23/+88
| | | | | | | | | | | | When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup. Listeners are set on the form text field in a similar fashion than for password save. The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows. The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown. Review URL: http://codereview.chromium.org/8885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
* Reinstate this commented-out code now the root cause of the problem has been ↵ben@chromium.org2008-11-052-4/+2
| | | | | | fixed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4803 0039d316-1c4b-4281-b951-d872f2087c98
* Some bandaids for tab dragging UI tests:ben@chromium.org2008-11-052-3/+8
| | | | | | | | | | | | | | - automation provider was moving mouse pointer to position in client coords, not screen coords as required. - TabStrip was allowing drags to occur in invalid conditions. This doesn't completely fix the underlying broken-ness of the SimulateDrag function, however I've not yet been able to get a version of it using SendInput working. http://crbug.com/4067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4802 0039d316-1c4b-4281-b951-d872f2087c98
* This is r4523, with a few changes to make things work under Vista.erg@google.com2008-11-0526-1233/+770
| | | | | | | | | | | | | - Explicitly set_delegate(NULL) before releasing a TabContents. (I think the order messages are getting handled is different from XP; this only seems neccessary under Vista.) - r4523 and someone elses change added entries to theme_resources.rc at roughly the same time, causing happy fun crashes. - Roll in sgk's SConscript fix. Review URL: http://codereview.chromium.org/9373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
* New batch of dlls to evict from the render process (top crashers).rvargas@google.com2008-11-051-43/+60
| | | | | | Review URL: http://codereview.chromium.org/9376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4797 0039d316-1c4b-4281-b951-d872f2087c98
* When a windowless plugin is hanging, the browser processnsylvain@chromium.org2008-11-051-4/+0
| | | | | | | | | | | | | | | | | | | | | | | is also hanging because of the "dummy activation window". Unfortunately we used to skip the hung plugin notification dialog for this window. I'm changing this behavior to display it even for this window. We don't know what plugin it is, so we just display "an unknown plugin", but this is better than nothing. This is a potential fix for 3383. I do not expect to completely fix 3383 with it, but it should help minimize the problem. bug:3383 Review URL: http://codereview.chromium.org/9386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4792 0039d316-1c4b-4281-b951-d872f2087c98
* Make the test "pass" when the internal data is not found.maruel@chromium.org2008-11-051-0/+8
| | | | | | Review URL: http://codereview.chromium.org/9416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4788 0039d316-1c4b-4281-b951-d872f2087c98
* Add to SCons build:sgk@google.com2008-11-051-1/+3
| | | | | | | | | chrome\browser\bookmarks\bookmark_drop_info.cc chrome\browser\importer\toolbar_importer.cc chrome\views\view_constants.cc Review URL: http://codereview.chromium.org/9387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4782 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bookmark manager bugs:sky@google.com2008-11-054-11/+39
| | | | | | | | | | | | | | . Pressing enter when more than one folder is selected opens them all. . Show in folder is only enabled when it makes sense: you've selected a bookmark in the table and the table is showing recently bookmarked or search results. BUG=4034 4044 TEST=see bugs Review URL: http://codereview.chromium.org/9367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the user that HTML documents can harm their computer because they can. abarth@chromium.org2008-11-052-3/+10
| | | | | | | | | | | This patch blocks all the extensions that we register. R=nsylvain BUG=1463961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4769 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate save_file.cc from the Windows-specific list.sgk@google.com2008-11-051-1/+0
| | | | | | Review URL: http://codereview.chromium.org/9153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4728 0039d316-1c4b-4281-b951-d872f2087c98