summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Hopefully final attempt at landing ↵joth@chromium.org2010-02-081-0/+396
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Adds tests for network geolocation provider. In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38354 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 34343: "Tab to search" hint on omnibox disappears on drag dropped tab.suzhe@chromium.org2010-02-081-0/+3
| | | | | | | | | BUG=34343 TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there. Review URL: http://codereview.chromium.org/576013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38347 0039d316-1c4b-4281-b951-d872f2087c98
* Move candidate_window from third_party/chromeos_text_input to ↵satorux@chromium.org2010-02-082-0/+977
| | | | | | | | | | | | | | | | | | | chrome/browser/chromeos/text_input. Turned out there is no benefit of having this in a separate git repository. No code change in candidate_window.cc, but modified the copyright notice from Chromium OS Authors to Chromium Authors. Slightly modified text_input.gyp to make it compile. We'll also change cros_deps/DEPS in a separate CL. BUG=none TEST=confirmed candidate_window compiles as before. Review URL: http://codereview.chromium.org/579026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38345 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Animation::CurrentValueBetween and gets rid of a bunch ofsky@chromium.org2010-02-075-85/+55
| | | | | | | | | | | duplicate code. BUG=none TEST=none Review URL: http://codereview.chromium.org/570055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38323 - Add IPv6 probing support, and disable IPv6 resolution when it ↵jar@chromium.org2010-02-071-13/+1
| | | | | | | | | | | | | | | | | | is useless I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution. I've also added histograms and A/B test support to evaluate the impact of this change. r=wtc,eroman Review URL: http://codereview.chromium.org/579010 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/582011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38327 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPv6 probing support, and disable IPv6 resolution when it is uselessjar@chromium.org2010-02-071-1/+13
| | | | | | | | | | | | | I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution. I've also added histograms and A/B test support to evaluate the impact of this change. r=wtc,eroman Review URL: http://codereview.chromium.org/579010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38323 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38316 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS Bustage: Use string16 instead of wstring.ben@chromium.org2010-02-065-6/+6
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/573048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38313 0039d316-1c4b-4281-b951-d872f2087c98
* Make basic side tabs actually appear.ben@chromium.org2010-02-069-13/+264
| | | | | | | | | http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/572041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38307 - Test to see if IPv6 can be disabled: Will roll back ASAPjar@chromium.org2010-02-061-1/+1
| | | | | | | | | | | | | This tests to see what happens if the command line option disables IPv6. I will roll back as soon as the builders start. TBR=eroman Review URL: http://codereview.chromium.org/579022 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/579023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38308 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if IPv6 can be disabled: Will roll back ASAPjar@chromium.org2010-02-061-1/+1
| | | | | | | | | | This tests to see what happens if the command line option disables IPv6. I will roll back as soon as the builders start. TBR=eroman Review URL: http://codereview.chromium.org/579022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38307 0039d316-1c4b-4281-b951-d872f2087c98
* Rework nonclient hittest plumbing so the NonClientFrameView is responsible ↵pkasting@chromium.org2010-02-064-10/+21
| | | | | | | | | | for the whole window's hit testing. Make use of this in the glass frame to add support for HTSYSMENU. Doing this in the opaque frame will be more complex, so that's coming next. BUG=6961 TEST=Single- and double-clicks on the upper left corner of a Chrome window in Aero glass mode should trigger the system menu and the window closing, respectively. Review URL: http://codereview.chromium.org/573042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38301 0039d316-1c4b-4281-b951-d872f2087c98
* Change how the opaque frame lays out its titlebar. This takes advantage of ↵pkasting@chromium.org2010-02-062-113/+76
| | | | | | | | | | | | a system metric I didn't know about to both simplify the code and correctly handle (by which I mean "lay out more like a native window") the case when the user's theme has a large titlebar height but not a large titlebar font. Doing this makes icon layout simpler and more native, which will help when trying to modify hittesting to return HTSYSMENU. BUG=none TEST=In Classic mode, setting the Active Title Bar height larger and then running Chrome should cause popup and app windows' icons to scale up like native windows' icons do. Review URL: http://codereview.chromium.org/573040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38300 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix use-after-free when dragging tabs with page-actions.shess@chromium.org2010-02-064-24/+35
| | | | | | | | | | | | | | | | | | | When dragging and dropping a tab who's window is going away entirely, the LocationBarViewMac instance and the PageActionViewList w/in go away before the cell. Sometimes windows can re-display while being closed, then BANG. Converted page_action_view_list_ from a pointer because it didn't seem to need to be one anywhere. Also plug leak of views_ elements. BUG=34110 TEST=Install an extension which shows a page action (*). Bring up two tabs, drag one with the page action off to a separate window. Drag it back into the first window. (*) For instance, the "Subscribe in Feed Reader" example at http://code.google.com/chrome/extensions/samples.html , then browse to Google News to get a page action. Review URL: http://codereview.chromium.org/577028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38299 0039d316-1c4b-4281-b951-d872f2087c98
* Pass login-manager switch value to login wizard to determine which screen toavayvod@chromium.org2010-02-067-100/+203
| | | | | | | | | | | | | start with. Refactored LoginObserver to ScreenObserver that could be used by other screens as well. BUG=34716 TEST=Currently there just should be no regression for Chrome based login manager. Review URL: http://codereview.chromium.org/574014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38297 0039d316-1c4b-4281-b951-d872f2087c98
* Delete HTML5 database in BrowsingDataRemover, part 1.jochen@chromium.org2010-02-063-3/+63
| | | | | | | | | | | This part deletes databases except for when they're currently used by a renderer. BUG=34633 TEST=open the webkit html5 database demo, create some notes. close the tab. clear browsing data. open the demo again. notes should be gone. Review URL: http://codereview.chromium.org/570032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38296 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flaky unit testhclam@chromium.org2010-02-061-1/+1
| | | | | | | | | | | | | This test is flaky and is disabled: Win32WifiDataProviderTest.StartThreadViaDeviceDataProvider BUG=34832 TEST=none TBR=joth Review URL: http://codereview.chromium.org/577036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38290 0039d316-1c4b-4281-b951-d872f2087c98
* Makes mini-tabs work on the UI side (at least for views). I still havesky@chromium.org2010-02-0617-433/+473
| | | | | | | | | | | a handful of things to resolve before I turn on pinning. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
* Implement copy/paste of bookmarks for macfeldstein@chromium.org2010-02-065-18/+265
| | | | | | | | | | | Implements Copy, paste, and can paste as extension apis for use in the extension bookmark manager. BUG=33461 TEST=Copy and paste single and multiple bookmarks in the extension bookmark manager, and between it safari's bookmark manager and plain text fields. Review URL: http://codereview.chromium.org/562010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where reloading an extension from an infobar when another window ↵andybons@chromium.org2010-02-061-5/+6
| | | | | | | | | | | does not have that infobar open but has another crashed extension's infobar hoses the browser. Phew. BUG=34683 TEST=follow repro steps in bug. should not crash. Review URL: http://codereview.chromium.org/572045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38285 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the AutoFillManager as an observer of the PersonalDataManager in the ↵jhawkins@chromium.org2010-02-061-0/+1
| | | | | | | | | | constructor. In rare circumtances, the user can close the browser (and shutdown the AutoFillManager) after we've set ourselves as observers of the PersonalDataManager and before the PersonalDataManager has called us back. BUG=none TEST=none Review URL: http://codereview.chromium.org/579013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38284 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-063-12/+49
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't let omnibox popup text tighten while resizing.shess@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | | | | Sets the tightening factor to 0.0 so that the popup text doesn't tighten then rebound after being elided. BUG=24296 TEST=Get the omnibox popup up, resize the window smaller, all the left-hand-side text which stays should be rendered in a stable position (right-hand-side text may shift as LHS text is elided, but the spacing between characters should stay the same). Review URL: http://codereview.chromium.org/577029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert debugging crud I added while trying to track down bug 31719.erg@chromium.org2010-02-053-105/+16
| | | | | | | | | | | | Revert "Speculative fix for the windows theme crasher." (r36036) Revert "More debugging statements to try to track down BrowserThemePack crash." (r37259). BUG=31719 TEST=none Review URL: http://codereview.chromium.org/573036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38279 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] o Adds a slight drop shadow to the drawn images within Browser Action ↵andybons@chromium.org2010-02-057-25/+88
| | | | | | | | | | | | | buttons. o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later. o Alters Toolbar.xib to use the new view class instead of a plain NSView. TEST=none BUG=none Review URL: http://codereview.chromium.org/565048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
* Added Star button to compact navigation mode.avayvod@chromium.org2010-02-0511-195/+202
| | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star icon works. Review URL: http://codereview.chromium.org/577026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38273 0039d316-1c4b-4281-b951-d872f2087c98
* Check for the existance of a profile manager. Might not exist during early ↵jochen@chromium.org2010-02-051-0/+7
| | | | | | | | | | | shutdown. BUG=34652 TEST=Execute chrome. Run chrome --uninstall. Should not crash. Review URL: http://codereview.chromium.org/572043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38269 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored out JS specific part of modal dialog stack into its own class, ↵zelidrag@chromium.org2010-02-0527-713/+1178
| | | | | | | | | | | exposed cookie/storage prompt as a modal dialog. BUG=32719 TEST=none, requires Darin to hook this with his code. Review URL: http://codereview.chromium.org/560030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38268 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-0522-49/+54
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Make open tab items check item.oshima@chromium.org2010-02-051-6/+6
| | | | | | | | | | | and fixed comment in simple_menu_model.h BUG=chromium-os:1217 TEST=none Review URL: http://codereview.chromium.org/575012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38263 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix tab strip width calculation for RTLestade@chromium.org2010-02-051-1/+4
| | | | | | | | | BUG=34763 TEST=see bug Review URL: http://codereview.chromium.org/579006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38258 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Toggle set-above property on bookmark bar event box when showing it.estade@chromium.org2010-02-051-9/+16
| | | | | | | | | | | BUG=34564 TEST=In both normal theme mode and gtk theme mode, a) doesn't regress 33220 b) floating bookmark bar accepts input Review URL: http://codereview.chromium.org/577005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38257 0039d316-1c4b-4281-b951-d872f2087c98
* 1st step to implement notification panel for chromeososhima@chromium.org2010-02-056-0/+548
| | | | | | | | | | | | | | - re-using views implementation, but removed layout related code - add NotificationPanel - added SetSize in BalloonViewHost. I needed this because I removed animation code and NativeViewHostGtk doesn't know about render view. I need to think a bit more to find out how to deal wit this. It's using existing balloon collection, but we may need one for chromeos (or may not). BUG=33306 TEST=none Review URL: http://codereview.chromium.org/572018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38255 0039d316-1c4b-4281-b951-d872f2087c98
* Page Info dialog button HIG fixes.mattm@chromium.org2010-02-051-9/+4
| | | | | | | | | | | | | | All: Remove ellipses from IDS_PAGEINFO_CERT_INFO_BUTTON, as it does not require further action to display the info. Add use_titlecase version. Linux: Place button in the primary area instead of secondary to match HIG (I guess). BUG=34425 TEST=read Gnome HIG (and MSDN "Command Buttons" guidelines), open Page Info for some page, compare Review URL: http://codereview.chromium.org/561079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38251 0039d316-1c4b-4281-b951-d872f2087c98
* When clearing browsing data modified since a certain time, do not delete ↵jochen@chromium.org2010-02-055-15/+30
| | | | | | | | | | | | | extension data. You can use the cookie tree model to really delete all data. BUG=34598 TEST=install an extension that uses local storage, delete browsing data, check that the extension data still exist. Review URL: http://codereview.chromium.org/573030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38248 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement the new content blocking address bar bubbles on Linux.erg@chromium.org2010-02-056-3/+498
| | | | | | | | | BUG=33314 TEST=none Review URL: http://codereview.chromium.org/573023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38246 0039d316-1c4b-4281-b951-d872f2087c98
* Added validation for non-emptiness of the label.georgey@chromium.org2010-02-052-1/+55
| | | | | | | | TEST=If any label (in address or credit card) is empty, the save button is disabled. Otherwise it is enabled. BUG=33026 Review URL: http://codereview.chromium.org/575027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38245 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the HostResolver::Shutdown() method.eroman@chromium.org2010-02-051-2/+5
| | | | | | | | | | | While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl. Hopefully in the future HostResolver will not be refcounted so this can go away altogether. BUG=18373 Review URL: http://codereview.chromium.org/569035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38243 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when a theme specifies a non-existant image.erg@chromium.org2010-02-054-6/+31
| | | | | | | | | | | Fixes the current TopCrasher. BUG=31719 TEST=BrowserThemePackTest.TestNonExistantImages Review URL: http://codereview.chromium.org/572039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38242 0039d316-1c4b-4281-b951-d872f2087c98
* skia is absolute coords for rectsdavemoore@chromium.org2010-02-053-125/+226
| | | | | | Review URL: http://codereview.chromium.org/575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38240 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension API test to catch cookie regressions.mpcomplete@chromium.org2010-02-051-0/+4
| | | | | | | | BUG=34649 Review URL: http://codereview.chromium.org/573032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38239 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tab strip model changes. I'm hoping this is the last ofsky@chromium.org2010-02-058-79/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it. I'm now going with: // . Mini-tab. Mini tabs are locked to the left side of the tab strip and // rendered differently (small tabs with only a favicon). The model makes // sure all mini-tabs are at the beginning of the tab strip. For example, // if a non-mini tab is added it is forced to be with non-mini tabs. Requests // to move tabs outside the range of the tab type are ignored. For example, // a request to move a mini-tab after non-mini-tabs is ignored. // You'll notice there is no explcit api for making a tab a mini-tab, rather // there are two tab types that are implicitly mini-tabs: // . App. Corresponds to an extension that wants an app tab. App tabs are // identified by TabContents::is_app(). // . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed. // Non-app tabs whose pinned state is changed are moved to be with other // mini-tabs or non-mini tabs. I'm going with a more neutral name like mini-tabs so that we can change the meaning if we need to without changing around all the UI code. I'll convert the UI code next. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/570043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
* Tab strip model: Fix an off by one error where we do not check the first tab.thestig@chromium.org2010-02-051-15/+10
| | | | | | | | BUG=33323 TEST=see bug Review URL: http://codereview.chromium.org/561066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38234 0039d316-1c4b-4281-b951-d872f2087c98
* Don't need ipc_message.h any morecmasone@google.com2010-02-052-16/+0
| | | | | | Review URL: http://codereview.chromium.org/577025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds support for displaying Chrome InfoBars in pages rendered via ↵ananta@chromium.org2010-02-056-26/+88
| | | | | | | | | | | | | | | | | | ChromeFrame. To achieve this the ExternalTabContainer now creates a view which comprises of the InfoBarContainer and the TabContentsContainer view. It uses the GridLayout manager to layout this view. The InfoBarContainer no longer depends on the BrowserView. It now passes notifications to the InfoBarContainerDelegate interface which is implemented by the BrowserView and the ExternalTabContainer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24051 Bug=24051 Review URL: http://codereview.chromium.org/573022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in LocationBarView when browser is closed with page action ↵mirandac@chromium.org2010-02-054-19/+31
| | | | | | | | | | install bubble showing. BUG= 34282 TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever. Review URL: http://codereview.chromium.org/561028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38225 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-057-25/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Makes example.com resolve to localhost for test.sky@chromium.org2010-02-051-0/+2
| | | | | | | | | | BUG=32845 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/573029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38215 0039d316-1c4b-4281-b951-d872f2087c98
* Split out of reverted change ↵joth@chromium.org2010-02-053-13/+23
| | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Commit fixes to code under test, whilst tests themselves are still pending. BUG=http://crbug.com/11246 TEST=see http://codereview.chromium.org/578006 Review URL: http://codereview.chromium.org/571014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38213 0039d316-1c4b-4281-b951-d872f2087c98