summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Adjust the plus button offset to match Windows more.avi@google.com2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/46042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11652 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-1317-9/+8
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11642.finnur@chromium.org2009-03-131-2/+2
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11648 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownership error with GtkTextTagTable and GtkTextTag.deanm@chromium.org2009-03-131-3/+2
| | | | | | | | | | | | | | | When we create with gtk_text_buffer_create_tag: """ The returned tag is owned by the buffer's tag table, so the ref count will be equal to one. """ We do not own the tags, only the table. Review URL: http://codereview.chromium.org/46044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11647 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11641.finnur@chromium.org2009-03-132-5/+0
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11646 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11640.finnur@chromium.org2009-03-1314-300/+79
| | | | | | Reverting for now. Will try again later git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-133-22/+47
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a couple of UI tests while I investigate.finnur@chromium.org2009-03-131-2/+2
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/46040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11642 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing function to LocationBarViewGtk.finnur@chromium.org2009-03-132-0/+5
| | | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/46038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11641 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1)finnur@chromium.org2009-03-1314-79/+300
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for ↵xji@chromium.org2009-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | RTL languages on "Bookmark Manager" (http://crbug.com/8684) The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. The fix is to pass the correct canvas text alignment when DrawStringWithHalo(). Test: 1. Run Hebrew Chrome 2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog 3. Select "Search" 4. Observe Without the fix: Text "Enter a query in the text field above to search your bookmarks" is left aligned With the fix: The above text is right aligned Hebrew Review URL: http://codereview.chromium.org/43146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a change made to try and make purify errors go away now that Erik Kay ↵pkasting@chromium.org2009-03-131-5/+2
| | | | | | | | has disabled purify runs for the relevant tests. Review URL: http://codereview.chromium.org/42162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutocompleteEditViewGtk's resources and widgets.deanm@chromium.org2009-03-131-0/+19
| | | | | | | Review URL: http://codereview.chromium.org/46034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when with chrome-ui://about/" or anything invalidamit@chromium.org2009-03-131-4/+4
| | | | | | | | | | | | If DOMUIContents::InitCurrentUI returns true then current_ui_ should always be valid. Changed logic inside to make sure that this is the case. Review URL: http://codereview.chromium.org/46009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes.maruel@chromium.org2009-03-132-2/+0
| | | | | | Review URL: http://codereview.chromium.org/43091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some browser shutdown issues on Linux.deanm@chromium.org2009-03-132-8/+27
| | | | | | | | | | | | | The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away). This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire. BUG=8712 Review URL: http://codereview.chromium.org/43135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
* Call into the IM hooks from the Linux Omnibox keyboard handling.deanm@chromium.org2009-03-131-14/+28
| | | | | | | | | This should give input methods the proper chance to handle enter and escape. Review URL: http://codereview.chromium.org/43149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded platform_thread.h includes. Reduces number of includes from ↵thestig@chromium.org2009-03-131-1/+0
| | | | | | | | 598 to 511. Review URL: http://codereview.chromium.org/42165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak visited site information from original profile to OTR profile.abarth@chromium.org2009-03-131-1/+3
| | | | | | | | | BUG=8388 R=brettw Review URL: http://codereview.chromium.org/42114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11613 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for repositioning/resizing a tab window. This is needed as the ↵ananta@chromium.org2009-03-132-0/+29
| | | | | | | | | | SetWindowPos call can fail on Vista if the caller is running under low IL. Review URL: http://codereview.chromium.org/42150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the gears in renderer process code. This allows me to do some ↵jam@chromium.org2009-03-134-72/+15
| | | | | | | | cleanup in how resource dispatching happens in a future cl. Review URL: http://codereview.chromium.org/42158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-127-11/+207
| | | | | | | | Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-1215-16/+1
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-1213-9/+11
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'inspect element' crash when hosted in external tabamit@chromium.org2009-03-121-5/+6
| | | | | | | | | | | | | | If chrome tab is hosted in an external tab and 'inspect element' is invoked via GUI (as opposed to sending an automation request for AutomationMsg_InspectElement), we get a crash in AutomationProvider::ReceivedInspectElementResponse BUG=1694650 Review URL: http://codereview.chromium.org/43102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on subview ordering to be equivalent to tab ordering. Allows us ↵pinkerton@chromium.org2009-03-123-44/+71
| | | | | | | | to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image. Review URL: http://codereview.chromium.org/43144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionRestoreUITest.TwoTabsSecondSelected in single process mode.jam@chromium.org2009-03-121-13/+12
| | | | | | | | This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it. The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call. So since we generate the in-process 'pid', I do it in the constructor instead of in Init. Review URL: http://codereview.chromium.org/42144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11571 0039d316-1c4b-4281-b951-d872f2087c98
* Run ExtensionViewTest in single-process mode to try to make it less flaky.mpcomplete@google.com2009-03-121-0/+3
| | | | | | | | Changed InProcessBrowserTest to restore the original CommandLine after it tears down. Review URL: http://codereview.chromium.org/42084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11568 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11566 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11565 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-253/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11564 0039d316-1c4b-4281-b951-d872f2087c98
* Make Widget return a gfx::NativeView instead of a HWND.ben@chromium.org2009-03-1240-118/+381
| | | | | | Review URL: http://codereview.chromium.org/43124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code for showing bookmarks menus into a standalone classsky@google.com2009-03-128-384/+569
| | | | | | | | | | | | | | | that isn't tied to the bookmark bar. Removes some dead code from the bookmark bar, and fixes a UMR in chrome_menu that I found when running under purify. There isn't any behavior change in this patch. BUG=none TEST=this is a large refactoring of how bookmark menus are shown. Please thoroughly test menus on the bookmark bar to make sure I didn't screw anything up. Review URL: http://codereview.chromium.org/42128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
* Make toggling fullscreen mode on/off significantly less janky-looking by ↵pkasting@chromium.org2009-03-125-16/+69
| | | | | | | | means of various crazy hacks. Review URL: http://codereview.chromium.org/42106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build. we need to include basictypes.h to gettc@google.com2009-03-121-0/+1
| | | | | | | | | | | DISALLOW_COPY_AND_ASSIGN TBR=finnur Review URL: http://codereview.chromium.org/43140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
* Some work in refactoring FindBarWin/FindBarView sotc@google.com2009-03-1214-216/+467
| | | | | | | | | | | we can share code across platforms. See http://code.google.com/p/chromium/wiki/FindBarRefactoring for more information about the design. Review URL: http://codereview.chromium.org/42057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-126-42/+221
| | | | | | | | Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
* Have RenderWidgetHostViewGtk take ownership of its widget.deanm@chromium.org2009-03-121-0/+5
| | | | | | | | | | | We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy(). BUG=8707 Review URL: http://codereview.chromium.org/42119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11530 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup the escape key on Linux Omnibox to revert to the permanent text (like ↵deanm@chromium.org2009-03-121-2/+7
| | | | | | | | | | | Windows). BUG=8236 Review URL: http://codereview.chromium.org/42074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Linux Omnibox bug where a widget was used after it was destroyed.deanm@chromium.org2009-03-121-0/+4
| | | | | | | Review URL: http://codereview.chromium.org/42073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
* Better keyboard and mouse handling in Omnibox:deanm@chromium.org2009-03-122-33/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Grab enter key events before they get to GtkTextView. We need to do this, otherwise enter when text is selected will replace the text, and we won't get a chance to catch that happening. This might have problems with IME, but it should be straightforward to fix anything IME related. - Don't deselect when we lose focus. This sometimes looks a bit strange, but it's the GTK thing to do. This also unbreaks copy and paste via the context menu, since popping up the context menu makes the GtkTextView lose focus. - Rewrite the inefficent newline eater. This should now only be needed for newlines that didn't come from the keyboard (like when you paste text). Use the builtin iter support for finding line boundaries, hopefully more efficient than checking the characters one by one. Still might have some bad behavior when pasting a ton of newline characters, but that can be improved later. This fixes inline autocomplete, you can now hit the enter key on an inline autocompleted suggestion, and you will get the intented navigation, instead of the navigation with the selected completion removed. This also adds support for alt-enter in Omnibox to navigate in a new tab. BUG=8236 Review URL: http://codereview.chromium.org/43072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-123-7/+10
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug were sorting bookmarks wouldn't trigger a save.sky@google.com2009-03-121-0/+3
| | | | | | | | | BUG=8655 TEST=see bug Review URL: http://codereview.chromium.org/42103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11513 0039d316-1c4b-4281-b951-d872f2087c98
* Stop having renderers use both pids and a monotonically increasing ↵jam@chromium.org2009-03-1225-200/+193
| | | | | | | | "host_id". This allows ResourceDispatcher to be used by child processes other than renderers. I've done minor related cleanup on the way to make the code simpler. Review URL: http://codereview.chromium.org/42054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11509 0039d316-1c4b-4281-b951-d872f2087c98
* Make fullscreen exit bubble link work by preventing the bubble from ever ↵pkasting@chromium.org2009-03-122-5/+25
| | | | | | | | | being activated. Not sure why this worked in the first place and then regressed. BUG=8318 Review URL: http://codereview.chromium.org/43107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11503 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes of googleurl/src/url_parse.h and url_canon.h.thestig@chromium.org2009-03-123-3/+3
| | | | | | Review URL: http://codereview.chromium.org/42102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11502 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the storing/restoring of the focus from TabContents to ↵jcampan@chromium.org2009-03-1217-125/+182
| | | | | | | | | | | | WebContentsView. This makes TabContents less dependent on views. This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically. BUG=None TEST=Run the interactive tests. Review URL: http://codereview.chromium.org/39269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
* Bring over more code from cole to improve the appearance of tabs. Start ↵pinkerton@chromium.org2009-03-111-106/+132
| | | | | | | | building parts of GTM that are needed for theming. Review URL: http://codereview.chromium.org/42081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11482 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building of browser/debugger/debugger_{contents,shell}.cc on Linux.sgk@google.com2009-03-111-0/+20
| | | | | | | | | This required getting rid of the stubs in common/temp_scaffolding_stubs.cc to avoid duplicate symbols, in favor of moving the stubs into a separate module for use when porting to new platforms. Review URL: http://codereview.chromium.org/43089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11477 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11467.mpcomplete@google.com2009-03-111-3/+0
| | | | | | Review URL: http://codereview.chromium.org/43093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11471 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-12 18:06:04 +0000