| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland Disallow chrome.tabs.executeScript from injecting code into gallery
TBR=aa
BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066
Original review: http://codereview.chromium.org/501098/
Review URL: http://codereview.chromium.org/518005
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/515025
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check permissions for chrome.tabs.executeScript() in the renderer
Original Review: http://codereview.chromium.org/509032
TBR=aa
Review URL: http://codereview.chromium.org/515023
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29538
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.
Review URL: http://codereview.chromium.org/520001
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/515020
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin.
R=aa,darin
Review URL: http://codereview.chromium.org/421005
TBR=tangjie@chromium.org
Review URL: http://codereview.chromium.org/518013
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't inject content scripts into incognito browsers
BUG=21392
original review: http://codereview.chromium.org/502079
Review URL: http://codereview.chromium.org/517007
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r34203 | evan@chromium.org | 2009-12-09 15:53:18 -0800 (Wed, 09 Dec 2009) | 5 lines
extensions: Properly use string16 for Unicode text.
BUG=29850
Review URL: http://codereview.chromium.org/477011
TBR=evan
Review URL: http://codereview.chromium.org/504076
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/501136
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapt Chrome to use KeystoneRegistration 1.0.7.1306. Use "tag path" and "tag
key" to direct Keystone to use a tag stored in the application as opposed to
in its ticket.
BUG=30730
TEST= - ksadmin --print-ticket --productid com.google.Chrome should show
tagPath pointing to GC.app/Contents/Info.plist, and
tagKey of KSChannelID;
- ksadmin --print-tag --productid com.google.Chrome should show the
value of the KSChannelID key in GC.app/Contents/Info.plist;
this should be the tag that is used for autoupdates
The above steps should be validated after the following operations:
- launching Chrome when on a user ticket,
- promoting Chrome from a user ticket to a system ticket, and
- when a Chrome update is applied (using this version of
keystone_install.sh) when on either a user or a system ticket.
The tagPath and tagKey will NOT be set when launching Chrome on a
system (promoted) ticket, but they WILL be set when the ticket is
initially promoted and also when an update is applied using this version
of keystone_install.sh.
Review URL: http://codereview.chromium.org/506061
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/505055
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions and Page Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/501130
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
simple_menu_model.h was moved after we branched. It looks fixing the include should do the trick.
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501119
TBR=arv@chromium.org
Review URL: http://codereview.chromium.org/502082
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501121
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/501129
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW has nonASCII characters.
BUG=30736
TEST=Open chrome with lang=sr and try to pack extension. It shouldn't crash, and files with be generated.
Review URL: http://codereview.chromium.org/503051
TBR=cira@chromium.org
Review URL: http://codereview.chromium.org/503061
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch exempts nontheme extensions (extensions not downloaded from theme minigallery) from showing the arrow download animation.
BUG=29632
TEST=Install extension from the gallery. No download arrow should be shown. Install theme from https://tools.google.com/chrome/intl/en/themes/index.html. Download arrow should be shown. Download random other stuff > download arrow should be shown.
Review URL: http://codereview.chromium.org/504031
TBR=rafaelw@chromium.org, aa@chromium.org
Review URL: http://codereview.chromium.org/504062
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501121
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
simple_menu_model.h was moved after we branched. It looks fixing the include should do the trick.
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501119
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r34925 | estade@chromium.org | 2009-12-17 18:39:47 -0800 (Thu, 17 Dec 2009) | 10 lines
gtk: Browser action dragging fixes
1) fix crasher triggered any time a drag from a different source hovers over the browser action bar.
2) fix graphical issue where changes to the ordering could possibly take a few seconds to propagate to other browser windows.
BUG=30639
TEST=a) drag a bookmark over the browser action toolbar, don't crash
b) open two windows. drag a browser action around, keep holding left mouse button and drag to a distant part of the screen, then rele
ase. The positional change should instantly take effect in the second browser window.
Review URL: http://codereview.chromium.org/506065
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/501117
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
downstream vendor name, etc.).
Also reformat the Mac/Win version strings as per comments in
http://codereview.chromium.org/506007.
Review URL: http://codereview.chromium.org/506016
TBR=mmoss@google.com
Review URL: http://codereview.chromium.org/502062
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
location.
Add channel info to about:version.
Linux about box work not done.
Linux channel determination code still a stub.
BUG=30444
How to verify:
on both Mac and Win, with a branded build:
confirm the About Box and about:version have channel info after the version number.
Channel for PC comes from the registry so it'll be the channel of your official install, not this build.
Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined.
Review URL: http://codereview.chromium.org/506007
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/501095
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch changes the behavior of the LOADING dialog such that it is only shown for extension downloads from the minigallery (theme) url. Note that this means that themes from the chrome extensions gallery will also NOT have the dialog shown.
BUG=29628
TEST=Install an theme from https://tools.google.com/chrome/intl/pt/themes/index.html. The gray LOADING dialog should appear. Install extension or theme from chrome.google.com/extensions. No LOADING dialog should appear
Review URL: http://codereview.chromium.org/507016
TBR=rafaelw@chromium.org,aa@chromium.org
Review URL: http://codereview.chromium.org/505037
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If javascript code puts custom toJSON functions on Array.prototype, our
extension API code detects malformed requests and kills the offending renderer.
Also, the browser can crash if a browser action popup process dies (for various
reasons, including this json serialization problem).
BUG=29283
TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update().
Before this change, the popup bubble will crash, and when you click away, crash the browser too.
Review URL: http://codereview.chromium.org/466065
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/506044
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split extension renderer crashes out of the existing UMA renderer crash metric
into its own metric.
Add a new metric for the sum of all ChildProcessHost crashes.
Add histograms for each crash type.
BUG=28022
TEST=We should start getting more crash reports in UMA and histograms.
Review URL: http://codereview.chromium.org/468005
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/501064
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cancel button.
Add padding to throbber.
Fix merge and sync cutoff.
BUG=27770, 29767, 29788, 29782, 29647
TEST=manually checked all languages,
Review URL: http://codereview.chromium.org/460123
TBR=chron@google.com
Review URL: http://codereview.chromium.org/500028
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the OSX complement to http://src.chromium.org/viewvc/chrome?view=rev&revision=32853
BUG=b/2168147
TEST=extension autoupdate should still work on MacOS
Review URL: http://codereview.chromium.org/431033
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/506006
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also enable the task_manager_browsertest.cc (where I added the new test) on Linux.
TEST=Covered by browser_tests.
BUG=21635
Review URL: http://codereview.chromium.org/465007
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/491072
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks and is already synched.
BUG= 28795
TEST= sync bookmarks with promo; then try to sync again by clicking on promo. message should appear.
Review URL: http://codereview.chromium.org/491060
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Focus is a bit weird within these; I suspect that it's the same
with the browser action bubbles. It looks like the same issue that
the bookmark bubble had: the bubble grabs the pointer; when a
widget within it (e.g. combobox) gets clicked it steals the grab;
when it ungrabs it the grab is released instead of being
transferred back to the bubble. Unsure of what the correct fix
is for this.
BUG=28061
TEST=installed two separate extensions with page action popups and clicked on their icons
Review URL: http://codereview.chromium.org/412001
TBR=derat@chromium.org
Review URL: http://codereview.chromium.org/490022
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to mutating extension functions, as discussed on chromiumdev and
in Extensions quotaserver design doc.
Add a hook in the dispatcher to have the quota service assess the request.
Wire up bookmarks.{create, move, remove, update} to the service.
BUG=19899
TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new)
Review URL: http://codereview.chromium.org/441006
Review URL: http://codereview.chromium.org/464076
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29444
Review URL: http://codereview.chromium.org/469001
TBR=abarth@chromium.org
Review URL: http://codereview.chromium.org/463043
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shared memory usage. (which shows 0 for me)
BUG=none
TEST=Task manager shows the interesting stats by default.
Review URL: http://codereview.chromium.org/468017
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/460092
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29425
TEST=Open the wrench menu. There should not be a sync menu item.
Review URL: http://codereview.chromium.org/467022
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23178
TEST=Requires manual inspection for text trunction on lang=de (when closing Chrome while downloading)
Review URL: http://codereview.chromium.org/465041
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/460066
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will only be merged into 249, NOT into ToT.
BUG=29204
TEST= puzzle piece on linux, but no promo footer. mac and windows unchanged.
REVIEWED at http://codereview.chromium.org/455043/show
Review URL: http://codereview.chromium.org/467007
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
garbage
collection.
BUG=28884
Review URL: http://codereview.chromium.org/455026
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/460024
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.
Also, add a DCHECK that we only enter this method once, which
is my current assumption.
Review URL: http://codereview.chromium.org/457028
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/462004
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
return a
blank page.
This bug was introduced by the fix for issue 26129 (r30418), which
was to limit view source so that it wouldn't be able to load
javascript or data URLs, but that change forgot to allow file urls.
This fixes the above omission by allowing file URLs again.
TEST=works:viewsource:file:///tmp/test.html, doesn't work:viewsource:javascript:alert('foo')
BUG=27409
Review URL: http://codereview.chromium.org/434094
TBR=gspencer@google.com
Review URL: http://codereview.chromium.org/460009
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the popup got resized smaller.
To repro:
go to the chrome issue tracker (crbug.com)
search for "aaaa" and "aaa"
clear the search field and paste "aaaa" into the box
press backspace
At this point, you should see both autocomplete suggestions.
BUG=29042
Review URL: http://codereview.chromium.org/457024
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/450042
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/29086
TEST = Try installing and running extensions.
Review URL: http://codereview.chromium.org/450039
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This can only happen for extensions with delayinitialized RenderWidgetHost.
BUG=28715
Review URL: http://codereview.chromium.org/450029
TBR=piman@chromium.org
Review URL: http://codereview.chromium.org/452030
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the overflow menu is shown)
This also makes the chevron throb when no bookmarks is added during a sync and merge.
BUG=24306
TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible.
Patch by Bruno Calvignac<BrunoCalvignac@gmail.com>
Original Review: http://codereview.chromium.org/306054/show
Review URL: http://codereview.chromium.org/454010
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/449060
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automatically due to conflicts.
Original code review URL: http://codereview.chromium.org/418044
BUG=26551
TEST=See bug description.
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/452024
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These changes merged the completion of browser action popups
to trunk, which we've decided we don't want.
Review URL: http://codereview.chromium.org/449035
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
access to nonincognito shared workers.
BUG=27883
TEST=added new uitest
Review URL: http://codereview.chromium.org/441022
TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/450016
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27543
TEST=Manually tested
Review URL: http://codereview.chromium.org/437033
TBR=chron@google.com
Review URL: http://codereview.chromium.org/452019
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b/2168147
TEST=Extensions autoupdates should still work.
Review URL: http://codereview.chromium.org/403026
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/457007
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r32449 | estade@chromium.org | 2009-11-18 16:36:21 -0800 (Wed, 18 Nov 2009) | 7 lines
GTK: Fix popup menu positioning.
Don't go off end of screen. push_in doesn't actually work as well as one might hope.
BUG=27800
Review URL: http://codereview.chromium.org/408017
------------------------------------------------------------------------
TBR=laforge
Review URL: http://codereview.chromium.org/450014
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the status bubble as child window when hidden, rather than just setting
its opacity to 0. I'm not sure about the effects, if any, of doing this rather
than destroying the window completely. This doesn't eliminate zorder problems
with Spaces, but should improve it considerably.
This may also ameliorate the problems with moving windows between Spaces using
Expose.
BUG=28107, 24956
TEST=Create a bunch of windows; get the status bubble to appear in the active (key) window and then get it to disappear; switch to another spaces and back; make sure the active window is on top; repeat.
Review URL: http://codereview.chromium.org/434120
TBR=pinkerton@chromium.org, thakis@chromium.org, viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/457001
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into the closing state in an attempt to prevent errant messages to dead objects.
BUG=24987
TEST=open a ton of tabs, rapidly click the close box, hope nothing crashes and the tabs still close correctly.
TBR=pinkerton@chromium.org
Review URL: http://codereview.chromium.org/452012
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only implements Windows right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
browser: all enabled extensions
renderer: unique set of extensions from all user scripts
extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/451005
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33274 0039d316-1c4b-4281-b951-d872f2087c98
|