| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match what the user is doing.
There are a couple major moving parts here:
* Change AutocompletePopupModel::URLsForCurrentText() to InfoForCurrentText() and have it return an AutocompleteMatch, which callers can use to parse out whatever they want. I needed to get at the match type for the current text and found the proliferation of arguments here ridiculous. This had major ripple effects throughout the codebase, including changing the name and location of SearchVersusNavigateClassifier as it no longer had an "is_search" parameter directly, so the name became misleading and too narrow. I also ended up adding a null constructor for AutocompleteMatch because it was too cumbersome otherwise.
* Change the name of the "SecurityImageView" (or similar) to reflect its broader purpose, and plumb it to the edit to get an icon instead of to the toolbar model.
* Add an AutocompleteMatch::Type to icon mapping function, and use it not only in the new code but also to simplify showing the popup contents.
BUG=27570,39725
TEST=An icon should appear next to the address at all times. It should be a globe on non-secure pages, a magnifying glass on the NTP, and a match for whatever the user is typing as he types.
Review URL: http://codereview.chromium.org/1457002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Presumably, people keep copying stuff from other files.
BUG=none
TEST=everything still builds
Review URL: http://codereview.chromium.org/1519009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34514
TEST=None
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1519001
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test timeout.
Layout tests run in ui_tests can now have their timeout set via the cmd line,
and a longer timeout is passed in when valgrind is run.
BUG=39570
TEST=existing tests suffice
Review URL: http://codereview.chromium.org/1518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
focuses it on back/forward navigations.
This becomes important for some upcoming omnibox M5 changes, and was what Glen and Scott and I agreed was the right behavior.
BUG=none
TEST=ctrl-t + navigate + click in page + hit back button = location bar focused
Review URL: http://codereview.chromium.org/1423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39540
TEST=none
Review URL: http://codereview.chromium.org/1578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to give the window an initial position from which to animate from.
BUG=34514
TEST=Play around with http://www.html5rocks.com/samples/notifications/quick/ and make sure the notifications animate up from the bottom.
Review URL: http://codereview.chromium.org/1578001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
randomly on the Chromium Linux 64
builder.
Bug=39753
TBR=amit
Review URL: http://codereview.chromium.org/1583001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles". Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code re-arranged and no autofill++ impl.
Review URL: http://codereview.chromium.org/1521002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1251011
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1526003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons and sync the order of buttons across windows when a drag has completed.
Also fixes an issue where drag events were being intercepted by other buttons when they were not supposed to be and so stuff got shuffled around as a result.
TEST=none
BUG=39199
Review URL: http://codereview.chromium.org/1569002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
number of downloads allowed at one time. When this limit is reached, we re-prompt the user.
BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1251011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test was originally
disabled for chrome os and mac.
TBR=amit
Review URL: http://codereview.chromium.org/1574002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1543001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
protocol launch message.
BUG=35168
TEST=None
Review URL: http://codereview.chromium.org/1518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension as an error.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/1517001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1409002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Do not limit search results to 50 items.
2. Middle clicking a bookmark should open it in a new tab
3. Clear lead/anchor item when clearing the selection.
BUG=39589, 39704, 39611
TEST=1. Search for http (or some other common term). The number of items in the result should not be limited to 50 items.
2. Middle click on a bookmark. It should open in a new tab.
3. See crbug.com/39611
Review URL: http://codereview.chromium.org/1508004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show on the RenderWidgetHostView. on Windows this would cause
the tab HWND to be parented to the desktop (as Show was called
when Hide had not been called).
BUG=36290
TEST=See bug for steps.
Review URL: http://codereview.chromium.org/1388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Within the SUID sandbox, we IPC up to the browser process when
we need to open font files. We should do the same thing within
the seccomp sandbox. (Note that in test_shell and in SELinux,
which uses finer grained file access permissions, we don't
need to do such a thing.)
BUG=26522
Review URL: http://codereview.chromium.org/1541002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do this by switching the text from a NSTextField to a NSTextView.
xib changes: Make text field an ordinary NSTextField instead of our own subclass, connect it to labelPlaceholder_ instead of to label_.
BUG=?,22187
TEST=Open an infobar with a link (e.g. the new geolocation infobars). The cursor should become a hand on hover, and clicking the info bar should no longer put a caret in there. Other infobars (e.g. "Flash plugin crashed" when you kill the flash process on youtube) should look exactly as before. The cursor should still not become an ibeam.
Review URL: http://codereview.chromium.org/1552001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32414
TEST=manual,unittests,trybot
Review URL: http://codereview.chromium.org/1399001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37419
TEST=Dragging a file from desktop to bookmark bar --> creates a bookmark.
Dragging a link from content area to bookmark bar --> creates a bookmark.
Review URL: http://codereview.chromium.org/1504002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the popup should close.
BUG=32161
TEST=none
Review URL: http://codereview.chromium.org/1571001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upload zero bytes if the file size shrinks.
BUG=30850
TEST=uploading an unreadable file works
Review URL: http://codereview.chromium.org/1250002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1519007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- original review URL: http://codereview.chromium.org/1321003
- this reland fixes uniitest build break in translate_manager_unittest.cc
BUG=38548
TEST=none yet (details in original review url)
Review URL: http://codereview.chromium.org/1542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interstitial page wouldn't work.
Also, factor out a method WindowDispositionShouldOpenNewTab that's used to decide if a given window disposition opens in a new tab or the current tab.
BUG=39248
TEST=SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton, SSLUITest.TestHTTPSExpiredCertAndGoBackViaMenu, manual test: Go to www.google.com, then to https://ebay.com to show the HTTPS interstitial, then navigate back using the toolbar.
Review URL: http://codereview.chromium.org/1406001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42971 - Patch the Browser GDI crash with excessive downloads by restricting maximum number of downloads allowed at one time. When this limit is reached, we reprompt the user.
BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001
TBR=inferno@chromium.org
Review URL: http://codereview.chromium.org/1572001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
number of downloads allowed at one time. When this limit is reached, we re-prompt the user.
BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pressing ESCAPE key.
Accelerator and label are active only in non-official builds.
BUG=39279
TEST=Build Chrome with macro OFFICIAL_BUILD undefined. Run out/Debug/chrome --login-manager --login-screen=update. Label "Press ESCAPE..." should be visible, and pressing escape should cancel the update and proceed to the login screen. Build Chrome with OFFICIAL_BUILD macro defined. Run previous command, label should not be visible and pressing ESCAPE should have no effect.
Review URL: http://codereview.chromium.org/1222007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42959 - Make sure we poll immediately on the first syncer loop.
BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds
Review URL: http://codereview.chromium.org/1421003
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1568003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39557
TEST=Search for a, then search for b. The list should now show the results of b.
Review URL: http://codereview.chromium.org/1537001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=the world keeps turning
Review URL: http://codereview.chromium.org/1538001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds
Review URL: http://codereview.chromium.org/1421003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No need for permission context to hold scoped ref to the arbitrator, so I remvoed it.
(Note this fix still reveals bug https://bugs.webkit.org/show_bug.cgi?id=36535)
BUG=39405
TEST=open page with 2 embedded frames using geolocaiton, answer infobar prompts out of order. Should not crash
Review URL: http://codereview.chromium.org/1542002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The feature that the TODO states is already implemented.)
BUG=None
TEST=None
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1526002
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Due to broken build (compile).
TBR=kuan
BUG=38548
Review URL: http://codereview.chromium.org/1567001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- this cl implements the UI on Windows and the partial backend of IPC messaging to include error type
- implement error state
- add translate error types
- use a structure as details for IPC messaging between render view and browser so as to include error type (was using std::pair)
- translate delegate handles error state and provides mapping to error messages
- infobar handles visual error states
- modify background painting to handle normal and error backgrounds, and animation of cross-fading between the 2 backgrounds
- infobar now stores state (and translation_pending flag) that it's currently displaying to user, instead of just relying on TransateInfoBarDelegate's
- if infobar receives PAGE_TRANSLAED notification before delegate does (possible because order is not fixed), delegate's state won't be updated to be used by infobar.
- after all the observers have received the notification, both infobar and delegate will end up with matching states, so there's no worries of out-of-sync.
- update unittests accordingly
- update mac and linux code accordingly to make build pass
- jay will implement the remaining backend to pass actual translate error types to the IPC message (tracked by bug 37778)
BUG=38548
TEST=none yet, until bug 37778 is also fixed.
Review URL: http://codereview.chromium.org/1321003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|LocationBarViewMac::PageActionImageView::UpdateVisibility()| updates
|visible_| based on |preview_enabled|. It is called immediately after
|preview_enabled| is set. This means that the only case
where |IsVisible()| is false but |preview_enabled| is true will be the
unit test which contrives that situation to exist.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1511001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On the geolocation bubble, need to StartRow() before AddView() per host.
TEST=As described in the bug.
BUG=39687
Review URL: http://codereview.chromium.org/1522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests
BUG=9758
Review URL: http://codereview.chromium.org/1528004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't use the Mozilla code which (a) wasn't designed for lazy writes, and (b) is weird and kind of broken for file URLs.
BUG=29911
TEST=Should be able to drag images (from a local web page) to Finder. Other drag-and-drop functionality (from web content) should continue to work as before.
Review URL: http://codereview.chromium.org/1223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Refactor CrosInProcessBrowserTest - granular mocks and expectations.
Fix PowerMenuButtonTest.
Review URL: http://codereview.chromium.org/1405001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
operator and it shouldn't be called as 0-arguments function.
BUG=29062
Review URL: http://codereview.chromium.org/1516003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
- Add a new subview to the details view for displaying appcache information in the cookie prompt. It is in the style of the existing views.
- The new view has a single info line for the manifest url.
- The label of this line is ^IDS_COOKIES_APPLICATION_CACHE_MANIFEST_LABEL
- The value is bound to content.details.manifestURL
- "hidden" binding set to content.details.shouldShowAppCachePromptDetailsView with a NSBNegateBoolean transformer OR selection.@count with a NSNegateBoolean transformer.
- Adjusted the layout of all of the details subviews, labels and values slightly to improve spacing and make it consistent
Screenshot of prompt for appcache available here:
http://img156.imageshack.us/img156/5941/picture2hj.png
http://img404.imageshack.us/img404/3747/picture3bi.png
Screenshot of adjusted cookie prompt with settable expiration:
http://img337.imageshack.us/img337/2296/picture4g.png
BUG=39288
TEST=manual testing, new unit tests
Review URL: http://codereview.chromium.org/1296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in cookie prompt.
BUG=38979
TEST=set cookie settings to ask, go to google.com
Review URL: http://codereview.chromium.org/1394004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38659
TEST=Unit tests in browsing_data_local_storage_helper_unittest.cc and browsing_data_database_helper_unittest.cc
Review URL: http://codereview.chromium.org/1405002
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unit-test
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1516001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42933 0039d316-1c4b-4281-b951-d872f2087c98
|