| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=submit feedback from chrome, check production feedback UI for the submitted report
BUG=chromium-os:3463
Review URL: http://codereview.chromium.org/2153007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Four tests in TaskManagerBrowserTest.* now disabled on Windows;
one test in NewTabUITest.* marked flaky on Windows.
BUG=44991, 45001
TEST=covered by buildbots (browser_tests and ui_tests)
Review URL: http://codereview.chromium.org/2157007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wizard is proceed to the next screen once "Continue" button is clicked and selected network is connected.
- Preselect Ethernet if it's connected.
- Clear selection when encrypted network dialog has been cancelled.
- Ask for network selection when connection timed out.
- Support list of connected/connecting networks.
BUG=cros:3279, cros:3306
TEST=Welcome screen & network selection should work.
Review URL: http://codereview.chromium.org/2077019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When adding a search provider from JS, and the autogenerated keyword clashes with an existing search engine, ask the user.
BUG=15060
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2155001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used for debugging. To enable logging, we can modify
/usr/share/ibus/component/candidate_window.xml as follows.
- <exec>/opt/google/chrome/candidate_window</exec>
+ <exec>/opt/google/chrome/candidate_window --logtofile=/tmp/log.cw</exec>
BUG=chromium-os:3395
TEST=manually
Review URL: http://codereview.chromium.org/2101020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2563
TEST=wrote unit tests and manually
Review URL: http://codereview.chromium.org/2116012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3428
TEST=manually
Review URL: http://codereview.chromium.org/2168002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, doing
osascript -e 'tell application "Chromium" to quit'
wasn't resulting in our AE handler being called.
I decided that Cocoa's default handling for quitting would call [NSApp
terminate] in all cases anyway, which is exactly what we want.
BUG=44965
TEST=Make sure the above works. Make sure quitting by right-clicking on the Dock icon and selecting Quit works (that sends an aevt/quit, which was correctly handled before). Make sure that onbeforeunload handlers still prevent window closure and quitting (go to about:blank, enter 'javascript:window.onbeforeunload=function () { return "please stay"; }' in the Omnibox, choose to stay on the page when the dialog comes up).
Review URL: http://codereview.chromium.org/2154004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrote TaskPump to use Chrome message loops.
Removed now-unused notifier code.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2067021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=seh
Review URL: http://codereview.chromium.org/2074026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
clear the IME state in GTK+.
BUG=9883
Review URL: http://codereview.chromium.org/2110019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=checked the patched code can compile with libcros v35.
Review URL: http://codereview.chromium.org/2101018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Decisions to tint the buttons the color of the selection color was made back
in the Hardy era, in a desire to match the Windows theming system, and this
worked OK with the themes as they were written at the time. In Lucid, this
means too light or too dark buttons. Instead of trying to match the
selection color, try to match the label color. This works well in all the
themes I've tried so far on Lucid.
This kind of sucks that it's not as colorful, but the buttons are now as
legible as text.
BUG=43853
TEST=none
Review URL: http://codereview.chromium.org/2159003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything builds
Review URL: http://codereview.chromium.org/2089025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug which incorrectly classifies client redirects following an in
page navigation as an auto navigation.
TEST=NavigationControllerTest.ClientRedirectAfterInPageNavigation
BUG=40395
Review URL: http://codereview.chromium.org/2077023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
working now.
BUG=39476
TEST=SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers
Patch by Doug Muir <dmuir@google.com>.
Review URL: http://codereview.chromium.org/2063016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41027
TEST=ExtensionApiTest.FavIconPermission
Patch by Doug Muir <dmuir@google.com>
Review URL: http://codereview.chromium.org/2132019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Testing support of storage in TopSites.
BUG=None
TEST=TopSitesTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48061
Review URL: http://codereview.chromium.org/2133011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44546
TEST=none
TBR=dmazzoni@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
shortcuts to the Chrome binary.
Review URL: http://codereview.chromium.org/2155004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when moving a bookmark from and to the Other Bookmarks folder.
BUG=44712
TEST=1) Start with a fresh Chrome and do not import bookmarks.
2) Show the bookmarks bar.
3) Verify that the "For quick access..." text appears in the bookmark bar.
4) Add a bookmark to Other Bookmarks.
5) Verify that the "For quick access..." text still appears in the bookmark bar.
6) Drag the bookmark from Other Bookmarks onto the bookmark bar.
7) Verify that the "For quick access..." text does not appear in the bookmark bar.
8) Drag the bookmark back to the Other Bookmarks.
9) Verify that the "For quick access..." text appears in the bookmark bar.
Review URL: http://codereview.chromium.org/2080022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a small notch in the top right corner of the button when it is on the
left so mirror it so the notch is on the left when the button is on the left.
BUG=44647
TEST=none
Review URL: http://codereview.chromium.org/2086023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44453
TEST=Hidden CA plugins shouldn't draw.
Review URL: http://codereview.chromium.org/2147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Check that document_accessible is non null so that the test doesn't crash.
BUG=44546
TEST=NONE
Review URL: http://codereview.chromium.org/2070017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Linux patch. There will be separate patches for Windows and Linux.
BUG=42685
TEST=none
Review URL: http://codereview.chromium.org/2123014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. gets dragging of side tabs to work.
. gets icons to render correctly.
. adds animation support.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2100013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so that they we don't get an ugly resize on first run.
BUG=44218
TEST=none
Review URL: http://codereview.chromium.org/2144004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44885
TEST=Valgrind is green.
Review URL: http://codereview.chromium.org/2164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Testing support of storage in TopSites.
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2133011
TBR=nshkrob@chromium.org
Review URL: http://codereview.chromium.org/2128024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Associate a RequestContext with a WorkerProcessHost. This corresponds to themain request context of the profile for which the worker process is running. Also associate the context with each WorkerInstance which comes into existance priorto the WorkerProcessHost that will host the instance.
* Give the WorkerProcessHost an AppCacheDispatcherHost.
* Fix up some recently botched IPC plumbing for ViewHostMsg_CreateWorker_Params.
BUG=39368
TEST=there are no worker unit tests
Review URL: http://codereview.chromium.org/2010010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
asynchronously.
BUG=44454
TEST=see bug
Review URL: http://codereview.chromium.org/2128023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Testing support of storage in TopSites.
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2133011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the comments in the bug: this is an important code path for
performance and we've found that different code works best for
notebook platforms, but regresses on desktops/laptops.
We could implement a lot of complex code to measure the speed at
run-time and select the best algorithm, but it appears that we can get
good results from just an #ifdef, so we'll start simple.
BUG=44124
http://codereview.chromium.org/2110022/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since polling is required only for the preferred height and mac only needs preferred width, add a flag that specifies if the client is interested in width and/or height.
This is a band-aid, the Real Fix is tracked in 44850.
BUG=44494
TEST=Open chrome's task manager. Idle renderer processes should take close to 0 %cpu instead of ~1.5 before.
Review URL: http://codereview.chromium.org/2145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabStripModel::InternalCloseTabs calls Browser::CanCloseContentsAt, which could end up closing a tab before trying to close it again, which causes a crash.
The fix is to call Browser::InProgressDownloadResponse asynchronously from BrowserWindowCocoa::ConfirmBrowserCloseWithPendingDownloads.
TEST=DownloadTest.NewWindow; See bug description for manual test.
BUG=44454
Review URL: http://codereview.chromium.org/2095012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2077020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=GeolocationContentSettingsTableModelTest.*
BUG=40286
Review URL: http://codereview.chromium.org/2109006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43608
TEST=None
Review URL: http://codereview.chromium.org/2083021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Patch from Ningxin Hu)
http://codereview.chromium.org/2097003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=cros:2876
TEST=See the issue.
Review URL: http://codereview.chromium.org/2092024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implemented the dialog which shows 4 pref items: Input method (Romaji/Kana), keymap (MSIME/ATOK/Kotoeri), punctuation style, and symbol style.
- Added string resources for the dialog to generated_resources.grd.
- Added chrome prefs to pref_names.cc.
- Added mappings from the mozc engine name to the dialog to language_config_view.cc while it's commented out now.
- Added comments to sync/glue/synchronized_preferences.h.
BUG=chromium-os:2625
TEST=manual
Review URL: http://codereview.chromium.org/2068014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ime state.
BUG=9883
Review URL: http://codereview.chromium.org/2095024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the OS X patch. There will be separate patches for Windows and Linux.
BUG=42685
TEST=unit_tests --gtest_filter=WebDropTargetTest.*
Review URL: http://codereview.chromium.org/2095011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=compiles
Review URL: http://codereview.chromium.org/2110021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trivial change to test commit from alternate network.
BUG=none
TEST=none
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/2117028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a GtkViewsTextView derived from GtkTextView and supports border and
info text when empty;
- Update NativeTextfieldGtk to use GtkViewsTextView for multiline text;
- Remove the multiline suppression in BugReportView;
BUG=chromium-os:3426
TEST=Verify feedback dialog on ChromeOS uses multiline text edit for description field.
Review URL: http://codereview.chromium.org/2138003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
can't reproduce this crash, so we'll keep an eye on crashes.
BUG=43815
Review URL: http://codereview.chromium.org/2144001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unit tests
Review URL: http://codereview.chromium.org/2074022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47980 0039d316-1c4b-4281-b951-d872f2087c98
|