summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Linux: convert classes GtkUtil/GtkTreeUtil back to namespaces ↵mdm@chromium.org2009-07-3152-196/+198
| | | | | | | | | | | gtk_util/gtk_tree_util. BUG=none TEST=none Review URL: http://codereview.chromium.org/160417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
* Adding outbound header filtering to automation HTTP requests.robertshield@chromium.org2009-07-311-2/+30
| | | | | | Review URL: http://codereview.chromium.org/159649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22127 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable commands when coming out of full screen mode on linux.tc@google.com2009-07-303-33/+41
| | | | | | | | | | | | Since the call is async, we need to manually tell Browser that we're no longer in full screen mode. BUG=18104 Review URL: http://codereview.chromium.org/159670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22120 0039d316-1c4b-4281-b951-d872f2087c98
* GTK find bar positioning: Don't try to make a negative-width rectangle.estade@chromium.org2009-07-301-2/+4
| | | | | | | | | BUG=none TEST=make your browser very narrow in debug mode, it doesn't crash Review URL: http://codereview.chromium.org/159665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22117 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED() in plugin code that can be reached.phajdan.jr@chromium.org2009-07-301-2/+2
| | | | | | | | | | | It was contributing to test flakiness. I also updated a comment explaining why the code doesn't kill the plugin process. TEST=none http://crbug.com/18108 Review URL: http://codereview.chromium.org/159602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22116 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Bidify the status bubble.estade@chromium.org2009-07-301-7/+9
| | | | | | | | BUG=17632 Review URL: http://codereview.chromium.org/159664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22114 0039d316-1c4b-4281-b951-d872f2087c98
* Remember/restore the bookmark manager pane position.estade@chromium.org2009-07-302-5/+20
| | | | | | | | BUG=18071 Review URL: http://codereview.chromium.org/160422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22113 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the page info on Gtk Linux.jcampan@chromium.org2009-07-3013-219/+291
| | | | | | | Review URL: http://codereview.chromium.org/159657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
* Try again: Add unittest for Gtk cookie manager.mattm@chromium.org2009-07-303-33/+456
| | | | | | | | | | | | | | Fix a few bugs of button sensitivity not updating when it should. Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is causing UninitCondition errors when run with no DISPLAY. BUG=11507 BUG=15445 Review URL: http://codereview.chromium.org/160420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22107 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeURLRequestContext falloutamit@chromium.org2009-07-303-14/+48
| | | | | | | | | | | | | | | | Fix the issues caused by static_cast<ChromeURLRequestContext*>. There were assumptions in the code that a URLRequestContext* will always be ChromeURLRequestContext* and resulting 'static_cast's. This assumption is no longer true. Instead, URLlRequestContext now has a member GetChromeURLRequestContext that returns a ChromeURLRequestContext* if it really that type. BUG=none TEST=none Review URL: http://codereview.chromium.org/160332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22104 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplication of DieFileDie, and move it to proper location.phajdan.jr@chromium.org2009-07-301-7/+8
| | | | | | | | | TEST=none http://crbug.com/18085 Review URL: http://codereview.chromium.org/159658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement omnibox DnD destination behavior.estade@chromium.org2009-07-302-0/+40
| | | | | | | | BUG=18025 Review URL: http://codereview.chromium.org/160369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22102 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab z-ordering on Mac. Make the TabStripController take fullpinkerton@chromium.org2009-07-302-31/+61
| | | | | | | | | | | | | ownership of its list of subviews. The subviews of the TabStripView are now generated directly (in appropriate z-order) from a list of permanent subviews (e.g., the new tab button) and the list of tabs. In general, this patch seems to make tab manipulation much more stable. Patch from Viet-Trung Luu (viettrungluu@gmail.com) BUG=14913 TEST=open/move/close/duplicate/rip/etc. tabs and observe; also check context menus git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22101 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for moving the mouse so that GetMessagePos would notice.darin@chromium.org2009-07-302-5/+26
| | | | | | | | | | R=pkasting BUG=18079 TEST=covered by TabDraggingTest.Tab2OutOfTabStrip Review URL: http://codereview.chromium.org/160412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22097 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add unittest for Gtk cookie manager."mattm@chromium.org2009-07-303-433/+24
| | | | | | | | This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors. TBR=erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22093 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab dragging to always hide the new tab button while dragging a tab or ↵pinkerton@chromium.org2009-07-306-22/+63
| | | | | | | | | | targeting an existing window. Makes things much nicer. BUG=14923, 14925, 15667 TEST=dragging tabs in and out of windows, and within windows. Make sure new tab button goes away when it should and always comes back. Review URL: http://codereview.chromium.org/160345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22092 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: render view: grab focus *before* forwarding mouse event to renderer.estade@chromium.org2009-07-301-3/+4
| | | | | | | | | BUG=18047 TEST=see bug Review URL: http://codereview.chromium.org/159654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22090 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for Gtk cookie manager.mattm@chromium.org2009-07-303-24/+433
| | | | | | | | | | Fix a few bugs of button sensitivity not updating when it should. BUG=11507 Review URL: http://codereview.chromium.org/159625 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix search engine manager allowing you to remove the current default search ↵mattm@chromium.org2009-07-302-3/+3
| | | | | | | | | | | | | engine. If a search engine entry is already in the main group, MakeDefaultTemplateURL should return the current index(so that button states will be updated) rather than -1(which should mean nothing was done.) BUG=17566 TEST=Select search engine that is already in the main group but not the default, and click "make default". The "make default" and "remove" buttons should no longer be clickable. Review URL: http://codereview.chromium.org/159557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22088 0039d316-1c4b-4281-b951-d872f2087c98
* gcc >= 4.3 fixesmdm@chromium.org2009-07-301-0/+1
| | | | | | | | | | Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377 BUG=none TEST=none Review URL: http://codereview.chromium.org/159648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22085 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Grab the pointer when we grab focus for the source tab's widget. Fixes ↵jhawkins@chromium.org2009-07-301-1/+8
| | | | | | | | | | a crash where events were being sent to an unknown, unrealized widget. BUG=18049 TEST=Quickly drag a tab down out of the tab strip. The browser should not crash. Review URL: http://codereview.chromium.org/160379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22084 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22070.jcampan@chromium.org2009-07-3012-291/+212
| | | | | | Review URL: http://codereview.chromium.org/159645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the page info dialog on Linux Gtk.jcampan@chromium.org2009-07-3012-212/+291
| | | | | | | | | | BUG=http://crbug.com/11598 TEST=Visit an HTTPS page, click the lock icon, the page info should show. Review URL: http://codereview.chromium.org/159521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
* Add plumbing for allowing the renderer to intercept and cancel redirects beforedarin@chromium.org2009-07-3027-135/+226
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | they are sent. A good portion of this CL is to support the new UI test. The IPC to notify the renderer of a redirect now includes a ResponseInfo struct allowing WebURLLoaderImpl to provide detailed response info (including response headers) to WebKit. This isn't strictly necessary, but I thought I'd include this to make the code more future proof. A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp. This is most unfortunate, and I filed a bug at bugs.webkit.org about the similar duplication of logic in WebCore. There seemed to be enough code paths leading to request cancellation at the ResourceDispatcher level that I couldn't easily ensure that a request only gets cancelled once. So, I added an is_cancelled flag to record if it is not necessary to send a ViewHostMsg_CancelRequest IPC. This avoids some warnings in the ResourceDispatcherHost. To support my UI test, I needed to change URLRequestMockHttpJob to know how to serve redirects. I moved URLRequestHttpJob::IsRedirectResponse to its base class, URLRequestJob so that the implementation could be shared. This revealed a minor bug in URLRequest. We were never resetting response_info_ upon following a redirect. I added this code consolidated similar code from URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart method. To support my UI test, I added a "hit count" field to URLRequestFilter, and I added an associated automation IPC to query the value. The test was a bit challenging to write because there is no way to tell the difference from JS. Before and after, it appears to JS as though the cross-origin redirect failed. However, the server can see the extra redirect request. So, I simply record the number of hits against URLs of the form http://mock.http/foo, and use that to observe if any extra requests were made. I implemented the new IPC message by extending the AutomationResourceMessageFilter. This allowed me to trap the IPC message on the IO thread where it is safe to probe the URLRequestFilter. I then changed the implementation of AutomationMsg_SetFilteredInet to work similarly. I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports. This actually allowed me to reuse URLRequestMockHTTPJob to service URLs in different security origins. My test redirects from http://mock.http/ to http://mock.http:4000/. Please see the comments in cross-origin-redirect-blocked.html for details about how the test functions. R=brettw,wtc BUG=16413 TEST=covered by resource_dispatcher_host_uitest.cc Review URL: http://codereview.chromium.org/159370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22067 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the google browser name in about:memory page.kuchhal@chromium.org2009-07-301-11/+15
| | | | | | | | | | BUG=4928 TEST=Open about:memory page a see if the browser name of Google is what is expected. Review URL: http://codereview.chromium.org/159385 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22066 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing interactive UI test.darin@chromium.org2009-07-301-1/+1
| | | | | | | | | | TBR=avi BUG=18079 TEST=none Review URL: http://codereview.chromium.org/160400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22061 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of redundant tab layout by installing incognito badge and adjusting ↵pinkerton@chromium.org2009-07-301-3/+4
| | | | | | | | | | tab strip before creating the tab strip controller. BUG=none TEST=initial incognito tab layout should exactly match normal tab layout (including new tab button). Review URL: http://codereview.chromium.org/160397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22060 0039d316-1c4b-4281-b951-d872f2087c98
* Properly destroy popups when their parent views are told to destroy.avi@chromium.org2009-07-301-15/+38
| | | | | | | | | BUG=http://crbug.com/12970 TEST=as in bug Review URL: http://codereview.chromium.org/160353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22058 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock url request classes to a location when browser tests will be able ↵phajdan.jr@chromium.org2009-07-3018-75/+124
| | | | | | | | | | | to use them too. TEST=none BUG=none Review URL: http://codereview.chromium.org/160366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22056 0039d316-1c4b-4281-b951-d872f2087c98
* Use GET_X/Y_PARAM instead of LO/HIWORD.darin@chromium.org2009-07-302-2/+2
| | | | | | | | | | | | | | | | According to MSDN, this avoids signed/unsigned issues that can lead to problems on systems with multiple monitors. Credit goes to Yoav Zilberberg for catching this! R=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22054 0039d316-1c4b-4281-b951-d872f2087c98
* Pull CrxInstaller out of ExtensionsService.aa@chromium.org2009-07-3012-543/+489
| | | | | | | | | | | | | | | | | | | | | | | | | CrxInstaller is a new stateful object that encapsulates a single installation from unpack through notification. It currently contains the UI bits, but I suspect in the next CL (where I will finally implement the install UI) these will come out and CrxInstaller will become SilentCrxInstaller, and only used for updates and external installs. Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller. With this CL, ExtensionsServiceBackend is almost completely dead, with only a few zombie methods left like LoadAllExtensions(). These should all become little objects like CrxInstaller that hold a reference to ExtensionsService over their lifetime and then kill themselves. I'll get to that eventually. Review URL: http://codereview.chromium.org/160311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22043 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert namespace gtk_util to class GtkUtil to meet style guidelines.mdm@chromium.org2009-07-3051-172/+170
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Add the 'Stats for nerds' link to the task manager.jhawkins@chromium.org2009-07-302-0/+39
| | | | | | | | BUG=17851 TEST=Open the task manager. Click on the 'Stats for nerds' link. Browser should navigate to about:memory. Review URL: http://codereview.chromium.org/159616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22035 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetMessagePos instead of GetCursorPos to avoid unwanted detached tabs.darin@chromium.org2009-07-292-6/+7
| | | | | | | | | | | | | | | | | | | | The problem with GetCursorPos is that it queries the mouse position right now, which means that the values may not be consistent with the values reported via windows messages. GetMessagePos on the other hand returns the mouse position as last reported via the message loop. With this change, I'm unable to reproduce unwanted detached tabs even under heavy system load. R=ben BUG=2993 TEST=While your system is heavily loaded, click on a tab, release the mouse button and then move the mouse downward. Do this as quickly as you can, and the tab should stay put. Review URL: http://codereview.chromium.org/160364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22024 0039d316-1c4b-4281-b951-d872f2087c98
* There is no need for the browser process to have an accelerator handler.This ↵jcampan@chromium.org2009-07-296-30/+6
| | | | | | | | CL cleans this up.BUG=NoneTEST=Accelerator should work in Chrome and in the first run window. Review URL: http://codereview.chromium.org/160301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22020 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: factor out some shared GTK tree utility code.mdm@chromium.org2009-07-294-138/+28
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22019 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Native omnibox part 2.erg@google.com2009-07-294-48/+91
| | | | | | | | | | | | Put the star and go/stop buttons inside the location bar drawing. Reverts my changes to location_bar_view_gtk.cc in the previous patch. (Showed mocks of this to Ben and Glen.) Also fixes rendering of the location bar background under Crux and other themes that draw an entry_bg. Review URL: http://codereview.chromium.org/159610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22018 0039d316-1c4b-4281-b951-d872f2087c98
* Added automation messages and corresponding handlers to support operations like ananta@chromium.org2009-07-292-33/+123
| | | | | | | | | | | 1. SelectAll 2. Cut/Copy/Paste 3. Reload :- Added an asynchronous version of this IPC 4. Stop. Review URL: http://codereview.chromium.org/159609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22017 0039d316-1c4b-4281-b951-d872f2087c98
* Force sizing of a new tab as soon as TabContents is created.japhet@chromium.org2009-07-292-0/+13
| | | | | | | | | | | BUG=619 BUG=15960 TEST=none Review URL: http://codereview.chromium.org/126290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22016 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Don't wrap around when scrolling the tab strip using the scroll event. ↵jhawkins@chromium.org2009-07-291-2/+4
| | | | | | | | | | This matches native gtk behavior. BUG=17869 TEST=Open multiple tabs. Scroll the tabs using the scroll wheel. The scroll should not wrap around. Review URL: http://codereview.chromium.org/160362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22015 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: move the findbar out of the way when it covers a find result.estade@chromium.org2009-07-295-50/+69
| | | | | | | | BUG=15875 Review URL: http://codereview.chromium.org/160350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22012 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DownloadRequestDialogDelegateGtk always report some response to the ↵estade@chromium.org2009-07-293-27/+30
| | | | | | | | | | | | download request manager. We weren't reporting Cancel on page navigation, which meant the download request manager had a stale pointer that it later tried to dereference. BUG=18021 Review URL: http://codereview.chromium.org/160361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22011 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Save and restore bookmark manager and task manager window size.derat@google.com2009-07-295-88/+308
| | | | | | | | | | | | | | | | | | | | | | | | | To test, did the following under Metacity/GNOME: - remove window_placement prefs from "Local State" file - start chrome - open bookmark manager with Ctrl-Shift-B - resize window to be small and close it - reopen bookmark manager and confirm that its window is the same size as when closed - maximize bookmark manager and close it - reopen bookmark manager and confirm that it's still small - minimize bookmark manager before closing it; confirm that the size remains the same - restart chrome and confirm that the window size is still saved - repeat the above tests with the task manager (which is a bit quicker, since it doesn't allow maximizing or minimizing) BUG=15488 TEST=see above Review URL: http://codereview.chromium.org/160330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22001 0039d316-1c4b-4281-b951-d872f2087c98
* Undisable DnsMasterTest.MassiveConcurrentLookupTest.phajdan.jr@chromium.org2009-07-292-2/+2
| | | | | | | | | | | | It still passes, and provides coverage for situation where there are lots of DNS requests at the same time. TEST=none BUG=none Review URL: http://codereview.chromium.org/159601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22000 0039d316-1c4b-4281-b951-d872f2087c98
* Add private: before DISALLOW_IMPLICIT_CONSTRUCTORS.mattm@chromium.org2009-07-291-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21998 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Firefox import on OSX + stubs for Safari import.jeremy@chromium.org2009-07-2910-31/+128
| | | | | | | | | | | | | | Known limitations: * Runs in browser process, should run in a separate process. * No UI. * No FF password import. BUG=15455 TEST=Check that firefox settings are correctly imported on first run, firefox password importing and Safari importing still don't work. Review URL: http://codereview.chromium.org/160341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21995 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk password dialog: Initialize pending_login_query_.mattm@chromium.org2009-07-292-2/+6
| | | | | | | | BUG=8205 Review URL: http://codereview.chromium.org/159603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21991 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the side and bottom shadows in the native frame.tc@google.com2009-07-292-15/+118
| | | | | | | | | | | | As with the rest of our shadow drawing, we don't overlap 1 pixel, we just draw the area around. BUG=15505 Review URL: http://codereview.chromium.org/160306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21989 0039d316-1c4b-4281-b951-d872f2087c98
* Move the tabstrip to the right one pixel so our tab placementtc@google.com2009-07-291-2/+8
| | | | | | | | | | | matches up with Windows. BUG=17915 Review URL: http://codereview.chromium.org/160281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21986 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Thiago Farina's CL.jcampan@chromium.org2009-07-2914-19/+18
| | | | | | | | | | | | | See http://codereview.chromium.org/159186 Renaming GetNormalBounds to GetRestoredBounds from browser_window.h. BUG=None TEST=None TBR=tfarina Review URL: http://codereview.chromium.org/160337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 19:45:58 +0000