summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-19103-12/+112
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash caused in a ChromeFrame instance while displaying the ↵ananta@chromium.org2010-02-192-12/+10
| | | | | | | | | | | | | | | | | | | inspector window. The inspector window uses the browser view which instantiates the whole view including the ToolBar, which in turn instantiates the Autocomplete edit bar which uses Richedit on Windows. The auto complete edit bar dynamically loads and unloads the richedit control and it uses ATL to superclass the richedit control. If the rich edit dll loads at a different base address it causes a crash in Chrome while creating the window as ATL caches the wndproc address for a class. Fix is to setup an implicit dependency on the riched20.dll and not load and free it all the time. To achieve this we use #pragma comment for the riched20.lib and a dummy call to the CreateTextServices function exported by the dll to ensure that the linker does not discard the import. Fixes bug http://code.google.com/p/chromium/issues/detail?id=33308 Bug=33308 Review URL: http://codereview.chromium.org/646043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39415 0039d316-1c4b-4281-b951-d872f2087c98
* check if ModelNeutralExecuteImpl succeeded before running ↵dantasse@chromium.org2010-02-194-7/+13
| | | | | | | | | | | ModelChangingExecuteImpl BUG:36200 TEST:manual Review URL: http://codereview.chromium.org/646078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39412 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor omnibox popup to fix click-drag display.shess@chromium.org2010-02-192-111/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix the confusion between highlighted and selected cells by overriding |-mouseDown:| and directly implementing the desired behaviors. Which are: - while mouse is down in the view, the item under the mouse looks selected, like it would if you used the arrow keys to move it around (rather than highlighted). - dragging off with mouse down reverts to previous selection (the one matching the field's contents). - releasing while mouse is off-view reverts to previous selection. - dragging back with mouse still down selects the cell under the mouse. Additionally, refactor to remove useless utility object. The custom matrix now just messages the C++ object directly. BUG=25435 TEST=See bug. Review URL: http://codereview.chromium.org/646063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39411 0039d316-1c4b-4281-b951-d872f2087c98
* Extracted non-XRender painting path from BackingStoreX into PutARGBImage().scherkus@chromium.org2010-02-191-90/+4
| | | | | | | | | BUG=n/a TEST=everything should stay the same Review URL: http://codereview.chromium.org/647062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39410 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of using a single template file and leaving some parts of it out, ↵johnnyg@chromium.org2010-02-196-20/+86
| | | | | | | | | | | use template files for each configuration. this allows for better presentation of small notifications without a lot of empty space. BUG=36081 TEST=create notification with a short string Review URL: http://codereview.chromium.org/628010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39409 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when installing an extension from incognito mode.mpcomplete@chromium.org2010-02-191-3/+6
| | | | | | | | BUG=36077 Review URL: http://codereview.chromium.org/646072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39408 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dock icon while downloading.avi@chromium.org2010-02-191-4/+2
| | | | | | | | | BUG=http://crbug.com/35791 TEST=paste on a new app icon, download something, switch between apps, app icon should always be right Review URL: http://codereview.chromium.org/646036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39406 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser on Linux. This is based ↵jianli@chromium.org2010-02-196-72/+231
| | | | | | | | | | | on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html BUG=none TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder. Review URL: http://codereview.chromium.org/600154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39405 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in about:memory that resulted in showing null for browser ifsky@chromium.org2010-02-181-1/+3
| | | | | | | | | | | | | | you had a crashed tab or phantom tab. BUG=none TEST=create two tabs, pin one, close it (so that it goes phantom), navigate to about:memory and make sure you don't see an entry for the phantom tab. Review URL: http://codereview.chromium.org/646035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code from safe_browsing_util.h/cc.shess@chromium.org2010-02-185-647/+73
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/630012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39398 0039d316-1c4b-4281-b951-d872f2087c98
* Have rlz record first search event in a corner casecpu@chromium.org2010-02-181-6/+7
| | | | | | | | | | | | | | | | 1- start chrome do nothing for 90+ seconds 2- close chrome 3- relaunch chrome 4- type in the omnimbox before 90 seconds 5- observe (with debuger) that first search event is not recorded BUG=b\1812626 TEST=see bug for testing details. Review URL: http://codereview.chromium.org/646031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 33138: Clicking on the extension name for an extension downloadedfinnur@chromium.org2010-02-181-1/+8
| | | | | | | | | | | | | | off the web (non-gallery) goes to the Gallery page (and shows id not found). We now disable this link for non-gallery extensions. BUG=33138 TEST=Download an extension from a non-gallery source. Right click the icon, the name menu item should be grayed out. For extensions from the gallery, it should not be grayed out. It should link to the gallery. Review URL: http://codereview.chromium.org/646026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39396 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the command line flag --testing-fixed-host.eroman@chromium.org2010-02-181-13/+3
| | | | | | | | | | | | This has been superceded by --host-resolver-rules. (Instead of --testing-fixed-host="foobar" one would use --host-resolver-rules="MAP * foobar") BUG=36053 Review URL: http://codereview.chromium.org/647005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39393 0039d316-1c4b-4281-b951-d872f2087c98
* The PromptDelegate needs to delete itself once it gets a reply.darin@chromium.org2010-02-181-3/+11
| | | | | | | | | | R=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/646021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39392 0039d316-1c4b-4281-b951-d872f2087c98
* Client-side SSL cert support for Mac.snej@chromium.org2010-02-185-48/+139
| | | | | | | | | | This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen. BUG=16831 TEST=none Review URL: http://codereview.chromium.org/604067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
* We need to traverse the infobars with a reverse loop asjcampan@chromium.org2010-02-181-1/+1
| | | | | | | | | | | | | | | | | we remove them (as after removal the index is pointing too far by 1, so the next immediate infobar won't be removed). BUG=None TEST=Get to a page with 2 infobars (for ex: crash the browser and restart (so you get the browser crashed infobar and make it not your default browser so you get the default browser infobar), kill the page process with the task manager. The sad page should be shown and the infobars should disappear. Review URL: http://codereview.chromium.org/646045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39388 0039d316-1c4b-4281-b951-d872f2087c98
* Adding @@extension_id reserved message to l10n message map for extension.cira@chromium.org2010-02-182-1/+8
| | | | | | | | | | | | | | | | | | | | | It's added outside of ExtensionMessageBundle so that non-localized extensions can use it. Developer doesn't have to define default_locale in the manifest in order to get it working. With this change every extension css file will go through message replacement process (only localized extensions went through that before). This change will allow following construct in extension css: body { background-image:url('chrome-extension://__MSG_@@extension_id__/background.png'); } BUG=35208 TEST=Add an background image to your extension, and refer to it from css file using __MSG_@@extension_id__. Image should show up in the background. Review URL: http://codereview.chromium.org/628009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39385 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes switching the target back to the original languagejcampan@chromium.org2010-02-181-2/+1
| | | | | | | | | | | | | revert the translation. It also simplifies the page translator logic. We are initializing the PageTranslator states when a new page is translated. Further translations reuse the text nodes already retrieved. Also an unused method has been removed from RenderView. BUG=36073 TEST=See bug. Thoroughly test the translation feature. Review URL: http://codereview.chromium.org/647030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39384 0039d316-1c4b-4281-b951-d872f2087c98
* Mac fullscreen: prevent mouse clicks on overlay from passing through to content.viettrungluu@chromium.org2010-02-181-0/+18
| | | | | | | | | | | Also make it so that double-clicks on overlay should (theoretically) minimize. BUG=36108 TEST=Enter fullscreen mode. With content having links or similar (e.g., NTP bookmark bar), click at various locations on the (slide-down) overlay bar. Clicks should not pass through. Mouse cursor should not reflect web content underneath. Review URL: http://codereview.chromium.org/646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39382 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all infobars from a tab when its renderer crashes.jcampan@chromium.org2010-02-181-0/+4
| | | | | | | | | | | | | They are irrelevant in the sad tab. BUG=36035 TEST=Navigate to a foreign page so the translate infobar shows up. From the task manager, kill the renderer process for that page. The translate infobar should disappear. Review URL: http://codereview.chromium.org/646023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39366 - Initial Geolocation implementationbulach@chromium.org2010-02-1819-907/+147
| | | | | | | | | | | | | | Adds IPC plumbing. Adds Infobar buttons for requesting permission TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/548188 TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/646027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
* Test SetAcrossInstances crashed on Mac also. Disabling.finnur@chromium.org2010-02-181-2/+2
| | | | | | | | | | BUG=36068 TEST=None TBR=joth Review URL: http://codereview.chromium.org/647025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39368 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Geolocation implementationbulach@chromium.org2010-02-1819-147/+907
| | | | | | | | | | | Adds IPC plumbing. Adds Infobar buttons for requesting permission TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/548188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes close other tabs regression. It needed to check overall tabsky@chromium.org2010-02-181-1/+1
| | | | | | | | | | | count too. BUG=35576 TEST=see bug Review URL: http://codereview.chromium.org/629006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39365 0039d316-1c4b-4281-b951-d872f2087c98
* convert power_save_blocker NOTIMPLEMENTED into a bugevan@chromium.org2010-02-181-1/+2
| | | | | | | | | | Warning everyone about this every time we run the app is not helpful. BUG=33605,34081 Review URL: http://codereview.chromium.org/646012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39360 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: enable seccomp sandbox by default"evan@chromium.org2010-02-183-10/+51
| | | | | | This reverts commit r39358. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39359 0039d316-1c4b-4281-b951-d872f2087c98
* linux: enable seccomp sandbox by defaultevan@chromium.org2010-02-183-51/+10
| | | | | | | | | | | This is an experiment. Hopefully it will flush out problems. Use --disable-seccomp-sandbox to turn it off. BUG=36133 Review URL: http://codereview.chromium.org/647017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39358 0039d316-1c4b-4281-b951-d872f2087c98
* Switch browser prefs to use the higher level geolocation::RegisterPrefs ↵joth@chromium.org2010-02-181-2/+2
| | | | | | | | | | | | | method rather than call into random internal component of geolocaiton (and so avoid the associated header file dependency bloat) geolocation_prefs.h was already added in http://src.chromium.org/viewvc/chrome?view=rev&revision=39232 I just forgot to include this edit BUG=none TEST=none Review URL: http://codereview.chromium.org/618016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39352 0039d316-1c4b-4281-b951-d872f2087c98
* Actually delete databases in CookiesTreeModel.jochen@chromium.org2010-02-185-23/+27
| | | | | | | | | BUG=34633 TEST=delete a database while it's opened in the renderer Review URL: http://codereview.chromium.org/600104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39346 0039d316-1c4b-4281-b951-d872f2087c98
* linux: clean up a bit of redundant logicevan@chromium.org2010-02-181-7/+9
| | | | | | | | | | | I noticed this while looking for something else. In theory, this will reduce flashing when the dialog comes up (since we first do all the layout of the contents and then once that's all done we show the window), but I haven't verified that. Review URL: http://codereview.chromium.org/608034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39345 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the "unique file:// URI origin" flag to on. Add thecevans@chromium.org2010-02-181-0/+2
| | | | | | | | | | | | | --allow-file-access-from-files developer switch. Turn on this flag for the UI tests, which depend on the old behaviour. BUG=4197 TEST=WebKit test submitted upstream TBR=abarth Review URL: http://codereview.chromium.org/648003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39343 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line flag to remap hostnames based on patterns.eroman@chromium.org2010-02-181-26/+39
| | | | | | | | | | | This is a generalization of the --testing-fixed-server flag. BUG=36053 TEST=MappedHostResolverTest.* Review URL: http://codereview.chromium.org/647001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39342 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test verifying the merge behavior when there are twonick@chromium.org2010-02-181-0/+20
| | | | | | | | | | | | duplicate URLs. I promised this test a long time ago for an old bug. TEST=ran this unittest; passes at trunk, fails if you change "multiset" to "set" in the BookmarkNodeFinder. BUG=24995 Review URL: http://codereview.chromium.org/640002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39340 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular message loop for cros login windowdavemoore@chromium.org2010-02-1812-64/+235
| | | | | | | | | | | | | | First we have to allow the regular initialization to happen. This will permit the login wizard screens to use the network and rendering capabilities of chrome safely. Once a user logs in and cros mounts their encrypted directory as a profile, we change the default profile to that one and create a new browser window with it as well. This ought to make launching the first browser window even faster. Review URL: http://codereview.chromium.org/604052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39339 0039d316-1c4b-4281-b951-d872f2087c98
* Use net::LOAD_IGNORE_CERT_AUTHORITY_INVALID for websocket experimentukai@chromium.org2010-02-181-1/+2
| | | | | | | | | | | to avoid Mac SSL issue. BUG=none TEST=none Review URL: http://codereview.chromium.org/648001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39338 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: allow Esc in the Omnibox to give up focus in fullscreen mode.viettrungluu@chromium.org2010-02-183-0/+19
| | | | | | | | | | | | (Use the same "signal" as for stopping load: if we'd allow Esc to stop loading the current page, we'll let Esc dismiss the Omnibox.) BUG=35961 TEST=Enter fullscreen mode, Cmd-L to focus the Omnibox (and thus show it), Esc should revert to the original URL and give up focus (hiding the Omnibox). In normal, non-fullscreen mode, Esc should work as before. Review URL: http://codereview.chromium.org/601091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39337 0039d316-1c4b-4281-b951-d872f2087c98
* Turns out the test crashes on Linux, not just Linux with toolkit_views.finnur@chromium.org2010-02-181-2/+2
| | | | | | | | | | BUG=http://crbug.com/36068 TEST=None TBR=joth Review URL: http://codereview.chromium.org/645002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39329 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in cookie prompting:sky@chromium.org2010-02-188-36/+57
| | | | | | | | | | | | | | | | | | . In certain situations we could crash because we weren't letting CookiePromptView::Init complete and then attempting to reference some NULL fields. I've fixed this by adding AppModalDialog::IsValid and moving the logic that was in Init to IsValid. This way we only create CookiePromptView when needed. . We were leaking AppModalDialogs. I've made CookiePromptView own the AppModalDialog and delete it when the CookiePromptView is deleted. BUG=36079 TEST=enable prompting for cookies, go to a bunch of sites make sure you don't crash. Review URL: http://codereview.chromium.org/632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39328 0039d316-1c4b-4281-b951-d872f2087c98
* Incremental addition to preferences_window_controller that handles the ↵dhollowa@chromium.org2010-02-182-16/+99
| | | | | | | | | | | | | | button click for changing autofill settings from the preferences dialog on Mac. Due to the deferred loading of the PesonalDataManager data we install an observer that waits for the data to load before bringing up the dialog for the user. This is a precondition for having the PersonalDataManager data available for display in the dialog. These changes do not address sending the actual data down to the dialog for display. That will be addressed in future change. BUG=33029 TEST=none Review URL: http://codereview.chromium.org/620006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39318 0039d316-1c4b-4281-b951-d872f2087c98
* Send suggestions from the AutoFillManager to the AutoFillSuggestionsPopup in ↵jhawkins@chromium.org2010-02-185-13/+124
| | | | | | | | | | WebKit. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/627005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39310 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add some interactive tests to catch common bookmark bar regressions.estade@chromium.org2010-02-184-1/+89
| | | | | | | | | BUG=33220, 34564 TEST=test passes Review URL: http://codereview.chromium.org/606009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39309 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make selections in task manager apply to all members of resource groupestade@chromium.org2010-02-182-12/+36
| | | | | | | | | | BUG=33087 TEST=manual Review URL: http://codereview.chromium.org/614008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39308 0039d316-1c4b-4281-b951-d872f2087c98
* Add unique hashing to sync API.chron@google.com2010-02-185-25/+126
| | | | | | | | | TEST=included unit test BUG=35586 Review URL: http://codereview.chromium.org/593094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39287 - Chromium pieces to use the WebKit support for isolation ↵cevans@chromium.org2010-02-181-2/+0
| | | | | | | | | | | | | | | | | | file:// documents in their own unique domains. By default, we use this isolation for security. We provide a command line switch override for developers: allowfileaccessfromfiles BUG=4197 TEST=WebKit test pending Review URL: http://codereview.chromium.org/625001 TBR=abarth@chromium.org Review URL: http://codereview.chromium.org/625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39304 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a test that crashes on Linux Views bot.finnur@chromium.org2010-02-181-1/+8
| | | | | | | | | | BUG=http://crbug.com/36068 TEST=None TBR=joth Review URL: http://codereview.chromium.org/630008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39303 0039d316-1c4b-4281-b951-d872f2087c98
* previous cl (r39286) only disables commands in fullscreen mode for ↵kuan@chromium.org2010-02-171-1/+1
| | | | | | | | | | chromeos=1, this cl adds another variant toolkit_views=1. BUG=34340 TEST=verify per bug report. Review URL: http://codereview.chromium.org/629005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39296 0039d316-1c4b-4281-b951-d872f2087c98
* Make Esc in Omnibox *not* stop loading if it has reverted editing.viettrungluu@chromium.org2010-02-171-1/+1
| | | | | | | | | BUG=none TEST=Begin loading a slow-loading web page. While it's loading, begin editing in the Omnibox. While it's still loading, press Esc. The text should revert to the original URL and be all selected, but the page should continue loading. A second Esc at this point should stop loading. Review URL: http://codereview.chromium.org/628005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39295 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium pieces to use the WebKit support for isolation file:// documents incevans@chromium.org2010-02-171-0/+2
| | | | | | | | | | | | | their own unique domains. By default, we use this isolation for security. We provide a command line switch override for developers: --allow-file-access-from-files BUG=4197 TEST=WebKit test pending Review URL: http://codereview.chromium.org/625001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39287 0039d316-1c4b-4281-b951-d872f2087c98
* disable comamnds in full screen modekuan@chromium.org2010-02-171-0/+8
| | | | | | | | | | | original bug was to disable CTRL+B (toggling of bookmark bar) in full screen mode; turns out there's a method that other platforms call to disable specific comamnds in full screen mode BUG=34340 TEST=verify per bug report. Review URL: http://codereview.chromium.org/626007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39286 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 21:48:11 +0000