summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-0623-208/+575
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactor some things so GTK doesn't touch the on disk image cache.erg@google.com2009-10-053-41/+64
| | | | | | | | | | Hopefully will solve crash. BUG=23588 Review URL: http://codereview.chromium.org/258020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28066 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminate unintended "menu" method overrides.viettrungluu@chromium.org2009-10-059-53/+54
| | | | | | | | | | | This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing. BUG=22148,23606 TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing. Review URL: http://codereview.chromium.org/251091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28064 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to DOMUIContents. It looks like the class doesn't exist.tony@chromium.org2009-10-052-5/+1
| | | | | | Review URL: http://codereview.chromium.org/257055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28063 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-0510-24/+25
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: mpcompleteerikkay@chromium.org2009-10-053-33/+3
| | | | | | revert previous checkin (compile failure due to bad merge resolution) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28057 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-053-5/+5
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups to close themselves with window.close().erikkay@chromium.org2009-10-053-3/+33
| | | | | | | | | | | | This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC. BUG=23832 TEST=run set_page_color extension, when it sets the color, the popup should close Review URL: http://codereview.chromium.org/243096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28053 0039d316-1c4b-4281-b951-d872f2087c98
* Make the main menu open at full screen and provides command linesky@chromium.org2009-10-051-16/+65
| | | | | | | | | | | switches for changing the url and size. BUG=none TEST=none Review URL: http://codereview.chromium.org/246091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28051 0039d316-1c4b-4281-b951-d872f2087c98
* Up the new tab paint observer timeout from 2s to 5s. Trying to seetony@chromium.org2009-10-051-2/+2
| | | | | | | | | | | | if this gets us more accurate data on new tab times. BUG=21398 TBR=evanm (ok'ed in person) Review URL: http://codereview.chromium.org/257052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28050 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Allocate |cache| after we have a logic path where we can return ↵jhawkins@chromium.org2009-10-051-2/+1
| | | | | | | | | | | and leak. CID=6380 BUG=none TEST=none Review URL: http://codereview.chromium.org/255081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28044 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a Dev Tools test that got missed.pkasting@chromium.org2009-10-051-1/+1
| | | | | | | | BUG=23858 TEST=none Review URL: http://codereview.chromium.org/242147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.pkasting@chromium.org2009-10-053-2/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/259050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the dev tools unit tests. They were broken by the ↵jparent@chromium.org2009-10-051-16/+16
| | | | | | | | | | | webkit merge from 49050:49097. TEST=none BUG=23858 Review URL: http://codereview.chromium.org/257049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the RenderProcessHost from the list of renderer processes when we ↵jam@chromium.org2009-10-051-1/+7
| | | | | | | | | call DeleteSoon, not in the destructor. Otherewise the process can be reused in the meantime. This matches what we do in ChildProcessHost. BUG=21038 Review URL: http://codereview.chromium.org/257028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28034 0039d316-1c4b-4281-b951-d872f2087c98
* Adds command line flag to enable desktop notifications.johnnyg@chromium.org2009-10-051-0/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/249057/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28031 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED from the keyword editor dialog. To hit,tony@chromium.org2009-10-051-3/+2
| | | | | | | | open the keyword editor dialog and press enter. Review URL: http://codereview.chromium.org/259029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28028 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check TemplateURL::url return value.mattm@chromium.org2009-10-051-1/+4
| | | | | | | | | | CID=6325 BUG=none TEST=none Review URL: http://codereview.chromium.org/256045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor ImporterHost as preparation for OOP switch", which caused ↵mattm@chromium.org2009-10-0520-670/+475
| | | | | | | | | | | | | | | | | | | purify XP leak: std::_W::_Allocate(unsigned int,wchar_t *) [unit_tests.exe] Alloc Location ... chrome/browser/importer/ie_importer.cc IEImporter::StartImport(ProfileInfo,WORD,ImporterBridge *) base/tuple.h ?DispatchToMethod@VImporter@@P81@AEXUProfileInfo@@GPAVImporterBridge@@@ZU2@GV?$scoped_refptr@VImporterBridge@@@@@@YAXPAVImporter@@P80@AEXUProfileInfo@@GPAVImporterBridge@@@ZABU?$Tuple3@UProfileInfo@@GV?$scoped_refptr@VImporterBridge@@@@@@@Z ^^^ This reverts commit r28007 and r27996. TBR=jeremy Review URL: http://codereview.chromium.org/260011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28019 0039d316-1c4b-4281-b951-d872f2087c98
* Move nsimage_cache into base so that it can be accessed from outside of chrome.mark@chromium.org2009-10-0512-101/+12
| | | | | | | | | | This is in support of the next round of rebundling. TEST=does it still build, do the unit tests still pass, does it still work? BUG=14610 Review URL: http://codereview.chromium.org/243100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28016 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include.craig.schlenter@chromium.org2009-10-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/242144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28007 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager: show right click context menu no matter where you click on the ↵estade@chromium.org2009-10-052-4/+1
| | | | | | | | | | task manager window. discoverability++ Review URL: http://codereview.chromium.org/203047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28005 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy call to icu::TimeZone.createDefault() before the sandbox kicks in.jshin@chromium.org2009-10-051-0/+9
| | | | | | | | | | | This is necessary to get the datetime formatting work correctly in a renderer process (e.g. FTP directory list that is now done in a renderer process.) BUG=23361,23082 TEST=... Review URL: http://codereview.chromium.org/243060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27999 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use the utility process on linux.asargent@chromium.org2009-10-055-8/+43
| | | | | | | | | | | We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703. BUG=23327 TEST=Extensions installation/autoupdate and New Tab Page tip download should still work. Review URL: http://codereview.chromium.org/256036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27997 0039d316-1c4b-4281-b951-d872f2087c98
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-0520-475/+669
| | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27996 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Insert views into the proper place in the view hierarchy when tearing ↵rohitrao@chromium.org2009-10-053-28/+11
| | | | | | | | | | | | off tabs. BUG=http://crbug.com/19320 BUG=http://crbug.com/23407 BUG=http://crbug.com/20555 TEST=Tearing off a tab with an open infobar should not show a blank transparent space. After tearing off a tab, both find in page and fullscreen should work properly. Review URL: http://codereview.chromium.org/258012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27992 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar l10n passthomasvl@chromium.org2009-10-052-65/+90
| | | | | | | | | | | | | | | | | | - remove the close button outlet (unused) - add a helper to hide the buttons and resize the text field to use the same. - if no image, move the text field - tweak the xib to make it clear the values aren't used - tweak the xib to remove the NSEveryone image - make the link text use the control's font so it matches what's in the xib and other infobar modes (if we ever had to tweak it). - use the GTM helper for autosizing buttons - reflow how we position the buttons/textfield for the button infobars so it updates the textfield once. TEST=if you make the window skinny, any infobars that don't have buttons shouldn't reserve space for them. the the plugin crashed info bar shouldn't show a bogus graphic (currently we have none set). BUG=20535 BUG=19183 Review URL: http://codereview.chromium.org/251075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27983 0039d316-1c4b-4281-b951-d872f2087c98
* "Windows" and "Macintosh" are proper names, and should be capitalized in the UI.thomasvl@chromium.org2009-10-051-2/+62
| | | | | | | | TEST=Encoding menus should have these two capitalized. BUG=22843 Review URL: http://codereview.chromium.org/251043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27981 0039d316-1c4b-4281-b951-d872f2087c98
* TestOverrideEncoding hanging is because TabProxy::WaitForNavigation can not ↵jnd@chromium.org2009-10-042-1/+9
| | | | | | | | | | | | | | | | | | | get reply if current last last_navigation_time for tab _tracker is great than the input last_navigation_time. See AutomationProvider::WaitForNavigation, it is handled by IPC_MESSAGE_HANDLER_DELAY_REPLY, which means the message handler need to send the reply message by itself. According to current WaitForNavigation logic, if current last last_navigation_time for tab _tracker is less than the input last_navigation_time, the replay will be sent by NavigationNotificationObserver. Otherwise, the reply will never be sent. So if somehow the test machine is slow, the navigation has happened before calling AutomationProvider::WaitForNavigation, the caller will never get reply. That is why TestOverrideEncoding hangs sometimes. Please refer to http://chrome-svn/viewvc/chrome?view=rev&revision=9585 to see how the logic was changed before. The problem also happened on other two places. BUG=23121 TEST=BrowserEncodingTest.TestOverrideEncoding Review URL: http://codereview.chromium.org/242024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27966 0039d316-1c4b-4281-b951-d872f2087c98
* Change ConfirmMessageBoxDialog to just be a native view (it was only windows ↵tim@chromium.org2009-10-034-70/+89
| | | | | | | | | | | | | | before, too, but now at least it doesn't cause zombie processes) with an observer that is notified when the user clicks OK/closes the dialog instead of running a nested message loop and blocking. This fixes bug 20451, where nested message loops were running a confirm dialog and could cause zombie processes at browser shutdown. BUG=20451 TEST=None (manual: verify that the confirmation dialog is shown when you try to remove all passwords, and that no zombie is left behind if the browser is closed while the confirmation dialog is showing) Review URL: http://codereview.chromium.org/243054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27961 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Remove pthreads from event_sys code. Remove asynch version of ↵timsteele@google.com2009-10-0315-151/+130
| | | | | | | | | | | | | | | GaiaAuthenticator, as it is never used. This allowed replacing all lock/mutex code with current MessageLoop assertions. Some temp scaffolding in auth_watcher (e.g creating a message loop for the current pthread), which will be removed as part of my next trick. TEST=sync_unit_tests suite, sync_integration_tests suite BUG=19895 Review URL: http://codereview.chromium.org/251080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27956 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a warning:nsylvain@chromium.org2009-10-031-2/+2
| | | | | | | | | | browser_focus_uitest.cc:401: warning: 'unfocused_browser' may be used uninitialized in this function browser_focus_uitest.cc:400: warning: 'focused_browser' may be used uninitialized in this function TBR:maruel Review URL: http://codereview.chromium.org/256050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27954 0039d316-1c4b-4281-b951-d872f2087c98
* Add an API to manipulate the browser action badge.aa@chromium.org2009-10-035-16/+78
| | | | | | | | BUG=23268 Review URL: http://codereview.chromium.org/256032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27951 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build failure makes no sense. Try random fix.pkasting@chromium.org2009-10-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27950 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite chunks of the blocked popup container code:pkasting@chromium.org2009-10-038-144/+218
| | | | | | | | | | | | | | * Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups. * Be clearer and stricter about item indexes and sanity checking. Hopefully, this or the previous item fix a crash we saw (no bug filed). * Add notice support (as much as exists for Windows) to GTK and Mac. * Make the implementations in the three platforms mirror each other a little more precisely. * Fix (expected, actual) mis-ordering in Mac unittest. BUG=none TEST=none Review URL: http://codereview.chromium.org/260005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27949 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. Re-submission of ↵jorlow@chromium.org2009-10-0310-36/+192
| | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Review URL: http://codereview.chromium.org/258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
* Add quota support.jorlow@chromium.org2009-10-034-7/+12
| | | | | | | | | | | Add a 5mb quota to DOM Storage. Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ). BUG=16876 TEST=I added a layout test upstream and it works. Review URL: http://codereview.chromium.org/255050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27942 0039d316-1c4b-4281-b951-d872f2087c98
* More WebView / WebViewDelegate cleanup.darin@chromium.org2009-10-036-9/+9
| | | | | | | | | | | | Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-0316-28/+79
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Update slide animation progress in a cleaner way.estade@chromium.org2009-10-032-22/+6
| | | | | | | | | BUG=none TEST=animations still work: infobar, findbar, download shelf Review URL: http://codereview.chromium.org/255071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27934 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a build error in the jumplist to use the new png codec location.brettw@chromium.org2009-10-031-3/+3
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27933 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-0331-91/+87
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Pass unhandled keyup messages coming in from the renderer to the underlying ↵ananta@chromium.org2009-10-032-9/+5
| | | | | | | | | | | | | | | | | | | view. This is needed for system keyboard messages which are generated when the Alt key is pressed in addition to other keys to function correctly in ChromeFrame. The TabContentsView implementation for windows does the right thing by specifically checking for keydown events before processing them as accelerators. The TabContentsView implementation for Linux also treated keyup messages as accelerators, which is now fixed. This fixes parts of http://code.google.com/p/chromium/issues/detail?id=22996 Bug=22996 Review URL: http://codereview.chromium.org/255028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27926 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to check in the badge stuff.aa@chromium.org2009-10-033-3/+123
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27925 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms that track how long it takes to open the new tab page.tony@chromium.org2009-10-026-8/+68
| | | | | | | | | | | | | | | This doesn't time all loads of the new tab page, just new foreground tabs using ctrl+t or the plus button. This includes the time it takes to create the tab contents and logs the time until JS has started executing, domcontentloaded, and onload. Note: onload doesn't mean the page is done loading. We have "NewTabUI load" for that. BUG=23120 Review URL: http://codereview.chromium.org/242107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27918 0039d316-1c4b-4281-b951-d872f2087c98
* Set the default action of the import data dialog to "Import" andtony@chromium.org2009-10-021-0/+3
| | | | | | | | | | focus the button. BUG=19627 Review URL: http://codereview.chromium.org/259028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27916 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my revert because it causes more problems.nsylvain@chromium.org2009-10-022-34/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27912 0039d316-1c4b-4281-b951-d872f2087c98
* revert this change because protoc.exe crashes during compile and breaks the ↵nsylvain@chromium.org2009-10-022-1/+34
| | | | | | | | | | | | | try servers: Set the LITE runtime optimization flag in sync.proto. This generates c++ code without support for protobuf reflections, and shaves 175000 bytes off of the final release size of syncapi.dll. Review URL: http://codereview.chromium.org/242133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27910 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the test while I figure out why it is flaky.finnur@chromium.org2009-10-021-1/+1
| | | | | | | | | | And update the version number (forgot in my last changelist). No code change there. TBR=nsylvain Review URL: http://codereview.chromium.org/255066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27906 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a filing test temporarily.jcampan@chromium.org2009-10-021-1/+2
| | | | | | | | | TEST=None BUG=23683 TBR=cpu Review URL: http://codereview.chromium.org/257040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27905 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 18:55:50 +0000