| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=18201
TEST=PersonalDataManagerTest.SetProfiles
Review URL: http://codereview.chromium.org/545175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31008
TEST=Right click in the content area, there will be an "Input Method" submenu.
Review URL: http://codereview.chromium.org/549100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Modified chrome.tabs.executeScript so that it sends error message if
failure in sending message (which happens with phantom tabs).
. When a tab is made phantom we send TabInsertedAt event.
. Made connecting to a phantom tab send disconnect.
. Disallow changing the url of pinned tabs.
. Disallow closing phantom tabs.
. Detect language fails for phantom tabs.
And I removed the flag for phantom tabs.
BUG=25309
TEST=on windows or chromeos create a window with a couple of tabs, pin
the first, then close it. Selection should change to another tab and
the favicon of the closed tab should remain, but not the tab
border. control-tab should not select the phantom tab, but if you
click on the phantom tab it should become live again and the border
should reappear.
Review URL: http://codereview.chromium.org/552110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32927
TEST=make sure you can bring up the options dialog without hitting a
DCHECK (only on debug builds).
Review URL: http://codereview.chromium.org/546119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32782
TEST=unit_tests
Review URL: http://codereview.chromium.org/555033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also fixes a related bug not mentioned in the report: app global commands like New Window etc. are disabled when the bookmark manager is active.
BUG=32200
TEST=none (see bug description)
Review URL: http://codereview.chromium.org/551100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32938
TEST=ChromiumOS valgrind becomes happier.
Review URL: http://codereview.chromium.org/553062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
plugins since we do not unload them now, thus they already show up in the module list.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderers.
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.
BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests
Review URL: http://codereview.chromium.org/509016
TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/549138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is currently no distinction between the 32 and 64 bit
build, so this extends the UMA used version to include a postfix "-64" for 64 bit architecture.
This will currently only appear in the stability reports,
but RSN we'll have separate histograms as well.
r=evanm
Review URL: http://codereview.chromium.org/552028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* defined UIStyle enum
* fixed #if for compact navbar so that it's enabled only on chromeos
* Moved view initialization and layouts code from NormalExtender to chromeosBrowserView and ChromeosBrowsrViewLayoutManager respectively.
* Removed unnecessary extender code from BrowserView.
* no functional change
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateSyncErrorButton is not unused anywhere.
Original CL by thiago.farina@gmail.com: http://codereview.chromium.org/549003/edit
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/552095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There was a problem with pages that call window.close() then immediately open a js alert. The problem was that the TabContents would get destroyed, but the alert would stick around, and when you closed the alert, it would try to call back to the tab contents' js, crashing chrome. The other OSs got around this by closing the alert immediately, but mac didn't implement the CloseModalDialog method. This CL implements that.
BUG=29580
TEST=Run the html attached to the bug
Review URL: http://codereview.chromium.org/549126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window
BUG=32827
TEST=Open incognito window. Wrench menu --> Preferences --> Basics --> Manage. Don't crash.
Review URL: http://codereview.chromium.org/545177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist implements the following:
- A resize gripper and chevron in the browser action container
- Overflow when icons don't fit
- Snap to multiple of icon size (no excess pixels)
- Animation when resizing container / adding&removing icons (disable, enable).
- Persists the last width of the browser action container.
Known issues:
- No menu (yes, the chevron button doesn't do anything yet).
BUG=32101
TEST=Install and uninstall browser actions & make sure install bubble appears in
the right location. Make sure browser action container does not expand if
chevron is showing when you add browser action. Make sure container loses
chevron when no overflow occurs. Make sure browser action icons never disappear
due to shrinking when you release the mouse (when resizing). Make sure snapping
works.
Review URL: http://codereview.chromium.org/553039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is half the solution, but it should make some stuff work. This should make
double-clicking on local HTML files (when Chromium is set as default browser)
work more correctly, both when Chromium is already running and when it's not.
(The same, but easier to check: dragging a file or files to the Chromium
application icon.) You should no longer be told that Chromium can't open HTML
files. It's not the full solution since an extraneous (NTP/home page) tab -- or
worse -- will be created if Chromium is not already running; solving this will
require modifying browser startup.
BUG=14808
TEST=Drag a file to the Chromium application icon, both when it's already running and when it's not; file should open in a tab. Do the same, but select multiple files; selected files should open in tabs. Check the same for the Chromium Dock icon (when Chromium is already running). Note that if Chromium is not running, there will be an extraneous (NTP or home page) tab.
Review URL: http://codereview.chromium.org/552109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32844
TEST=URLFetcherCancelTest.CancelWhileDelayedStartTaskPending
Review URL: http://codereview.chromium.org/552107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/546110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.
BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests
Review URL: http://codereview.chromium.org/509016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/553058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added a --enable-openmax switch to enable OpenMAX for video
decoding.
Review URL: http://codereview.chromium.org/555046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
popup is shown would hose the browser.
BUG=32653
TEST=none
Review URL: http://codereview.chromium.org/554044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it depends on how child views are laid out.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It simply records the uptime into the tmp directory for metrics collection
BUG=none
TEST=none
Original review: http://codereview.chromium.org/548044
Patch by sosa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
New Folder when Bookmark Bar or Others selected.
BUG=32732,32733
TEST=BookmarkTreeControllerTest.NewFolder
Review URL: http://codereview.chromium.org/549125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25309
TEST=none
Review URL: http://codereview.chromium.org/551118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
couldn't be loaded. it segfaulted. This makes it not die, disable login, and tell the user. Not so much so that a user could do anything about it, but so that devs can run chromeos chrome on their linux machines and develop the login UI there.
BUG=NONE
TEST=run chromium for chromium OS on your linux box with the --login-manager flag, and watch it not segfault :-)
Review URL: http://codereview.chromium.org/555036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobars.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most themes have specific data for a "MetaFrames" class that we weren't using. This fixes the titlebar color
for the xfce themes. I suspect that this also fixes 32173, but I don't have
a Karmic machine yet so I can't test.
BUG=32173
TEST=Themes with different titlebar and selection colors (Xfce-b5 was what I
tested with) shouldn't use the selection color for the titlebar.
Review URL: http://codereview.chromium.org/552092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialization into IOThread.
The global host resolver and dns master have changed to be member variables of IOThread.
BUG=26156,26159
Review URL: http://codereview.chromium.org/553026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/552102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have per platform config and overrides. This is easier to manage
than the mess of <if>'s in the existing grd and xtb files.
Each platform only builds its locale_settings_{win,mac,linux}.grd file.
All the grd files generate the same platform_locale_settings.h
header (for easy inclusion in .cc files).
We use the fallback feature of grit to only specify locale specific values
in xtb files if we want to override the default for the locale.
BUG=28590
Review URL: http://codereview.chromium.org/545132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac/linux (and they
were green) but they aren't.
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/552098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Introduce an equivalence class enum to group sync model types that live on the same
chrome native model together.
- Remove ModelSafeWorkerBridge as it is no longer needed.
- Rename BookmarkModelWorker -> UIModelWorker, and make it use the new stuff.
- Allow syncable entries belonging to an "unsynced" model type to be just
processed "passively" from
the SyncerThread (rather than dispatching), and allow this to change as a result
of enable/disabling.
- Experimenting with a way to complete issue 31909 (the CLASS_UNASSOCIATED
stuff).
BUG=31925,31911,31909
Review URL: http://codereview.chromium.org/553015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
persistent cookies as reported in bug 30786.
TEST=Run FullTabModeIE_ChromeFrameDeleteCookieTest.
BUG=32546,30786
Review URL: http://codereview.chromium.org/551101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The body of OnPromptShown handles default focus.
BUG=none
TEST=middle click on a link that requires http auth in debug mode, the browser shouldn't crash
Review URL: http://codereview.chromium.org/554042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.
Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Everyone once in a while gtk_drag_begin() returns NULL meaning the drag failed to start. Inform webkit of this.
BUG=30580
TEST=see bug
Review URL: http://codereview.chromium.org/548108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
situations, leading to a stuck throbber.
BUG=31462
TEST=see bug
Review URL: http://codereview.chromium.org/554025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/545160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible this will move the crash location elsewhere, but since we don't even support showing badges on PageActions, we have no reason to attempt it.
BUG=http://crbug.com/31080
TEST=Monitor the crash rate and see if the crash is fixed. Badges should still work on BrowserActions.
Review URL: http://codereview.chromium.org/551105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=exists
BUG=32013
Review URL: http://codereview.chromium.org/546094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32216
TEST=manually
Review URL: http://codereview.chromium.org/548051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30728
TEST=trybots
Review URL: http://codereview.chromium.org/548062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in in my last checkin and added things I was working on but didn't want checked in yet). :/
TBR=oshima
BUG=http://crbug.com/28629, http://crbug.com/16447
TEST=None
Review URL: http://codereview.chromium.org/554041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
selection.
XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.
BUG=32627
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.
Review URL: http://codereview.chromium.org/546102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the time.
See http://crbug.com/28629 for details.
TBR=pkasting
BUG=http://crbug.com/28629, http://crbug.com/16447
TEST=None
Review URL: http://codereview.chromium.org/552086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36795 0039d316-1c4b-4281-b951-d872f2087c98
|