summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* First steps toward page actions on Mac. Page action icons shold show andpamg@google.com2009-12-147-67/+551
| | | | | | | | | | | | | | | | | | | | | perform their click actions when clicked. This is very rough, being committed in an early form so more people can contribute to the effort. Includes some early work from andybons too, toward making popups work. Known issues: * Icons don't refresh properly when an extension is installed or removed. Switching windows, then back again, updates the location bar properly. * Right- and middle-clicks do nothing * No tooltips, badges, installation previews, or popups yet * No unit tests yet BUG=12281 TEST=none yet Review URL: http://codereview.chromium.org/427009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34509 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for http://crbug.com/29473estade@chromium.org2009-12-141-2/+32
| | | | | | | | | BUG=29473 TEST=it passes Review URL: http://codereview.chromium.org/486037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few languages: sync dialog box was cutting off the cancel button.chron@google.com2009-12-142-6/+6
| | | | | | | | | | | | Add padding to throbber. Fix merge and sync cutoff. BUG=27770, 29767, 29788, 29782, 29647 TEST=manually checked all languages, Review URL: http://codereview.chromium.org/460123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34502 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor browser action apitest and port for mac.kkania@chromium.org2009-12-1411-135/+225
| | | | | | | | BUG=29709 TEST=none Review URL: http://codereview.chromium.org/443013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 30244xiyuan@chromium.org2009-12-141-2/+3
| | | | | | | | | | | | Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew IME generated Shift+Ctrl does not pass through and triggers RTL. BUG=30244 TEST=Verify fix for 30244 and issue 24888 does not regress. Review URL: http://codereview.chromium.org/497010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34497 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "open in incognito window" for incognito windows.avi@chromium.org2009-12-141-0/+8
| | | | | | | | | BUG=http://crbug.com/24637 TEST=as in bug Review URL: http://codereview.chromium.org/488018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34496 0039d316-1c4b-4281-b951-d872f2087c98
* [extensions] Position browser action popup correctly for RTL languages.mhm@chromium.org2009-12-141-1/+3
| | | | | | | | | | | ExtensionPopup::Show was hard coded to use BubbleBorder::TOP_RIGHT, by changing it to be dynamic that depends on UI Layout fixes this issue. BUG=29807 TEST=Change chrome language to Arabic, install Sidewiki, the popup will position itself correctly. Review URL: http://codereview.chromium.org/494008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34491 0039d316-1c4b-4281-b951-d872f2087c98
* Persist the order of extensions in the browser action toolbar across sessions.estade@chromium.org2009-12-145-14/+122
| | | | | | | | | | Very similar to what we did with the extension shelf. BUG=26990 Review URL: http://codereview.chromium.org/487021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34490 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension shutdown notification, take 2.estade@chromium.org2009-12-144-9/+17
| | | | | | | | | | The first patch was broken because a lot of stuff relied on the EXTENSION_PROCESS_CRASHED notification being sent when the extension hadn't actually "crashed". New fix: rename the notification to EXTENSION_PROCESS_TERMINATED, and don't send unload notifications during browser shutdown. BUG=30057 Review URL: http://codereview.chromium.org/489009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34489 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: improve performance of tab dragging.estade@chromium.org2009-12-144-20/+22
| | | | | | | | | | | Remove two server trips and two byte swizzles by keeping the tab image server side (instead of piping it through an SkBitmap). This creates noticeably better performance on drawing attached dragged tabs (i.e. when you drag a tab to reorder it, but don't drag out of the tab strip) on non-compositing WMs (I suspect it is better for compositing as well, but did not test it). BUG=21657 TEST=see above Review URL: http://codereview.chromium.org/496002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34488 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI helper method to just get the sync status without needing labels.akalin@chromium.org2009-12-147-23/+60
| | | | | | | | | | | Patch by thiago.farina@gmail.com ( original code review: http://codereview.chromium.org/469017 ). BUG=none TEST=trybots Review URL: http://codereview.chromium.org/486044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34487 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2: Completely redo how themes are stored on disk and processed at ↵erg@google.com2009-12-1414-1505/+1768
| | | | | | | | | | | | | | | | | install time. Same as previous patch, except we now have a BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in ntp_resource_cache.cc. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Previous Review URL: http://codereview.chromium.org/460050 Review URL: http://codereview.chromium.org/499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
* Switch name of emit-login-prompt-ready target to use '_'; this fixes the ↵cmasone@google.com2009-12-141-1/+1
| | | | | | | | | scons build for chromium OS TBR=davemoore git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34471 0039d316-1c4b-4281-b951-d872f2087c98
* Retry landing the chrome-as-chromeos-login-manager changecmasone@google.com2009-12-148-16/+377
| | | | | | | Old CL: http://codereview.chromium.org/449023 Review URL: http://codereview.chromium.org/488007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34463 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WebSocket crash bug.ukai@chromium.org2009-12-143-12/+20
| | | | | | | | | | | | | | When closing the tab, ResourceDispatcherHost::Receiver is deleted, so all SocketStreamHost for the receiver should be deleted. Add CancelRequestsForProcess() in SocketStreamDispatcherHost that deletes all SocketStreamHost for the |host_id|. BUG=30290 TEST=visit http://wbe02.mibbit.com/?debug=true&channel=%23websocket, and close the tab. Didn't crash the browser. Review URL: http://codereview.chromium.org/494011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34456 0039d316-1c4b-4281-b951-d872f2087c98
* Make KeywordEditorCocoaController implement the proper protocols. Also removersesek@chromium.org2009-12-132-4/+6
| | | | | | | | | | | unnecessary ones from FontLanguageSettingsController. BUG=30155 TEST=Build with 10.6 SDK. Review URL: http://codereview.chromium.org/496006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34445 0039d316-1c4b-4281-b951-d872f2087c98
* [Windows] Fix issue 30123: REGRESSION: Alt-D causes system beepsuzhe@chromium.org2009-12-132-1/+39
| | | | | | | | | BUG=30123 TEST=Press Alt+D should not beep. Review URL: http://codereview.chromium.org/487035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34444 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable ExtensionDevToolsBrowserTest.TimelineApiyurys@chromium.org2009-12-121-1/+1
| | | | | | | | BUG=30087 Review URL: http://codereview.chromium.org/486033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34420 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove extension shelf code.viettrungluu@chromium.org2009-12-126-499/+4
| | | | | | | | | | | | | Otherwise, I'll shortly have to update it and test other changes against the extension shelf (or let bitrot set in). The extension shelf was removed from Chrome/Chromium. This code was left in for possible future use since doing so posed no cost. The corresponding code remains in the Windows version (for experimental purposes), but has also been removed from the Linux version. If this code is ever needed again, this patch will be the one to try to revert. BUG=30178 TEST=Trybots, to make sure everything still compiles and unit tests run cleanly. Review URL: http://codereview.chromium.org/495004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad rearrangement of code which causes notifications to crash. johnnyg@chromium.org2009-12-121-1/+1
| | | | | | | | | BUG=30109 TEST=none Review URL: http://codereview.chromium.org/490020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34402 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude chrome:// requests from showing up on the about:net-internals page.eroman@chromium.org2009-12-122-0/+12
| | | | | | | | | | | The problem is that most people would get to about:net-internals by first opening a new tab and then navigating it. Opening a new tab page generates lots of requests, which could end up overwriting things we cared about in the circular buffer of recent requests. BUG=30163 Review URL: http://codereview.chromium.org/491062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34401 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled toolstrip testsoshima@chromium.org2009-12-122-2/+10
| | | | | | | | | BUG=30151 TEST=Run browser_tests and ui_tests on linux_views. toolstrip tests should be disabled. Review URL: http://codereview.chromium.org/491058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34396 0039d316-1c4b-4281-b951-d872f2087c98
* Theme download status message, so that it's readable in themes of any color.mirandac@chromium.org2009-12-121-22/+39
| | | | | | | | BUG= 21176 TEST= Download something large in a dark or light theme. Note that status update (notification of how much data is left to download) is legible. Review URL: http://codereview.chromium.org/488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Completely redo how themes are stored on disk and processed at installerg@google.com2009-12-1114-1749/+1507
| | | | | | | | | | time," as it fails valgrind tests. This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379). Review URL: http://codereview.chromium.org/490025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34385 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: augment Strict Transport Security with the beginnings of SPDY upgrade.agl@chromium.org2009-12-117-81/+81
| | | | | | | | | | | | | | | | | | | | | | | This adds an opportunistic flag to the information that we store in the Strict Transport Security State. Given this, STSS might be misnamed now, but renaming it in this patch would add huge amounts of noise. We process the 'X-Bodge-Transport-Security' header which has the same format as the STS header. When we see this on an HTTP connection, we'll probe for a clean HTTPS path to the host and then remember it. This header should be considered mutually exclusive with STS, although this isn't enforced in the code. The remembered flag is currently ignored by the rest of the code. This will be addressed in a future patch. The header should be called 'Opportunistic-Transport-Security' in the future, but we have some issues to work out before we take that name. http://codereview.chromium.org/456011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34380 0039d316-1c4b-4281-b951-d872f2087c98
* Completely redo how themes are stored on disk and processed at install time.erg@google.com2009-12-1114-1507/+1749
| | | | | | | | | | | | | | | | | | | | Rewrites most of BrowserThemeProvider and adds a new class BrowserThemePack. BrowserThemePack takes all the logic of generating resources out of the BrowserThemeProvider, does all of them at theme install time (previously, we lazily generated all the button images and a good number of colors, which muddled logic quite a bit), and then writes all the data out into an mmap()able file to speed startup when a theme is installed. In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider now generates all of its images lazily and doesn't reach into the implementation details of BrowserThemeProvider as it used to. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Review URL: http://codereview.chromium.org/460050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34379 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back r34316 due to tab_switching_test failing. TBR=scherkusandybons@chromium.org2009-12-113-27/+2
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34374 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Fix license copyright text.evan@chromium.org2009-12-1112-14/+14
| | | | | | | | | | | Checked with debian/licensecheck.pl BUG=28291 Review URL: http://codereview.chromium.org/495001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34368 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame net tests randomly crash in the url request redirect tests ↵ananta@chromium.org2009-12-111-0/+7
| | | | | | | | | | | | | | | | | | | | | | on the chrome frame builder. Some debugging revealed that we send over two redirect responses from the IE host network stack implementation to Chrome, which causes a crash in the url request automation job while dereferencing a NULL request. Two redirect responses are sent in the following scenario:- 1. We received a redirect notification in our bind status callback. We abort the binding and return E_ABORT. 2. Eventually we receive a call in our bind status callback implementation of OnResponse even after the binding was aborted. This causes the response to be sent twice. Added a check for a NULL binding and a trace in the IE host network stack implementation. I also added a NOTREACHED in the url request automation job if we ever receive a message for an automation job which has a NULL request. Bug=30118 Review URL: http://codereview.chromium.org/487028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34360 0039d316-1c4b-4281-b951-d872f2087c98
* Change the cookies view so that the remove buttons are only enabled when ↵johnnyg@chromium.org2009-12-111-0/+4
| | | | | | | | | | | there are cookies in the list to remove. BUG=27663 TEST=none Review URL: http://codereview.chromium.org/486027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34356 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: sky@chromium.orgoshima@chromium.org2009-12-111-6/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34353 0039d316-1c4b-4281-b951-d872f2087c98
* Creating new CL for uploading a picture from ChromiumOSdavemoore@chromium.org2009-12-113-36/+341
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/452016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34351 0039d316-1c4b-4281-b951-d872f2087c98
* Moves cros_api.gyp into Chrome. The current situation (cros_api.gypdavemoore@chromium.org2009-12-111-0/+17
| | | | | | | | | | | living in third_party/cros) won't work as the SConstruct file in third_party/cros is different than the one Chrome wants (it's for the Chrome OS side). As a result, when chrome gclient syncs it clobbers third_party/cros/SConstruct and further syncs fail. Review URL: http://codereview.chromium.org/487016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34350 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-117-9/+6
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Pass one empty argument to ApuAgentDelegate.DispatchToApu to match ↵yurys@chromium.org2009-12-111-0/+1
| | | | | | | | | | ExtensionDevToolsBridge::OnRpcMessage. BUG=30087 Review URL: http://codereview.chromium.org/491046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34346 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable ExtensionDevToolsBrowserTest.TimelineApi which is ↵yurys@chromium.org2009-12-111-1/+1
| | | | | | | | | | | failing after 34337 TBR=pfeldman BUG=30087 Review URL: http://codereview.chromium.org/490015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34342 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-115-30/+20
| | | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34333 Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: use WebDevToolsMessageData for devtools rpc messages"yurys@chromium.org2009-12-114-15/+28
| | | | | | | | This reverts commit ea393f34b293ebf8b96bef5855b9f41faf82b192. Review URL: http://codereview.chromium.org/492018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34334 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-114-28/+15
| | | | | | Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34333 0039d316-1c4b-4281-b951-d872f2087c98
* Get web app icon via FavIconHelper and auto repair/updatexiyuan@chromium.org2009-12-1110-175/+599
| | | | | | | | | | | | | | | | | | | | | - Expose a DownloadImage method from FavIconHelper to download/decode image for an image url; - Expose FavIconHelper from TabContents; - Update CreateApplicationShortcutView to use the exposed DownloadImage method to get web app icon instead of do it via URLFetcher/PNGCodec; - Check and update web app icon and shortcuts when chrome is lauched as app for OS_WIN; - Code cleanup: - Move a bunch of FavIconHelper methods that are not used externally to private; - Remove an unused cancelable_consumer_ from TabContents; BUG=8539 TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog. Review URL: http://codereview.chromium.org/482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r34321 as it breaks the task manager:estade@chromium.org2009-12-112-15/+10
| | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r34321 | estade@chromium.org | 2009-12-10 18:19:50 -0800 (Thu, 10 Dec 2009) | 5 lines Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash). BUG=30057 Review URL: http://codereview.chromium.org/492014 Review URL: http://codereview.chromium.org/487023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34324 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar fixes:estade@chromium.org2009-12-114-20/+52
| | | | | | | | | | | | - prefer previous find from same tab contents over overall most recent find when re-opening find bar - GTK + Windows: always update find bar view text if it doesn't match the search results. TEST=see bug for repro steps BUG=30006 Review URL: http://codereview.chromium.org/482015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34322 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process ↵estade@chromium.org2009-12-112-10/+15
| | | | | | | | | | is fast-terminated (i.e., didn't crash). BUG=30057 Review URL: http://codereview.chromium.org/492014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34321 0039d316-1c4b-4281-b951-d872f2087c98
* fix chromeos buildoshima@chromium.org2009-12-112-4/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/492013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34319 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fixes bug where extension background hosts were being cleared when the ↵andybons@chromium.org2009-12-113-2/+27
| | | | | | | | | | last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown. TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window. BUG=28666 Review URL: http://codereview.chromium.org/465143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34316 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PhoneField, a FormField that matches a phone number field in a form.jhawkins@chromium.org2009-12-113-0/+160
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34311 0039d316-1c4b-4281-b951-d872f2087c98
* Display channel in about box after version. Windows.jrg@chromium.org2009-12-101-1/+75
| | | | | | | | | BUG=3000 TEST=see bug Review URL: http://codereview.chromium.org/463062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromiumos build, try 2estade@chromium.org2009-12-101-1/+2
| | | | | | | tbr=oshima git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos compileestade@chromium.org2009-12-101-1/+1
| | | | | | | | TBR=wtc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34291 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame uses the IPC automation channel to talk to Chrome. The IPC ↵ananta@chromium.org2009-12-104-2/+155
| | | | | | | | | | | | | | | | | messages sent by ChromeFrame are handled by the AutomationProvider class in Chrome, which also handles other IPC's not used by ChromeFrame. We now have a new class ChromeFrameAutomationProvider which derives from the AutomationProvider class and validates that incoming IPC messages are valid ChromeFrame messages. Bug=29931 Test=Covered by unit test Review URL: http://codereview.chromium.org/476008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34290 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 20:51:50 +0000