summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Resolve issue 22731jhawkins@chromium.org2010-01-113-21/+12
| | | | | | | | | | | | | | The RenderViewHost for the TabContents of a DraggedGtkTab was changing, and the dragged tab was using the backing store associated with the invalidated RenderViewHost. BUG=22731 TEST=See issue description Patch from Garret Kelly <gdk@chromium.org> Review URL: http://codereview.chromium.org/550002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35933 0039d316-1c4b-4281-b951-d872f2087c98
* Made GaiaAuth use Chrome threads instead of libjingle threads.akalin@chromium.org2010-01-112-71/+106
| | | | | | | | | | | | | | | | | This partially solves the issue in 30721, as it makes sure that there is a Chrome message loop for the SSL socket adapter on OS X/Linux. However, although it has stopped crashing, gaia authentication still times out. Renamed GaiaAuth::WorkerThread to GaiaAuth::WorkerTask and cleaned it up. BUG=30721 TEST=manual Review URL: http://codereview.chromium.org/542003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35932 0039d316-1c4b-4281-b951-d872f2087c98
* Cocoa bookmarks manager fixes:mark@chromium.org2010-01-112-4/+11
| | | | | | | | | | | | | | | | - -[NSTableView selectRow:byExtendingSelection:] was deprecated in 10.3 and is superseded by -[NSTableView selectRowIndexes:byExtendingSelection:]. - -[BookmarkGroupsController tableView:shouldEditTableColumn:row:] must be declared in an @interface if it is to be called. - In BookmarksOutlineView, -[NSOutlineView delegate]'s id<NSOutlineViewDelegate> must be cast to BookmarkTreeController* before using as a BookmarkTreeController*. BUG=none TEST=none Review URL: http://codereview.chromium.org/549008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35930 0039d316-1c4b-4281-b951-d872f2087c98
* Use dropdown bar for compact location bar.oshima@chromium.org2010-01-1110-179/+413
| | | | | | | | | | | | | | | | | | | | * Refactored CompactLocationBar to Host/View to use DropdownBarHost/View. * Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar. Following features are not implemented yet. * Window cripping while animating. * Adjust location when toolbar is shown (it's always under tab) * clipping autocomplete dropdown. Timer code is no longer used right now, but is left intentionally as we may put it back. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35674 Review URL: http://codereview.chromium.org/525018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35929 0039d316-1c4b-4281-b951-d872f2087c98
* Clear the host cache when closing the last incognito window.eroman@chromium.org2010-01-114-41/+59
| | | | | | | | | | | | This avoids retaining navigation history relating to the incognito window. I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary. BUG=24629 Review URL: http://codereview.chromium.org/523076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35923 0039d316-1c4b-4281-b951-d872f2087c98
* Add two AutoFill prefs. autofill.infobar_shown is true if the autofill ↵jhawkins@chromium.org2010-01-114-8/+54
| | | | | | | | | | infobar has been shown to the user. autofill.enabled is true if the user has accepted the autofill confirmation infobar. BUG=none TEST=none Review URL: http://codereview.chromium.org/541001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35917 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Increase the width for 'date-container' in download.html to 110px to make ↵jshin@chromium.org2010-01-112-6/+17
| | | | | | | | | | | | | | | room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). BUG=21699 TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. Review URL: http://codereview.chromium.org/381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35908 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fixes regression where the I-Beam was not being shown when hovering ↵andybons@chromium.org2010-01-111-4/+7
| | | | | | | | | | over the Omnibox while it was out of focus. BUG=31449 TEST=Hover over the omnibox when it is out of focus (but the app is in focus). Observe that the I-Beam is shown instead of the arrow cursor. Review URL: http://codereview.chromium.org/544007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35906 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two fullscreen bugs on views/gtk:sky@chromium.org2010-01-114-74/+100
| | | | | | | | | | | | | | | . On X changing fullscreen is asynchronous. This means we have to ask the window to change it's fullscreen state, then once changed update the necessary things. . ExtensionShelf is needlessly triggering a bunch of layouts when we toggle fullscreen state. BUG=31143 TEST=see bug Review URL: http://codereview.chromium.org/542001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35905 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HandleKeyboardEvent() method in HtmlDialog implementations.suzhe@chromium.org2010-01-115-0/+42
| | | | | | | | | | | To send unhandled keyboard events to the system default handler, so that system accelerators can work as normal. BUG=30707: Keyboard shortcuts failed to work on Bookmark sync Sign in Authentication dialog TEST=See bug report. Review URL: http://codereview.chromium.org/525112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35902 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark bar context menu wouldn't show whensky@chromium.org2010-01-112-0/+5
| | | | | | | | | | | | | | clicking on the bookmark bar. The regression is the result of introducing AccessibleToolbarView as a superclass of BookmarkBarView and having it override ShowContextMenu. BUG=none TEST=right click on an empty spot of the bookmark bar and make sure you get a context menu. Review URL: http://codereview.chromium.org/544001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35901 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35888 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-102-14/+2
| | | | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/536009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35890 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-102-2/+14
| | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35888 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35883 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-2/+2
| | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Submitting to get perf numbers, will revert. Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35884 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-2/+2
| | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Submitting to get perf numbers, will revert. Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35883 0039d316-1c4b-4281-b951-d872f2087c98
* EntryKernel: change from assignable refs to puts.nick@chromium.org2010-01-093-68/+77
| | | | | | | | | | | | | | Make EntryKernel have only private data members. When we switch to protobuf based storage, we'll need to use getters and setters. BUG=30041 TEST=unit tests Review URL: http://codereview.chromium.org/500113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35879 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TaskManagerBrowserTest.NoticeExtensionChanges on XP until it is stable.tyoshino@google.com2010-01-091-0/+5
| | | | | | | | | | | TaskManagerBrowserTest.NoticeExtensionChanges is crashing occasionally on XP. BUG=31663 TBR=japhet,lzheng Review URL: http://codereview.chromium.org/536007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35864 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome OS build to support panel-dragging change.derat@chromium.org2010-01-093-11/+65
| | | | | | | | | | | | | | The window manager side of this change (already committed) is described at http://codereview.chromium.org/527005. This change also makes Chrome report the version of the IPC messages that it's using to the window manager at startup. TEST=built and tested that panel-dragging works as expected BUG=none Review URL: http://codereview.chromium.org/521070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35862 0039d316-1c4b-4281-b951-d872f2087c98
* linux: prompt before overwriting a file in downloadsevan@chromium.org2010-01-091-0/+2
| | | | | | | | | | | | We rename implicit downloads so they don't conflict with existing files, but we should prompt if you manually type in an existing filename. BUG=26117 Review URL: http://codereview.chromium.org/537005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35859 0039d316-1c4b-4281-b951-d872f2087c98
* official build and buildbots are now chromeos=1oshima@chromium.org2010-01-092-12/+3
| | | | | | | | | | | | valgrind bots are up (they're still red tho). I believe it's ready to check this in. BUG=None TEST=None Review URL: http://codereview.chromium.org/487003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35858 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set a minimum size for dialogs based on locale resourcesevan@chromium.org2010-01-094-7/+16
| | | | | | | | | | | GTK dialogs size to their contents, but sometimes the title is the longest string available. BUG=28024 Review URL: http://codereview.chromium.org/534006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35855 0039d316-1c4b-4281-b951-d872f2087c98
* Don't theme app/popup windowoshima@chromium.org2010-01-091-9/+22
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/535005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35853 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build error. jshin@chromium.org2010-01-091-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35852 0039d316-1c4b-4281-b951-d872f2087c98
* Make about:plugin page get rendered properly in Hebrew and Arabic Chrome. ↵jshin@chromium.org2010-01-092-25/+31
| | | | | | | | | | | | | | Also make it use the same font as other 'domUI' pages. While doing so, get rid of some unnecessary string conversions in browser_about_handler.cc BUG=31782 TEST=Run Chrome with --lang=ar / --lang=he on Windows (or LANGUAGE=ar or LANGUAGE=he on Linux) and go to 'about:plugins' page. The page should be properly 'RTLized'. Review URL: http://codereview.chromium.org/523153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35851 0039d316-1c4b-4281-b951-d872f2087c98
* Changes synchronous session restore to create windows after nestedsky@chromium.org2010-01-081-3/+19
| | | | | | | | | | | | | | | message loop returns. The problem with the old approach was we created a bunch of windows than exited the nested message loop. But because exit isn't processed immediately it meant someone could also ask for the nested loop to be exited and then you're hosed (one nested message loop still running). BUG=22878 TEST=none Review URL: http://codereview.chromium.org/519090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35850 0039d316-1c4b-4281-b951-d872f2087c98
* Move the extension messaging tests to be ExtensionApiTests. Remove the oldmpcomplete@chromium.org2010-01-082-107/+6
| | | | | | | | tests. Review URL: http://codereview.chromium.org/519087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35843 0039d316-1c4b-4281-b951-d872f2087c98
* Switch GTK's cookie_view_unittest.cc to use the TestingProfile's new ↵rsesek@chromium.org2010-01-081-46/+3
| | | | | | | | | | | Create/GetRequestContext() BUG=None TEST=Unit tests Review URL: http://codereview.chromium.org/529003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35840 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable ExtensionBrowserTest.AutoUpdate on non-linux platforms.asargent@chromium.org2010-01-081-1/+5
| | | | | | | | | BUG=31737 TEST=(this is re-enabling a test on win/mac) Review URL: http://codereview.chromium.org/537001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35836 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in RenderWidgetHostViewGtk that occurs if during paintsky@chromium.org2010-01-081-1/+4
| | | | | | | | | | | obtaining the backing store triggers a scroll. BUG=none TEST=none Review URL: http://codereview.chromium.org/523155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35831 0039d316-1c4b-4281-b951-d872f2087c98
* ThemeBackground class.oshima@chromium.org2010-01-0812-107/+151
| | | | | | | | | | | This simplifies the background painting of components on the frame in various tab modes. Removed unused code in status_are_view, as it's always compiled with views now. BUG=None TEST=None Review URL: http://codereview.chromium.org/517076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35828 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Manager key-equivalent improvementssnej@chromium.org2010-01-083-21/+112
| | | | | | | | | | | | | | | | The changes to the xib are: 1. Autosave splitter position 2. Disable empty-selection in left table view, so it comes up with the first row (bookmarks bar) selected 3. Wire up each table view as the other's nextKeyView. 4. Wire up right outline view as window's initialFirstResponder. BUG=31844 TEST=none Review URL: http://codereview.chromium.org/518089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35826 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/527033 for bryenug:sky@chromium.org2010-01-081-0/+4
| | | | | | | | | | | Allow URLs to be pasted as text. BUG=31776 TEST=see bug Review URL: http://codereview.chromium.org/529001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35825 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few pieces of the heuristic autofill:jhawkins@chromium.org2010-01-083-5/+7
| | | | | | | | | | | | * Escape a parenthesis. * Add firstname, lastname to the regular expressions for first and last name fields. * Compare the result of WebRegularExpression.match to -1 to mean not found. BUG=none TEST=none Review URL: http://codereview.chromium.org/530006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35822 0039d316-1c4b-4281-b951-d872f2087c98
* Made MenuController handle dynamic labels.akalin@chromium.org2010-01-083-5/+50
| | | | | | | | | | | Made AppMenuModel handle sync item dynamically. BUG=31691 TEST=made sure wrench menu item dynamically updates sync menu item Review URL: http://codereview.chromium.org/523147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35821 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to support communication with a privileged processcmasone@google.com2010-01-085-33/+66
| | | | | | | This change allows the chrome-login code to talk back to a privileged process and ask it to emit upstart signals and such. Eventually, this IPC will be changed to use DBus, probably when cryptohomed lands. Review URL: http://codereview.chromium.org/518086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35813 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ImportFormData and GetPossibleFieldTypes for PersonalDataManager, ↵jhawkins@chromium.org2010-01-086-5/+229
| | | | | | | | | | used by the AutoFillManager. BUG=none TEST=none Review URL: http://codereview.chromium.org/521067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35808 0039d316-1c4b-4281-b951-d872f2087c98
* Add autodetection of "intranet" redirection, for ISPs etc. that send typos ↵pkasting@chromium.org2010-01-0817-63/+392
| | | | | | | | | | and nonexistent addresses to custom pages, and plumb it to the code that puts up infobars when users type in a search that appears to be an intranet address, so we don't show these for erroneous cases. BUG=31556 TEST=none Review URL: http://codereview.chromium.org/525079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35807 0039d316-1c4b-4281-b951-d872f2087c98
* Simplified the api by replacing them with single Show(false) call and ↵oshima@chromium.org2010-01-0810-64/+58
| | | | | | | | | | | cleaned up linux/mac code. BUG=22036 TEST=None Review URL: http://codereview.chromium.org/523125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35803 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: temporarily disable Full Screen and Task Manager.viettrungluu@chromium.org2010-01-081-0/+8
| | | | | | | | | | | | | We need to do it in Browser, since the new common menu code (for the App and Page menus) doesn't look to the BrowserWindowController for their enabled status. BUG=31768 TEST=On Mac, make sure the Full Screen and Task Manager menu items are disabled in both the main menu and in the App and Page menus. On other platforms, make sure they still work as usual. Review URL: http://codereview.chromium.org/518085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35801 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in background tabs not getting sized correctly. We need tosky@chromium.org2010-01-081-1/+8
| | | | | | | | | | | | | set the size request, which triggers a layout. The old code wasn't updating the size request, so the hosting widget never changed the size. BUG=31132 TEST=see bug Review URL: http://codereview.chromium.org/523145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35796 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the "show certificates" button in under the hood to launch the ↵pinkerton@chromium.org2010-01-082-118/+132
| | | | | | | | | | | keychain access app. Change to the xib is to hook up the button's target/action and enable it. BUG=none TEST=click the button, watch the app launch. Review URL: http://codereview.chromium.org/523104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35795 0039d316-1c4b-4281-b951-d872f2087c98
* revert 35785. TBR=phajdan.jr@jochen@chromium.org2010-01-082-36/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35787 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK for error_string so future NULL pointers can be caughtjochen@chromium.org2010-01-081-0/+1
| | | | | | Review URL: http://codereview.chromium.org/523138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35786 0039d316-1c4b-4281-b951-d872f2087c98
* Also match against the query string if present.jochen@chromium.org2010-01-082-3/+36
| | | | | | | BUG=none TEST=BlacklistTest.QueryStringMatch git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35785 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionApiTest.Storage flaky only on Linux.tyoshino@google.com2010-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2628/steps/browser_tests/logs/Storage http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2604/steps/browser_tests/logs/Storage ExtensionApiTest.Storage: Got EXTENSION_LOADED notification. Got EXTENSION_HOST_DID_STOP_LOADING notification. C:\b\slave\chromium-dbg-builder\build\src\chrome\test\in_process_browser_test.cc(293): error: Test timed out. Each test runs for a max of 30000 ms (kInitialTimeoutInMS). C:\b\slave\chromium-dbg-builder\build\src\chrome\browser\extensions\extension_storage_apitest.cc(8): error: Value of: RunExtensionTest("storage") Actual: false Expected: true No response from message loop. BUG=22006 TBR=lzheng,japhet Review URL: http://codereview.chromium.org/525110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35784 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this.ananta@chromium.org2010-01-085-11/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function TBR=amit Review URL: http://codereview.chromium.org/521072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35778 0039d316-1c4b-4281-b951-d872f2087c98
* Move code duplicated in two tests up into the TestingProfile.rsesek@chromium.org2010-01-082-89/+27
| | | | | | | | | | | | | | | | Move TestURLRequestContextGetter and friends from CookieTreeModelTest and CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return a valid CookieMonster and URLRequstContextGetter, if CreateRequestContext() is called. Original CL: http://codereview.chromium.org/525072/show BUG=None TEST=Covered by unit tests Review URL: http://codereview.chromium.org/525106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35776 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a NetworkChangeNotifier dependency to ProxyService; when we observer a ↵eroman@chromium.org2010-01-082-3/+5
| | | | | | | | | | | | | | | network change through the notifier, the ProxyService re-configures itself. So for example, if you were to switch to VPN and are using a custom PAC URL, we will re-download that URL on the new network. Similarly if you are using auto-detect PAC settings, we will re-run the autodiscovery steps for the next resolve. Note that Chromium is still passing a NULL NetworkChangeNotifier dependency into its ProxyService -- until it passes a real implementation, this will not impact Chrome. BUG=12293 TEST=ProxyServiceTest.NetworkChangeTriggersPacRefetch Review URL: http://codereview.chromium.org/525104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35772 0039d316-1c4b-4281-b951-d872f2087c98
* Reason:tyoshino@chromium.org2010-01-084-45/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Linux Builder (ChromiumOS) failed. http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(ChromiumOS)/builds/2050/steps/compile/logs/stdio Please add changes to external_cookie_handler_unittest.cc no to break compilation and reland? ---- Revert 35769 - Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the SetCookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function Review URL: http://codereview.chromium.org/518054 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/517070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35771 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug of unnecessary "Confirm form resubmission" dialog.tkent@chromium.org2010-01-082-0/+58
| | | | | | | | | | | | | | | If a URL is requested by the POST method and then the page is redirected to another URL, NavigationEntry::has_post_data_ is not cleared correctly with the prior code. So "Confirm form resubmission" dialog is shown when a user asks reloading the redirected page. TEST=Add a unit test BUG=21245 Review URL: http://codereview.chromium.org/524057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35770 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 14:59:14 +0000