summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Convert InfoBubble to using BubbleBorder. This also replaces the border ↵pkasting@chromium.org2009-09-168-442/+476
| | | | | | | | | | | | graphics with a slightly darker set from Nicholas. The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one. BUG=21028 TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position. Review URL: http://codereview.chromium.org/195099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for history HTML escaping issue.cevans@chromium.org2009-09-161-0/+17
| | | | | | | | | BUG=17892 TEST=SessionHistoryTest.HistorySearchXSS Review URL: http://codereview.chromium.org/206040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26392 0039d316-1c4b-4281-b951-d872f2087c98
* Set OS X cache directory to ~/Library/Caches/[app name]/[profile name] mark@chromium.org2009-09-161-2/+36
| | | | | | | | | | | | | - Added implementation of GetUserCacheDirectory() for OS X. - Added FilePath::GetRelativePath(). - Implemented per-profile cache directories for OS X. Patch by Fred Akalin <akalin@gmail.com> Code review URL: http://codereview.chromium.org/174053 Review URL: http://codereview.chromium.org/204043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26387 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: memset the window command data structure. |timestamp| is aligned ↵jhawkins@chromium.org2009-09-161-2/+8
| | | | | | | | | | on a 16 byte boundary leaving 4 bytes of uninitialized data in the middle of the struct. We write this data to disk, which is a possible security risk. BUG=22031 TEST=TabRestoreUITest.RestoreToDifferentWindow Review URL: http://codereview.chromium.org/196144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26379 0039d316-1c4b-4281-b951-d872f2087c98
* First part of automated_ui_tests improvements.phajdan.jr@chromium.org2009-09-161-0/+21
| | | | | | | | | | | | - disable unreliable RestoreTab action - make more command sync, waiting for their completion TEST=none BUG=21547, 21636 Review URL: http://codereview.chromium.org/196096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26371 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/206025 for Charlie:sky@chromium.org2009-09-161-0/+5
| | | | | | | | | | | | Fix settings page transparent background issue Also comment out focus manager check due to bug: http://crbug.com/21378 TEST=none BUG=none Review URL: http://codereview.chromium.org/194128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26370 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up newer GTMthomasvl@chromium.org2009-09-164-24/+17
| | | | | | | | | | Switch a bunch of window sizing over to use the helper so it's completely in all cases. BUG=none TEST=about box, hung renderer, edit search engine, and http auto still size correctly. Review URL: http://codereview.chromium.org/201137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26369 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce severity of alert level when extension installation fails.pamg@google.com2009-09-161-1/+1
| | | | | | | | BUG=19907 TEST=as described in bug Review URL: http://codereview.chromium.org/204034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26366 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Polish dragging of ToolStrips'. This CL restricts the motion of ↵sidchat@chromium.org2009-09-161-1/+23
| | | | | | | | | the ToolStrip to just horizontal motions until it is dragged far enough from the extension shelf, in which case it is torn away from it (similar to Tabs). BUG=18443 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26362 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTRxji@chromium.org2009-09-161-11/+16
| | | | | | | | | | | | | | | | | | | directionality in download shelf. File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
* Build the sync unit tests:nick@chromium.org2009-09-163-33/+2
| | | | | | | | | | | | | | | | | | | - Remove old main(argc, argv) from syncable_unittest. - Since the old notifier target had only one unittest, merge it with the syncer tests. - Remove listener_unittest.cc entirely. - Don't compile natserver_main.cc, which has another main() - Use a test main from the test_support_unit library. This has the downside of pulling in a lot of deps we don't need, but it gives us a run_all_unittests.cc. - Fix a few compile errors in test code. TEST=unit tests pass BUG=none Review URL: http://codereview.chromium.org/205021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26358 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that HTML can't be executed when entered on the "Search History" or ↵mirandac@chromium.org2009-09-162-2/+2
| | | | | | | | | | | "Search downloads" pages. BUG= http://crbug.com/17892 TEST= Open history / downloads page. Search for "<h1>HI</h1>". Note that the HTML is not interpreted, but displayed as text. Review URL: http://codereview.chromium.org/201129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26357 0039d316-1c4b-4281-b951-d872f2087c98
* Improve tab-closability of right-most tab.thakis@chromium.org2009-09-161-5/+15
| | | | | | | | | BUG=21903 TEST=Open 20 tabs. Put mouse over close button of some tab in the middle and keep clicking to close tabs. When the tab below the mouse is right-most, closing it should cause the other tabs to grow so that another close box ends up below the cursor (until the remaining tabs have reached the maximum tab width). Review URL: http://codereview.chromium.org/196137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26354 0039d316-1c4b-4281-b951-d872f2087c98
* disable extension bar for nowthakis@chromium.org2009-09-161-0/+4
| | | | | | | | | BUG=none TEST=extension bar is no longer visible Review URL: http://codereview.chromium.org/206030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26352 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversionsmark@chromium.org2009-09-165-10/+11
| | | | | | | | | The SDK has gotten stupider in 10.6, and has conspired with the compiler, which now thinks that when the receiver is held in a scoped_nsobject, NSColor and NSSize arguments should be converted to their CG cousins. Review URL: http://codereview.chromium.org/205016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26348 0039d316-1c4b-4281-b951-d872f2087c98
* Add pause and resume to Linux download shelf.craig.schlenter@chromium.org2009-09-162-1/+6
| | | | | | | | BUG=16929 Review URL: http://codereview.chromium.org/203069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26344 0039d316-1c4b-4281-b951-d872f2087c98
* Edit Search Engine fix up:thomasvl@chromium.org2009-09-162-0/+47
| | | | | | | | | | | | | Fix the class name to match a rename that happened before commit. Make the label size changes force the fields over, but not string the fields (window grows). Make the url description autosize to the text it gets. Make the window track the height needed for the url description field. BUG=21893 TEST= The url description text should stay under the url box in all languages. The labels should never clip or overlap the text fields. Review URL: http://codereview.chromium.org/195096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26342 0039d316-1c4b-4281-b951-d872f2087c98
* Another try to fix a build break caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | This change just adds a namespace. I wish this fixes. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/201132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26322 0039d316-1c4b-4281-b951-d872f2087c98
* A quick build fix caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | It seems this "static_cast<GtkWidget*>(window)" has been moved from a static member "InfoBubble::Show()" to a non-static member "InfoBubble::Init()". So, we don't need this cast. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/204036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26321 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 21587, a regression of CL 196020.suzhe@chromium.org2009-09-163-20/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. It's a regression of my CL: http://codereview.chromium.org/196020, which reverts the text of omnibox in OnAfterPossibleChanges(), when enter key is pressed: ... // If the change is caused by an Enter key press event, and the event was not // handled by IME, then it's an unexpected change and shall be reverted here. // {Start|Finish}UpdatingHighlightedText() are called here to prevent the // PRIMARY selection from being changed. if (enter_was_pressed_ && (char_inserted_ == '\n' || char_inserted_ == '\r')) { StartUpdatingHighlightedText(); SetTextAndSelectedRange(text_before_change_, sel_before_change_); FinishUpdatingHighlightedText(); return false; } ... Unfortunately, this piece of code causes the char_inserted_ to be set to wrong value in HandleInsertText(), if the text has only one character. See the source code of HandleInsertText(): ... // Filter out new line and tab characters. // |text| is guaranteed to be a valid UTF-8 string, so it's safe here to // filter byte by byte. // // If there was only a single character, then it might be generated by a key // event. In this case, we save the single character to help our // "key-press-event" signal handler distinguish if an Enter key event is // handled by IME or not. if (len == 1) char_inserted_ = text[0]; ... This CL uses a boolean |enter_was_inserted_| instead of char |char_inserted_| to record the enter key status, to make sure it won't be reset unexpectly. The test has been updated to cover this case. An unexpected dns lookup issue in the test which causes a failure on Windows was also fixed. BUG=21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. TEST=Input one character in omnibox and press enter, the default link matched with the character should be opened. Review URL: http://codereview.chromium.org/200131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26315 0039d316-1c4b-4281-b951-d872f2087c98
* More miscellaneous cleanup bits to try and move info_bubble.* closer to my ↵pkasting@chromium.org2009-09-163-67/+51
| | | | | | | | | | locally rewritten versions, so that the diff will be readable. BUG=none TEST=none Review URL: http://codereview.chromium.org/196131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26312 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bare-bones extension shelf that displays extension items on OS X.thakis@chromium.org2009-09-1613-30/+658
| | | | | | | | | | | | | | | | | | | This brings our extension support to about the level it has on linux. One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this. Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe. The extension shelf uses the DownloadShelfView as background view for now. Screenie: http://imgur.com/wSHgU.png BUG=19073 TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble. Review URL: http://codereview.chromium.org/175025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: print page to file rather than using shared memory to send it to the ↵estade@chromium.org2009-09-163-28/+74
| | | | | | | | | | | | browser. BUG=9847 adapted from patch by <minyu.huang [at] gmail> Review URL: http://codereview.chromium.org/203062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26308 0039d316-1c4b-4281-b951-d872f2087c98
* Add SSL icons on Mac OS Xhawk@chromium.org2009-09-165-1/+122
| | | | | | | | BUG=14899 TEST=https sites have a lock icon in the address field, plain http sites do not Review URL: http://codereview.chromium.org/199072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26307 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Snow Leopard SDK errorsmark@chromium.org2009-09-162-2/+2
| | | | | | | error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing Review URL: http://codereview.chromium.org/204028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26304 0039d316-1c4b-4281-b951-d872f2087c98
* Build sync engine as part of the browser build.nick@chromium.org2009-09-1546-96/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | As before, syncapi is built as a dynamic library, and only on windows. The difference is that it's built from source, rather than being pulled in as a binary. Changes to sync engine code: * Use OS_WIN instead of OS_WINDOWS (requires build_config.h). * Rename platform-specific files to match the chrome convention. This allows them to be excluded by rules that already exist in chrome.gyp. The convention is either a /win/ directory, or an _win.cc at the end of the file. Other valid platforms are _mac, _linux, and _posix Changes to DEPS: * On Windows, pull in pthreads-win32. Changes to chrome.gyp: * Add new library targets for sync, notifier, sync_proto, and syncapi. Review URL: http://codereview.chromium.org/193103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
* applicationDockMenu: is used in the unit test, it should not be privatemark@chromium.org2009-09-152-1/+3
| | | | | | Review URL: http://codereview.chromium.org/201127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26294 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the AutocompletePopupPositioner into a BubblePositioner in ↵pkasting@chromium.org2009-09-1531-181/+215
| | | | | | | | | | | | preparation for using it to position both the Omnibox bubble and InfoBubbles. It now gets the bounds of the location stack, which can be turned into useful coordinates for both items. This should not result in any visible change. BUG=21028 TEST=none Review URL: http://codereview.chromium.org/194110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98
* Use a better highlight images for "hover" state and pushed "state".finnur@chromium.org2009-09-152-3/+3
| | | | | | | | | BUG=18452 TEST=Try different themes and make sure the extension toolstrips have a nice hover and "pushed" images (by hovering over and then clicking and holding the left mouse button). Review URL: http://codereview.chromium.org/201125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26287 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Connect signal handlers before initing widgets in browser window.estade@chromium.org2009-09-151-1/+1
| | | | | | | | | | | Moved the function call to the beginning of InitWidgets() to enforce this. BUG=21868 TEST=interactive ui tests still working locally Review URL: http://codereview.chromium.org/205012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26284 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "First part of automated_ui_tests improvements."phajdan.jr@chromium.org2009-09-151-21/+0
| | | | | | | | | | | | Revert "Fix Mac by disabling some UI tests on it." Too many failures. TBR=huanr Review URL: http://codereview.chromium.org/193118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26281 0039d316-1c4b-4281-b951-d872f2087c98
* Size the buffer used for the metrics log text properly.mark@chromium.org2009-09-151-4/+6
| | | | | | | | | | | | | | | | The existing code was abusing the WriteInto interface (base/string_util.h). The size passed to WriteInto should be the size of the string plus one for a terminating NUL byte. This bug caused the final newline in the log to be clipped. c_str users (there probably weren't any) would see the final newline which wouldn't be wouldn't be followed by a NUL byte. TEST=not really any BUG=21733 Review URL: http://codereview.chromium.org/194099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26280 0039d316-1c4b-4281-b951-d872f2087c98
* Some scaffolding for the task manager.thakis@chromium.org2009-09-154-1/+162
| | | | | | | | | BUG=13156 TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button). Review URL: http://codereview.chromium.org/200094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26278 0039d316-1c4b-4281-b951-d872f2087c98
* Land review 193091: Avoid unnecessary conversions between wchar_taa@chromium.org2009-09-151-3/+3
| | | | | | | | | and wstring. TBR=erikkay@chromium.org Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26277 0039d316-1c4b-4281-b951-d872f2087c98
* Unified the color definitions for the dividers so that extension shelf is ↵finnur@chromium.org2009-09-154-14/+15
| | | | | | | | | | using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did. BUG=18452 TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds. Review URL: http://codereview.chromium.org/204026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26274 0039d316-1c4b-4281-b951-d872f2087c98
* First part of automated_ui_tests improvements.phajdan.jr@chromium.org2009-09-151-0/+21
| | | | | | | | | | | | - disable unreliable RestoreTab action - make more command sync, waiting for their completion TEST=none BUG=21547, 21636 Review URL: http://codereview.chromium.org/196096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26272 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome should shut down cleanly when quit from the Dock icon menu, duringmark@chromium.org2009-09-1510-72/+133
| | | | | | | | | | | | | | | | | | | | | | user logout, and during system restart and shutdown. MainMenu.xib changes (because you're not expected to parse nibs yourself): - The quit menu item's action is changed from the AppController object's -quit: method (which no longer exists) to the application object's -terminate: method (the Cocoa standard). - The application and owner object types are changed from NSApplication to CrApplication. - The application menu name is changed from Chromium to ^IDS_SHORT_PRODUCT_NAME. Cocoa doesn't use this anyway, it gets replaced at runtime with the localized value of CFBundleName, but we shouldn't have branding-specific strings in our nibs. BUG=18078 TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch. You should NOT see the "Google Chrome didn't shut down correctly" info bar. Review URL: http://codereview.chromium.org/201121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26269 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mole/toolstrip URLs properly.erikkay@chromium.org2009-09-152-7/+32
| | | | | | | | | | | | | * expand/collapse to chrome-extension://crashme no longer crashes * expand/collapse to a relative URL now works BUG=20412,21905 TEST=browser_tests ExtensionApi.Toolstrip (note that the test doesn't actually exercise these changes due to 21905) Review URL: http://codereview.chromium.org/195093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26266 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-1517-53/+57
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to svn add files when landing patch.sky@chromium.org2009-09-154-0/+685
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/193115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26261 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the sqlite cookie database and web database to use the new sqlitebrettw@chromium.org2009-09-1510-549/+989
| | | | | | | | | | | wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/193032 for Charlie:sky@chromium.org2009-09-155-4/+36
| | | | | | | | | | | | | | | First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
* Address ExtensionApiTest.Tabs flakinessrafaelw@chromium.org2009-09-151-2/+1
| | | | | | | | | | | | This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add support for SELinux.agl@chromium.org2009-09-151-16/+62
| | | | | | | | | | | | | | | | | | This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Tell the AppCacheService which request context to use when fetching ↵michaeln@google.com2009-09-151-2/+4
| | | | | | | | | | | | | resources for updates. Done for both chrome and test_shell. The service does not yet take a reference to that context, because the extra reference apparently gives some tests grief. 2) Added methods to generate new storage ids for different object types on the IO thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/195077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26253 0039d316-1c4b-4281-b951-d872f2087c98
* Keyword editor fixes:thomasvl@chromium.org2009-09-151-0/+8
| | | | | | | | | | | | | | | | | The "make default" button Auto size to always fit the text. Be a small style control, look better (changes font). General fix up so the window resizes. TableView Turn off column select Turn off multiple selection (code doesn't support it on delete). Update the xib for the class name change that happened as part of the prior commit. BUG=21892 TEST=window resize correctly, make default button fits it's text for all languages. Review URL: http://codereview.chromium.org/206016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26252 0039d316-1c4b-4281-b951-d872f2087c98
* Committing original patch http://codereview.chromium.org/178036paul@chromium.org2009-09-151-6/+7
| | | | | | | | | | | | | by Vassili Bykov. BUG=19983 TEST=Follow the steps in the bug to test the bubble's move-out-of-the-way behavior with dowload shelf both visible and hidden. Review URL: http://codereview.chromium.org/200135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26250 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the pageup, Shift-pageup, and Option-Shift-pageup keys scroll the ↵rohitrao@chromium.org2009-09-151-0/+22
| | | | | | | | | | underlying webpage when using the findbar. BUG=http://crbug.com/17421 TEST=Try pressing pageup with focus in the findbar. Review URL: http://codereview.chromium.org/204006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26246 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the text color is set correctly for incognito themes until we ↵pinkerton@chromium.org2009-09-151-0/+13
| | | | | | | | | | theme them correctly BUG=20707 TEST=tab text appears correctly in incognito. Review URL: http://codereview.chromium.org/196123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26232 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Restore focus to the previously focused view when dismissing the find bar.rohitrao@chromium.org2009-09-156-1/+195
| | | | | | | | | | | | | | If a result was found, restore focus to the tab contents. This allows for keyboard navigation using the find bar. Now with fix for valgrind failure. This CL reverts 26219, which in turn reverted 26214. BUG=http://crbug.com/12657 BUG=http://crbug.com/21374 TEST=See test case in bug 21374 Review URL: http://codereview.chromium.org/205010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26231 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 14:02:39 +0000