summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix a crash during extension installation (debug only).erikkay@google.com2009-06-151-4/+1
| | | | | | | | | | BUG=none TEST=browser_tests.exe --gtest_filter=ExtensionViewTest.Incognito Review URL: http://codereview.chromium.org/126151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://crbug.com/13971: OSX: Text copied from Omnibox is styledjeremy@chromium.org2009-06-154-4/+152
| | | | | | | | | | | Provide a custom field editor for the location bar that overrides cut/copy to only write plain text to the clipboard. BUG=13971 TEST=Type a URL in the Omnibox, select all and copy url, open Textedit and paste the url into it. Expected results: url should be unstyled previous behavior: styled text (as it appeared in the Omnibox was pasted) Review URL: http://codereview.chromium.org/126075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18425 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers for Windows and re-enable building of LoginDatabase.stuartmorgan@chromium.org2009-06-151-0/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18423 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where keyword editor would end up prefixing all keyword urlssky@chromium.org2009-06-1514-71/+77
| | | | | | | | | | | | | | | | with "http://" if they didn't have one. This proves problematic as for the google search url we don't have http:// and don't want it. The fix is to only add http:// if the url field is editable. If the url field isn't editable, we know the user hasn't editted it and don't need to try and fix it up. BUG=13282 TEST=see bug, but also make sure you don't run into any other problems with the keyword editor. Review URL: http://codereview.chromium.org/126052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18410 0039d316-1c4b-4281-b951-d872f2087c98
* Make tooltips work correctly, allowing for multiple tooltips w/out the mouse ↵pinkerton@chromium.org2009-06-152-7/+39
| | | | | | | | | | leaving the view (which is all NSView can handle by itself). Adds some Camino code to do so. BUG=13995 TEST=tooltips in web pages, pages with multiple tooltips, expose and spaces. Review URL: http://codereview.chromium.org/125133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18408 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add support for chrooted renderers.agl@chromium.org2009-06-154-2/+321
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a UMR that happens while trying to forward mouse events.tc@google.com2009-06-151-2/+5
| | | | | | | | | | | | | The input param gets clobbered so we need to make a copy before using it. TEST=Run chrome via valgrind and move the mouse over the content area. There should be no errors. Review URL: http://codereview.chromium.org/126081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18404 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6223 (comment #10 and #15).xji@chromium.org2009-06-151-10/+54
| | | | | | | | | | | | | | | | | | | | | There are the following 3 issues: 1. the tab image in gray box is wrong in RTL locale. This is fixed by flipping canvas in RTL locale when draw those images. 2. dropped tab was not rendered in the correct position when gray box appears but the tab was not dropped inside the gray box. This is fixed by adjusting x coordinate of the dropped tab when there is dock information available in RTL in CompleteDrag(). 3. when chrome is maximized, drag/drop a tab to left/right window, then drag the tab through original main browser tabstrip and drop it anywhere else, dropped tab was not rendered in the right position. This is fixed by initialize window create point based on source_tabstrip_, not attached_tabstrip_, and move the initialization function from Attach() (since the position is no longer related to attached_tabstrip_) to CaptureDragInfo() where the mouse_offset_ is set. BUG=http://crbug.com/6223 TEST= 1. Open Hebrew Chrome, 2. drag a tab to the right of the screen till the gray box showed up, the tab image showed in the gray box should be similar to the tab image in Hebrew Chrome (not that in English Chrome), 3. drop the tab outside of the gray box while gray box is showing, the dropped tab should be rendered using the mouse click as the top-right corner (not top-left corner). 4. maximize chrome and open at least 2 tabs in it. 5. drag a tab out to left screen till the "left-half of screen" gray box showed up and drop it inside the gray box so that the tab was in the left-half of the screen and the original chrome browser is still maximized. 6. drag this tab back to the title of chrome (as if to re-insert it back to the maximized chrome's tabstrip) but do not release mouse, continue drag it back to somewhere on the screen and drop it. The dropped tab should be rendered using the mouse click as a point in its tabstrip (not rendered far away from the mouse click). Review URL: http://codereview.chromium.org/126006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18401 0039d316-1c4b-4281-b951-d872f2087c98
* Use linked_ptr for the ExternalExtensionProviders.finnur@chromium.org2009-06-152-35/+36
| | | | | | | | | BUG=None TEST=Covered by automated tests. Review URL: http://codereview.chromium.org/125137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18400 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up extension loading:erikkay@google.com2009-06-158-303/+365
| | | | | | | | | | | | | | | | | | | * load extensions from prefs rather than by scanning filesystem * fix multiple loading bug * in-place upgrade * split out Init() behavior into individual pieces that can be called by tests Also: * add look up of extension by URL * rename GetExtensionByID -> GetExtensionById BUG=12399 BUG=14053 TEST=ExtensionServiceTest.* Review URL: http://codereview.chromium.org/125102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in CocoaUtils::SkBitmapToNSImagenirnimesh@chromium.org2009-06-151-0/+1
| | | | | | Review URL: http://codereview.chromium.org/125127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18396 0039d316-1c4b-4281-b951-d872f2087c98
* Extract form related classes from the guts of WebFrameImpl.darin@chromium.org2009-06-1513-25/+43
| | | | | | | | | | | | | | | | | | | Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so. This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API. Most significant change: Now, RenderView always sets a NavigationState on WebDataSource instances. We used to only do so for browser initiated navigations. This is done so that we can store things like SearchableFormData and friends on the NavigationState. To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement. This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens. Some of the other changes are about moving more things into the webkit_glue namespace. On hindsight, I probably should have done that as a separate CL. BUG=10041 TEST=none R=brettw Review URL: http://codereview.chromium.org/126083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18395 0039d316-1c4b-4281-b951-d872f2087c98
* Popuplate bookmark menus on 1st launch.jrg@chromium.org2009-06-152-3/+22
| | | | | | | | | | | | | BUG=13794 TEST=launch Chrome. Before doing anything (e.g. changing focus or creating new windows), make sure the bookmark menu is populated. If you have no bookmarks you'll need to add them ('star' some URLs) then restart Chrome. Review URL: http://codereview.chromium.org/125094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18394 0039d316-1c4b-4281-b951-d872f2087c98
* Badge browser window with incognito icon when in incognito modepinkerton@chromium.org2009-06-151-0/+28
| | | | | | | BUG=12536 TEST=incognito icon on window opened in incognito mode git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18390 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronizes message types.sky@chromium.org2009-06-151-12/+42
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18387 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting Rev 18383 since it brings down the performance of single core page ↵mad@chromium.org2009-06-159-226/+85
| | | | | | cyclers too much... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18385 0039d316-1c4b-4281-b951-d872f2087c98
* This is to thest the page cycler performance without the resize corner, to ↵mad@chromium.org2009-06-159-85/+226
| | | | | | | | | | | | | see if these paint optimizations are worth it. I will revert these changes as needed... You may revert them yourself if they cause you trouble before I get to revert them. I have tested these changes on two different linux configuration, but there are more code paths that I couldn't verify myself, though agl gave me the OK anyway. These changes have already been reviewed here: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18383 0039d316-1c4b-4281-b951-d872f2087c98
* Revert processing naming change, which breaks UI tests iterating over thedeanm@chromium.org2009-06-151-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chrome processes by name. Reverting: commit b60e93b5ccb3bf0eefbc5b15b74b5a8be30aa589 Author: deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Jun 15 09:59:38 2009 +0000 Set process name on Linux This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://chrome-svn/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98 Review URL: http://codereview.chromium.org/126119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18380 0039d316-1c4b-4281-b951-d872f2087c98
* Set process name on Linuxdeanm@chromium.org2009-06-151-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98
* Consider a redirect following user gesture as user-initiated in maintainingyuzo@chromium.org2009-06-157-5/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | navigation entries. Also, ignore redirect- or machine-initiated- new subframe navigations. The current code treats all redirects as machine-initiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement user-initiated navigation (Bug 11896). This change assumes that a machine-initiated redirect happens within 300ms since the last document load was completed, while a user-initiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine- initiated or user-initiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18373 0039d316-1c4b-4281-b951-d872f2087c98
* [Refactor] Rename DnsResolutionObserver --> HostResolver::Observer.ericroman@google.com2009-06-151-2/+1
| | | | | | | | | | TEST=this is striclty a refactoring; just needs to compile and pass existing tests. BUG=14056 Review URL: http://codereview.chromium.org/126110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18372 0039d316-1c4b-4281-b951-d872f2087c98
* * Move the global "DnsResolutionObserver" code depended on by DNS ↵ericroman@google.com2009-06-153-21/+45
| | | | | | | | | | | | | | prefetcher, into HostResolver. This has the advantage that consumers of DNS no longer have to remember to call "DidFinishDnsResolutionWithStatus()" followed by "DidStartDnsResolution()" in order for the prefetcher to observe the resolution. Instead it just happens automatically, and subscribers register via HostResolver::AddObserver() on a particular resolver instance. * To accomodate the prefetcher's observer, HostResolver::Resolve() needs an additional "referrer" parameter. This is slightly awkward since "referrer" has nothing to do with the actual resolve request. To simplify plumbing through this and other optional parameters, Resolve() was changed to take a "RequestInfo&" parameter in place of say {hostname, port, flags}. * Added an option to HostResolver::Resolve() for disallowing cached responses (RequestInfo::allow_cached_response). This will be used when you refresh a page, to bypass the host cache. The code to do this has been added to HttpNetworkTransaction, but is commented out pending an appropriate unit-test to verify it. BUG=14056 Review URL: http://codereview.chromium.org/125107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18371 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed 3 tests that failed in hebrew enabled vistahbono@chromium.org2009-06-153-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | BrowserTest.NoTitle BrowserTest.Title AutomationProxyVisibleTest.WindowGetViewBounds Some notes : There has been a small regression in the UI tests which makes them get stuck even more on my very slow machine (maybe race conditions) however, the fixes i post here do not make this state any worse and fix these 3 tests above which always failed TEST=1. run ui_tests on a RTL windows (or use --extra-chrome-flags=--lang=he) 2. the 3 tests listed above will always fail, as they expect LTR behavior 3. this fixes it BUG=12636 http://code.google.com/p/chromium/issues/detail?id=12636 Original Patch by Yoav Zilberberg <yoav.zilberberg@gmail.com> Original review: http://codereview.chromium.org/118441 R=me,jeremy,sky Review URL: http://codereview.chromium.org/125036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18370 0039d316-1c4b-4281-b951-d872f2087c98
* Fix commented-out favicon dumping code.thakis@chromium.org2009-06-141-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18369 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsViewWin and RenderViewContextMenu*Win to ↵ben@chromium.org2009-06-147-12/+12
| | | | | | | | | | | | | | | browser/views/tab_contents They are dependent on the views API (WidgetWin, Menu2, SadTabView, etc etc) so this makes sense. As a follow-on step, I will create a new tab_contents_view_gtk.cc/h in browser/views/tab_contents as well, so TOOLKIT_VIEWS is not exposed to bustage introduced from the non-TOOLKIT_VIEWS version of this file as it is now. I cannot have two files called "tab_contents_view_gtk" in the same directory (browser/tab_contents). Mimicking TabContentsViewWin, TOOLKIT_VIEWS TabContentsViewGtk will subclass WidgetGtk, use browser/views/sad_tab_view and utilize RenderViewContextMenuWin which is now cross platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/126099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18368 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the PlatformContext layer to have only one class.brettw@chromium.org2009-06-149-10/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Review URL: http://codereview.chromium.org/125109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-1352-51/+102
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions visible in the Task Manager.phajdan.jr@chromium.org2009-06-135-23/+100
| | | | | | | | | | | | | - register for notifications when extension hosts are created/destroyed - collapse extension tabs into just one table row, also for tabs opened while the task manager stays open TEST=Start chrome.exe with --enable-extensions. Install the buildbot monitor extension. Open the task manager. You should see an extension process. http://crbug.com/12127 Review URL: http://codereview.chromium.org/125047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18352 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension id format back to mp-decimal, and change theaa@chromium.org2009-06-134-37/+47
| | | | | | | | length to 32 chars (exactly 128 bits). Review URL: http://codereview.chromium.org/126074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18351 0039d316-1c4b-4281-b951-d872f2087c98
* The context menu in external hosts would not work as expected as the command ↵ananta@chromium.org2009-06-132-0/+18
| | | | | | | | | | | | | | ids received from the TrackPopupMenuEx call were the indices of the commands. This was because of the MNS_NOTIFYBYPOS menu style on the context menu coming in from chrome. Fix is to turn off this style for external hosts. R=ben Review URL: http://codereview.chromium.org/126091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18349 0039d316-1c4b-4281-b951-d872f2087c98
* Restructure menu initialization for the TabContents. InitMenu cannot be ↵ben@chromium.org2009-06-133-3/+6
| | | | | | | | | | called from the constructor because it seems to break RenderViewContextMenuExternalWin's virtual AppendItem from being called. BUG=none TEST=none Review URL: http://codereview.chromium.org/126089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18348 0039d316-1c4b-4281-b951-d872f2087c98
* gtk bookmark manager:estade@chromium.org2009-06-132-26/+76
| | | | | | | | | | | | - Implement list view activation. - Fix a crasher. TEST=double click on something in the right pane (folder or bookmark) http://crbug.com/13110 Review URL: http://codereview.chromium.org/126084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18344 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix refresh accelerators.estade@chromium.org2009-06-131-6/+3
| | | | | | | | | by Jacob Mandelson <jacob@mandelson.org> original review: http://codereview.chromium.org/127001 Review URL: http://codereview.chromium.org/125093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18342 0039d316-1c4b-4281-b951-d872f2087c98
* Add favicons to Mac bookmark bar.jrg@chromium.org2009-06-134-6/+232
| | | | | | | | | | | | BUG=8381 TEST=Open bookmark bar (Cmd-B). Add some bookmarks with sites that have favicons (cnn.com). See icons in bookmark buttons. Make sure color is correct. Review URL: http://codereview.chromium.org/125061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18340 0039d316-1c4b-4281-b951-d872f2087c98
* Make findbar paint themed image.estade@chromium.org2009-06-135-29/+81
| | | | | | | | | | | | | Also, fixed drawing of background images that are not 1 pixel wide. (The code for this is somewhat speculative as there is no way of testing it at the moment, but for now it should still at least look correct.) If you open the findbar while the bookmark bar is opened and then close the bookmark bar, the findbar painting is a little messed up in that it still thinks it's farther away from the tabstrip than it really is. The solution (unfortunately) is to continuously repaint the findbar as it is closing. Since this is glitch is hardly noticeable, I'm putting off fixing it. TEST=findbar should look more integrated with bookmark bar, toolbar. BUG=none Review URL: http://codereview.chromium.org/125084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18339 0039d316-1c4b-4281-b951-d872f2087c98
* Restores an early return that was incorrectly removed in the PasswordStore ↵stuartmorgan@chromium.org2009-06-131-0/+4
| | | | | | | | | | refactoring. BUG=13979 TEST=Save a password on a site with a valid SSL certificate, then visit in when the cert is no longer valid. Review URL: http://codereview.chromium.org/125074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18338 0039d316-1c4b-4281-b951-d872f2087c98
* Create a basic test case for the common usage of BlockedPopupContainer.erg@google.com2009-06-133-1/+113
| | | | | | Review URL: http://codereview.chromium.org/125083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18336 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where both restore and maximize buttons were showing aftertc@google.com2009-06-121-1/+1
| | | | | | | | | | | toggling window manager decorations on/off. TBR=estade Review URL: http://codereview.chromium.org/125090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18334 0039d316-1c4b-4281-b951-d872f2087c98
* Copy login-related section of WebDatabase into a new class for use in ↵stuartmorgan@chromium.org2009-06-125-0/+734
| | | | | | | | | | | | | | PasswordStore. The platform-specific inheritence here is because the current Windows implementation of PasswordStore is a temporary shim, and will eventually need to use its own database instead; since we'll need almost all the fields on the Mac for the bag-on-the-side anyway, it makes sense to share as much of this implementation as possible. The code and unit tests are pretty much unchanged from WebDatabase (except for the inheritence stuff); the duplication should be temporary as the WebDatabase copy will be removed once Windows switches (and migrates their passwords). BUG=none TEST=none Review URL: http://codereview.chromium.org/119392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18330 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the titlebar code into its own class because it's getting bigtc@google.com2009-06-127-279/+387
| | | | | | | | | | | | | | | and cluttering up browser_window_gtk. Fix a small painting bug when a menu is drawn over the titlebar background. Also move the tab strip context menu into the titlebar background container by adding an event box. Now the context menu appears e.g., below the min/max/close buttons or above the tab strip. Review URL: http://codereview.chromium.org/125078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18328 0039d316-1c4b-4281-b951-d872f2087c98
* Use a bool instead of disconnecting/reconnecting the changedtc@google.com2009-06-122-11/+11
| | | | | | | | | signal handler. I don't really care one way or the other :) Review URL: http://codereview.chromium.org/118518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18327 0039d316-1c4b-4281-b951-d872f2087c98
* Google Gears should be renamed to Gearsmhm@chromium.org2009-06-122-2/+2
| | | | | | | | | | | BUG=6234 (http://crbug.com/6234) TEST=Checked the Google Gears screen to see if they got changed. Wrench > Options > Under the Hood > Web Content Review URL: http://codereview.chromium.org/125037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18326 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to the try chrome toastcpu@google.com2009-06-122-5/+24
| | | | | | | | | | | | | - Wire it to the cmdline param --try-chrome-again - Set window bounds so it looks nice on Vista - Enable the link to help center BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/126029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18321 0039d316-1c4b-4281-b951-d872f2087c98
* Fix themed toolbar drawing following tabstrip changes.estade@chromium.org2009-06-127-13/+46
| | | | | | | | | | | The code should also be more robust to future changes. BUG=none TEST=active tab blends into toolbar Review URL: http://codereview.chromium.org/126013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18319 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file descriptor exhaustions a little more gracefully. This prevents ↵stuartmorgan@chromium.org2009-06-121-2/+4
| | | | | | | | | | the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue. TEST=none BUG=none Review URL: http://codereview.chromium.org/125024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18318 0039d316-1c4b-4281-b951-d872f2087c98
* Verify signed .crx extension installationsrafaelw@chromium.org2009-06-127-110/+336
| | | | | | | | | | | | | | | This is second try of: http://codereview.chromium.org/115682 that was comitted in in 18189 and reverted. BUG=12114 R=erikkay,wtc,aa Review URL: http://codereview.chromium.org/126014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-1219-216/+270
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-121-1/+0
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert thakis's changes to download_file.cc from r17595.estade@chromium.org2009-06-121-15/+8
| | | | | | | | BUG=13991 Review URL: http://codereview.chromium.org/126066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18307 0039d316-1c4b-4281-b951-d872f2087c98
* Change some DCHECKs to CHECKs in hope of tracking down a crash.pkasting@chromium.org2009-06-121-2/+2
| | | | | | | | BUG=13986 TEST=none Review URL: http://codereview.chromium.org/125066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18302 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 07:46:21 +0000