summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-2879-311/+135
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle middle click in autocomplete popup.shess@chromium.org2009-08-282-2/+90
| | | | | | | | | | | | Middle click should open the item clicked in a background tab. http://crbug.com/20282 TEST=Start typing in omnibox. Middle click an item. The item should open in a different tab without affecting the current omnibox state. Review URL: http://codereview.chromium.org/179009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-2879-135/+311
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* override chrome:// URLs via extensions.erikkay@chromium.org2009-08-2814-54/+361
| | | | | | | | | | Overrides are declared in an extension's manifest. The last one installed wins. However, we keep a list of those installed per page so that priority is preserved and so that uninstall will revert to a previous state. Review URL: http://codereview.chromium.org/174277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24791 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the custom frame on app mode windows. This includes thetony@chromium.org2009-08-282-16/+23
| | | | | | | | | | | | | dev tools window. It makes app mode windows feel a lot more native. BUG=16474 Review URL: http://codereview.chromium.org/183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24778 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show extension disabled infobar when manually updatingaa@chromium.org2009-08-288-16/+62
| | | | | | | | | | extensions that increase privilges. BUG=20461 Review URL: http://codereview.chromium.org/174637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24775 0039d316-1c4b-4281-b951-d872f2087c98
* Extension API Renaming/Consistency changesrafaelw@chromium.org2009-08-2812-101/+137
| | | | | | | | BUG=20288 Review URL: http://codereview.chromium.org/180016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24770 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle backspacing out of keyword search.shess@chromium.org2009-08-282-0/+31
| | | | | | | | | | | | | | | | | | When the user hits backspace with the caret on the LHS in a keyword search, should exit keyword search. [Apple keyboards may label what I'm calling "backspace" as "delete". The wide key above |\ key.] http://crbug.com/20286 TEST=Type www.google.com, then tab to enter keyword search. Type some text. Select-all and hit backspace, should stay in keyword mode. Type some text, backspace should work as normal. Type some text, position caret at LHS, backspace should take you out of keyword mode. Review URL: http://codereview.chromium.org/180009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24767 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionBrowsertest.MessagingContentScripts on linuxrafaelw@chromium.org2009-08-281-0/+3
| | | | | | | | | TBR=tc Review URL: http://codereview.chromium.org/175011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24766 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Clip the tab title to the content height and not the font height. The ↵jhawkins@chromium.org2009-08-281-2/+1
| | | | | | | | | | font height is a design measure and should not be used for a bounding box. BUG=20401 TEST=Open google.com in a tab. Tab title should be fully visible and not clipped. Review URL: http://codereview.chromium.org/179022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24765 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a default icon to the install dialog if the extensionaa@chromium.org2009-08-284-17/+18
| | | | | | | | | | | | | | | doesn't specify one. This icon came from Crystal Clear [1] and is licensed under LGPL. [1] http://commons.wikimedia.org/wiki/Crystal_Clear BUG=20510 Review URL: http://codereview.chromium.org/173604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24754 0039d316-1c4b-4281-b951-d872f2087c98
* Make the default ok/cancel button come from the pak files.thomasvl@chromium.org2009-08-281-8/+6
| | | | | | | | BUG=20496 TEST=more alerts should get localized strings. Review URL: http://codereview.chromium.org/181006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24752 0039d316-1c4b-4281-b951-d872f2087c98
* Remove JSTemplate from NTParv@google.com2009-08-283-34/+24
| | | | | | | | | | | | | | This should reduce the time to show the NTP with about 5ms :-) Fix a bug with tips causing an exception when there are no tips. BUG=None TEST=None Review URL: http://codereview.chromium.org/178015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24751 0039d316-1c4b-4281-b951-d872f2087c98
* Duplicate about_memory.html to create a Linux version.agl@chromium.org2009-08-281-0/+690
| | | | | | | | | This is in preparation for adding about:memory support for Linux, but the change is otherwise too large to be considered the same file without this trick. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24750 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Remove unnecessary gtk_widget_queue_draws from the tabstrip code.jhawkins@chromium.org2009-08-281-6/+1
| | | | | | | | BUG=15872 TEST=none Review URL: http://codereview.chromium.org/182007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24744 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't eat tab if tab-to-search hint not visible.shess@chromium.org2009-08-282-9/+15
| | | | | | | | | | | | | http://crbug.com/20284 TEST=Type "test text". You should see "Type to search" hint. TAB should take you into the content view. Unfortunately, there are other unrelated bugs around the tab sequencing, so this only works with NTP on a new window. Hit TAB twice and you should start tabbing between thumbnails. Review URL: http://codereview.chromium.org/180010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24741 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tweaks to Omnibox metrics.shess@chromium.org2009-08-284-5/+13
| | | | | | | | | | | | Pull in the popup corners by half a pixel to more closely match the rounding on the buttons. Pull up the gap between the popup and the field by one pixel to match Windows. http://crbug.com/20446 Review URL: http://codereview.chromium.org/178007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24739 0039d316-1c4b-4281-b951-d872f2087c98
* Add background_tile_view for tiling an image as UI background (about box ↵thomasvl@chromium.org2009-08-289-65/+511
| | | | | | | | | | | | | | | | | needed it) Added restart_browser as a helper like Views helper for putting up a request for the user to restart. Added a new string needed for Mac style alerts to go with the existing restart string. Make Mac Chromium use a custom about box. Give Chromium and Google Chrome an about box that matches the one on other platforms Use all the existing UI strings for the about box so we get credits, copy rights, etc. TEST=New aboutbox for Chromium and Google Chrome. About box should be fully l10n and size as needed. Chrome update messaging should more match windows and be localized. BUG=13219,19020 Review URL: http://codereview.chromium.org/173606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24737 0039d316-1c4b-4281-b951-d872f2087c98
* Change default homepage experience.kuchhal@chromium.org2009-08-284-13/+31
| | | | | | | | | | | We want to make google.com homepage by default and also show the home button (see the bug below). BUG=http://crbug.com/19392 TEST=Delete user profile and launch Chrome - homepage should be set to google.com and should be enabled. also home button should show up. Review URL: http://codereview.chromium.org/174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24736 0039d316-1c4b-4281-b951-d872f2087c98
* Enable a bunch of extension browsertests for linuxrafaelw@chromium.org2009-08-283-5/+16
| | | | | | | Review URL: http://codereview.chromium.org/173545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24720 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 20297: Typing backspace while in a form field causes the browser ↵suzhe@chromium.org2009-08-281-0/+1
| | | | | | | | | | | | | to go back in its history With the changes made in CL http://codereview.chromium.org/173344, gtk_window_activate_key() is used to handle a key event that was not handled by webkit. Unlike the old code, gtk_window_activate_key() may match the key event with predefined accelerators according to its hardware_keycode rather than keyval. Thus, we need to set hardare_keycode to an invalid value in GtkIMContextWrapper if the key event is handled by IME, to prevent BrowserWindowGtk from handling it again. BUG=20297: Typing backspace while in a form field causes the browser to go back in its history TEST=Starts scim's XIM server by running "scim -d", then runs chrome with GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search box, the browser shall not go back to previous page. Review URL: http://codereview.chromium.org/179016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24719 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme caching on Vista 64 when default theme is installed from the theme ↵mirandac@chromium.org2009-08-282-6/+18
| | | | | | | | | | | gallery. BUG= http://crbug.com/20344 TEST= On vista 64 , install a non-default theme. Open theme gallery and choose "Classic" theme. Close browser and restart. Theme should be default aero theme on Vista, and not the opaque blue windows theme. Review URL: http://codereview.chromium.org/174562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24709 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24700.avi@chromium.org2009-08-2822-526/+181
| | | | | | Review URL: http://codereview.chromium.org/181002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24708 0039d316-1c4b-4281-b951-d872f2087c98
* Fix control key and paste behavior in Linux omnibox.suzhe@chromium.org2009-08-283-6/+53
| | | | | | | | | | | | | BUG=12316: Linux Omnibox, autocomplete on paste annoying. BUG=13096: Support desired_tld in Linux omnibox BUG=20166: Linux omnibox control key behavior is incorrect TEST=Select all text in omnibox and paste something into omnibox by either ctrl-v, paste item in context menu or middle click, to see if inline autocomplete is not activated. TEST=Input something in omnibox, eg. "goog", make sure the inline autocomplete is activated, then press ctrl key to see if the inline autocomplete is still there. TEST=Input something in omnibox, eg. "cnn", press ctrl-Enter to see if www.cnn.com is opened. Review URL: http://codereview.chromium.org/173462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24705 0039d316-1c4b-4281-b951-d872f2087c98
* Do at least some rudimentary sorting of bookmarked URLs in the omnibox ↵pkasting@chromium.org2009-08-287-47/+212
| | | | | | | | | dropdown (existing sort was effectively random). Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked. BUG=16230 TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24704 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for all navigations that will happen in ErrorPageTest.phajdan.jr@chromium.org2009-08-281-12/+20
| | | | | | | | | | | Will it kill flakiness? I'm undisabling some tests on Linux to find out. TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/175006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24703 0039d316-1c4b-4281-b951-d872f2087c98
* Move observers out of automation_provider.cc to declutter the file.phajdan.jr@chromium.org2009-08-284-746/+976
| | | | | | | | | | | Also make sure they all use DISALLOW_COPY_AND_ASSIGN. TEST=none http://crbug.com/19874 Review URL: http://codereview.chromium.org/176004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24702 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-2722-181/+526
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24700 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Refresh the entire location bar area on Update().erg@google.com2009-08-271-1/+7
| | | | | | | | http://crbug.com/20027 Review URL: http://codereview.chromium.org/182004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24698 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for Gtk search engine manager dialog.mattm@chromium.org2009-08-273-15/+283
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/180012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24692 0039d316-1c4b-4281-b951-d872f2087c98
* With an upcoming ICU 4.2 upgrade, the way 'search' works has changed and FiP ↵jshin@chromium.org2009-08-271-4/+8
| | | | | | | | | | | | | | | | | | doesn't make a hit for a stand-alone dependent vowel sign of Indic scripts, which is OK according to a native Malayalam speaker. Revise FindInPageControllerTest.FindCrash_Issue1341577 to run FindInPage (U+0D4C) without checking the return value because the test was devised to test the 'crash' issue. BUG=8198 TEST=FindInPageControllerTest.FindCrash_Issue1341577 pass before and after ICU upgrade to 4.2 Review URL: http://codereview.chromium.org/174629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24686 0039d316-1c4b-4281-b951-d872f2087c98
* Ellipsize long entries in bookmark menus and the back/forward menus.estade@chromium.org2009-08-275-9/+58
| | | | | | | | | | | | | | | Also ellipsize long tooltips. Also make the bookmark bar tooltips more like window (Title on one line, then url on the next line). I've made the title bold, although that isn't the case on windows. Menus: Prefer popping downwards rather than upwards when there is more space down than up. BUG=18617 BUG=20120 Review URL: http://codereview.chromium.org/175004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24685 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download shelf item overflow on os x.thakis@chromium.org2009-08-271-4/+8
| | | | | | | | | | | This was regressed by the subview layout refactoring. BUG=14672 TEST=download several items, resize window, make sure that no download item ever overlaps the "Show all downloads" link on the right. Review URL: http://codereview.chromium.org/173048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24683 0039d316-1c4b-4281-b951-d872f2087c98
* Add a fast path for tab strip expose.tony@chromium.org2009-08-274-2/+116
| | | | | | | | | | | | | | | | | This optimizes the common case of just needing to update favicons. If the expose area consists of just favicons, only paint the favicons (i.e., don't bother with the complex tab edges that overlap). This doesn't help when tabs are resizing or moving, but does reduce CPU usage quite a bit. BUG=15872 Review URL: http://codereview.chromium.org/179003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24675 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes typo in new_new_tab.js that turned off tips.mirandac@chromium.org2009-08-271-1/+1
| | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/178005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24668 0039d316-1c4b-4281-b951-d872f2087c98
* Make the about:plugins page use a normal-sized font.evan@chromium.org2009-08-271-22/+8
| | | | | | | | This has been bugging me. Review URL: http://codereview.chromium.org/174620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24667 0039d316-1c4b-4281-b951-d872f2087c98
* Remove completed downloads from shelf when the shelf closes.thakis@chromium.org2009-08-279-14/+91
| | | | | | | | | | | | | | | | | BUG=15712 TEST=Download a few things, close shelf, download something else, note initial few things are no longer on the shelf. Special cases: * Dangerous downloads still awaiting affirmation should never be removed, no matter if they are completed or not. * Cancelled downloads should be removed. * In-progress downloads should not be removed. Review URL: http://codereview.chromium.org/173186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24663 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for WAI-ARIA role option, by adding exposure of MSAA role ↵klink@chromium.org2009-08-271-0/+2
| | | | | | | | | | | ROLE_SYSTEM_LISTITEM. BUG=19982 TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively. Review URL: http://codereview.chromium.org/173488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24662 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 20398: PageAction icon disappears on reader.google.com when url includes ↵finnur@chromium.org2009-08-271-2/+9
| | | | | | | | | | | | | reference We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons). BUG=20398 TEST=None Review URL: http://codereview.chromium.org/174613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24654 0039d316-1c4b-4281-b951-d872f2087c98
* Send release events as well as press events in linux event mocking ↵estade@chromium.org2009-08-271-35/+90
| | | | | | | | | | infrastructure. Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach. Review URL: http://codereview.chromium.org/178002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
* Add call to BrowserThemeProvider::GenerateBitmap removed in r24170.erg@google.com2009-08-272-1/+5
| | | | | | | | | | (Linux relies on the lazy generation provided by GenerateBitmap; having to call GenerateTabImages() regressed linux startup; theoretically it'd be nice if everything was done lazily...) Review URL: http://codereview.chromium.org/180004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24643 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the settings tab to options on chrome os. The contents is just a placesky@chromium.org2009-08-274-0/+79
| | | | | | | | | | holder at this point. BUG=none TEST=none Review URL: http://codereview.chromium.org/174596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of bugs in the "custom home pages" list in the Preferences window.ben@chromium.org2009-08-274-1/+53
| | | | | | | | | | | | | 1. It was possible to add empty rows to the list by repeatedly clicking the + button. 2. There was a crash when editing an existing item, clearing the text and pressing enter. CustomHomePagesEntry::setURL didn't handle a nil NSString passed to it in this condition. I added a controlTextDidEndEditing method to PreferencesWindowController that forces a revalidation of the contents of the model backing the TableView. http://crbug.com/19555 TEST=Click the + button below the custom home pages table view in the Basics page of Preferences. You should get an active edit but not add the item if you don't type anything. Also, try adding a few valid URLs, then click one to edit and delete the URL, then press enter. It should be removed from the table. See also attached unit test. Review URL: http://codereview.chromium.org/174173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24635 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Subtract the tabstrip x offset from the last tab x offset when ↵jhawkins@chromium.org2009-08-271-1/+1
| | | | | | | | | | calculating the available tab width. The tabstrip and its tabs are not necessarily based at (0,0). BUG=20329 TEST=Open many tabs until they resize smaller. Repeatedly close the left-most tab with the close button. The tabs should not resize at all until the mouse leaves the tabstrip. Review URL: http://codereview.chromium.org/173559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24630 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Remove base/values dependency from devtools.pfeldman@chromium.org2009-08-275-28/+20
| | | | | | Review URL: http://codereview.chromium.org/173480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24606-24607. The tree didn't like them. :(phajdan.jr@chromium.org2009-08-277-88/+29
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/173574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24608 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for navigations in ErrorPage UI test.phajdan.jr@chromium.org2009-08-271-4/+4
| | | | | | | | | | | TBR=darin TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/173571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24607 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-277-25/+84
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24606 0039d316-1c4b-4281-b951-d872f2087c98
* Draw background of Linux extension toolstrips.phajdan.jr@chromium.org2009-08-276-0/+36
| | | | | | | | | | | This makes Linux extension shelf quite pretty now IMHO. TEST=Just see it. http://crbug.com/16759 Review URL: http://codereview.chromium.org/174585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24605 0039d316-1c4b-4281-b951-d872f2087c98
* Update of the extension install UI:aa@chromium.org2009-08-275-56/+81
| | | | | | | | | | | | | | | | | - Give the user more information about which hosts an extension can access. - Remove the red severe warning because it doesn't play well with themes and because it adds nothing when the other text is more specific. - Make the image a bit smaller. Also integrate this new idea with the silent/not-silent update flow. BUG=12129,12140,19582 Review URL: http://codereview.chromium.org/173463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24599 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 08:57:02 +0000