summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Prevent extensions api windows.onFocusChange from firing more than once with ↵rafaelw@chromium.org2010-05-212-2/+14
| | | | | | | | | | | | | | | same windowId. For some reason (on windows, at least) BrowserList::SetLastActive seems to get called for every click in the content area of a window. This ensures that ExtensionBrowserEventRouter only fires once when the focus changes. BUG=39882 TEST=none Review URL: http://codereview.chromium.org/2076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47970 0039d316-1c4b-4281-b951-d872f2087c98
* Remove histogram collection evaluating impact of changing extension url ↵rafaelw@chromium.org2010-05-211-41/+9
| | | | | | | | | | | | | resolution. This reverts the histogram collection part of http://codereview.chromium.org/1605005. BUG=21909 TEST=none Review URL: http://codereview.chromium.org/2082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47969 0039d316-1c4b-4281-b951-d872f2087c98
* Kill all child processes at IO thread shutdown time.michaeln@chromium.org2010-05-213-0/+16
| | | | | | | | | BUG=none TEST=wrapper-map-gc.html leaks a WorkerProcessHost which this cleanup logic takes care of Review URL: http://codereview.chromium.org/2063015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47968 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a assertion failure caused by new asserion in simple_menu_model.cc.oshima@chromium.org2010-05-211-2/+3
| | | | | | | | | | | * command id now has to be positive. BUG=none TEST=manual: clicking options menu on notification shows menu instead of crashing Review URL: http://codereview.chromium.org/2066017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47966 0039d316-1c4b-4281-b951-d872f2087c98
* Size the EV bubble after calculating the space taken by the star/page ↵pkasting@chromium.org2010-05-211-10/+15
| | | | | | | | | | actions/content settings, so we won't take as much space for users with a lot of these. BUG=42856 TEST=Elided EV bubble should take less space when there are lots of icons in the omnibox. Review URL: http://codereview.chromium.org/2073019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47963 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the default profile for cros has no extension servicedavemoore@chromium.org2010-05-2111-55/+77
| | | | | | | | | BUG=chromeium-os:3232 TEST=LoginProfileTest.UserNotPassed Review URL: http://codereview.chromium.org/2094018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome crash seen at times in chrome frame reliability test runs. It ↵ananta@chromium.org2010-05-211-0/+1
| | | | | | | | | | | | | | | appears that the crash occurs because we attempt to unregister focus manager accelerators registered by the external tab container twice as the Uninitialize function gets invoked twice in WM_DESTROY and in the destructor. Fix is to set the focus_manager_ pointer to NULL after unregistering the accelerators. Bug=42365 Review URL: http://codereview.chromium.org/2069015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47958 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Prevent double free by not deleting gconf object we don't own.erg@chromium.org2010-05-211-2/+0
| | | | | | | | | BUG=none TEST=Set to GTK+ theme and then try to change the system theme 4 times to 4 different themes. It shouldn't crash on the 2nd, 3rd or 4th time. Review URL: http://codereview.chromium.org/2070020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47953 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of displaying title with parenthesis in extension.xji@chromium.org2010-05-212-9/+1
| | | | | | | | | | | | | | | Wrap title with correctly bidi control characters in windows for display purpose. BUG=43485 TEST=1. open RTL chrome. 2. install Google dictionary extension. 3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page, 4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu, 5. extension title should be displayed correctly in other places, such as task manager, etc. Review URL: http://codereview.chromium.org/2015004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47937 0039d316-1c4b-4281-b951-d872f2087c98
* Update BrowsingDataRemover to use only the asynchronousrvargas@google.com2010-05-212-57/+100
| | | | | | | | | | | interface of the http/disk cache. BUG=26729 TEST=none Review URL: http://codereview.chromium.org/2063017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47936 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Elide the EV bubble to approximately half of the location bar when ↵erg@chromium.org2010-05-212-9/+64
| | | | | | | | | | | | | | | really long. This only counts the non-icon area of the location bar. Unlike the windows implementation, the minimum size of the EV bubble is 10 characters instead of 150px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. Review URL: http://codereview.chromium.org/2123015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47929 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a TODO in data export of net-internals, added Chrome version and ↵maruel@chromium.org2010-05-213-3/+52
| | | | | | | | | | | | | command line. BUG=none TEST=Go to about:net-internals click on dump to text, check if version and command line are good. Patch contributed by malavv Review URL: http://codereview.chromium.org/2104012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47926 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability to determine if a tab was explicitly closed by thesky@chromium.org2010-05-2110-54/+109
| | | | | | | | | | | | user. This will be used to determine if the tab should be restored on startup or not. BUG=4923 TEST=none Review URL: http://codereview.chromium.org/2087012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47923 0039d316-1c4b-4281-b951-d872f2087c98
* Windows accessibility improvements: 1. All WebKit roles are now passed to thedmazzoni@chromium.org2010-05-2111-239/+735
| | | | | | | | | | | | | | | | | | browser and then converted to MSAA roles - this is both because the logic needs to be more complicated, and so we can support Mac accessibility, too. 2. The serializable object used to pass accessibility info from the renderer to the browser now uses a map for uncommon attributes, rather than having a bunch of fields that are almost always empty. 3. Handles the accSelect method with TAKE_FOCUS, allowing assistive technology to set focus to a particular control. 4. Implements several other IAccessible2 interfaces. BUG=25564 BUG=13291 TEST=None Review URL: http://codereview.chromium.org/2121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47922 0039d316-1c4b-4281-b951-d872f2087c98
* Land dhg's CL 2109011xiyuan@chromium.org2010-05-213-4/+24
| | | | | | | | | | | | Fixing download case, adding new method to download manager to support chromeos downloads. Original Review: http://codereview.chromium.org/2109011 BUG=none TEST=none Review URL: http://codereview.chromium.org/2112012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47921 0039d316-1c4b-4281-b951-d872f2087c98
* Removed dependency on ChromeThread from JsonPrefStore and moved ↵sanjeevr@chromium.org2010-05-2117-397/+63
| | | | | | | | | | | JsonPrefStore and PrefStore to chrome/common. This is because JsonPrefStore is needed in the service process BUG=None. TEST=Updated unit-tests Review URL: http://codereview.chromium.org/2066015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47915 0039d316-1c4b-4281-b951-d872f2087c98
* Break extension tab api test into multiple parts, to reduce the odds of a ↵skerner@chromium.org2010-05-211-8/+19
| | | | | | | | | | | timeout. BUG=43440 TEST=ExtensionApiTest.Tab* Review URL: http://codereview.chromium.org/2072007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47914 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 47902 and 47900.dpolukhin@chromium.org2010-05-211-1/+1
| | | | | | | | | | | | Chrome UI blinks after replacement of gtk_widget_set_size_request with gtk_widget_size_allocate on resizing or infobar appearing animation. It happens because gtk_widget_size_allocate results in background resizing on message loop idle. It looks like we can't use gtk_widget_size_allocate at this place at all. Review URL: http://codereview.chromium.org/2131021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47913 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Implement core mechanism to honor Windows Group Policydanno@chromium.org2010-05-218-6/+516
| | | | | | | | | BUG=42640 TEST=--gtest_filter=WinConfigurationPolicyProviderTest* Review URL: http://codereview.chromium.org/2119005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47910 0039d316-1c4b-4281-b951-d872f2087c98
* Do nothing when "No selection" entry is selected.nkostylev@google.com2010-05-211-1/+2
| | | | | | | | | | | That entry is at index=0. BUG=cros:3361 TEST=Select secure network and cancel dialog. Select first entry at network combobox. It should not crash. Review URL: http://codereview.chromium.org/2074020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47908 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB should use WebSecurityOrigins rather than passing origin stringsjorlow@chromium.org2010-05-211-1/+4
| | | | | | | | | | | The Chromium side of https://bugs.webkit.org/show_bug.cgi?id=39216 which (among other things) switches WebCore/WebKit to use SecurityOrigin/WebSecurityOrigins. I'm also switching it to use databaseIdentifiers (rather than just toString) since its semantics match HTML5's origins (and toStrings do not). BUG=none TEST=none Review URL: http://codereview.chromium.org/2097005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47907 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flack check in FindInPageTest.CrashEscHandlers on Linux views.dpolukhin@chromium.org2010-05-211-1/+1
| | | | | | | | | | | | See http://codereview.chromium.org/2068006 for details. BUG=none TEST=none TBR=jcivelli@chromium.org, sky@chromium.org Review URL: http://codereview.chromium.org/2135010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47902 0039d316-1c4b-4281-b951-d872f2087c98
* Update language_menu_l10n_util.cc data.yusukes@google.com2010-05-212-7/+4
| | | | | | | | | | | | - Added DIRECT_INPUT for ibus-mozc. - Removed ROMAN and KANA since they're for ibus-anthy. BUG=chromium-os:3452 TEST=Checked ../chrome_log manually. Review URL: http://codereview.chromium.org/2110018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47901 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for AddLanguageComboboxModel.satorux@chromium.org2010-05-211-2/+86
| | | | | | | | | TEST=out/Release/unit_tests --gtest_filter='LanguageConfigViewTest*' BUG=chromium-os:3432 Review URL: http://codereview.chromium.org/2104015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47899 0039d316-1c4b-4281-b951-d872f2087c98
* Specify --chromium flag to run new-run-webkit-websocketserverukai@chromium.org2010-05-211-7/+0
| | | | | | | | | | | | | WebKit r59595,r59823 adds --chromium flag in new-run-webkit-websocketserver. It is necessary to use Chromium port obj in the script to set up cygwin environment on win bot. BUGS=41319,40995 TEST=none Review URL: http://codereview.chromium.org/1710007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47898 0039d316-1c4b-4281-b951-d872f2087c98
* This change enables FieldTrial for SPDY. When --use-spdy=npn is used, field ↵lzheng@chromium.org2010-05-213-11/+46
| | | | | | | | | | | | | | | | | test won't be enabled. However, when that flag is missing, A/B test is added to browser_main.cc. Trial A: use npn and spdy. B: use npn but no spdy. C: do nothing. A and B are set to zero for now The histograms we collect are: 1. Page begin to finish time when spdy is enabled/disabled across all sites; 2. Page begin to finish time when spdy is used on sites that support spdy and when spdy is intentionally ignored. BUG=43997 TEST=Don't use --use-spdy=npn, manually change _npn_nospdy and _npn_withspdy percentile and go to spdy supported sites. Review URL: http://codereview.chromium.org/2036012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47896 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47875 - ProcessSingleton(all): create the lock immediately after ↵thestig@chromium.org2010-05-216-119/+26
| | | | | | | | | | | | | | | | failing to connect to an existing process. ProcessSingletonLinux: if creating the lock fails, try to notify again. BUG=44417 TEST=manual Review URL: http://codereview.chromium.org/2066014 TBR=mattm@chromium.org Review URL: http://codereview.chromium.org/2125015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix major UI ugliness in the "Languages and Input" dialog.satorux@chromium.org2010-05-212-157/+209
| | | | | | | | | | | | | | | Before this change, clicking on "Add..." button opened a sub dialog, that only contained a combobox. The behavior was ugly. After this change, users can add new languages directly from the "Language and Input" dialog, without opening the ugly sub dialog. TEST=manually BUG=chromium-os:3432 Review URL: http://codereview.chromium.org/2092017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47888 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the hack for ibus-pinyin.satorux@chromium.org2010-05-211-56/+40
| | | | | | | | | | | | | | | | Before this change, the code assumed that the orientation is vertical, if the number of candidates is 5, which is an ugly hack. After this change, we'll use orientation information in InputMethodLookupTable. To be compatible with IBus's standard candidate window, the default orientation is set to horizontal. BUG=chromium-os:2724 TEST=manually Review URL: http://codereview.chromium.org/2120010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47887 0039d316-1c4b-4281-b951-d872f2087c98
* ProcessSingleton(all): create the lock immediately after failing to connect ↵mattm@chromium.org2010-05-216-26/+119
| | | | | | | | | | | | | to an existing process. ProcessSingletonLinux: if creating the lock fails, try to notify again. BUG=44417 TEST=manual Review URL: http://codereview.chromium.org/2066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47875 0039d316-1c4b-4281-b951-d872f2087c98
* Don't populate WebDropData with file URLs when dragging files.dcheng@chromium.org2010-05-211-1/+1
| | | | | | | | | | | This is the Windows patch. There will be separate patches for Mac and Linux. BUG=42685 TEST=none Review URL: http://codereview.chromium.org/2126010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47870 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED() that I'm triggering when I righttony@chromium.org2010-05-211-1/+2
| | | | | | | | | | | click on a text field. BUG=None TEST=Right click on a text field with an IME installed. Review URL: http://codereview.chromium.org/2108023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47868 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing mounting case.dhg@chromium.org2010-05-201-1/+1
| | | | | | | | | BUG=chromium-os:3292 TEST=none Review URL: http://codereview.chromium.org/2102013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47866 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for blank status bubble.mirandac@google.com2010-05-201-21/+14
| | | | | | | | | | Fixes a codepath which could possibly lead to an empty status bubble. I haven't been able to repro, but calling SetText instead of SetTextAndAnimate looks like the one spot that doesn't check for an empty string before displaying. Eliminating this loophole by consolidating into a single method, SetText, that always triggers the "hide" animation on an empty string, and only triggers animate if |should_animate| is set. This is actually closer to the SetText method before I added the status bubble expansion code. BUG=43640 TEST=no more empty link target bubbles floating on the screen. Review URL: http://codereview.chromium.org/2111013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47863 0039d316-1c4b-4281-b951-d872f2087c98
* Made feedback icon hidden on login screen.zelidrag@chromium.org2010-05-201-0/+3
| | | | | | | | | BUG=chromium-os:3348 TEST=make sure feedback icon does not show on login mgr screens Review URL: http://codereview.chromium.org/2081015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47861 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: delete text when cutting from the omnibox.estade@chromium.org2010-05-201-2/+5
| | | | | | | | | BUG=44232 TEST=cut all the contents from the omnibox. The url (along with the protocol) should be on both PRIMARY and CLIPBOARD selections. The omnibox should now lay empty. Review URL: http://codereview.chromium.org/2108014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47847 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix GConfValue leak in GConfTitlebarListener.mattm@chromium.org2010-05-201-0/+4
| | | | | | | | | BUG=none TEST=tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.\* (Probably any ui test will work.) Review URL: http://codereview.chromium.org/2106018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47840 0039d316-1c4b-4281-b951-d872f2087c98
* Marking DevToolsSanityTest.TestStepOut as flaky on Linux too.robertshield@chromium.org2010-05-201-1/+1
| | | | | | | | | | BUG=43479 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2111014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47839 0039d316-1c4b-4281-b951-d872f2087c98
* Simple code rearranging to better group by function area and protocol.mrossetti@chromium.org2010-05-203-1583/+1601
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2136020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47838 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: use the shared menu.css for the options menu.arv@chromium.org2010-05-204-34/+11
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/2063014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47837 0039d316-1c4b-4281-b951-d872f2087c98
* Implement full screen lock functionality.oshima@chromium.org2010-05-206-34/+134
| | | | | | | | | | | | | | | | | * Send Unlock request to PM when authentication succeeds. * Re-enable input when Unlock request failed. * Changed if (screen_locker_) to assertion in Show method: state is controlled in PowerManager now, and duplicated Show request should not happen. * Send Unlock/Lock complete to PowerManager. BUG=http://crosbug.com/2914 TEST=none locker Review URL: http://codereview.chromium.org/2126008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47833 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill telephone number prefix and suffix heuristics.dhollowa@chromium.org2010-05-202-2/+43
| | | | | | | | | | | Extends matching of telephone number prefix and suffix fields to include fields explicitly labeled with "prefix" and "suffix" strings. BUG=40694 TEST=PhoneFieldTest.ThreePartPhoneNumberPrefixSuffix Review URL: http://codereview.chromium.org/2129016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47829 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47675.mirandac@chromium.org2010-05-2026-25/+253
| | | | | | | | | | Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data. BUG=18774 TEST=none Review URL: http://codereview.chromium.org/2095020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47827 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing overlap problem when a download in dangerous.dhg@chromium.org2010-05-201-1/+2
| | | | | | | | | BUG=chromium-os:2773 TEST=none Review URL: http://codereview.chromium.org/2079013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47823 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-2010-18/+39
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* Moved ImportantFileWriter to chrome/common in preparation of moving ↵sanjeevr@chromium.org2010-05-207-365/+8
| | | | | | | | | | | JsonPrefStore to chrome/common. BUG=None. TEST=Unit-tests moved and modified. Review URL: http://codereview.chromium.org/2128014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47818 0039d316-1c4b-4281-b951-d872f2087c98
* Marking BrowserEncodingTest.TestOverrideEncoding as FLAKY.robertshield@chromium.org2010-05-201-1/+2
| | | | | | | | | | Bug=44668 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2106020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47817 0039d316-1c4b-4281-b951-d872f2087c98
* Marking BrowserEncodingTest.TestEncodingAutoDetect as FLAKY. robertshield@chromium.org2010-05-201-1/+2
| | | | | | | | | | BUG=44666 TEST=none TBR=cbentzel Review URL: http://codereview.chromium.org/2071021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47814 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a preference for the tab key cycling between just form fields, or ↵rsesek@chromium.org2010-05-205-0/+23
| | | | | | | | | | | | | | | links as well. XIB change: Add a checkbox bound to FilesOwner.tabsToLinks underneath the translate webpages preference. BUG=31177 TEST=Uncheck Chromium-->Preferences-->Under the Hood-->Pressing Tab... Then press Tab on Google.com and the links don't get focus; it alternates between search field and location bar. Review URL: http://codereview.chromium.org/2082011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47807 0039d316-1c4b-4281-b951-d872f2087c98
* Boot times weren't getting displayeddavemoore@chromium.org2010-05-202-4/+4
| | | | | | | | | BUG=NONE TEST=Ensure that boot times are shown at startup. Review URL: http://codereview.chromium.org/2102011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47805 0039d316-1c4b-4281-b951-d872f2087c98