summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* WebSocket in Worker: renderer_host changeukai@chromium.org2009-12-078-83/+181
| | | | | | | | | | | | | | To support WebSocket in Worker, SocketStreamDispatcherHost should be part of ResourceDispatcherHost instead of ResourceMessageFilter. ResourceMessageFilter is used only for renderer process, so it would not handle IPC message from worker process. SocketStreamHost changed to have ResourceDispatcherHost::Receiver, which is a peer of child process, and indexed by receiver id and socket_id. BUG=27618 TEST=none Review URL: http://codereview.chromium.org/437084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33953 0039d316-1c4b-4281-b951-d872f2087c98
* Allow silent extension installations from the extensions gallery - Part 1.rafaelw@chromium.org2009-12-0719-61/+254
| | | | | | | | | | | | | | | | In this episode we: -Create a new ChildProcess privilege (SILENT_INSTALL_EXTENSION) which is granted to the extension gallery pages. -Ensure that extension gallery pages are isolated into their own process which is never shared with other urls. Important: The SILENT_INSTALL_EXTENSION privilege is never granted any additional abilities in this patch, so this patch only has the effect of grouping gallery URLs into a separate process. In subsequent patch(es) we plan to (a) observe this new privilege and allow gallery urls to install extensions bypassing the normal prompts, (b) polish this UI flow [in particular, do not show the black "loading" dilaog, (c) check the id of the extension to be installed (from the crx) matches the expected id (from gallery url). BUG=27431 Review URL: http://codereview.chromium.org/400018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33952 0039d316-1c4b-4281-b951-d872f2087c98
* Some code cleanups.thakis@chromium.org2009-12-073-27/+27
| | | | | | | | | | Rename tabView_ to tabStripView_. Fix indentation. TEST=BUG=none Review URL: http://codereview.chromium.org/465095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33948 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash bug on user script installation and add a testaa@chromium.org2009-12-062-11/+47
| | | | | | | | | | | | | | | | to make sure it doesn't happen again. Also, re-enable a test nearby. The history has been lost of why this was failing, so it may fail again, but at least we'll have data. Finally, fix a Greasemonkey compat issue. BUG=29298 Review URL: http://codereview.chromium.org/466053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33945 0039d316-1c4b-4281-b951-d872f2087c98
* Use factory to create histograms, and refcounts to track lifetimesjar@chromium.org2009-12-069-73/+99
| | | | | | | | | | | | | | | This is CL patch 377028 by Raman Tenneti, with minor changes to make the try-bots happier. It is cleanup that better ensures lifetimes of histograms (making it harder for users to abuse them). bug=16495 (repairs leak induced by the first landing) bug=18840 (should make leaks less possible) tbr=raman.tenneti Review URL: http://codereview.chromium.org/462027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make a stop-gap visual indicator for dropping URLs on the tab strip.viettrungluu@chromium.org2009-12-053-9/+84
| | | | | | | | | | | A.k.a. a present for pkasting. Eventually we'll probably want to do something more sophisticated (at the very least arrows should fade in/out), but for now this doesn't look (much?) worse than what's on Win/Chrome. BUG=25405 TEST=Drag URLs to the tab strip, move around, make sure the ugly arrow appears in the right locations, dropping to confirm. Repeat with various themes to make sure arrow is reasonably visible. Review URL: http://codereview.chromium.org/466051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix null-pointer crash.abarth@chromium.org2009-12-051-0/+3
| | | | | | | | BUG=29444 Review URL: http://codereview.chromium.org/469001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33914 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ExternalTabAutomationProxy by switching the extension UIjoi@chromium.org2009-12-051-229/+180
| | | | | | | | | | | tests over to ExternalTabUITest. BUG=27326 TEST=ui_tests.exe Review URL: http://codereview.chromium.org/468013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33902 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-054-61/+75
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement drag-and-drop of URLs to tabs/tab strip.viettrungluu@chromium.org2009-12-048-10/+359
| | | | | | | | | | | | | Not yet implemented: visual feedback, dropping multiple URLs/files, perhaps key modifiers (?). Doing the visual feedback right (making the tabs move around, etc.) will require a fairly hefty work on the tabs code, so I'm splitting up the work. BUG=25405 TEST=Test dragging and dropping URLs/links, files, plain text (with a possibly-poorly-formed URL), etc. on the tab and on the empty part of the tab strip; web page should load in tab or in new tab, and that tab should be selected. Review URL: http://codereview.chromium.org/337055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33890 0039d316-1c4b-4281-b951-d872f2087c98
* views/options: Use non-deprecated version of PathService::Get.thestig@chromium.org2009-12-041-9/+9
| | | | | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com> Original review: http://codereview.chromium.org/462038 BUG=none TEST=none Review URL: http://codereview.chromium.org/465068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33889 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Record the list of plugins loaded in browser process crash reports.thestig@chromium.org2009-12-041-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/459015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33888 0039d316-1c4b-4281-b951-d872f2087c98
* Remember zoom on a per-host basis.pkasting@chromium.org2009-12-0412-49/+246
| | | | | | | | BUG=567 TEST=Visit a page, zoom in or out, then navigate to a different host. The new page should not be zoomed. Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed. Review URL: http://codereview.chromium.org/437077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33886 0039d316-1c4b-4281-b951-d872f2087c98
* Fix html_dialog_gtk.cc so that the dialog is large enough to display the ↵zork@chromium.org2009-12-041-1/+2
| | | | | | | | | | | entire html control. BUG=none TEST=Enable sync and attempt to log in. The cancel button should be completely visible. Review URL: http://codereview.chromium.org/464029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33885 0039d316-1c4b-4281-b951-d872f2087c98
* Make the system menu for app/popup windows slightly shorter. Original patch ↵pkasting@chromium.org2009-12-042-14/+15
| | | | | | | | | by Thiago Farina (see http://codereview.chromium.org/402095 ), r=me. BUG=23787 TEST=Popup window system menus (right click the icon in the upper left corner) should not have Save Page, Duplicate Tab, and a few other things anymore. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33875 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: theme the close button for the find bar.estade@chromium.org2009-12-042-4/+19
| | | | | | | | | | The blocked popup container isn't themed, but it will need similar treatment. BUG=29101 (sort of) TEST=use a dark theme, the close button should be visible on the findbar Review URL: http://codereview.chromium.org/465049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33870 0039d316-1c4b-4281-b951-d872f2087c98
* Delay DNS subresource resolution until navigational resolution is completejar@chromium.org2009-12-041-2/+6
| | | | | | | | | | | | | | | | | | | | | | | This should probably help some folks that have very sensitive DNS resolution systems, by at least assuring that the initial navigation can't get stuck behind congestion induced by DNS prefetching. There is a tiny chance that this used to be a bit less problematic, as the DNS prefetch system used to use its own threads, which gave the navigational resolution a "racing" chance to be handled first (or at least sooner). With the centralized use of the resolver, the code (as noted by eroman) actually started the sub-resource resolution (in all cases) before the navigational resolution. This change explicitly forces the clearly better ordering. It won't "fix" bug 3041... but it may help some users with more recent comments in that bug. bug=3041 r=eroman Review URL: http://codereview.chromium.org/464023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33869 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Show the private memory usage by default instead of the shared memory ↵thestig@chromium.org2009-12-041-2/+2
| | | | | | | | | | usage. (which shows 0 for me) BUG=none TEST=Task manager shows the interesting stats by default. Review URL: http://codereview.chromium.org/468017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33862 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve optimized scrolling in the presence of multiple animating rects.darin@chromium.org2009-12-0410-51/+140
| | | | | | | | | | | | | | Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied. Modifying the interface to make this an option bloated the CL too much. I may do this as a follow-up. Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues. R=brettw BUG=25905 TEST=none Review URL: http://codereview.chromium.org/414016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33861 0039d316-1c4b-4281-b951-d872f2087c98
* Add IsWindowActive to the Mac plugin interpose liststuartmorgan@chromium.org2009-12-041-6/+18
| | | | | | | | | BUG=28021 TEST=Mouseover should work in Silverlight Review URL: http://codereview.chromium.org/460057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33860 0039d316-1c4b-4281-b951-d872f2087c98
* Use the zygote for extension page popup processes.tony@chromium.org2009-12-041-1/+3
| | | | | | | | BUG=29377 Review URL: http://codereview.chromium.org/464041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33858 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale information to the links in the chrome://extensions page.mirandac@chromium.org2009-12-041-4/+5
| | | | | | | | | BUG= 28624 TEST= links from the chrome://extensions page should include locale information. Review URL: http://codereview.chromium.org/467019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33857 0039d316-1c4b-4281-b951-d872f2087c98
* Move incognito text box down.mirandac@chromium.org2009-12-041-0/+1
| | | | | | | | | Top line of incognito text box is now at the same point as the top line of the thumbnails in the regular NTP. This means that themed NTP backgrounds look the way the theme designers planned them to (for example, you can see the "Chrome comet" in Star Gazing, and the pattern swirl in OP), and the regular and incognito NTPs have a unified look. Review URL: http://codereview.chromium.org/463030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33856 0039d316-1c4b-4281-b951-d872f2087c98
* Don't bounce the downloads folder if the download was auto-removed (e.g. themes)avi@chromium.org2009-12-042-10/+8
| | | | | | | | | BUG=http://crbug.com/28717 TEST=as in bug Review URL: http://codereview.chromium.org/465064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Route edit-state messages via observer rather than delegate.shess@chromium.org2009-12-048-349/+338
| | | | | | | | | | | | | | | | | | | AutocompleteTextField routes messages to AutocompleteEditViewMac via a Cocoa-style delegate and also a C++ observer class. The Cocoa-style delegate has been gradually being pruned down in favor of the observer, this CL completes the transformation. The noted bugs occur because some bit of Cocoa code was sending spurious delegate notifications. Since this code no longer depends on those notifications, the spurious notifications are no longer a problem for this case. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33853 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtk & glib headers in message_pump_glib.h, saves 1 sec on ↵mattm@chromium.org2009-12-043-0/+10
| | | | | | | | | | | do-nothing make. TEST=manual browser test, trybots BUG=none Review URL: http://codereview.chromium.org/464031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
* enabled one browser test and tag JavascriptAlertActivatesTab, ↵thomasvl@chromium.org2009-12-041-17/+17
| | | | | | | | | | ReloadThenCancelBeforeUnload, & SingleBeforeUnloadAfterWindowClose as disabled so they compile but don't run on the Mac TEST=tree stays green BUG=29424 Review URL: http://codereview.chromium.org/464039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33850 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r4177, reimplements a fix for bug 3417. Adding UpdateObservers to ↵avi@chromium.org2009-12-042-1/+3
| | | | | | | | | | | DownloadItem::Finished is wrong, as it causes a duplicate notification to fire when a download is complete. BUG=http://crbug.com/3417 TEST=bug does not regress Review URL: http://codereview.chromium.org/464043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33848 0039d316-1c4b-4281-b951-d872f2087c98
* Added new IPC message class for CommandBuffer.apatrick@google.com2009-12-048-10/+10
| | | | | | | | | | Increased IPC message header type from 16 bits to 32 bits so it can accomodate more message classes. TEST=none BUG=none Review URL: http://codereview.chromium.org/399013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33832 0039d316-1c4b-4281-b951-d872f2087c98
* Enable browser_tests: SavePageBrowserTest.FileNameFromPageTitle & ↵thomasvl@chromium.org2009-12-041-10/+0
| | | | | | | | | | SavePageBrowserTest.SaveHTMLOnly on the Mac. BUG=16322 TEST=waterfall stays green Review URL: http://codereview.chromium.org/463031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33830 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.pinkerton@chromium.org2009-12-041-4/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33829 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0429-145/+163
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of data races on booleanstimurrrr@chromium.org2009-12-041-9/+10
| | | | | | | | | BUG=21468,22520 For the explanation why these are data races, see http://code.google.com/p/data-race-test/wiki/PopularDataRaces Review URL: http://codereview.chromium.org/251027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33825 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionApiTest.Bookmarks from DISABLED to FLAKY since it doesn'terikkay@chromium.org2009-12-041-1/+1
| | | | | | | | | | | crash. BUG=19866 TEST=ExtensionApiTest.Bookmarks Review URL: http://codereview.chromium.org/465034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33822 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: restore window size/position when hiding bookmark bar or download shelf.viettrungluu@chromium.org2009-12-043-34/+253
| | | | | | | | | | | | | | | This applies in particular when the bookmark bar or download shelf causes the window to grow at the top (due to there not being enough space at the bottom of the screen). Note that resizing or moving reset the state (* for moving it's a bit more subtle), so hiding afterwards will always shrink the window from the bottom. BUG=29192 TEST=(1) Navigate to a normal (non-NTP) page and hide bookmark bar; move window close to the bottom of the screen (keeping the window fully on-screen); Shift-Cmd-B to show the bookmark bar (which show grow maybe a bit downwards and then upwards); Shift-Cmd-B to hide it again; it should shrink from the top and from the bottom, restoring its original size/position. (2) Do the same but move the window away from the bottom of the screen after the first Shift-Cmd-B; now upon hiding it should only shrink at the bottom. (3) Check that if the window is far enough away from the bottom of the screen to begin with, then growing/shrinking only occurs at the bottom. (4) Do (1)-(3) for the download shelf (download something to show the shelf; then hide it by closing it). Review URL: http://codereview.chromium.org/465024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33821 0039d316-1c4b-4281-b951-d872f2087c98
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-043-0/+38
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98
* Adding instrument to NotificationRegistrar to checkhuanr@chromium.org2009-12-042-0/+11
| | | | | | | | | | | | | | | Add() and Remove() are called from same thread. Note I already checked in a fix for the bug. The CL is trying to check whether the issue exists in other code path. TEST=none BUG=27834 Review URL: http://codereview.chromium.org/449044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33802 0039d316-1c4b-4281-b951-d872f2087c98
* Enable remote fonts by default. This change introduces ↵yusukes@google.com2009-12-041-1/+1
| | | | | | | | | | | --disable-remote-fonts flag and obsoletes --enable-remote-fonts. BUG=17818 TEST=(1) Start chromium WITHOUT --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _remote_ fonts (reference image: http://www.alistapart.com/d/cssatten/poen.png ) / (2) Start chromium WITH --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _local_ fonts Review URL: http://codereview.chromium.org/165236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download dialog truncation in German locale.finnur@chromium.org2009-12-041-4/+13
| | | | | | | | | BUG=23178 TEST=Requires manual inspection for text trunction on --lang=de (when closing Chrome while downloading) Review URL: http://codereview.chromium.org/465041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33798 0039d316-1c4b-4281-b951-d872f2087c98
* Improve reporting of subprocess crashes.asargent@chromium.org2009-12-045-4/+55
| | | | | | | | | | | | | | | | | -Split extension renderer crashes out of the existing UMA renderer crash metric into its own metric. -Add a new metric for the sum of all ChildProcessHost crashes. -Add histograms for each crash type. BUG=28022 TEST=We should start getting more crash reports in UMA and histograms. Review URL: http://codereview.chromium.org/468005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33794 0039d316-1c4b-4281-b951-d872f2087c98
* Implement keyboard access between bookmarks and main toolbar.mhm@chromium.org2009-12-049-315/+406
| | | | | | | | | | | | | | | | Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views. Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab. There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed: bool IsAccessibleViewTraversable(views::View* view) BUG=25625 TEST=Test to see if the main toolbar and bookmarks bar is traversable. Review URL: http://codereview.chromium.org/333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak reported in extensions_quota_service_unittest.cctim@chromium.org2009-12-042-7/+5
| | | | | | | | TBR=nick Review URL: http://codereview.chromium.org/468018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33791 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetStringUTF16 to return string16 instead of std::wstring in bookmark ↵nick@chromium.org2009-12-041-4/+5
| | | | | | | | | | | | | manager. Patch by Thiago Farina <thiago.farina@gmail.com>. BUG=none TEST=none Review URL: http://codereview.chromium.org/460056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33780 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium os build.estade@chromium.org2009-12-042-0/+7
| | | | | | Review URL: http://codereview.chromium.org/468016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33777 0039d316-1c4b-4281-b951-d872f2087c98
* Make the default RendererPreferences smarter.estade@chromium.org2009-12-049-15/+15
| | | | | | | | | | | Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however). BUG=29043 TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color) Review URL: http://codereview.chromium.org/458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33775 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove hacky way the New Tab button is obtained from the nib.viettrungluu@chromium.org2009-12-044-10/+21
| | | | | | | | | | | | | | | I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. Unit test fixed. Previously committed at r33758, reverted at r33761. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/460058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33771 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExtensionsQuotaService to limit abusive amounts of requeststim@chromium.org2009-12-0411-37/+1010
| | | | | | | | | | | | | | | | to mutating extension functions, as discussed on chromium-dev and in Extensions quotaserver design doc. Add a hook in the dispatcher to have the quota service assess the request. Wire up bookmarks.{create, move, remove, update} to the service. BUG=19899 TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new) Review URL: http://codereview.chromium.org/441006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33758 - Mac: remove hacky way the New Tab button is obtained from the ↵viettrungluu@chromium.org2009-12-043-15/+6
| | | | | | | | | | | | | | | | | | nib. I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/465042 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/465045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33761 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove hacky way the New Tab button is obtained from the nib.viettrungluu@chromium.org2009-12-043-6/+15
| | | | | | | | | | | | | I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/465042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33758 0039d316-1c4b-4281-b951-d872f2087c98
* Removed sync/notifier/base/mac/time_mac.cc (which just includes time_posix.cc).akalin@chromium.org2009-12-041-8/+0
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/462014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33755 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:41:33 +0000