summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Modifies the growbox behavior to be more Mac-like.rohitrao@chromium.org2009-06-093-6/+81
| | | | | | | | | | | | | | | | | | Nib file changes: - Set the min browser window size to 400x250. BUG=http://crbug.com/11844 BUG=http://crbug.com/13015 BUG=http://crbug.com/13017 TEST=Verify that windows have a minimum size. Verify that (with a single monitor) windows cannot be resized into the dock area, unless their lower right corner started in the dock area. Verify that windows can be resized across multiple monitors. Review URL: http://codereview.chromium.org/118439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17965 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor bug in the print dialog on windows. The minimum page number was ↵sverrir@google.com2009-06-091-0/+1
| | | | | | | | | | | | | not set so you could ask for a printout of page 0-5 in a 5 page document. This caused an empty page to be printed before the others. BUG=none TEST=Try to enter illegal page number in the page number dialog. Review URL: http://codereview.chromium.org/118446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17963 0039d316-1c4b-4281-b951-d872f2087c98
* Should provide checks while loading bookmarksmhm@chromium.org2009-06-091-12/+6
| | | | | | | | | | | | | | Instead of providing a separate check to validate bookmarks while loading, we could assume invalid bookmarks are invalid, hence we don't break the loading sequence. We keep looping since another bookmark might be valid. If the JSON syntax is broken, it will exit gracefully because the parser can't parse the file. This patch is only good for people who are editing their bookmarks directly and missing a item in the bookmark node. BUG=10709 (http://crbug.com/10709) TEST=Deleted any line from the Bookmarks file within the bookmark children node. Loaded up Chromium and it loaded the error free bookmarks. Review URL: http://codereview.chromium.org/118351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17960 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stack-based class for property disabling and re-enabling screen ↵pinkerton@chromium.org2009-06-091-4/+3
| | | | | | | | | | updating without epic fail. Fixes issues where we weren't re-enabling updates in many cases which caused both jank and resize issues. BUG=13476 TEST=closing windows shouldn't have jank regardless of the # of tabs. Resizing a window shouldn't explode visually in the chrome. Review URL: http://codereview.chromium.org/119363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17956 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Import passwords from Firefox.kuchhal@chromium.org2009-06-092-48/+56
| | | | | | | | | | BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet). Review URL: http://codereview.chromium.org/118443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17955 0039d316-1c4b-4281-b951-d872f2087c98
* Implement default search popup.pinkerton@chromium.org2009-06-095-0/+289
| | | | | | | | BUG=13151 TEST=default search popup persistance. Review URL: http://codereview.chromium.org/119310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17947 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: Import passwords from Firefox."kuchhal@chromium.org2009-06-092-55/+48
| | | | | | | | This reverts commit a45f7c83ced4af4ded3fcbd3608a1fe50a2c9f08. Review URL: http://codereview.chromium.org/118435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17946 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Import passwords from Firefox.kuchhal@chromium.org2009-06-092-48/+55
| | | | | | | | | BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet). Review URL: http://codereview.chromium.org/119267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17943 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: restore sanity test suite.pfeldman@chromium.org2009-06-093-41/+75
| | | | | | | BUG=11533 Review URL: http://codereview.chromium.org/119355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17941 0039d316-1c4b-4281-b951-d872f2087c98
* Make Ctrl-Shift-J to work across platforms.mnaganov@chromium.org2009-06-091-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17936 0039d316-1c4b-4281-b951-d872f2087c98
* apply patchaa@chromium.org2009-06-091-0/+9
| | | | | | Review URL: http://codereview.chromium.org/119350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17935 0039d316-1c4b-4281-b951-d872f2087c98
* Implement different radio groups for Options > Personal Stuffmhm@chromium.org2009-06-092-8/+9
| | | | | | | | | | | | | | Passwords and Form autofill share the same group, they need to be treated separately. It did not work correctly, when "password" radio option was chosen,two of "form autofill" radio option both change to blank(not selected). This patch will properly create different radio groups for passwords and autofill. BUG=13222 (http://crbug.com/13222) TEST=Radio buttons now function propertly TBR=ben Review URL: http://codereview.chromium.org/119347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views bustage by updating callsite to use the new function name.ben@chromium.org2009-06-091-2/+3
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/118419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17929 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.exe --package-extension generates .crx from extension directoryrafaelw@chromium.org2009-06-097-2830/+3291
| | | | | | | | | R=aa BUG=12114 Review URL: http://codereview.chromium.org/118328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17927 0039d316-1c4b-4281-b951-d872f2087c98
* Form Autofil Options should be a radio groupmhm@chromium.org2009-06-092-84/+64
| | | | | | | | | | | | The Form Autofil is currently just a checkbox. To fit the chomium design, we prefer radios for single questions because it a bit clearer which choice you choose. As well, we merged import data and clear browsing data into browsing data since the page was getting a bit long. BUG=13222 (http://crbug.com/13222) TEST=Tested the options pane, the form autofil worked as expected. Review URL: http://codereview.chromium.org/119146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17926 0039d316-1c4b-4281-b951-d872f2087c98
* Stats for nerds should bring up applicaiton browser window to foregroundmhm@chromium.org2009-06-091-1/+9
| | | | | | | | | | | | The reason why it didn't bring up the stats in foreground is because it is an application window. Application (same goes for popup) windows cannot have tabs, it is just a single page. When the link is clicked, we need to get the last active browser so we could open that about:memory page. When you open a page in an application window, it will create a new window or find a window (normal) that is present, then open the url in that tab. So now we don't have the browser pointed to that tab, its still pointed to the application window. By finding the last active tab again, we can ensure we have the correct tab. BUG=11822 (http://crbug.com/11822) TEST=tested if the stats appeared in foreground and it did. Review URL: http://codereview.chromium.org/119293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17925 0039d316-1c4b-4281-b951-d872f2087c98
* Fix omnibox popup positioning by not calling "SetChildBounds" which attempts ↵ben@chromium.org2009-06-091-5/+4
| | | | | | | | | | to do a bunch of things to keep windows visible on screen... this isn't really what we want for this window, so we just call SetBounds instead. http://crbug.com/11721 TEST=drag window so it's half offscreen, type in the omnibox. dropdown should appear properly anchored underneath omnibox even though it's half offscreen. Review URL: http://codereview.chromium.org/119338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17922 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird stretchy text rendering in O2 popup. Apparently the tile flags ↵ben@chromium.org2009-06-091-2/+2
| | | | | | | | | | were angering the skia gods. http://crbug.com/13277 TEST=size window to various sizes, type stuff in omnibox, text shouldn't be stretched or scrunched. Review URL: http://codereview.chromium.org/118414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17921 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call NPP_SetWindow before we have the plugin geometry.jam@chromium.org2009-06-091-9/+14
| | | | | | | | | Note: the full fix to the bug also needs Ananta's change at http://codereview.chromium.org/119200 Bug=12993 Review URL: http://codereview.chromium.org/118359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17920 0039d316-1c4b-4281-b951-d872f2087c98
* Implement URL Drag & Drop for the linux tabstrip.jhawkins@chromium.org2009-06-094-8/+407
| | | | | | | | BUG=none TEST=Drag a link from Firefox into the Chromium tab strip. A new tab should open either before, after, or in the same tab depending on where the drop occurred. Review URL: http://codereview.chromium.org/118411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17915 0039d316-1c4b-4281-b951-d872f2087c98
* blechaa@chromium.org2009-06-081-8/+10
| | | | | | Review URL: http://codereview.chromium.org/118412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17910 0039d316-1c4b-4281-b951-d872f2087c98
* First part of tab overview. It isn't wired up, nor is it complete, butsky@chromium.org2009-06-0810-0/+1054
| | | | | | | | | | | it's a good enough stage that I want to check it in. BUG=none TEST=none Review URL: http://codereview.chromium.org/119329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17906 0039d316-1c4b-4281-b951-d872f2087c98
* Creates a BlockedPopupContainerView interface, and changes the current ↵erg@google.com2009-06-088-357/+369
| | | | | | | | | | BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the TabContents::SetInitialFocus(reverse) method to ↵jcampan@chromium.org2009-06-089-27/+23
| | | | | | | | | | | TabContents::FocusThroughTabTraversal(reverse), as SetInitialiFocus can be easily confused with TabContentView::SetInitialFocus(). BUG=None TEST=None Review URL: http://codereview.chromium.org/118392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17900 0039d316-1c4b-4281-b951-d872f2087c98
* Fix user scripts not getting initialized.aa@chromium.org2009-06-083-52/+29
| | | | | | | | | BUG=13290,13128 TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions. Review URL: http://codereview.chromium.org/119256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17898 0039d316-1c4b-4281-b951-d872f2087c98
* Convert toolbar page and app menus over to use the new system.ben@chromium.org2009-06-087-392/+446
| | | | | | | TEST=test page and app menus thoroughly. Review URL: http://codereview.chromium.org/119291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17897 0039d316-1c4b-4281-b951-d872f2087c98
* Move GTK spacing constants into chrome/common/gtk_util.hmattm@chromium.org2009-06-0811-56/+47
| | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/118399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where hitting enter in the Omnibox would ignore recent editing.pkasting@chromium.org2009-06-084-17/+29
| | | | | | | | | | Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results. This just highlights how more of this stuff should move to the AutocompleteController. BUG=13428 TEST=Type "food.c" and wait for the popup to stabilize. Then _very_ quickly type "om" and hit enter. You should navigate to food.com instead of searching for "food.c". Review URL: http://codereview.chromium.org/118398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17891 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusting the page action icon drawing slightly.finnur@chromium.org2009-06-081-14/+16
| | | | | | | | | | | | | When multiple page actions are active, there was no padding between icons. Also, the entry_width was being truncated too much (the more page actions the more apparent it came). This fixes that. BUG=12060 TEST=Have multiple page actions (more than 3) active in the Omnibox, make sure there is a little bit of space between each icon. Start typing and make sure you can type all the way to the page action icons. Review URL: http://codereview.chromium.org/118390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17888 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes scrolling in the mac backingstore. We were copyingrohitrao@chromium.org2009-06-081-4/+5
| | | | | | | | | | | pixels to the wrong location when the scrolled region did not start at y=0. BUG=13521 TEST=Open url in bug report. Scroll in the two frames with scrollbars, then switch to a different window. The webpage should not get scrambled. Review URL: http://codereview.chromium.org/118372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17886 0039d316-1c4b-4281-b951-d872f2087c98
* linux build fixesestade@chromium.org2009-06-081-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17882 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark bar shutdown crash.estade@chromium.org2009-06-081-0/+6
| | | | | | | | | | If the bookmarks backend finishes loading during shutdown (after the browser's gtk window has been destroyed but before the application is finished shutting down), we may try to call show() on a destroyed widget. BUG=13575 Review URL: http://codereview.chromium.org/119317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17881 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More drag support for bookmark manager.estade@chromium.org2009-06-082-22/+107
| | | | | | | | | | - drag into folders - improve pre-drop highlighting - use default drag icon instead of row bitmap for tree view row drag. Review URL: http://codereview.chromium.org/118357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17880 0039d316-1c4b-4281-b951-d872f2087c98
* Move a few commands to the appropriate slot in the command order.pkasting@chromium.org2009-06-081-2/+6
| | | | | | Review URL: http://codereview.chromium.org/118311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17879 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a header that is no longer being used after r17818.jhawkins@chromium.org2009-06-081-1/+0
| | | | | | | TBR=thestig Review URL: http://codereview.chromium.org/118389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17874 0039d316-1c4b-4281-b951-d872f2087c98
* Use EXPLICIT_ACCESS when trying to get the PasswordStore to cancel a login ↵stuartmorgan@chromium.org2009-06-081-1/+1
| | | | | | | | | | query, since that's the mode that was used to start it. BUG=13348 TEST=Cancelling a login query should not fail in off-the-record mode. Review URL: http://codereview.chromium.org/119204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17873 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark bar, now with buttons.jrg@chromium.org2009-06-0828-238/+898
| | | | | | | | | Much of this CL is refactoring; it's not as large as it looks. (Do I always claim that? It's really true this time.) Review URL: http://codereview.chromium.org/115150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17872 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager: organize menu and aesthetic improvements.estade@chromium.org2009-06-086-50/+123
| | | | | | Review URL: http://codereview.chromium.org/118388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17868 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for printing selection only flag. This only adds the flag to the ↵sverrir@google.com2009-06-0810-36/+71
| | | | | | | | | | | IPC and implements the Windows dialog interaction but does not enable this just yet. BUG=http://crbug.com/1682 TEST=none Review URL: http://codereview.chromium.org/118338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17867 0039d316-1c4b-4281-b951-d872f2087c98
* Hack around klipper / glipper clipboard races.deanm@chromium.org2009-06-082-1/+19
| | | | | | | | | | | | | | | | | | | | | | | I don't completely understand the problem, but I hacked up glipper to dump what was going on. It watches the primary clipboard ownership changes, then waits for the clipboard contents. There are some races there and then it eats our selection. The solution, which isn't great, is to disable the primary selection around setting up the inline autocomplete selection. This means that the primary selection is the full text and not just the inlined portion, but I don't see a huge case for using the autocompleted portion as the primary selection anyway. The other clipboard (ctrl-c / ctrl-v) should work the same as before. BUG=11956 TEST=That inline autocomplete works correctly like it did before. It should now also work correctly with glipper / klipper running. Review URL: http://codereview.chromium.org/119170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17851 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the Linux bookmark bubble to the bookmark editor.deanm@chromium.org2009-06-082-15/+124
| | | | | | | | | | | Folder selection and the Edit... button should now work. BUG=11738 Review URL: http://codereview.chromium.org/119174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17850 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking a bookmark does not discard omnibox editsmhm@chromium.org2009-06-081-7/+16
| | | | | | | | | | | We need to manually reset the omnibox by reverting the text before the bookmark click event occurs BUG=12627 (http://crbug.com/12627) TEST=Clicked on bookmark while editing in omnibox to bring up suggestionlist, as well tried unfocused omnibox while clicking on a focused inpage browser link Review URL: http://codereview.chromium.org/119292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17849 0039d316-1c4b-4281-b951-d872f2087c98
* Check to see if we're still real before talking to renderWidgetHostView_.shess@chromium.org2009-06-061-0/+6
| | | | | | | | | http://crbug.com/13514 TEST=See bug. Review URL: http://codereview.chromium.org/119278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17842 0039d316-1c4b-4281-b951-d872f2087c98
* Prototype implementation of zygotes. dkegel@google.com2009-06-061-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Limitations that need addressing still: - Doesn't forcibly terminate children that should have exited but haven't Enable with env var ENABLE_ZYGOTE_MANAGER=1. BUG=11841 TEST= start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites. Here's an example script to hide and unhide the .pak files (note: do not move the directory they're in, that doesn't work): #!/bin/sh chmod_all() { chmod $1 sconsbuild/Debug/chrome for path in . locales obj/chrome/app/intermediate/repack obj/global_intermediate/* themes do chmod $1 sconsbuild/Debug/$path/*.pak done } case $1 in hide) chmod_all 000 ;; show) chmod_all 755 ;; esac Review URL: http://codereview.chromium.org/115773 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17840 0039d316-1c4b-4281-b951-d872f2087c98
* Second (and hopefully the final) fix for the issue 805:yusukes@google.com2009-06-064-3/+17
| | | | | | | | | | | | | | | | Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met: (XP) Chromium is used over RDP. (Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client. Review: http://codereview.chromium.org/115304 BUG=805 TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag. Review URL: http://codereview.chromium.org/118307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17827 0039d316-1c4b-4281-b951-d872f2087c98
* Display extension processes in task manager.phajdan.jr@chromium.org2009-06-069-21/+258
| | | | | | | | | | | | | This is the first part of the change. I will submit code to listen for new extension processes while task manager is open in following patch(es). TEST=Install an extension which renders to the extension shelf, like Buildbot Monitor from http://dev.chromium.org/developers/design-documents/extensions/samples. Open the task manager. You should see the extension process. http://crbug.com/12127 Review URL: http://codereview.chromium.org/115858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17826 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions installable again.aa@chromium.org2009-06-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/119279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17825 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Duplicate Accelerator mapping in browser window mhm@chromium.org2009-06-061-1/+0
| | | | | | | | | | CTRL+W is duplicated twice, we just need one, so this is just a cleanup. BUG=none TEST=CTRL+W works Review URL: http://codereview.chromium.org/118360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17823 0039d316-1c4b-4281-b951-d872f2087c98
* Partial revert of r17790. Don't use a OwnedWidgetGtk for container_.thestig@chromium.org2009-06-062-17/+17
| | | | | | Review URL: http://codereview.chromium.org/119274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17818 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call HandleGetMostVisited on the backend after each black listarv@google.com2009-06-062-22/+25
| | | | | | | | | | | | | | | | | operation. Instead let JS do the call as needed. This is in preparation for the new new tab page which will do other things when an URL is blacklisted. Also, fix some issue in the last CL BUG=13362 TEST=Add and clear most visted items like before. Things should work as before Review URL: http://codereview.chromium.org/118350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17817 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 04:56:34 +0000