summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Don't send queries when URL is like:darin@chromium.org2008-09-104-16/+52
| | | | | | | | | | | | | | | - starts with http:// or https:// and includes username (e.g. http://me@test.com/) - starts with http:// or https:// and includes query (e.g. http://test.com/?q=x) - starts with https:// and includes path component (e.g. https://test.com/path) so as not to leak user data to the suggest server. Patch by takayoshi.kochi@gmail.com BUG=1647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1978 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with resizeBy in Gears dialogs.mpcomplete@google.com2008-09-091-11/+1
| | | | | | | BUG=1340253 Review URL: http://codereview.chromium.org/1867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1945 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-0935-70/+67
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* backing out checkin to closed treebeng@google.com2008-09-091-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1938 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1936 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from Szymon Piechowicz <szymonpiechowicz@o2.pl>beng@google.com2008-09-091-6/+6
| | | | | | | | | Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu. Code review: http://codereview.chromium.org/1826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1903 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CHECK in a memcpy that it is not trivial to understand.cpu@google.com2008-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/1630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1883 0039d316-1c4b-4281-b951-d872f2087c98
* Pages with mixed content were shown as secure.jcampan@google.com2008-09-081-0/+4
| | | | | | | | BUG=1347301 TEST=Go to https://www.corp.google.com the page should not be reported as safe (the location bar should not show a lock). Review URL: http://codereview.chromium.org/2201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1874 0039d316-1c4b-4281-b951-d872f2087c98
* Change the external protocol handler to look at thensylvain@google.com2008-09-084-18/+35
| | | | | | | | | | | command that will be run before warning the user. If the command is empty, there is no reason to warn. I removed a dcheck. This dcheck is good, but unfortunately we can't use g_browser_process in the io_thread. Review URL: http://codereview.chromium.org/1632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1871 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-0818-75/+49
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST() instead of guessing the test class name (!)maruel@google.com2008-09-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/1626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1857 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flakey test.deanm@google.com2008-09-081-2/+2
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=1880 Review URL: http://codereview.chromium.org/1816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1852 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-082-0/+47
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully remove 102 unneeded static initializers. This should require less ↵deanm@google.com2008-09-081-197/+198
| | | | | | | | memory, since now we will share the PrepopulatedEngines across the language locales. Review URL: http://codereview.chromium.org/1619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1846 0039d316-1c4b-4281-b951-d872f2087c98
* Makes new tab page update properly when its told bookmarks aresky@google.com2008-09-081-5/+10
| | | | | | | | | | | changed. BUG=1861 TEST=see bug Review URL: http://codereview.chromium.org/1618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1845 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is from Andrew Brampton <me@bramp.net>.sky@google.com2008-09-081-1/+2
| | | | | | | | | | | | | | This patches allows menu items in PopUpMenus to be clicked with the right mouse button. menu.cc controls the web content popup menus, and some others chrome_menu{.cc,.h} controls popup menu on the chrome, for example right clicking on a tab. BUG=718 TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash (visible sometimes in the single process UI tests inbrettw@google.com2008-09-081-2/+7
| | | | | | | RestoreToDifferentWindow). Review URL: http://codereview.chromium.org/1809 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1833 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser is destroyed during DestroyBrowser because EndSession ↵beng@google.com2008-09-081-1/+9
| | | | | | | | | handling needs it to be synchronously deleted, rather than by the Window's destruction. B=1031854 Review URL: http://codereview.chromium.org/452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL state in the URL bar being incorrect. Going to an EV site like ↵brettw@google.com2008-09-079-53/+109
| | | | | | | | | | | | | https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on. This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar. BUG=1359547 TEST=see repro steps in bug Review URL: http://codereview.chromium.org/436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1831 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reinvent the wheel - base::wclscpy does this work in one line of code.beng@google.com2008-09-071-6/+2
| | | | | | Review URL: http://codereview.chromium.org/1807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1828 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the import lock dialog to be sized by locale.tc@google.com2008-09-061-4/+8
| | | | | | | | | Also increase the height of the Italian first run bubble. BUG=1334381,1359145 Review URL: http://codereview.chromium.org/482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak introduced in the SafeBrowsing prefix cache test.paulg@google.com2008-09-061-1/+5
| | | | | | | BUG=1484 Review URL: http://codereview.chromium.org/481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1817 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp open file name size.beng@google.com2008-09-051-1/+6
| | | | | | | B=1362425 Review URL: http://codereview.chromium.org/476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1810 0039d316-1c4b-4281-b951-d872f2087c98
* Readding UI test I pulled yesterday; hopefully the bots will like it more ↵finnur@google.com2008-09-0514-7/+98
| | | | | | | | now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. Review URL: http://codereview.chromium.org/473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1809 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes keyword editor to show error image when keyword isn't valid.sky@google.com2008-09-051-1/+1
| | | | | | | | | | | BUG=1318 TEST=Edit a keyword in the keyword editor. Change the keyword to one that is being used by another keyword. Make sure the icon updates appropriately. Review URL: http://codereview.chromium.org/258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1803 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash. I believe this is happening during sessionsky@google.com2008-09-056-2/+44
| | | | | | | | | | | | | | | | end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
* Same CL as 448. Had to redo it.cpu@google.com2008-09-051-19/+34
| | | | | | | | | | | | | Change the default download path if needed, in Vista it could be set tothe destkop which is a risky location.- Remove reading the download location from IE in vista.BUG=b/1355855 This was already LGTmed Review URL: http://codereview.chromium.org/462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1753 0039d316-1c4b-4281-b951-d872f2087c98
* Cache empty responses from the SafeBrowsing servers for GetHashpaulg@google.com2008-09-056-11/+67
| | | | | | | | | | | requests so that we don't keep asking for full hashes that don't exist. We flush this cache with each update, which is a little aggressive, but on the safe side. BUG=1358225 Review URL: http://codereview.chromium.org/454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1748 0039d316-1c4b-4281-b951-d872f2087c98
* New Frames.beng@google.com2008-09-051-1/+2
| | | | | | | | | Fix browser UI tests relating to page titles. "- Chromium" was not being appended to the window title. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1746 0039d316-1c4b-4281-b951-d872f2087c98
* My new test is failing on the bots. Disabling while I investigate.finnur@google.com2008-09-041-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1736 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue where a sub chunk coming in before an add chunk, both containg ↵jam@chromium.org2008-09-043-3/+42
| | | | | | | | | the same prefixes, will lead to the whole hostname looking like it's blocked. BUG=1358531 Review URL: http://codereview.chromium.org/439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1729 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing issue 1343052: a regression where the Find box moves up when you open ↵finnur@google.com2008-09-043-3/+4
| | | | | | | | | | | | | | | a new tab and close it again. This is because during a TabClosingAt call, we end up calling ShowTabContents(NULL) which leads to ShelfVisibilityChangedImpl(NULL). Because the parameter current_tab is NULL, we end up removing the BookmarkBarView from the RootView (only to add it back a little too late), the Find window thinks there is no BookmarkBar and hence moves up a bit. I am also enabling the disabled UI test I wrote for this, since it should now pass. BUG=1343052 TEST=Covered by UI test. Review URL: http://codereview.chromium.org/441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1727 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke a flag setting for 'dictionary download over' in the IO loop through ↵sidchat@google.com2008-09-041-33/+33
| | | | | | | | a proxy in the UI loop. Review URL: http://codereview.chromium.org/438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1726 0039d316-1c4b-4281-b951-d872f2087c98
* HMAC-SHA1 implementation for Mac based on CommonCrypto;mmentovai@google.com2008-09-041-3/+3
| | | | | | | allow Windows HMAC-SHA1 to use keys longer than 16 bytes. Review URL: http://codereview.chromium.org/218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1724 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up brettw's checkin of r1032.wtc@google.com2008-09-043-11/+1
| | | | | | | | | | | Fix a DCHECK on ssl().content_status() in web_contents.cc. Remove the unused ResetInternal method of NavigationController. R=brettw Review URL: http://codereview.chromium.org/221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1720 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the polymorphic WindowResources class and FramePartBitmap enum.maruel@google.com2008-09-046-59/+80
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1710 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in BookmarkBarView. If the HistoryService fails to load itsky@google.com2008-09-044-57/+27
| | | | | | | | | | | | | | was possible for BookmarkBarView to deref NULL (the model_ field). There is no point in having the BookmarkBarView wait for history to load now though, so I've taken this out which makes it impossible to get in this situation. BUG=1356168 TEST=make sure bookmarks still work correctly Review URL: http://codereview.chromium.org/426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1709 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in history view. The crash occurs with the followingsky@google.com2008-09-042-0/+20
| | | | | | | | | | | | | | | | | | | | | | | sequence: 1. Delete a day of history. 2. Before the delete finishes, click to delete another day. 3. While the modal dialog is up wait for the delete/reload to complete. 4. Click ok. This crashes because the index supplied to delete in step 2 is bogus after step 3 completes. I suspect we could make this a bit more elegant, but I'm holding off until we figure out the HTML versions of these. BUG=1358107 TEST=Make sure history deletion still works. Review URL: http://codereview.chromium.org/602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1708 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include order in aero_glass_frame.cc. This was causing issues with ↵maruel@google.com2008-09-041-2/+2
| | | | | | | | WPO enabled. Review URL: http://codereview.chromium.org/430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1703 0039d316-1c4b-4281-b951-d872f2087c98
* Localize the 11th hour popup window hack. Right before release, we made a ↵erg@google.com2008-09-041-10/+5
| | | | | | | | change to the behaviour of constrained windows, where we hard coded English strings. Localize this now... Review URL: http://codereview.chromium.org/427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1702 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the new frames' BrowserView2::TabSelectedAt calls ↵beng@google.com2008-09-031-1/+5
| | | | | | | | | TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1698 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup to OneShotTimer and RepeatingTimer: moves more of the member ↵darin@google.com2008-09-0324-307/+114
| | | | | | | | | | | variables into the Task subclass. Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer. R=beng BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the allowed include path from v8/public to v8/include in thesgjesse@google.com2008-09-031-1/+1
| | | | | | browser DEPS file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1673 0039d316-1c4b-4281-b951-d872f2087c98
* Change the path of the V8 API headers from public to includesgjesse@google.com2008-09-034-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1672 0039d316-1c4b-4281-b951-d872f2087c98
* c_str was getting called on the return value of a function. The return ↵petersont@google.com2008-09-031-1/+3
| | | | | | | | | value would get destroyed when out of scope invalidating the pointer. Quick fix: copy the return value of the function into a local std::string, and call c_str on that. R=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1664 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in making Chrome the default browser from the optionssky@google.com2008-09-031-2/+4
| | | | | | | | | | | dialog. The crash happened if you clicked 'make chrome the default', then closed the window before we verified the choice stuck. BUG=1355679 TEST=make sure setting chrome as the default browser still works. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1662 0039d316-1c4b-4281-b951-d872f2087c98
* Moves the bookmark bar view test into the interactive tests. To getsky@google.com2008-09-023-10/+7
| | | | | | | | | | | | | | | this to work I changed the interactive ui tests to link with everything the unit tests do. I did this by way of clicking on the dependencies dialog in VS. Let me know if that wasn't right. I also had to slightly tweak BookmarkBarModel and BookmarkStorage to deal with changes I did a while back. These changes only matter during testing (background thread is NULL). BUG=1318942 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1659 0039d316-1c4b-4281-b951-d872f2087c98
* Take out uneeded comment (and test public Rietveld instance!).jam@chromium.org2008-09-021-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1657 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-26 17:22:25 +0000