summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Don't send resize messages until the renderer has been initialized.evan@chromium.org2009-04-2213-43/+22
| | | | | | | | | | | | | | | | [Retry of 14260 with fixed unit test.] 1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent). Should be identical semantics to before. 2) Test renderer_initialized_ in RWH::WasResized(). This also reverts r13725, which was another attempt at fixing this problem. BUG=9830,10659 TEST=From the Linux start page, click a link then click back -- should not get a gray page. From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page. Review URL: http://codereview.chromium.org/93038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14273 0039d316-1c4b-4281-b951-d872f2087c98
* Hide the exit bubble when the main window is inactivated, and don't re-show ↵pkasting@chromium.org2009-04-221-2/+7
| | | | | | | | | until it's reactivated. BUG=8945 Review URL: http://codereview.chromium.org/93048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14270 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Don't send resize messages until the renderer has been initialized."evan@chromium.org2009-04-2212-21/+43
| | | | | | This reverts commit r14260. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix focus rects for checkboxes and radio buttons:ben@chromium.org2009-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | - add concept of default insets to view which get added to any other insets provided by the user. used by label to provide room for a focus border. - provide the ability for the label to paint its focus border even if it isn't focused. needed because the outer container (the checkbox) gets focus but the inner label does not, however the label knows best the location of its text around which the focus border must be drawn. please note: - also make it easier to click checkboxes by not resetting mouse_pressed_handler_ in RootView when a view decides it doesn't want to handle a drag. this is so we can still receive mousereleased notifications when the mouse is released... it's "difficult" to click checkboxes and radio buttons when you accidentally drag a little on their label. (this is the root view change). - fix slight alignment issue on the general page of options. Also fix a slight error in my last radio checkbox - clicking on a checked radio button should still focus it. http://crbug.com/10834 TEST=visit options, Minor Tweaks. click the "always ask before downloading" checkbox and observe that the focus rect tightly surrounds the text label instead of stretching to the right side of the dialog. Visit options, click an already-checked radio button. observe that it takes focus. Visit options, click on any checkbox or radio button, drag slightly then release (still within the bounds of the item). note the item is now toggled or selected. click down then drag out and release, note that it is not toggled or selected. Review URL: http://codereview.chromium.org/92004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14265 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionView to properly set the size of the RenderWidgetHostView. ↵erikkay@google.com2009-04-221-15/+25
| | | | | | | | Without this, GetClientRect would return a size of 0,0 for the view, which would prevent the tooltip machinery from working properly. Review URL: http://codereview.chromium.org/87058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14264 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send resize messages until the renderer has been initialized.evan@chromium.org2009-04-2212-43/+21
| | | | | | | | | | | | | | | | 1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent). Should be identical semantics to before. 2) Test renderer_initialized_ in RWH::WasResized(). This also reverts r13725, which was another attempt at fixing this problem. BUG=9830,10659 TEST=From the Linux start page, click a link then click back -- should not get a gray page. From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page. Review URL: http://codereview.chromium.org/93038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14260 0039d316-1c4b-4281-b951-d872f2087c98
* Always enable copy-link-address in context menu.brettw@chromium.org2009-04-222-2/+6
| | | | | | | | | | | | | | Added a new field into ContextMenuParam only for this purpose. The new field won't be validated in frontend processes. In this way, even if renderer processes are going to mad, the frontend would be OK if the frontend uses this new field only for copying into the clipboard. Fix checked in for Shinichiro Hamaji Original code review: http://codereview.chromium.org/91002 BUG=2725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14256 0039d316-1c4b-4281-b951-d872f2087c98
* implement remaining tab events (except for onTabUpdated).rafaelw@chromium.org2009-04-222-11/+90
| | | | | | Review URL: http://codereview.chromium.org/88053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14255 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete the DOM UI property for the callback when the DOM UI is torn down.brettw@chromium.org2009-04-221-2/+8
| | | | | | | | | | With my ownership changes, the TabContents owns the RVHManager which owns the DOMUI. This means that the DOM UI is deleted from ~TabContents and it will crash during destruction if we access the TabContents to delete the property. Review URL: http://codereview.chromium.org/92042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14253 0039d316-1c4b-4281-b951-d872f2087c98
* Run user_script_master_unittest.cc on Mac.shess@chromium.org2009-04-221-4/+8
| | | | | | | | | | | | | | | | Removed anonymous namespace, Mac's gcc won't allow friend to reach into anonymous namespaces. Noticed that UserScriptMasterTest.NoScripts hanged it DirectoryWatcher was not implemented. Added a timeout event so that now it fails slowly. Then I disabled that test for non-Windows. Other tests pass, lets get those in the system! Review URL: http://codereview.chromium.org/88075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14252 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an assert caused by trying to add duplicate observers for multiple workers.jianli@chromium.org2009-04-221-11/+5
| | | | | | Review URL: http://codereview.chromium.org/87072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14243 0039d316-1c4b-4281-b951-d872f2087c98
* Weaken is_active check more, since it appears that Chromium can switch to andpam@chromium.org2009-04-221-19/+8
| | | | | | | | | | | | | | from being the frontmost app during the course of a ui_tests run. This way errors will show up in more carefully controlled local tests, but won't turn the bots red. BUG=5278 TEST=make sure TabRestoreUiTest.* don't fail due to is_active being false Review URL: http://codereview.chromium.org/92038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14242 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak build.estade@chromium.org2009-04-221-1/+3
| | | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/93037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14241 0039d316-1c4b-4281-b951-d872f2087c98
* Enable more tests, change a NOTREACHED to a bug since it's not fatal in the ↵pinkerton@chromium.org2009-04-225-12/+11
| | | | | | | | download code. Get other tests compiling even if disabled. Mark why tests are failing in gyp file. Review URL: http://codereview.chromium.org/92033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14239 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid DCHECK in nine box during download shelf animation.estade@chromium.org2009-04-222-4/+9
| | | | | | | | | That DCHECK might be a little overzealous, but is probably useful for most situations, so I'm leaving it. TBR=tony Review URL: http://codereview.chromium.org/92036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14237 0039d316-1c4b-4281-b951-d872f2087c98
* Restore closed tabs into new windows when necessary, and track the windows theypam@chromium.org2009-04-223-109/+264
| | | | | | | | | | | | | | | | | | | came from so they're restored together (into the same new window) when appropriate. Fix safety check on tab index when restoring: make it check the correct browser. Change some ASSERTs to EXPECTs in the unit test for greater coverage. BUG=5278 TEST=Open a window with two tabs, close both (closing the window), then restore both. Make sure both restored tabs are in the same window. Open a window with multiple tabs, close a tab, then close the window using its close box. Restore both and make sure the tab goes back into the window. Review URL: http://codereview.chromium.org/92001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14234 0039d316-1c4b-4281-b951-d872f2087c98
* Move all data members from WebContents to TabContents in preparation forbrettw@chromium.org2009-04-224-232/+287
| | | | | | | | | | | | | | | merging the two. This is extremely straightforward except for the GearsCreateShortcutCallbackFunctor which I had to move to the header (with a TODO and its associated function OnGearsCreateShortcutDone) and some of the constructors for the members which took a WebContents that I had to cast. I tried to reorganize the data to have some kind of groupings. I made the member initializers all explicit for TabContents because the extreme number of them makes them difficult to keep track of. Review URL: http://codereview.chromium.org/88021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14230 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused implementation of TabContentsDelegate in HtmlDialogView.stoyan@chromium.org2009-04-223-108/+3
| | | | | | Review URL: http://codereview.chromium.org/87031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14227 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a debugging change that was accidentally added to r14123.jhawkins@chromium.org2009-04-221-1/+0
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/88045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14222 0039d316-1c4b-4281-b951-d872f2087c98
* Add new item animation to download shelf.estade@chromium.org2009-04-226-15/+60
| | | | | | | | Also, fix duration and tween type for download shelf open animation. Review URL: http://codereview.chromium.org/88064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14220 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-228-11/+57
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak the RenderProcessHost when running site instance unit tests bybrettw@chromium.org2009-04-221-0/+4
| | | | | | | | | flusing the message queue (containing the delete message). BUG=10782 Review URL: http://codereview.chromium.org/92023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14208 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-2210-59/+208
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (r14075 take two) Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14206 0039d316-1c4b-4281-b951-d872f2087c98
* Add Australian English spell check support.sidchat@google.com2009-04-221-1/+4
| | | | | | | Issue=8934 Review URL: http://codereview.chromium.org/89006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14204 0039d316-1c4b-4281-b951-d872f2087c98
* Properly construct shell filters (forgetting the asterisk means it works but ↵avi@chromium.org2009-04-221-1/+1
| | | | | | | | | | doesn't show existing files). BUG=10734 Review URL: http://codereview.chromium.org/93019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14202 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/87034apavlov@chromium.org2009-04-2212-79/+89
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14187 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 9718.hbono@chromium.org2009-04-221-17/+64
| | | | | | | | | This change enables the keyboard shortcuts "control + right-shift" and "control + left-shift" only on a PC having RTL languages (i.e. Arabic or Hebrew) installed. BUG=9718 "Regression: Only use RCtrl + RShift to change directionality if RTL input languages are installed" Review URL: http://codereview.chromium.org/67296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14179 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BookmarkContextMenuTest under Linux.erg@google.com2009-04-221-2/+9
| | | | | | Review URL: http://codereview.chromium.org/89011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14163 0039d316-1c4b-4281-b951-d872f2087c98
* Provide an override for Webview drop effect.tc@google.com2009-04-221-6/+0
| | | | | | | | | | | | | | | | | | | | | Used for gears file drag & drop in chrome, provide a setter api to override the default webview drop effect. If gears overrides the drop_effect, then either a "copy" or "none" cursor is shown to the user. Otherwise, the drop effect shown is the default for the webview (controlled by WebKit). Also remove a TODO: during drag and drop, remember the drop accept state of the webview (in drag enter, drag over). Use that to prevent drops on webviews that can't accept the drop data. BUG=7995 Original patch from Noel Gordon via http://codereview.chromium.org/67297 Review URL: http://codereview.chromium.org/88073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14162 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-2157-185/+191
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes xji@chromium.org2009-04-211-13/+36
| | | | | | | | | | | | | | | | | issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse and issue 8686 - RTL: Can't select RTL text from Chrome UI boxes The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout). The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605 BUG=6125 BUG=8686 Review URL: http://codereview.chromium.org/86003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14158 0039d316-1c4b-4281-b951-d872f2087c98
* Better omnibox handling of numeric input. Now we search based on the user's ↵pkasting@chromium.org2009-04-213-11/+46
| | | | | | | | | | original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular. Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me. BUG=10054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14156 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BookmarkContextMenuGtk back into BookmarkContextMenu.erg@google.com2009-04-219-544/+178
| | | | | | Review URL: http://codereview.chromium.org/87038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14155 0039d316-1c4b-4281-b951-d872f2087c98
* Reland this change from yesterday. Gets basic text in omnibox2 popup ↵ben@chromium.org2009-04-212-40/+53
| | | | | | working. Ugly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14149 0039d316-1c4b-4281-b951-d872f2087c98
* posix: URLFixerUpper would DCHECK on input "/".evan@chromium.org2009-04-212-6/+17
| | | | | | | | Also, add some more tests to cover this case. Review URL: http://codereview.chromium.org/87048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-2153-147/+163
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-2153-163/+147
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it possible to mock URLFetcher.sky@chromium.org2009-04-214-4/+157
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/87035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14141 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang seen in plugin process because plugin creation ended up having to ↵jam@chromium.org2009-04-214-97/+104
| | | | | | | | | | wait on UI thread. Instead of using sync messages, the plugin hwnd is initially parented to the RenderWidgetHost's HWND. It's then lazily reparented to an intermediate HWND on the UI thread when it comes time to move it. BUG=10711 TEST=added regression tests, but testers please confirm plugins on top video sites are placed correctly. Review URL: http://codereview.chromium.org/67285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14137 0039d316-1c4b-4281-b951-d872f2087c98
* Implement (kinda) ProcessSingleton for the Mac.avi@google.com2009-04-212-4/+38
| | | | | | Review URL: http://codereview.chromium.org/88031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14136 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file drops and URL open requests. Along with declaring that we handle ↵avi@google.com2009-04-212-9/+69
| | | | | | | | the http scheme, this allows Chromium to be set as a default browser for the Mac. Review URL: http://codereview.chromium.org/87043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14134 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak accelerators, and add ctrl+_ for zoom out.estade@chromium.org2009-04-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/87041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14133 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly escape download item label markup.estade@chromium.org2009-04-211-9/+10
| | | | | | | | BUG=10766 Review URL: http://codereview.chromium.org/88055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in the download shelf.estade@chromium.org2009-04-211-2/+5
| | | | | | | | | | Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically. BUG=10739 Review URL: http://codereview.chromium.org/88044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14131 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #include (.h, not .cc).sgk@google.com2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14127 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up alt-d on linux.estade@chromium.org2009-04-211-2/+2
| | | | | | | | | | Also clean up some accelerators. BUG=10803 Review URL: http://codereview.chromium.org/90008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14123 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 2674 - search engine name containing parenthesis is not ↵xji@chromium.org2009-04-215-10/+16
| | | | | | | | | | | | | | displayed correctly in Omnibox NavSuggest drop-down list. The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI. BUG=2674 Review URL: http://codereview.chromium.org/79005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
* I missed this file in my last checkinestade@chromium.org2009-04-211-4/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14118 0039d316-1c4b-4281-b951-d872f2087c98
* Add open/close animations to infobar, download shelf.estade@chromium.org2009-04-216-48/+214
| | | | | | | | Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks. Review URL: http://codereview.chromium.org/88005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14116 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a race between the remove tab animation resizing the closing tab and ↵jhawkins@chromium.org2009-04-211-1/+11
| | | | | | | | | the gtk mouse events. Fixes a crash where the hover index would become stale before a leave-notify event. BUG=10776 Review URL: http://codereview.chromium.org/88037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14115 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 16:53:14 +0000