| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31292
TEST=bookmark_bar_view_test and I also ran the test case. NTP and Bookmark manager also works.
Review URL: http://codereview.chromium.org/1084014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39057
Review URL: http://codereview.chromium.org/1074010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes our Mac wmode hack--which prevents Flash from using "accelerated" QuickDraw mode, which is incredibly slow for us, but also prevents Flash 10.1 from using Core Animation in the same cases--conditional based on having both support for Core Animation mode in both Flash and Chromium, and on having a flag.
Once we are confident that there are no regressions preventing us from allowing Core Animation by default, the flag will be removed.
BUG=38932
TEST=Run with --enable-flash-core-animation and the current Flash 10.1 beta on 10.6; sites like YouTube should have negligable CPU usage.
Review URL: http://codereview.chromium.org/1115010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this in a
callback so that I can identify where the image is coming from.
[Reverter's note: There is nothing wrong with this CL per se, except that I'm going to
make it obsolete in my next checkin, so since noone is relying on this change yet, it
is better to revert it than to have a painful merge]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1167004
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1077011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/1173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38522
TBR=maruel
Review URL: http://codereview.chromium.org/1081015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*
Review URL: http://codereview.chromium.org/1127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is the follow up to http://codereview.chromium.org/1037006 which added it on windows, and http://codereview.chromium.org/1127001 which added it to Mac.
BUG=11246
TEST=run browser with --enable-geolocation, open maps.google.com and click my location.
Review URL: http://codereview.chromium.org/1081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't make sense to make this open the "Language Settings" preferenes windows (like on other platforms), since that panel
isn't implemented yet - http://crbug.com/23828.
Once that bug is fixed we can decide whether it make sense to
re-enable this item or change the context menu on OS X.
BUG=34512
TEST=Right click on a text input field on OS X, Spell Checking->Language settings menu item should be disabled. On Windows the item should be enabled.
Review URL: http://codereview.chromium.org/1161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 29631. This change adds a bool flag |need_elevation_| to notify when a button needs elevation to the NativeButton class and add shield icons to the following buttons.
- on the "Start Chromium" button on the first-run dialog when the "Make Chromium the default browser" checkbox is enabled.
- on the "Set as Default" button on the default browser infobar.
- on the "Make Google Chrome my default browser" button on the Basics tab of options.
BUG=29631
TEST=Launch Chrome when it is not set as a default browser and see the "Set as Default" button has a shield icon.
TEST=Launch Chrome when it is not set as a default browser and open the "Options" dialog, and see its "Make Google Chrome my default browser" button has a shield icon.
TEST=Launch Chrome with a '--first-run' option when it is not set as a default browser, and see its "Launch Chrome" button has a shield icon.
Review URL: http://codereview.chromium.org/661165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proposal for the API is documented at:
http://dev.chromium.org/developers/design-documents/extensions/context-menu-api
Notable limitations in this initial implementation:
-No reliable way to get at the unique, actual node clicked on in contexts like
IMAGE/LINK/etc. We'll need to fix this in the long run - see the API proposal
page for some notes on this.
-No update or deleteAll methods ; the only way you can change items is to delete
by id and re-add.
-We aren't yet matching the UI goal of having the extension items at the
top level include the extension icon on the left. This will require a
refactoring of RenderViewContextMenu to steal some of the code from the
bookmarks bar context menus, which can display favicons.
-The only kind of parent->child menu that currently works is if you have
a single top-level parent, and only one level of children. (This is because
of how RenderViewContextMenu currently works)
-No browser tests that the menu items actually get drawn (will wait on those
until the above mentioned refactor is complete), or API tests (the API may
change a bit based on feedback, at which point I'll write more tests).
-Unit tests need to cover some more cases.
BUG=32363
TEST=Should be able to create context menus with this API.
Review URL: http://codereview.chromium.org/1042003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38595
TEST=trybots, manual
Review URL: http://codereview.chromium.org/1110007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1132006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the relevant Extension*.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/1117008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up all the chrome side plumbing, but there are a couple
webkit changes that need to happen for this to fully work.
BUG=14654
Review URL: http://codereview.chromium.org/1084003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38681
TEST=none
Review URL: http://codereview.chromium.org/1124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also expand some documentation for functions that returned a GdkPixbuf about
who owns the reference
BUG=38895
TEST=manual test that nothing is broken, will watch bot for leak results
Review URL: http://codereview.chromium.org/1075014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the chrome side plumbing, but some patches need to
land on the WebKit side.
BUG=14654
Review URL: http://codereview.chromium.org/1132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on fixing it.
TBR=finnur
BUG=38992
Review URL: http://codereview.chromium.org/1092009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1141007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
text in the omnibox.
BUG=26354
Review URL: http://codereview.chromium.org/1149002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
low-latency mode.
Review URL: http://codereview.chromium.org/661386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The whole extension shelf and its items were missing MSAA information. Some of them were uninitialized due to the custom components not having any AccessibleRole.
Some extensions have no name, this could happen where the user didn't put a name for their browser action in the manifest. If such case happens, we will use the extension name itself.
BUG=36289
TEST=Extension shelf now has MSAA information according to Inspect32. Screenshot available on the issue tracker.
Review URL: http://codereview.chromium.org/1105008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Drag a folder in the tree. You should not be able to drop it on itself. You should only be able to drop it when there is a drop marker.
Review URL: http://codereview.chromium.org/1161004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
callback so that I can identify where the image is coming from.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1167004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Replaced "closed_by_user, update_pane_on_leave_" flags with KEEP_SIZE state. The panel moves to this state when a user interacts with the panel. It keeps its size unless a notification is added, or removed, or it has more space than neccessary when mouse leaves the panel.
* Fixed the crash when the preferred size is calculated to zero (can happen depending on timing) by adding minimum size.
* fixed wrong return type (bool -> int)
* GetNewBounds was using the panel's bounds instead of notification's bounds.
* Refactored and clean up in tests..
BUG=33306
TEST=added two more browser tests for state transition.
Review URL: http://codereview.chromium.org/1164004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the app launcher shows when you open a new tab.
Also removing the graying-out of the browser when the app launcher is showng for now, as
it is not clear how to make it cross-platform.
BUG=None
TEST=Start Chrome with --app-launcher-new-tab. Opening a new tab
should bring the app launcher (still a prototype at this point).
Review URL: http://codereview.chromium.org/1145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it would always run with the Default profile. This meant that two
different users could see the same data...a big problem.
We patched in the OS by deleting the profile directory each time
but this is the right fix.
When the session_manager reruns Chrome on a crash it will now
pass a new flag (--login-user). Chrome uses this and ensures that
the profile dir (specified by --login-profile) is mounted as an
encrypted drive. If this flag isn't specified then Chrome uses the
Default profile, but in incognito mode so no data is written.
BUG=chromiumos:1967
TEST=Login to chromeos as user1, in a terminal kill the browser process, chrome relaunches, log into gmail, sign out (using menu or power button). Login as user2, kill browser process, chrome relaunches, go to gmail. Ensure that user1 isn't logged in.
Review URL: http://codereview.chromium.org/1094009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enables the FindInPageControllerTest browser test on Mac.
BUG=38365,37808
TEST=Do a find in page for text in a link. Pressing ctrl-return while the findbar has focus should follow the link.
Review URL: http://codereview.chromium.org/1061003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmarks and Settings dialog.
BUG=9617
TEST=see bug
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1126009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few related changes to make tab switching work with accelerated plugins:
- Re-attach our layer to the view layer whenever it changes; using setWantsLayer: creates a layer that AppKit manages at will, so we can't rely on it.
- Override setFrame: on our layer to ignore bogus values sent by the view's layer.
- Notify the accelerated surface when our parent (and thus drawing context) changes, so it can associate its texture with the new context.
BUG=37701
TEST=Load the pepper test plugin (or a CA plugin in a build with CA enabled) and switch tabs away and back. The plugin should still be visible.
Review URL: http://codereview.chromium.org/1166002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Simplify constructor
- Rename to ExtensionContextMenuModel.*
- Remove views/extension_action_context_menu.*
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1107007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32728
TEST=run with --import-from-file
Review URL: http://codereview.chromium.org/1077007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declarations.
Add a PersistedKernelInfo member to the directory kernel, rather than having parallel members.
BUG=37331
TEST=unit tests.
Review URL: http://codereview.chromium.org/1078004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Clipboard
Review URL: http://codereview.chromium.org/1121004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Fix an issue where the grippy was too far to the right when no browser actions were shown.
o Maintain the correct order of extensions within the overflow menu.
Still to be done:
o Animating once resize is complete.
o Syncing the size of the container accross windows.
TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1165002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also cleans up some of the last remaining l10n_util usages within app/gfx in preparation for moving these files to toplevel gfx.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1110008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still to do:
1. Update upload rates based on response
2. Differentiate autofilled/not uploads
3. Do not query if there is no items in autofill
4. Fix forms to correspond to the data queried by toolbar
BUG=none
TEST=Should request data from toolbar servers
Review URL: http://codereview.chromium.org/1119004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notifications and the syncmanager subscribing to them.
Review URL: http://codereview.chromium.org/1096006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Report Bug dialog.
BUG=9614
TEST=see bug
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1154002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
save and restore the browser action toolbar's size. Linux already does this.
Also fixes a regression where Windows would ignore the pref and always show
all browser actions on startup.
Review URL: http://codereview.chromium.org/1081009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(bookmark model being deleted).
BUG=38665
Review URL: http://codereview.chromium.org/1165001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the hostname without adding the TLD was illegal, we'd sometimes fail to allow the TLD to be added.
BUG=38605
TEST=Should be able to hit ctrl-enter on "401k" and "999999999999" to open them with www. and .com attached.
Review URL: http://codereview.chromium.org/1088004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions service. The crash
occured while dereferencing a NULL manifest. Fix is to check for the same and avoid initializing
the extension if we don't have a manifest.
TBR=aa
Review URL: http://codereview.chromium.org/1107013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
42236.
TBR=dmazzoni
Review URL: http://codereview.chromium.org/1158004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42236 0039d316-1c4b-4281-b951-d872f2087c98
|